- 25 Jun, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/45f99e2caaf7..70ec83098831 Created with: gclient setdep -r src-internal@70ec83098831 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=reillyg@google.com,yhirano@google.com,futhark@google.com Change-Id: I2dbd047b07b5d5bd505733bcd85fe8bb258c8fef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676011Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672112}
-
Fredrik Söderquist authored
Bug: 978436 Change-Id: Ief76cb6af4ad65fe433eb2d6d66282be313e4d87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676168 Commit-Queue: Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#672111}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e198ec2f..0d7d36e8 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8c54705e1d2f3ec537d46a9c94f190a5159b0542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675251Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672110}
-
Scott Sheehan authored
midl.py currently does some path munging that is better handled by midl.gni. It has knowledge of 'third_party' and 'win_build_output' and these should be an argument to the script provided by the build system instead of knowledge intrinsic to midl.py. This changes moves that logic to midl.gni. midl.gni produces the same default path that midl.py previously generated (so net result is a no-op). browser_switcher/bho is the only consumer that had custom logic that needed to explicitly specify the output location. Additionally, this enables other IDL producers to specify a non-standard place to persist the IDLs if they so desire. Details: midl.py/gni facilitate IDL compilation. Nominally, one would run midl as part of the build process and be done with it. However, to support cross-platform compilation, IDL generation is done on Windows clients and persisted in the source tree. This way platforms that can't run midl directly can still produce a Windows build. For a given IDL, in the source tree |somewhere|, the standard location for the checked in midl outputs is third_party\win_build_output\midl\|somewhere|. midl.py knew how to get from the IDL built outputs (in |gen|) to the standard location. Now midl.gni has that knowledge, additionally some other location, other than the standard location may be used, if necessary. Bug: 976936 Change-Id: Ibd448c8d59cc59e19c26beb8235c6f581182061e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666483Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Scott Sheehan <ssheehan@microsoft.com> Cr-Commit-Position: refs/heads/master@{#672109}
-
Vadym Doroshenko authored
Bug: 969989, 975774 Change-Id: I10ea2dc24835b3da9d36d2045aef523ab11d10f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675672 Auto-Submit: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#672108}
-
Geoff Lang authored
The passthrough command decoder does not implement the state restoration functions because it does not track state. When a GLStateRestorer exists, it is used for the scoped binders in ui/gl/scoped_binders.h and leads to incorrect state being applied. BUG=88258 Change-Id: I18937597fc02562dfaf01d67a9d4a1b8b84290a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670949Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#672107}
-
Matthew Jones authored
Bug: 971868 Change-Id: Icdfba2d851058b961cec6e7546d3c6fb0123fed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674615Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#672106}
-
Olivier Yiptong authored
This CL moves write-related operations to NFSFileWriter. This makes the backend and interface closer to the current shape of the spec. Bug: 968550 Change-Id: Ia2ccd97416b478eddf210118132519eef2b16040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672026Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#672105}
-
Istiaque Ahmed authored
The two metrics are meant to monitor extension content verification related stats: ExtensionContentHashFetcher.CreateHashesTime Extensions.CorruptExtensionTotalDisables Mark these as never-expiring. Bug: 976038, 976013 Test: None Change-Id: I915898f9533a1e40a3576ce4924453ef9374cee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674206Reviewed-by:
-
Miguel Casas-Sanchez authored
This CL adds a |flip_y| param to said method next to |clockwise_rotation|. This is necessary to deprecate the PIXEL_FORMAT_RGB32 (see next CL in the relation list): Win video capture (and only that) uses RGB32 ISO the approved synonym ARGB to signify the vertical flip. Default arguments in virtual functions are banned, https://google.github.io/styleguide/cppguide.html#Default_Arguments so I left a couple of TODO()s to remove the ones currently there. Bug: 953128 Change-Id: I8651ad13c6457ac3209a286299469c3689ab24ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658689Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#672103}
-
Ben Pastene authored
Got green runs on the three desktop bots: https://ci.chromium.org/p/chrome/builders/ci/linux-google-rel/5659 https://ci.chromium.org/p/chrome/builders/ci/win-google-rel/5994 https://ci.chromium.org/p/chrome/builders/ci/mac-google-rel/2935 And trybot mirrors are not polluting the perf dashboard's streams for the CI bots since they upload to a different namespace based on master: https://codesearch.chromium.org/chromium/src/tools/perf/core/perf_dashboard_machine_group_mapping.json Bug: 961548 Change-Id: I9aae3c16eda8b2758e47a80f31a717c8c69f8772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656017Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#672102}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/adf18ce45a3c..d628747dfb54 git log adf18ce45a3c..d628747dfb54 --date=short --no-merges --format='%ad %ae %s' 2019-06-25 bsalomon@google.com Make GrColorSpaceInfo store GrColorType. 2019-06-25 halcanary@google.com SkQP: fix Filterable.filter 2019-06-25 jvanverth@google.com Use asynchronous routines to build Metal shaders and pipelines for MacOS. 2019-06-25 mtklein@google.com baby steps for aarch64 support 2019-06-25 herb@google.com Introduce mergeGlyphAndImage to SkStrike Created with: gclient setdep -r src/third_party/skia@d628747dfb54 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:974219 TBR=djsollen@google.com Change-Id: Ia2924532f22e09279bb232374319f569fd1914ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675742Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672101}
-
Sean Gilhuly authored
Move RendererType value instantiation into arrays, and use ValuesIn to remove the linting error for having a comma on a new line. Bug: 963446 Change-Id: I40095576d14b51e1515d7900b7a30703fa467cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674643 Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#672100}
-
Aaron Leventhal authored
HTML labelable elements can cause extreme slowness while loading in some cases. We should only call html_element->labels() if the current element is known to have labels (we can check our relationship cache). Bug: 976849 Change-Id: Ia5e0e312b3a5e1d2d2d4cfdc5249f6a58b38147c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669911 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#672099}
-
Kevin Babbitt authored
We already tolerate \r characters that exist in accessibility tree dump files, but some PDFs have been observed to produce \r characters in the generated "actual" tree dump, which can throw off the diff. This change normalizes line endings when generating a tree dump. Bug: 974397 Change-Id: I40f3f78398d890ef2f3536bfb0f807c455a96dbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673840Reviewed-by:
-
Ian Vollick authored
FILTER_TOUCH_FOR_SECURITY is not used by the touchless modal dialog presenter and need not be included in touchless modal dialog properties. Bug: None Change-Id: I6bb9faea0b095dc5fef36f85c7c6b0b09b11e838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675688Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#672097}
-
Ryan Hansberry authored
Also only Initialize the EasyUnlockService in the test once the test Profile object is ready. This change is high-priority because without it, the fix for crbug.com/953027 causes this test to fail (the incomplete Profile caused DCHECKs in known_user.h to fail). Bug: 857494, 953027 Change-Id: I5a389b3017e6428136295ccd6899ffc05c6c354b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669762 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#672096}
-
Bruno Santos authored
This unblocks deleting related code in chrome/ in parallel with ash/ Bug: 977019 Change-Id: I3578898a501b337829703cf474146f1219eabad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672586Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Bruno Santos <brunoad@chromium.org> Cr-Commit-Position: refs/heads/master@{#672095}
-
Michael Thiessen authored
We want shortcuts to feel more app-like as there are no tabs in touchless mode and shortcuts clobbering your tab is confusing amongst other things. See bug for additional details. Bug: 977198 Change-Id: I47c58ce218ffe6d0a146228fcd28c6c2e9b3abf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669235 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#672094}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d3fc161c169d..5767fb8cbd2a git log d3fc161c169d..5767fb8cbd2a --date=short --no-merges --format='%ad %ae %s' 2019-06-25 mbonadei@webrtc.org Stop passing deprecated flags to frame analyzer. Created with: gclient setdep -r src/third_party/webrtc@5767fb8cbd2a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib0d196c364ec9264d21afcc97f04b19a97852cad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676012Reviewed-by:
-
Harsh Patel authored
Changed proguard_utils to allow for non java executables to be run. Change-Id: I193288fbc857573a64a54926aa066d2a03e06698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672196Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Harsh Patel <harshpa@google.com> Cr-Commit-Position: refs/heads/master@{#672092}
-
Min Qin authored
Currently download use webcontents::GeURL() to check content settings. But the download can actually be triggered by javascript from another origin. This CL fixes the issue by passing the request initiator to check the content settings. Here is what included in this CL: 1. removed originating_web_contents param from TabDownloadState ctor, this param is never used. 2. Adding an origin param to DownloadRequestLimiter::CanDownload() call, and it will be used to check the content settings. 3. In DownloadRequestLimiter::CanDownloadImpl(), always do content setting check first. This fixes a bug that any site can always trigger a download first even if its automatic download setting is blocked 4. For restricted origins, record their download status. So that we can differentiate origins that are blocked and origins that require prompt. BUG=970378 Change-Id: I6f7efc8b5c6b27ff3eaec1bb436c5ffbb8c8b26d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657031Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#672091}
-
Tibor Goldschwendt authored
Bug: 891996 Change-Id: I5904066ca893c536cbed87b3e6fa55b1210f5f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675323 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#672090}
-
Andrew Grieve authored
The bot is now the same as is used by other perf tests, so if it is broken, it will not go unnoticed / will be covered by tree sheriffs. Change-Id: If63c11f92c43d0ecc45953b63301d95a31510f7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676346 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Allen Robinson authored
Change-Id: I859b6c87050b5c2eb7f43eb55b052a5bb125603a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669648 Auto-Submit: Allen Robinson <arobins@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#672088}
-
Eric Orth authored
Essentially a thread-safe notifier wrapping around DnsConfigService, intended (but not yet used) for NetworkChangeNotifier and HostResolverManager(s) to listen to a shared object for system DNS config changes. In subsequent CLs, this will allow us to divorce HostResolverManager from listening to NetworkChangeNotifier and be able to apply Chrome-internal config changes on top of the system-only changes currently triggerring change notifications. In non-test, will generally be expected to be broadly shared and leaked on shutdown. Sequence-safe destruction is still implemented (using an internal Core class with an OnTaskRunnerDeleter) for any special cases and for tests. Note that some of the internal workings of the new class work similarly to base::ObserverListThreadSafe, but it was too difficult to make that work with the requirement that we always be able to get an initial config once ready, whether read before or after adding observers. Bug: 971411 Change-Id: Iac79dba9f74018ae6b9559c27df60174bf4edc93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654881Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#672087}
-
Ian Kilpatrick authored
This moves NGLayoutAlgorithm onto the heap using partition alloc. This (in mac-64bit) reduces the stack space from 1392 -> 864 bytes which is the same as legacy. From pinpoint data, this only seems to have a slight performance regression. A follow up patch will be sent so which performs a refactoring, so that this patch can be a simple cherry pick with the beta branch. Bug: 977387 Change-Id: I75a5b995b26c60e69976f41876cea192bc761486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669917Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#672086}
-
Ryan authored
iOS 13 causes weak signature algorithms and key sizes to be rejected as ERR_CERT_STATUS_INVALID, as documented in https://support.apple.com/en-us/HT210176 BUG=977163 Change-Id: If65bb570155db479e70b940de27f2b76b7d93223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670397 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#672085}
-
Jacques Chen authored
-Profile avatar images not used on Android -Removed all except one placeholder avatar icon -Last avatar not removed due to having large part of profiles code still being dependent on avatar icon code -Configured some profile tests not to run on Android -Removed profile_avatar_icon_util unit tests on Android Bug: 799078 Change-Id: Ic7b726c3ac58f8f1f6b24c48d95ac81d08aa9eb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652193Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Jacques Chen <jacqueschen@google.com> Cr-Commit-Position: refs/heads/master@{#672084}
-
Sam Maier authored
This is a reland of eec7c07a Original change's description: > Using R8 in place of Proguard for creating main dex list > > Bug: 908988 > Change-Id: I9cfe718d3754b92022c9045f860dee36c7e049bb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635949 > Commit-Queue: Sam Maier <smaier@chromium.org> > Auto-Submit: Sam Maier <smaier@chromium.org> > Reviewed-by: Eric Stevenson <estevenson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#665957} Bug: 908988 Change-Id: I9d535df1e642f59a639865388b90fdd066a09802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650373 Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0f67ee5f..e198ec2f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I57f2746d43103b9912b2235b6d590efd4e6fb010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675886Reviewed-by:
-
Michael Lippautz authored
Attaching and detaching ThreadState from an Isolate must by in sync with setting an UnifiedHeapController on V8's isolate. This fixes the case in tests where a UnifiedHeapController was set up and attached to a V8 isolate but testing environments later on reset ThreadState's internal state using RegisterTraceDOMWrappers() which should have detached the ThreadState from the Isolate. Bug: 948807 Change-Id: I27d7cdafd8877afec09b4ff4b3f023647f82a2e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675548 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#672081}
-
Devlin Cronin authored
Push the expiration Extensions.ExtensionFrameMapCacheHit and Extensions.ExtensionFrameMapLookupSuccessful back a few milestones. Also add an additional owner. Bug: 975300 Change-Id: I160f5079e0dd18704de0f2d67520056ed7580e7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672757Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#672080}
-
Rune Lillesveen authored
TBR=luoe@chromium.org Bug: 978304 Change-Id: Ief1418341e44ed5f67a782be8bfd71f96bbbc47d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676128Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#672079}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cc84ea1d6c32..adf18ce45a3c git log cc84ea1d6c32..adf18ce45a3c --date=short --no-merges --format='%ad %ae %s' 2019-06-25 borenet@google.com [infra] Add go_win asset, add InfraTests_Win bot 2019-06-25 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-06-25 bsalomon@google.com Trace events in backend texture APIs and GrDataUtils Created with: gclient setdep -r src/third_party/skia@adf18ce45a3c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:919885 TBR=djsollen@google.com Change-Id: I2cabf55998853bc37f65b26e6841e4ad0c2d39a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676228Reviewed-by:
-
Robert Sesek authored
Bug: 932175, 944985 Change-Id: I9a209965e3454e09a6914b2b19a8a44c4e841a90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539799Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#672077}
-
Anna Mace authored
Implement GetSetSize, GetPosInSet, IsOrderedSet and IsOrderedSetItem overrides for ViewAXPlatformNodeDelegate. These functions currently use the empty base implementation (i.e. return false, 0) so screen readers will not get information about sets for View elements, e.g. groups of radio buttons. With this change, screenreaders using UIA will read 'n of m' for items within a set. The Views-specific implementation for these functions considers two things when calculating set size and pos in set: -If AXNodeData has the attribute kPosInSet or kSetSize, it will return that value first. -If not, it will see if this View is contained in a group (View::GetGroup()). If so, it will count how many nearby Views are in that same group. If the View has a parent, it will start from the parent and include all ancestors of the parent. That way, sibling elements within the same group are included in the count. When calculating position in set, it will return the index of that View in the resulting vector of Views. Views::SetGroup is only used in a few places in the codebase. I have based the implementation off those uses so they are all supported. I general it seems Views that share group ids are siblings, and sometimes also their parent. 1. Radio buttons are constructed with a group_id passed in. Typically, it seems RadioButtons are siblings. 2. Groups of buttons in dialogs (e.g. "Bookmark added" dialog "More", "Done" and "Remove" buttons) may be in groups. See DialogClientView::UpdateDialogButton button->SetGroup(kButtonGroup) 3. ParentAccessView::AccessCodeInput contains multiple AccessibleInputFields. These are all in the same group, including the parent AccessCodeInput. SetGroup(kParentAccessInputGroup); .. field->SetGroup(kParentAccessInputGroup); 4. DesktopMediaListView contains many child DesktopMediaSourceViews, which are all in the same group source_view->SetGroup(kDesktopMediaSourceViewGroupId); Based on that, I think it is reasonable to only count the parent and sibling Views (and their ancestors) in calculating the number of Views in a group. Change-Id: I0fb72ced30b1c8220cd076d92ecb279802d4b36e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669329 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#672076}
-
Morten Stenshorne authored
TBR=eae@chromium.org Bug: 481431, 978371 Change-Id: If5355445e48d3b022b9194b1efc0c8a423d55076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675361Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#672075}
-
Zentaro Kavanagh authored
- Some conditions are evaluated when the page first loads before displays have been fetched resulting in displays being undefined - Some of these cases were previously fixed, but this one was missed because it tries to get a property from displays when the unified desktop flag is enabled. - The result is that the display page in device settings never renders in unified desktop mode. - Add tests for all functions called before displays are populated - Add missing tests for unified desktop BUG=chromium:948888 TEST=manual Change-Id: I6beae6d46982ff632132ae3fe07044d2b73c0843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666743Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#672074}
-
Vladislav Kuzkokov authored
Refactor to |base::OnceCallback| where possible. Explicitly use |base::RepeatingCallback| where it isn't. Leave as is if depends on API that should be updated. Bug: 968109 Change-Id: I8b1c3dee4595b03a1f1cf1a285441be3707e83c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648494Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#672073}
-
