- 20 Aug, 2019 40 commits
-
-
Gabriel Charette authored
This is a partial reland of https://chromium-review.googlesource.com/c/chromium/src/+/1635827 for the task traits additions that were already LGTM'ed. TBR=fdoray@chromium.org Bug: 968047 Change-Id: I2dc33aadae040b12e58157c80c343a055ed441f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762417 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#688689}
-
Sammie Quon authored
It's only used for ash, but I think it makes most sense to be in transform_util.cc. Test: added test Bug: none Change-Id: I6cef151a97a1841e57db17083320bd444bb24b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756924Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#688688}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f624b9be..15b9f9d6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5079b45577a3365d646820b164e92a0ea33e9b3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758466Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688687}
-
Lutz Justen authored
Tickets should be forwardable by default to match the behavior for Chromad. This was an oversight. BUG=None TEST=Tested manually that getting tickets still works Change-Id: If35ba1d73e4348c3d87f6a685d509c24bdf5f621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753929Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Auto-Submit: Lutz Justen <ljusten@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#688686}
-
Koji Ishii authored
This patch moves |EnsureNodeId()| to inside of |NGTextFragmentPainter::Paint()| from its callers. All callers do the same preparations, this unifies them Bug: 924681 Change-Id: I3f0ca7d1ca418943604254ffd425df4e9edb7c33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761872 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#688685}
-
Ryan Powell authored
This CL creates the SystemMemoryPressureEvaluator for ChromeOS, as part of a refactoring of the MemoryPressureMonitor to use the Voter-Aggregator design described here: https://docs.google.com/document/d/1W3FPDyjIAKBcFGNYsHA3EKR1FHrJlbBaqT4_RUnxzq0/edit?ts=5d3f5714#heading=h.7nki9mck5t64 This Evaluator calculates memory pressure and emits notifications identically to the previous Monitor, but does so by casting its votes for memory pressure through a MemoryPressureVoter. Bug: 980965 Change-Id: I0b3d9caa19ede5474ef1bae04be43fd5a9334869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756765 Commit-Queue: Ryan Powell <ryanpow@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#688684}
-
Malay Keshav authored
This patch replaces the use of apng animation file (580 KiB) with a lottie animation file (8 KiB). Bug: 976057 TEST: Manually navigated to the animation page Change-Id: I4c8fa8784b1e2bd1be071752eae8696f58c66737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725235 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#688683}
-
Gabriel Charette authored
Partial reland of https://chromium-review.googlesource.com/c/chromium/src/+/1635827 Extracted HasTraits() modification to make revertable part of the desired change as small as possible. TBR=fdoray@chromium.org Bug: 968047 Change-Id: I9683326cceee53164e4482d71cf6929296a8db7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762332 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#688682}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f878992e96bd..35815c5fbd26 git log f878992e96bd..35815c5fbd26 --date=short --no-merges --format='%ad %ae %s' 2019-08-20 saklein@chromium.org Revert "AndroidService: Refactor uprev and unpin endpoints." 2019-08-20 cjmcdonald@chromium.org Migrate DepgraphGenerator to separate library 2019-08-20 dhanyaganesh@chromium.org config: Make fizz-moblab experimental 2019-08-20 mmortensen@google.com Update gen/chromite/api/binhost_pb2.py for PrepareDevInstallBinhostUploads. Created with: gclient setdep -r src/third_party/chromite@35815c5fbd26 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ia8257e433812a2faf619f4cfb36bc25830d33246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761681Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688681}
-
Yi Gu authored
VizHitTestSurfaceLayer will go 1% on stable in M77 (SR: Sep 10). In case that it cannot be fully shipped in M77, it's better to have the flag available in M78 (branch Sep 5) and M79 (branch Oct 17). Bug: None Change-Id: I0db79a07667ce18bafa66b6fd2f2e7a4b5f6aab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762580 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#688680}
-
Aaron Leventhal authored
Defer the menu start event, so that it does not conflict with form control focus announcements. Bug: 990476 Change-Id: I3c2559080aa8ccde5e515977077ae8dd08ce251f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758587Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#688679}
-
Madeleine Barowsky authored
YUV decoding is rolling out across platforms and bots for certain kinds of WebP images (crbug.com/900264). Because we do not yet (crbug.com/943519) support caching YUV decoders to incrementally decode an image as more data arrives, this can cause flakiness of the final web_tests image because the YUV and RGB shader results differ by a couple of pixels [1]. Thus we use JavaScript to preload images in web_tests that may go down the YUV path before decoding them. Because this makes the test asynchronously modify the DOM, we refactor the tests to use testRunner.waitUntilDone() to ensure all images have been decoded and added to the page before capturing pixel results. These modified tests are moved under images/yuv-decode-eligible/. Also, the gpu-rasterization virtual test suite now forces YUV decoding for the images/ directory because we intend this to become the default path. However, there will still be cases for RGB decoding and GPU rasterization, so this change maintains coverage by adding virtual/gpu-rasterization-disable-yuv. We update test expectations and baselines for those tests and suites affected by this change, committing deterministic results about which images currently go down the YUV or RGB decoding path. [1]: https://test-results.appspot.com/data/layout_results/win7-rel/130854/webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html See webp-no-color-profile-lossy.html. Bug: 981137, 943519, 730267 Change-Id: I6f783833489b116a4d64c8853fe63323f4236f6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700112 Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#688678}
-
Malay Keshav authored
This patch introduces a new polymer element for chrome OS that is responsible for running lottie animations on a third party player on a worker thread. Added unit tests. Bug: 976057 Change-Id: I32323d758e432d7506fed6d9346b019cd9234653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725322 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#688677}
-
Zinovy Nis authored
Bug: 994915 Change-Id: I2e1bcf286a2d2fa6613e18b5268098a0d258fb2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759163 Commit-Queue: Zinovy Nis <zynis@yandex-team.ru> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#688676}
-
Junbo Ke authored
Change-Id: I900f6f167ce35947be9c0908d2920fa9ddadd327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761442Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Junbo Ke <juke@chromium.org> Cr-Commit-Position: refs/heads/master@{#688675}
-
Connor Clark authored
Bug: 981495 Change-Id: Ide73a699c3bc4cb06e05623778a6c41a91af6163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761216Reviewed-by:
Erik Luo <luoe@chromium.org> Reviewed-by:
Paul Irish <paulirish@chromium.org> Commit-Queue: Connor Clark <cjamcl@google.com> Cr-Commit-Position: refs/heads/master@{#688674}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. LGTM from all OWNERS. Using NOPRESUBMIT since aleloi does not have permission to CR+1 NOPRESUBMIT=true Bug: 977050 Change-Id: Ibae0ce78a7866e011c30ad9c252cbcfe6a9bd823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700921 Commit-Queue: Eric Foo <efoo@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#688673}
-
Malay Keshav authored
Lottie player runs on a worker thread to paint on an offscreen canvas. To enable this on chrome internal pages the content security policy needs to be modified. This patch adds a virtual method that can be used to add content security policy for worker source url. A Worker thread is initialized here: https://chromium-review.googlesource.com/c/chromium/src/+/1725322 Bug: 976057 Change-Id: I91ad1c46c86475d496e6b5b993d9523f12736607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724865Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#688672}
-
Kurt Horimoto authored
OverlayPresentationContext::CancelOverlayUI() has no guarantees that the UI being cancelled has been requested yet. For example, the referenced crash occurs when cancelling a queued request whose UI has never been shown. The previous code assumed that CancelOverlayUI() was only ever called for OverlayRequests for which ShowOverlayUI() has been called previously. This CL updates the logic to early return if it's called for requests that haven't been passed to ShowOverlayUI(). Bug: 991614 Change-Id: I63532e13a32c10498901ae9b70082ded1b348c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762354 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#688671}
-
Kazuki Takise authored
Along with the changes to move always on top to ARC attributes in Android, this CL integrates always on top into commit logic in exo. For PIP, as we want to ensure that always on top is toggled after window state and bounds changes have been done, we update always on top in onPostWidgetCommit. BUG=b:138768141 BUG=b:138741400 TEST=Manually confirmed always on top works properly with ArcCompanionLibDemo TEST=Manually confirmed YouTube doesn't flicker when entering PIP Change-Id: I22dbad22985bd6e0249b207509e1b0563486edbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732703Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Commit-Queue: Kazuki Takise <takise@chromium.org> Auto-Submit: Kazuki Takise <takise@chromium.org> Cr-Commit-Position: refs/heads/master@{#688670}
-
Akihiro Ota authored
This change allows kMenuItems to be valid children of kMenuListOption elements for PosInSet and SetSize calculations. The motivating example for this change was navigating through the app menu in the Chrome toolbar using ChromeVox(the menu that contains buttons for new tab, history, downloads, bookmarks, dev tools, etc.). ChromeVox would report PosInSet and SetSize of 0 for many elements, due to the fact that the elements are held within a kMenuListOption, not a kMenu. In the PosInSet and SetSize code, we have checks to ensure valid parent-child relationships. This is a case that must have been missed in the initial implementation. Change-Id: I8ab6182862cb9a4112d525044046a1e15048fc5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757467 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#688669}
-
Victor Fei authored
Added UIA_IsDialogPropertyID to AxPlatformNodeWin::GetPropertyValue and associated unittests. Bug: 844149 Change-Id: Iebdc0a6227022bb27c355b799f40a9480d3ee7e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757887Reviewed-by:
Ian Prest <iapres@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Ian Prest <iapres@microsoft.com> Cr-Commit-Position: refs/heads/master@{#688668}
-
Nicolas Ouellet-payeur authored
The new `python_script' backend for network annotation buildbots checks calls to CreateMutableNetworkTrafficAnnotationTag(), except for whitelisted files. This CL updates the whitelist for the upcoming migration to the new backend. TBR=rhalavati@chromium.org Bug: 966883 Change-Id: Ib61fa214230a45b8d638f0626c3c2c9dfb5ab1c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760886 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#688667}
-
John Budorick authored
includes: - new footer syntax - correct links to commit-queue.cfg - description of how to configure partial CQ bots Change-Id: I3ba27a6abbe20186d5e3a094737a5f24dbf9e1b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761742Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#688666}
-
John Lee authored
This layers the Settings page's main contents above the toolbar such that the main content is interactable no matter how far the toolbar's text overlaps the main content. Bug: 995686 Change-Id: Id8e244a47a13f19c13b47ce86e8b44afc6255524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762062Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#688665}
-
Julie Jeongeun Kim authored
This CL converts RendererPreferenceWatcherPtr and RendererPreferenceWatcherRequest to new Mojo types. It updates CreateSharedWorker from shared_worker_factory.mojom and all methods and members for RendererPreferenceWatcher to new Mojo types. Bug: 955171, 978694 Change-Id: Ic7c2a1482d5b758e11a6ba48e4809d0542092247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760580 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#688664}
-
Chase Phillips authored
Bug: 995591 Change-Id: I3edba1148e9e03e1029713438189649a56dfe0c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761472 Commit-Queue: Chase Phillips <cmp@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Chase Phillips <cmp@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#688663}
-
Peter Boström authored
This has been enabled by default for quite a while now. Bug: chromium:941039 Change-Id: I263c9642af0aa87ece99e4638e4fdcd2e5308b23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761554 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#688662}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a44d67c6e809..ca1eb7d16750 git log a44d67c6e809..ca1eb7d16750 --date=short --no-merges --format='%ad %ae %s' 2019-08-20 raul@tambre.ee setup_color: Use native ANSI support on Windows 10 Created with: gclient setdep -r src/third_party/depot_tools@ca1eb7d16750 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: chromium:942522 Change-Id: I9e677d7ae8ba3f95185ef4f27c07c36de8ddfefd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760118Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688661}
-
Antonio Gomes authored
This reverts commit ab7e4e69. Reason for revert: https://crbug.com/995709 Original change's description: > Lazily create UserMediaController > > This CL addressed guidou's remark on [1], that > was accidentally left off when splitting the CL into > smaller pieces. > > [1] https://crrev.com/c/1757490/4/third_party/blink/renderer/modules/modules_initializer.cc#185 > > BUG=704136 > R=guidou@chromium.org, haraken@chromium.org > > Change-Id: Ie46cc5eeb9963dc54538d122b0c922a5ec5c4e3c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760407 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Kentaro Hara <haraken@chromium.org> > Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> > Cr-Commit-Position: refs/heads/master@{#688302} TBR=haraken@chromium.org,guidou@chromium.org,tonikitoo@igalia.com Change-Id: Icd01828810283a7467c03b3be0b22ec24591685b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 704136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758468Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#688660}
-
Mike Frysinger authored
Use r prefix for strings that have embedded backslashes, and for any regex expression as that's the norm. Bug: 983071 Test: `./grit/test_suite_all.py` passes Change-Id: Id045e3bd9627f6c8234151104d757aeaf1469dbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758425Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#688659}
-
Matt Menke authored
We should be establishing HTTP connections to HTTP/1.1 proxies, so it's weird to apply REQUIRES_HTTP_11 logic to them. I'm planning on moving the force HTTP/1.1 bool into HttpServerProperties::ServerInfo, to simplify the class. ServerInfo is, however, keyed on HttpServerProperties rather than HostPortPair, and using either an HTTPS or HTTP scheme in the HTTP proxy case when calling MaybeForceHTTP11 seems weird. Bug: 993801 Change-Id: I4237a28c6a16ea03fe9ad4f60657bd4c32a45b2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761635Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#688658}
-
Evan Stade authored
For certain tests (such as ProfileResetterTest.ResetExtensionsByDisabling), this was logging 2-6 times. Bug: none Change-Id: Ib83a0b9bf8dde67a61288acb123f7527261be37e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762557 Commit-Queue: Evan Stade <estade@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#688657}
-
Scott Violet authored
This provides mapping in ComputedStyle for webkit-box-direction so that it works when LayoutFlexibleBox is used for webkit-box. BUG=993813 TEST=none Change-Id: I2a5526666bf0966f2ade73f4be41e4aaeab5b0ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761393Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#688656}
-
Scott Violet authored
This provides mapping in ComputedStyle for box-ordinal. BUG=993813 TEST=none Change-Id: I0121a52d3c5ace231e36528f9513afbf39341a4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761404Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#688655}
-
Reilly Grant authored
Work on this has not progressed but is still planned. Bumping expiration to M-83. Bug: 422562 Change-Id: Ie27a49e8893c39d40606e65f5823ec993eaefc73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759898 Commit-Queue: Vincent Scheib <scheib@chromium.org> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#688654}
-
Ian Kilpatrick authored
In: https://chromium-review.googlesource.com/c/chromium/src/+/1761067 We moved all the custom layout files to their new NG directory, however we had this link still pointing at a (now non-existent) OWNERS file. NOPRESUBMIT=true Change-Id: I1ba9651947a189a82ce493c3e09585ec2d188964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761774 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#688653}
-
Xida Chen authored
There are already some backdrop-filter-*.html, this CL picks the ones that don't exist in wpt, and put them there. Bug: 900581 Change-Id: Ie6cf7454fed6d3e89f31e69cbad93fdaa7bf3f55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760889 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#688652}
-
Rayan Kanso authored
Move Icon fetching logic to its own file, and re-use the Manifest Icon selection logic to choose the best icon based on known parameters. Bug: 973844 Change-Id: I041f8d66eda86f71be8f2201598c761cb0beb0d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751793 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#688651}
-
Denis Kuznetsov authored
This check was made obsolete by crrev.com/c/1425726, but not removed at that point. As a result, no further work is done on devices without batteries. Bug: 995808 Change-Id: I4a927b8f45723dccdfee198c789bed13003a0e12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762240Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#688650}
-