GitLab

The windows bots were incorrectly doing 64-bit builds, and the
debug bots (both mac and win) were incorrectly doing shared builds.

TBR=phajdan.jr@chromium.org
BUG=454413
CQ_EXTRA_TRYBOTS=tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg

Review URL: https://codereview.chromium.org/1086163002

Cr-Commit-Position: refs/heads/master@{#325297}

BUG=462581

Review URL: https://codereview.chromium.org/1061803004

Cr-Commit-Position: refs/heads/master@{#325296}

This patch implements the Notification.data property for persistent
notifications, where the data is stored in the Notification Database.

The data associated with non-persistent notifications will never leave
Blink, so no changes are required in Chromium to support this.

As an implementation-defined limit, the size of the data will be
limited to a maximum of 1024^2 characters, with a UMA histogram tracking
the size of what developers are trying to store. The limit can then be
adjusted in future releases to match this more accurately, or as an
argument to introduce such a limit in the specification.

Further layout tests are being introduced in the following CL:
  https://codereview.chromium.org/1052693002

BUG=442129

Review URL: https://codereview.chromium.org/1052683002

Cr-Commit-Position: refs/heads/master@{#325295}

The switch to wall clock time used playback rate incorrectly when
calculating the wall clock time. Instead of multiplying by the
rate it should be divided.

BUG=477165
TEST=new unittest

Review URL: https://codereview.chromium.org/1085133002

Cr-Commit-Position: refs/heads/master@{#325294}

Summary of changes available at:
https://pdfium.googlesource.com/pdfium/+log/eddab44..b330016

This should fix the ARM/linux cross compile.

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_arm_compile
BUG=477162

Review URL: https://codereview.chromium.org/1059463004

Cr-Commit-Position: refs/heads/master@{#325293}

This makes DisplayItemList no longer retain individual display
items when caching into a picture is enabled, except when
tracing is also enabled (so that per-item trace output can
still be produced). Instead, only an SkPicture representation
is retained. This avoids the memory cost of storing both the
SkPicture representation (which is needed for raster performance)
as well as the individual display items.

BUG=476073

Review URL: https://codereview.chromium.org/1077033004

Cr-Commit-Position: refs/heads/master@{#325292}

Convert URLFetcherFile tests to use a shared test fixture.

BUG=471069

Review URL: https://codereview.chromium.org/1087883002

Cr-Commit-Position: refs/heads/master@{#325291}

These people are no longer active in the project, so remove them from
OWNERS because they're not expected to do code reviews.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/1090673002

Cr-Commit-Position: refs/heads/master@{#325290}

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/1085353002

Cr-Commit-Position: refs/heads/master@{#325289}

New error codes from 3.8.7.4 import.

BUG=340757

Review URL: https://codereview.chromium.org/1084243002

Cr-Commit-Position: refs/heads/master@{#325288}

This is relanding both 320971 and 322902 which were reverted in 323869.
See https://codereview.chromium.org/995283004 for the original review.

Previously extensions::Dispatcher was responsible for creating ScriptContexts
then Adding them to its ScriptContextSet. Now, ScriptContextSet creates them
itself. This prepares the Extension system for later changing to lazily or
asynchronously creating ScriptContexts.

BUG=466373
R=rockot@chromium.org

Review URL: https://codereview.chromium.org/1060463004

Cr-Commit-Position: refs/heads/master@{#325287}

The EV Certificate Whitelist loads ~1MB of data using BitStreamReader.
Currently this is read in one bit at a time. Changing BitStreamReader to
support byte reads sped up loading by about 65% on my computer.

BUG=457949

TEST=bit_stream_reader_unittest.cc

Review URL: https://codereview.chromium.org/1070903003

Cr-Commit-Position: refs/heads/master@{#325286}

BUG=

Review URL: https://codereview.chromium.org/1088743003

Cr-Commit-Position: refs/heads/master@{#325285}

Use #pragma suppress to make the warnig disabling more compact.
Don't disable the old 4311 warning because this only applies with /Wp64
which is deprecated and not used.

R=cpu@chromium.org
BUG=440500

Review URL: https://codereview.chromium.org/1091433002

Cr-Commit-Position: refs/heads/master@{#325284}

BUG=

Review URL: https://codereview.chromium.org/1089253002

Cr-Commit-Position: refs/heads/master@{#325283}

This CL moves GuestViewEvent to its own file.

It moves the permission check to GuestViewManager.

GuestViewBase now no longer directly depends on extensions.

BUG=444869
TBR=rockot@chromium.org for extensions.gypi

Review URL: https://codereview.chromium.org/1087123002

Cr-Commit-Position: refs/heads/master@{#325282}

Also allow enabling it via a GYP flag.

R=lcwu@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/1058013006

Cr-Commit-Position: refs/heads/master@{#325281}

This pulls in the following Native Client changes:

36f7841: (petarj@mips.com) [MIPS] Change TEST_IS_LOCK_FREE for 64bit types
c827ec5: (dschuff@chromium.org) Add torture test configs for nacl-clang
7005393: (dschuff@chromium.org) Add missing EH failures exclusion file for clang
9b89306: (teravest@chromium.org) Revert of Remove NACL_BUILD_ARCH_MAP (patchset #1 id:1 of https://codereview.chromium.org/1039253003/)
69c5742: (jfb@chromium.org) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
57f974d: (dschuff@chromium.org) Update and triage gcc torture known failures
10a7211: (shinyak@chromium.org) Check archive on Windows.
da6385f: (dschuff@chromium.org) PNaCl: Update compiler-rt revision in pnacl/COMPONENT_REVISIONS
0a06a29: (jvoung@chromium.org) Make the torture test known failures for PNaCl a bit stricter.
6a47074: (dschuff@chromium.org) Run compiler_rt test suite on FYI bots
021d15a: (jvoung@chromium.org) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
9b7cee1: (sbc@chromium.org) Cleanup libnacl's pthread.h
3a908f6: (sbc@chromium.org) Add pthead_condattr_* function to libpthread
002a793: (dschuff@chromium.org) FYI bot script: Fixes for compiler-rt test suite
5e87ba2: (dschuff@chromium.org) Remove libstdc++ tests from toolchain_tests
4d31bac: (dschuff@chromium.org) Fix breakage from 5e87ba2d2c3376efcec763954b5cb81c332d20d1
d25fdca: (dschuff@chromium.org) PNaCl: Update compiler-rt revision in pnacl/COMPONENT_REVISIONS
0ebde97: (dschuff@chromium.org) Remove libstdc++ support from PNaCl toolchain
9c667ae: (dschuff@chromium.org) Update revision for PNaCl
2ef8b63: (dschuff@chromium.org) Run ARM tests first on the PNaCl toolchain linux64 bot
40b7e45: (dschuff@chromium.org) Run memcpy_move_set test with and without -fno-builtin
11953a3: (phosek@chromium.org) Use depot_tools version of Git on Windows for toolchain build

Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/bd095c3ad5f1f25a9c6f44b7f38cec89383a5c33..11953a35fcd4f999b097a343bc49d89f94af21a8

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build

Review URL: https://codereview.chromium.org/1080923005

Cr-Commit-Position: refs/heads/master@{#325280}

R=jam@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/1058063003

Cr-Commit-Position: refs/heads/master@{#325279}

Issue was caused because scrolling the page should happen after the
extensions are visible.

BUG=473002

Review URL: https://codereview.chromium.org/1064573003

Cr-Commit-Position: refs/heads/master@{#325278}

Adds remaining WebStateObserver methods to WebStateObserverBridge and
updates CRWWebStateObserver protocol methods to follow Cocoa style
guidelines for naming delegate methods.

Review URL: https://codereview.chromium.org/1079693002

Cr-Commit-Position: refs/heads/master@{#325277}

Revert of [Android] Remove android_commands uses from build/android/. (patchset #4 id:60001 of https://codereview.chromium.org/1088793002/)

Reason for revert:
Broken for AdbWrapper.Devices(filters=None)

Original issue's description:
> [Android] Remove android_commands uses from build/android/.
>
> This also adds filtering to AdbWrapper.GetDevices().
>
> BUG=267773
>
> Committed: https://crrev.com/55d1762e76ebe2494c882594c620993419d97b98
> Cr-Commit-Position: refs/heads/master@{#325254}

TBR=perezju@chromium.org,klundberg@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=267773

Review URL: https://codereview.chromium.org/1089273002

Cr-Commit-Position: refs/heads/master@{#325276}

BUG=430054
R=rockot@chromium.org

Review URL: https://codereview.chromium.org/1084873003

Cr-Commit-Position: refs/heads/master@{#325275}

TBR=aboxhall@chromium.org
BUG=467921

Review URL: https://codereview.chromium.org/1063163003

Cr-Commit-Position: refs/heads/master@{#325274}

When this class was introduced, it served the needs for non-persistent
Web Notifications (and other kinds of notifications), with the knowledge
that it wouldn't be able to reliably provide many of the API methods
defined in the NotificationUIManager interface. That was OK.

Today, we only ship persistent Web Notifications, which can outlive the
browser process, and don't use the NotificationUIManagerAndroid for any
other purpose. However, the code to support other kinds of notifications
is still more or less in place, with no tests or users. It's broken.

Therefore we remove it. This CL also removes a test that doesn't make
sense anymore, since this stops us from double-closing notifications.

BUG=

Review URL: https://codereview.chromium.org/1072043003

Cr-Commit-Position: refs/heads/master@{#325273}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/826e9c27..dceaf644

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1091583002

Cr-Commit-Position: refs/heads/master@{#325272}

BUG=475090

Review URL: https://codereview.chromium.org/1087023003

Cr-Commit-Position: refs/heads/master@{#325271}

Requires some cleanup of issues exposed by various clang plugins.

R=lcwu@chromium.org,servolk@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/1080703004

Cr-Commit-Position: refs/heads/master@{#325270}

We want to show extension message bubbles on multiple platforms;
the first step towards this is to make the bubble factory
platform-abstract. Do so, and also add a handful of tests for the
process of showing the bubble.

BUG=474092
TBR=sky@chromium.org (no relevant changes since original land)

Review URL: https://codereview.chromium.org/1087713002

Cr-Commit-Position: refs/heads/master@{#325269}

Revert of Revert of Small refactor around futex.h. (patchset #1 id:1 of https://codereview.chromium.org/1084173003/)

Reason for revert:
Sorry, mistake on my part, this CL isn't the cause.

Original issue's description:
> Revert of Small refactor around futex.h. (patchset #1 id:20001 of https://codereview.chromium.org/1076213002/)
>
> Reason for revert:
> Breaks ChromeOS veyron_jerry boot.
>
> BUG=477352
>
> Original issue's description:
> > Small refactor around futex.h.
> >
> > This is the preparation of seccomp-bpf implementation
> > for nacl_helper_nonsfi.
> > PNaCl toolchain does not provides linux/futex.h.
> > This CL is the preparation to reuse android_futex.h
> > for PNaCl toolchain, too.
> >
> > TEST=Ran bots.
> > BUG=358465
> >
> > Committed: https://crrev.com/3b996212fa3c92af3233246ae54af728eb7c3591
> > Cr-Commit-Position: refs/heads/master@{#324996}
>
> TBR=mdempsky@chromium.org,hidehiko@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=358465
>
> Committed: https://crrev.com/4c05c94295ee26adffe966678719085f02b15f2f
> Cr-Commit-Position: refs/heads/master@{#325265}

TBR=mdempsky@chromium.org,hidehiko@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=477352

Review URL: https://codereview.chromium.org/1088253002

Cr-Commit-Position: refs/heads/master@{#325268}

Toggling the bookmarks bar changes the height of the browser window
when viewing a regular web page but does not change its height when
viewing a NTP. As a result, it is possible for the browser window to
creep taller or shorter with the right sequence of steps. When the
browser window gets shorter, it's possible to decrease its height to
0.

This change does not address the difference in behavior between NTPs
and regular web pages with the bookmarks bar, but it prevents the
browser window from programmatically dropping below its min height.

Added a unit test, and also had to adjust a unit test that created browser
windows with a height < 200 (min height for a browser window is 272).

BUG=230400
TEST=Create a browser window, confirm that View -> Always Show Bookmarks
Bar is checked, navigate to www.google.com, resize the window to its
minimum height, choose View -> Always Show Bookmarks Bar - the browser
window's bookmarks bar should disappear, but the browser window's height
should not change.

Review URL: https://codereview.chromium.org/1052123006

Cr-Commit-Position: refs/heads/master@{#325267}

Prevent the software encoder to accept odd sized video frames by
reusing the same constraints applied to frames allocated by
media::VideoFrame.

BUG=455409

Review URL: https://codereview.chromium.org/1085003002

Cr-Commit-Position: refs/heads/master@{#325266}

Revert of Small refactor around futex.h. (patchset #1 id:20001 of https://codereview.chromium.org/1076213002/)

Reason for revert:
Breaks ChromeOS veyron_jerry boot.

BUG=477352

Original issue's description:
> Small refactor around futex.h.
>
> This is the preparation of seccomp-bpf implementation
> for nacl_helper_nonsfi.
> PNaCl toolchain does not provides linux/futex.h.
> This CL is the preparation to reuse android_futex.h
> for PNaCl toolchain, too.
>
> TEST=Ran bots.
> BUG=358465
>
> Committed: https://crrev.com/3b996212fa3c92af3233246ae54af728eb7c3591
> Cr-Commit-Position: refs/heads/master@{#324996}

TBR=mdempsky@chromium.org,hidehiko@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=358465

Review URL: https://codereview.chromium.org/1084173003

Cr-Commit-Position: refs/heads/master@{#325265}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/f91e676..ddb714b

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review URL: https://codereview.chromium.org/1068483003

Cr-Commit-Position: refs/heads/master@{#325264}

[PATCH 1] : This Patch
[PATCH 2] : https://codereview.chromium.org/908483002/

BUG=223927

Review URL: https://codereview.chromium.org/1036823003

Cr-Commit-Position: refs/heads/master@{#325263}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5778f6a..4127337

TBR=mlamouri@chromium.org,dcheng@chromium.org

Review URL: https://codereview.chromium.org/1088183002

Cr-Commit-Position: refs/heads/master@{#325262}

UMA shows StartWorker fails more than expected, but most errors are just
the generic START_WORKER_FAILED. Use a more specific error when appropriate.

This has some user-visible behavior change in the error message that register()
rejects with. For example, a syntax error used to fail with "ServiceWorker failed
to install"; now it fails with "ServiceWorker script evaluation failed".

A Blink layout test is added for error messages, which didn't have test
coverage previously.

BUG=448003
TEST=https://codereview.chromium.org/1058323004

Review URL: https://codereview.chromium.org/1063823005

Cr-Commit-Position: refs/heads/master@{#325261}

The tab on the left side should be selected when scrolling to left and vice versa.

BUG=365501
TEST=Prepare a mouse with horizontal-scrolling feature, open multiple tabs, place cursor over tab strip and try to switch tabs.

Review URL: https://codereview.chromium.org/1084903002

Cr-Commit-Position: refs/heads/master@{#325260}

1) Window A belongs to user1 and is shown for user1. Minimizes window A.
Switch to user2, window A can not be activated by user2.

2) Window A belongs to user1 and is shown for user2. Then windowA can be activated
by user2 but cannot be activated by user1.

Also add unit tests for these two cases.

BUG=471858
TEST=manually tested

Review URL: https://codereview.chromium.org/1053013007

Cr-Commit-Position: refs/heads/master@{#325259}

SeparateHandler has been added to handle delete and undo commands when search box is active or focused.

BUG=462861

Review URL: https://codereview.chromium.org/1089163002

Cr-Commit-Position: refs/heads/master@{#325258}