GitLab

Ownership of the HANDLE in ResourceMsg_SetDataBuffer isn't managed
automatically.

Also invert ForwardingFilter/TestFilter's superclass/subclass
relationship. This arrangement avoids the useless dest_ = NULL
codepath.

BUG=366246

Review URL: https://codereview.chromium.org/257763007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266790 0039d316-1c4b-4281-b951-d872f2087c98

The latest version of the NDK experimental crtend in this location.
Andrew Hsieh confirms this is correct for multilib NDK.

BUG=346626

Review URL: https://codereview.chromium.org/256803008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266789 0039d316-1c4b-4281-b951-d872f2087c98

The captive portal window was being blocked by the GAIA auth extensions's
background script because the script could not tell it from the GAIA login
frame. This CL ensures that the login UI has a unique tab ID, making it
distinguishable from the captive portal window.

BUG=367713
TEST=Manual; updated tests forthcoming in bug 367731

Review URL: https://codereview.chromium.org/259663006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266788 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/256943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266787 0039d316-1c4b-4281-b951-d872f2087c98

BUG=362796

Review URL: https://codereview.chromium.org/236073004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266783 0039d316-1c4b-4281-b951-d872f2087c98

The dependency is no longer required.

Review URL: https://codereview.chromium.org/259983007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266782 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266781 0039d316-1c4b-4281-b951-d872f2087c98

BUG=365499
TBR=

Review URL: https://codereview.chromium.org/256853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266780 0039d316-1c4b-4281-b951-d872f2087c98

BUG=261628
R=markusheintz@chromium.org

Review URL: https://codereview.chromium.org/254933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266779 0039d316-1c4b-4281-b951-d872f2087c98

BUG=239179

Review URL: https://codereview.chromium.org/258603004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266778 0039d316-1c4b-4281-b951-d872f2087c98

We're setting them true, they already default true. We're removing them.

R=piman
BUG=365853, 366114, 365847

Review URL: https://codereview.chromium.org/257113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266777 0039d316-1c4b-4281-b951-d872f2087c98

The math with it just cancels out, so it's not necessary.

BUG=
TEST=open http://www.w3schools.com/html/tryit.asp?filename=tryhtml_youtubeobject with NPAPI flash and scroll it

Review URL: https://codereview.chromium.org/257963003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266776 0039d316-1c4b-4281-b951-d872f2087c98

BUG=239179

Review URL: https://codereview.chromium.org/245473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266775 0039d316-1c4b-4281-b951-d872f2087c98

With the current implementation, the field ordering start with 1, while
it must starts with 0 for structs.

R=davemoore@chromium.org

Review URL: https://codereview.chromium.org/252633007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266774 0039d316-1c4b-4281-b951-d872f2087c98

BUG=239179

Review URL: https://codereview.chromium.org/251673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266773 0039d316-1c4b-4281-b951-d872f2087c98

Android's delegate overrides Accept/Cancel and does not record
all the necessary histogram actions.

BUG=329200

Review URL: https://codereview.chromium.org/258093003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266772 0039d316-1c4b-4281-b951-d872f2087c98

This change is motivated by the need to set the test install attributes before the browser policy connector is initialized for the first time. In particular, test class members may cause the policy connector to be initialized in their constructors, so we also need to set the install attributes in the constructor of a member.

BUG=243341

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266094

Review URL: https://codereview.chromium.org/247283007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266771 0039d316-1c4b-4281-b951-d872f2087c98

This test had some issues with accidentally nested RunLoops.  The
attached bug includes a small essay that thoroughly describes the issue.

The solution implemented here is to prevent nesting by not allowing
multiple calls to IsExitConditionRequired() to occur on the stack at the
same time.  It also ensures that the requests to check the exit
condition are not fully ignored; it will retry the check if a call was
attempted and rejected while the current one was in progress.

This CL also disables self-notifications for the
MultipleClientPasswordsSyncTest.  Since the test no longer depends on
AwaitQuiescence, self-notifications should be no longer necessary.

BUG=363247

Review URL: https://codereview.chromium.org/250943005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266770 0039d316-1c4b-4281-b951-d872f2087c98

Now nacl_loader target is built on all platforms. Also,
nacl_loader target was renamed to nacl_linux.

TEST=ninja -C out/Release chromium_builder_tests
TEST=GYP_DEFINES='disable_nacl=1' ./build/gyp_chromium \
     ninja -C out/Release chromium_builder_tests
TEST=trybots
BUG=364751
R=mseaborn@chromium.org

Review URL: https://codereview.chromium.org/260063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266769 0039d316-1c4b-4281-b951-d872f2087c98

This is a regression issue what happened because
PR_SET_NO_NEW_PRIVS is set by default when launching some process.
It must be execute normally. (when using sandbox)

BUG=358713,366056

Review URL: https://codereview.chromium.org/246653008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266768 0039d316-1c4b-4281-b951-d872f2087c98

This is to support longer text in simple notifications.

BUG=361890

Review URL: https://codereview.chromium.org/256883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266767 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/250803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266766 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/257823003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266765 0039d316-1c4b-4281-b951-d872f2087c98

Enforce that certain key input events (see list below) are on screen. This
helps detecting bugs where we're accidentally starting a gesture that's off
screen and therefore doesn't have an effect.

BUG=363125

Review URL: https://codereview.chromium.org/256593013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266762 0039d316-1c4b-4281-b951-d872f2087c98

Modifies the pepper flash component installer to also look in a path under the Windows system directory for a debugger version of the flash DLL. This DLL is not registered as a chrome component. It is configured to load after the non-debugger flash DLL.

BUG=345886

Review URL: https://codereview.chromium.org/203993004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266761 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds:
- proto file for RegistrationData and ResourceRecords
- reading/writing/deleting operations for RegistrationData
- unittests for these operations


BUG=364099
TEST=content_unittests --gtest_filter=ServiceWorkerDatabaseTest.*

Review URL: https://codereview.chromium.org/248803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266760 0039d316-1c4b-4281-b951-d872f2087c98

BUG=363564
TEST=as in bug

Review URL: https://codereview.chromium.org/239393009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266759 0039d316-1c4b-4281-b951-d872f2087c98

This test started failing constantly in 
http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20%28dbg%29%281%29/builds/23020

But there is no obvious CL that caused the problem. The root cause seems to be related to 367665, so this test is now disabled on Mac until the root cause is found.

BUG=367665
TBR=nick@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/252893007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266758 0039d316-1c4b-4281-b951-d872f2087c98

Revert of cc: SwapAck throttle Swap without throttling MainFrames (https://codereview.chromium.org/222023010/)

Reason for revert:
[Sheriff] Speculative revert for breaking win7 dbg:

http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%284%29/builds/26034

Will reland if it didn't help.

Original issue's description:
> cc: SwapAck throttle Swap without throttling MainFrames
> 
> This should improve main thread throughput in cases
> where we are deferring the BeginMainFrame, but don't
> really need to because the swap ack will come back
> before the impl thread needs to draw anyway.
> 
> BUG=311213
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266685

NOTREECHECKS=true
NOTRY=true
BUG=311213
TBR=Sami, danakj, brianderson

Review URL: https://codereview.chromium.org/255033004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266757 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266747 0039d316-1c4b-4281-b951-d872f2087c98

The tab dragging code uses the GetCursorPos API to determine the tab strip to be used
to drag the tab into. This API returns values in pixel. We need to convert to DIP and
vice versa wherever needed.

Changes as below:-
1. window_finder_win.cc :- The cursor position after my changes now comes in as DIP.
                           We need to convert to pixel as this class uses PtInRect
                           and other APIs which need values in pixel.
2. screen_win.cc :- The GetCursorScreenPoint now returns values in DIP which is what is
                    expected. These values are passed to views and other places which
                    expect values in DIP.
3. apps_grid_view.cc :- Converted cursor position to DIP before passing it to the views code.

Looked at other usages of this API. They seem to be in order. Thought about adding helpers for
this for Windows. Decided against it as it is very hard to enforce given that it is a popular
API.

BUG=364969
R=sky@chromium.org, sky

Review URL: https://codereview.chromium.org/256923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266744 0039d316-1c4b-4281-b951-d872f2087c98

Mac currently links events_stub.cc. This change adds an events_mac.mm
allowing basic ui::Event fields to be populated for keyboard and mouse.

To implement CopyNativeEvent on Mac, some objective C code needs to be
called. Part of this change moves CopyNativeEvent from an anonymous
namespace to platform-specific events_foo.cc/mm, and adds a
corresponding ReleaseCopiedNativeEvent.

BUG=366021
TEST=events_unittests

Review URL: https://codereview.chromium.org/251493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266743 0039d316-1c4b-4281-b951-d872f2087c98

ui_unittests needs the ICU data file.

Review URL: https://codereview.chromium.org/259123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266742 0039d316-1c4b-4281-b951-d872f2087c98

BUG=354143

Review URL: https://codereview.chromium.org/258073003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266741 0039d316-1c4b-4281-b951-d872f2087c98

This will allow the test suite to be added to buildbot before any real code
lands, so it can be properly tested.

BUG=367863

Review URL: https://codereview.chromium.org/252073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266740 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266739 0039d316-1c4b-4281-b951-d872f2087c98

BUG=368051
TEST=none
R=robliao@chromium.org
TBR=robliao

Review URL: https://codereview.chromium.org/255063005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266738 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 5d76e140.

Original review:
https://codereview.chromium.org/106973003
BUG=362442,278540
TBR=dmazzoni
TEST=Manually verify ChromeVox starts on guest mode.
NOTRY=true

Review URL: https://codereview.chromium.org/258063008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266737 0039d316-1c4b-4281-b951-d872f2087c98

This caused breakage because many places create a LabelButton then call SetBorder. By calling SetBorder whenever the NativeTheme changes, the custom border is overridden.

BUG=367614,367625,367607

Review URL: https://codereview.chromium.org/256103006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266736 0039d316-1c4b-4281-b951-d872f2087c98

We create a new NaClSandbox class, with InitializeLayerOneSandbox() and
InitializeLayerTwoSandbox() methods.

This class centralizes existing code and adds important security checks as
to whether or not threads are running or directory file descriptors are open.

BUG=359230, 358719
R=mseaborn@chromium.org

Review URL: https://codereview.chromium.org/250773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266735 0039d316-1c4b-4281-b951-d872f2087c98