- 15 Sep, 2018 12 commits
-
-
Xiaohui Chen authored
Bug: 114082902 Test: locally build Change-Id: Id29bb95768d2a6da75b649e4a32b4e37c74a6897 Reviewed-on: https://chromium-review.googlesource.com/1226263Reviewed-by:
Mike Frysinger <vapier@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#591540}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7a02a8fc..d0c0f8f9 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I377aff811254e9e18a27ae5b0089cd14de6f6cb2 Reviewed-on: https://chromium-review.googlesource.com/1227471Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#591539}
-
Robbie McElrath authored
This migrates ServiceDiscoveryClientMdns from NetworkChangeNotifier to NetworkConnectionTracker, which is needed for it to work with the network service enabled. Bug: 883120 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I910b7987d849c2e66565a774937086382ba6f7e5 Reviewed-on: https://chromium-review.googlesource.com/1220808 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#591538}
-
Cathy Li authored
This is to facilitate sharing between explore sites and most likely tiles. Bug: 867488 Change-Id: Ic84c2a5363318bea6e7237085d4df9f346b09891 Reviewed-on: https://chromium-review.googlesource.com/1213706 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#591537}
-
Pete Williamson authored
This change adds metrics for how often the user takes multiple screenshots of a page, and when actions such as bringing up sharing or in product help for downloads happen after screenshotting a page. It also moves the logging of Tab.screenshot usercounts into Tab.java to make it unit testable, and adds a unit test for it. Metrics design doc: https://docs.google.com/document/d/1iyiVQODF1qh_Qiz7Is1y9jvWt1DYjgXmiJgLbFt2tSs Bug: 857505 Change-Id: I7bdcef8602782bade2fa1b3a55ff11d1ccfc6e6f Reviewed-on: https://chromium-review.googlesource.com/1211022 Commit-Queue: Peter Williamson <petewil@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#591536}
-
David Tseng authored
TBR=dmazzoni@chromium.org Bug: 881845 Change-Id: I4b95fe46c6d5c07ad94b17eaf76257e81767763d Reviewed-on: https://chromium-review.googlesource.com/1225984Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#591535}
-
Xianzhu Wang authored
The bugs are about crashes happening snapdragon 820 only which looks like a CPU bug triggered by particular instruction sequence. The CL creates non-inlined version of the destructors hoping the compiler can generate good code with smaller optimization scopes. As the classes have many data fields that needs destruction code, having non-inlined destructors may also be beneficial to code size. Bug: 877115,848404 Change-Id: Iffb6c4a31fadff6278a33b596520d4a60f6b11bd Reviewed-on: https://chromium-review.googlesource.com/1226134 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#591534}
-
Christian Biesinger authored
R=ikilpatrick@chromium.org,eae@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I4d70f5a3e22a32ee2c9c261b731fd7afafe7ce0f Reviewed-on: https://chromium-review.googlesource.com/1227252Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#591533}
-
Eugene But authored
Logs the number of items Navigation Manager was requested to restore. 100 is logged when the number of navigation items is greater than 100. This is just a requested count and actual number of restored items can be smaller. Bug: 877671 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Id528320cfae35a04c9199d21ff14d5ff72c0aed2 Reviewed-on: https://chromium-review.googlesource.com/1225697 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#591532}
-
Nasko Oskov authored
Bug: 789577 Change-Id: Idef29eb4330d8a4b350865d7acf1f01abc94cc8e Reviewed-on: https://chromium-review.googlesource.com/1227409 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#591531}
-
chrome://extensionsDevlin Cronin authored
Add a link to the help article for runtime host permissions in the chrome://extensions page. Note: the article that lives at this page is currently a placeholder, and will be updated on the server. Bug: 877664 Change-Id: Idc46b063d502b99458457679f279fa8d10e8e131 Reviewed-on: https://chromium-review.googlesource.com/1220473Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#591530}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ib9cdfe96e666e247d2974c894b1edcf8799e0a98 Reviewed-on: https://chromium-review.googlesource.com/1227485Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#591529}
-
- 14 Sep, 2018 28 commits
-
-
Melissa Galonsky authored
settings for unrelated content types. The extensions api had a bug where calling clear on an instance of content settings in turn called a function that did not take content type as a parameter and cleared all content settings for that extension. This adds a function that clears the settings set by an extension for a particular content type. Bug: 700404 Change-Id: I29d519a80006a892fa27be50cf54042247032b38 Reviewed-on: https://chromium-review.googlesource.com/1179620Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Melissa Galonsky <mgalonsky@chromium.org> Cr-Commit-Position: refs/heads/master@{#591528}
-
Robert Ogden authored
This is used to notify the Android ToolbarManager that the LoFi preview was opted-out of and the UI should no longer be shown to the user. Bug: 883388 Change-Id: I8151fa96adeb7d0afe4c0122a3a4cf10bb546e24 Reviewed-on: https://chromium-review.googlesource.com/1222410 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#591527}
-
Adam Langley authored
Change-Id: Ib6c4ae24146e435585fe1ba064e26002d49b8f9c Reviewed-on: https://chromium-review.googlesource.com/1224953Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#591526}
-
Etienne Pierre-Doray authored
Tls affects result of GetLastError on windows. To avoid interaction with base::File, last error is saved and restored in the destructor of ScopedBlockingCall. Bug: 874080 Change-Id: Id17ac4e7ee4ffaf33eda30784b86ad41e21b8b96 Reviewed-on: https://chromium-review.googlesource.com/1220172 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#591525}
-
Kevin Marshall authored
Allows PathService's APP_DATA path to be dynamically overriden, for handling incognito, persistent, and browsertest cases. Remove GetPackageRoot() and replace it with PathService getter calls. Add hooks to allow browser test suites to override how APP_DATA is configured. BUG=798851 Change-Id: I465d5801f3237d37e84011ae2f83b7efa6258c18 Reviewed-on: https://chromium-review.googlesource.com/1227406Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#591524}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/6d5f1bc2e846..4a4632264eb9 git log 6d5f1bc2e846..4a4632264eb9 --date=short --no-merges --format='%ad %ae %s' 2018-09-14 dnovillo@google.com Add IR dumping functions to use during debugging. 2018-09-14 antiagainst@google.com Add support for VK_KHR_shader_atomic_int64 in validator Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@4a4632264eb9 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic024fb44b8649e0e8f8f5a5a17f18d543aea8926 Reviewed-on: https://chromium-review.googlesource.com/1227232Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#591523}
-
Vladislav Kaznacheev authored
Currently ChromeOS is using existing Chrome resource icons to represent Web Store app in the system UI (Launcher and Shelf). There is a new requirement for ChromeOS app icons to be compliant with Material Design guidelines (crbug.com/848007). Adding a set of icons that satisfy the requirement. Bug: 882176 Test: manual Change-Id: Ie6ef8653bf6daac3e514a79610634fd898b7349f Reviewed-on: https://chromium-review.googlesource.com/1219234Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#591522}
-
Alex Moshchuk authored
This CL removes the logic that triggered process swaps in ChromeExtensionsRendererClient::ShouldFork() for the case when the main frame reloads a URL for which a hosted app was just installed or uninstalled. This logic isn't needed with --site-per-process, as that mode will already force a process transfer. This is covered by AppApiTest.ReloadIntoAppProcess and AppApiTest.ReloadIntoAppProcessWithJavaScript, which still pass with that logic removed. This CL also makes a fix on the browser side to keep this logic working even without --site-per-process, by unconditionally checking HasWrongProcessForURL() and forcing a process transfer if needed in IsRendererTransferNeededForNavigation(). This is possible because with PlzNavigate we will always go to the browser process and check for transfers, even without --site-per-process. With that fix, the above two tests also pass without --site-per-process. The above tweak also has a side effect of swapping processes when an app opens a cross-site, non-app popup (also made possible by work on issue 794315) in non-site-per-process mode, which seems acceptable and desirable - no reason for the cross-site popup to be in a process with app permissions. Bug: 883550, 883549, 718516 Test: AppApiTest.ReloadIntoAppProcess and AppApiTest.ReloadIntoAppProcessWithJavaScript keep working, with and without --site-per-process. Change-Id: Ibac63fff3a36318fabceb593ca7ae7967eefad89 Reviewed-on: https://chromium-review.googlesource.com/1226075Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#591521}
-
Kevin Bailey authored
Adds 2 histograms related to tab switch metrics: whether a suggestion offered a tab switch, and whether the offer was accepted. Bug: 854714 Change-Id: I9019909d0435efed3ec5f4dbdd31ebbb63c9db68 Reviewed-on: https://chromium-review.googlesource.com/1220268Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#591520}
-
Mina Almasry authored
Bug: b/115732685 Test: Manual Change-Id: I6ced3f247e2e099c92b9773c09d67fdbe0a7e015 Reviewed-on: https://chromium-review.googlesource.com/1227390 Commit-Queue: Mina Almasry <almasrymina@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#591519}
-
Chris Palmer authored
This somewhat relaxes the limitation, enabling more legitimate use-cases while still seemingly being low enough to contain abuse. Also, expressing the limitation in terms of FPS makes the limit less arbitrary. 8 FPS for history modification comports with other performance and functionality goals (like 60 FPS for graphics). Bug: 394296 Change-Id: Ic8edd8c3af57dc4436c71f9c03fb26face4114d7 Reviewed-on: https://chromium-review.googlesource.com/1220042 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#591518}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/4dc8c50f81bd..59d2a590a5fc git log 4dc8c50f81bd..59d2a590a5fc --date=short --no-merges --format='%ad %ae %s' 2018-09-14 tsepez@chromium.org Rename FPDF_RenderPage_Retail() to RenderPageWithContext() Created with: gclient setdep -r src/third_party/pdfium@59d2a590a5fc The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I3a5001368eea83429b2ce01fa7ebe108eaa46ede Reviewed-on: https://chromium-review.googlesource.com/1227231Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#591517}
-
Aga Wronska authored
Skip showing expanded login view and start Public Session right away after user clicks the button on login view. Use default locale and input method. This change applies only to views login. Bug: 882692 Test: Manually + run ash_unittests Change-Id: I85945e813cf61dd84008fab05a4a2dce728d0939 Reviewed-on: https://chromium-review.googlesource.com/1226254 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#591516}
-
Maks Orlovich authored
This should hopefully prevent the writer from falling behind the work queue, and if it does, should limit the memory use --- even if the writer is totally wedged. Credit to Helen Li for the idea. Bug: 809199 Change-Id: Ie9a080b613e3c0fd6a27006e66736e4252d2c920 Reviewed-on: https://chromium-review.googlesource.com/1217039 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#591515}
-
Chris Harrelson authored
This improves BGPT testing to take into account layer position updates due to PAC, and also reduces GraphicsLayer size a little bit. It exposes gfx::PointF directly to some code in core, but that is ok because we already decided that gfx types are ok in core and this is just for SPv1 compositing. Bug: 883949 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6c0423aa66e94c24e96331381e6523ba1fb574b6 Reviewed-on: https://chromium-review.googlesource.com/1227301Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#591514}
-
Daniel Cheng authored
This reverts commit 27986c7c. Reason for revert: r590596 should have fixed this in a more robust way. Original change's description: > Speculative fix for additional History DocumentLoader crashes. > > There is no guarantee that the DocumentLoader is always attached [1], > so let's introduce null checks in StateInternal and setScrollRestoration. > > [1] The DocumentLoader may be detached while FrameLoader::PrepareForCommit. > > BUG=879477, 872672 > > Change-Id: I048ad8ff3787fcead262c19fcdb485e9e5a5e3bf > Reviewed-on: https://chromium-review.googlesource.com/1200075 > Commit-Queue: Charlie Reis <creis@chromium.org> > Reviewed-by: Nate Chapin <japhet@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588227} TBR=creis@chromium.org,japhet@chromium.org,kouhei@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 879477, 872672 Change-Id: I1dd77d355f42269b70bb53ce19dcb3e1ecb0f15e Reviewed-on: https://chromium-review.googlesource.com/1227392Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#591513}
-
Dana Fried authored
Bug: 866513 Change-Id: I92abdf6f00cb59ef3c7193a3543a41a2fe4b4b6b Reviewed-on: https://chromium-review.googlesource.com/1227364Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#591512}
-
Robert Ogden authored
This DCHECK is especially annoying when testing on localhost when the server is not HTTPS. This changes the DCHECK to be a lot simpler. Open to other ideas to the same effect but the only alternative seems to be DCHECKing the finch param which doesn't seem better or worse. Bug: 864635 Change-Id: Icf7b12991acd2c6bab2cd13c4a40ff4bef1dcee1 Reviewed-on: https://chromium-review.googlesource.com/1227353Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#591511}
-
Dan Sanders authored
This CL completes plumbing a path for creating a MojoVideoDecoder via a render thread, and uses it to construct an RTCVideoDecoderAdapter if --enable-features=RTCVideoDecoderAdapter,MojoVideoDecoder is configured. Bug: 857111 Change-Id: Ia40b571c07cb7070150ec7c3d35320e051eb75ca Reviewed-on: https://chromium-review.googlesource.com/1226430Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#591510}
-
Alex Moshchuk authored
This only checked for the kContentShellAlwaysFork switch, which seems to be unused. Bug: 883549 Change-Id: Ib9e5e9df79caaa0e2d6cda8457b84cf4d391064c Reviewed-on: https://chromium-review.googlesource.com/1226462Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#591509}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4230d4847fdc..62114aae8550 git log 4230d4847fdc..62114aae8550 --date=short --no-merges --format='%ad %ae %s' 2018-09-14 courtneygo@google.com glBufferSubData: Exit early if size is zero Created with: gclient setdep -r src/third_party/angle@62114aae8550 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I5fc59ba1aeefeb44b62f149eaebbd400b84b80da Reviewed-on: https://chromium-review.googlesource.com/1227371Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#591508}
-
Ian Kilpatrick authored
This patch does a few things: 1) Introduces the concept of a "ReplacedPercentageResolutionSize". This is needed as replaced descandants of table cells have a different percentage resolution size than normal descendants. 2) This adds a bunch of special cases for how percentage resolution sizes are handled for table cells. 3) Adds the "scrollable" children of table cell quirk. This is during the "measure" phase, scrollable children contribute nothing to the size of the cell. 4) Adds the "box-sizing: border-box" table cell quirk. That is percentage children, during the layout phase, are sized as if they have box-sizing: border-box on them. It was easier to perform all these changes as a single monolithic patch to ensure correct behaviour. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I881a21662bfdf6b4ab7a0f62df6970143008ebca Reviewed-on: https://chromium-review.googlesource.com/1207890 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#591507}
-
Parastoo Geranmayeh authored
Part of the profile validation pipeline: Previously, we were only doing profile data validation on client side. Now we have two sources of validation: client and server. We need both. (The functions of the autofill profile are renamed accordingly.) Change-Id: Id930c667cacb512858fda4dd78268174d754159a Reviewed-on: https://chromium-review.googlesource.com/1205098 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#591506}
-
Min Qin authored
This serves as a base class for us to send UI updates for both download and offline items Bug: 881499 Change-Id: I54e50191764f9796250be02c7461cb96b9fa85a6 Reviewed-on: https://chromium-review.googlesource.com/1226456 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#591505}
-
Chris Palmer authored
Bug: None TBR: rsesek,kinuko,kouhei Change-Id: I2dda1e9ed0bcdf822a3d310a1654fded31eb8038 Reviewed-on: https://chromium-review.googlesource.com/1227355Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#591504}
-
Gang Wu authored
Implement error handling in content storage, and change callback in java to lambda. Bug: 884230 Change-Id: I0dd9999dc221e7fb4d030d2b8f56d16482b04985 Reviewed-on: https://chromium-review.googlesource.com/1226079Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#591503}
-
Justin DeWitt authored
It was getting a bit cluttered in ExploreSitesBridge, so this creates an ExploreSitesBridgeExperimental that contains all the code required for the "experiment" version (that is still in use behind a flag.) Bug: None Change-Id: Ie5575d1960ef7016a08f7b4eff56327fa15ce1d7 Reviewed-on: https://chromium-review.googlesource.com/1227216 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#591502}
-
Alexei Filippov authored
During thread exits TLS clears its storage vector. If after that a memory is allocated/deallocated profiler hooks gets triggered and access the TLS which makes it reallocate the storage vector that is then never deallocated. The patch makes profiler do not rely on base::ThreadLocalStorage and use the OS primitives directly. BUG=881352,803276 Change-Id: I8493768e57e4121c9ce38d09c77f8d38b04941b3 Reviewed-on: https://chromium-review.googlesource.com/1225280Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#591501}
-