GitLab

Bug: 1085007
Change-Id: I0cf4beaf1c10fabecb79eaa6d7a14d0b52eba6cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210486Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771086}

This function actually produces a periodic Hanning window instead of a
symmetric one.

Change-Id: If921c08d990eafe3e9475de2fbf7b6a64c7879f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211363
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771085}

This is the same file as included in

https://source.chromium.org/chromium/chromium/src/+/master:third_party/robolectric/cipd.yaml;l=16?originalUrl=https:%2F%2Fcs.chromium.org%2F
https://source.chromium.org/chromium/chromium/src/+/master:third_party/robolectric/BUILD.gn;l=59?originalUrl=https:%2F%2Fcs.chromium.org%2F

I'm just moving it to android_deps, so I don't think we need security
or license review.

Will remove duplicate file when robolectric moves to android_deps.
I could possibly remove it now but sdk_texts writes in the location.
https://source.chromium.org/chromium/chromium/src/+/master:third_party/robolectric/BUILD.gn;l=268?originalUrl=https:%2F%2Fcs.chromium.org%2F

Bug: 1060721
Change-Id: I95fd2fc63d652c3b7274753532e6a86081f60a58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210094Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: benjamin joyce <bjoyce@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771084}

Roll Chrome Mac PGO profile from chrome-mac-master-1590061793-cada8ca96f7665a04948a973b6cd8e2e12d92609.profdata to chrome-mac-master-1590076755-1b22274f1ce7584ce2730bbd2446e2694cb4fc1a.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:mac-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com
Change-Id: I480cf742a5dc461d028d4911f0768a547bc9cb8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212582Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#771083}

Post-chrome home, the BottomSheetTestRule has little functionality and
gets in the way of modularization. All existing tests have been easily
updated to work without it.

Bug: 100227
Change-Id: I6ae907599f0d651ae9d540b483b32146d678ed18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210668Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771082}

Make |version| a named parameter instead of positional. This should
make command lines less error-prone and magical (i.e. "what's this 3 in
the middle of the command").

Change-Id: I7ac59fa0268c0015f99232a8d3e24a64dadee717
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204627Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Jason Chase <chasej@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771081}

Hopefully this comment will help those trying to understand message
ordering. RenderFrameCreated() is a good place to send a message to the
renderer before loading starts.

BUG=none
TEST=none

Change-Id: Idd7e3d9b8c6e41daf6b1d50cd4088bd12132deae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212286Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771080}

This reverts commit bfe52a91.

Reason for revert: The Chrome security team has prohibited the use of gRPC in its current state as it does not go through Chrome's network stack. The Cloud Speech-to-Text implementation will be replaced with an alternative REST-based API that goes through the network stack.

Original change's description:
> Add protos required by Cloud Speech-to-Text
> 
> This CL adds the protos required by the Cloud Speech-to-Text service
> used by the Live Caption feature. The proto files come from Google3 with
> the following modifications:
> 
> 1. The package name of some of the protos were changed to avoid
>    conflicting with identical protos in the third_party/grpc repository.
> 
> 2. The license text was changed to align with Chromium conventions.
> 
> 3. any.proto and status.proto were renamed to prevent conflict with
>    protos in components/offline_pages/core/prefetch/proto.
> 
> 4. All protos are optimized for LITE_RUNTIME.
> 
> Bug: 1071626
> Change-Id: I351d98c9272e7ec7991a8182dbc305673c8e239c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153759
> Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
> Reviewed-by: Yuwei Huang <yuweih@chromium.org>
> Reviewed-by: Albert J. Wong <ajwong@chromium.org>
> Commit-Queue: Evan Liu <evliu@google.com>
> Cr-Commit-Position: refs/heads/master@{#764033}

TBR=ajwong@chromium.org,nyquist@chromium.org,yuweih@chromium.org,lgrey@chromium.org,evliu@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1071626
Change-Id: Ie0f8b65ed29217cbbedb28e8551e49189028203e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210799Reviewed-by: Evan Liu <evliu@google.com>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Evan Liu <evliu@google.com>
Cr-Commit-Position: refs/heads/master@{#771079}

Overall goal here is to ensure WindowAndroid instances are destroyed at
the end of instrumentation tests, but there is change in behavior for
production code.

Eager destroy WindowAndroid in AwContents. When the destroy runnable for
all AwContents that uses a WindowAndroid runs. Need to ensure at this
time that the WindowAndroid is removed from the global map as well. This
works because WindowAndroid lifetime and destroy runnable lifetime are
essentially the same.

Then in AwActivityTestRule, keep track of all AwContents created in
instrumentation tests in a list of weak references, and destroy at the
end of the test. Calling AwContents.destroy multiple is ok, so this
should be safe.

Need specific handling for AwUncaughtExceptionTest because it renders
the UI thread useless at the end of the test. Instead synchronously
destroy the AwContents in the test body itself.

Bug: 1081250
Change-Id: Ic07e52c7b21bf1300942e8b0a7cf178b8e3858b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205879
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771078}

Previously ShellWindowDelegateView had its initialization happen in
ViewHierarchyChanged(). This change splits initialization between the
constructor and AddedToWidget().

This allows the ShellWindowDelegateView to support being re-parented
to a Widget hierarchy multiple times.

Bug: 1083822
Change-Id: I4e0da0bcf458683bea2d327613588754c7372945
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206218
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771077}

There are a bunch of crashes that appear to be caused by invalid
ChildProcessSecurityPolicyImpl::Handle objects. This change adds
DumpWithoutCrashing() calls so we can see the call stacks that generate
these invalid handles.

Bug: 977169
Change-Id: I289c7c53eadd17eea8807e8244070259b72ad7a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211136
Auto-Submit: Aaron Colwell <acolwell@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771076}

Change-Id: If92458c27c98f08ae856e427de3ec99628e41283
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211282
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771075}

This moves the text/page zoom functions from eventSender to testRunner
so that we can reset them from TestRunner in a way consistent with how
we reset properties that can be changed on all frames/widgets/views
now.

We also move the text zoom API from WebView over to WebLocalFrame, where
it can be called for any local root. The only production usage is
Android WebView where it calls it for the main frame. In order to
support site isolation, it would need to do so on other local roots as
well. Since the renderer can't reliably tell what's a local root and is
the one setting/resetting the zoom level, it only allows it on the main
frame for now also.

We add a reset call for the zoom level and the text zoom there, which
have gone missing somehow in the refactoring process. We move other
calls from WebWidgetTestProxy that are resetting things testRunner
modifies over to the TestRunner class as well.

For example, without this, running the following tests in order causes
a failure:

[1/2] paint/invalidation/svg/zoom-coords-viewattr-01-b.svg passed
[2/2] paint/invalidation/svg/absolute-sized-content-with-resources.xhtml failed unexpectedly (text diff, image diff)

R=avi@chromium.org

Bug: 1083790, 866140
Change-Id: Idec021ba7a5d877a02b55b77d280454d6f8fb078
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208543
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771074}

BUG=108176
TBR=fdoray@chromium.org

Change-Id: I9723b07932b35fd098e40965735d1e92cb0c8946
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210466
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771073}

Bug: 1082728
Change-Id: I98c56d8348146e2d09be4ab159fcaaa2fada80f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206971Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771072}

Profile API is being updated (issue 1033903) and the usage of
GetOffTheRecordProfile and HasOffTheRecordProfile without argument is
getting deprecated. Use cases of this call that ONLY refer to incognito
or guest mode can use [Get/Has]PrimaryOTRProfile() instead.

Several tests are updated to use the new API.

This CL does NOT change any behavior.

Bug: 1060940
Change-Id: Ic05f7cc010bd29b04097f167a5eeed3feb0aa90c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210468Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771071}

This makes browser_tests and unit_tests use FlexNG. It's required before
launching a stable experiment.

Bug: 845235, 1062484
Change-Id: If5e9672bcf11c62d8ff92f1939608d8ab969682b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205975Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771070}

ChromePaymentRequestDelegate handles incognito mode differently in
compare to other off-the-record profiles. This change updates
ChromePaymentRequestDelegate::IsIncognito to return true for all
off-the-record profiles.
The function is also renamed to represent this change.

Bug: 968028, 1074201
Change-Id: I543413c993d484fe2ede6a589a8dd06a1b2ce186
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201596
Auto-Submit: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771069}

It is unclear why this returns a rectangle via out-param.

Change-Id: Ic83f7feb8a7a9cf95e017c1b3d72453c55afaad3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212481
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Auto-Submit: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771068}

This CL removes an unnecessary period in a tooltip string.

Bug: None
Change-Id: I1fd78a559e1a867d1478ec5cca3062b0350d0d65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211090Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Toby Huang <tobyhuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771067}

M81 is no longer an active milestone.

Change-Id: I5e772550fa52ac5ec2d56b5560e3e3b2e95d5e87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211121
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771066}

Remove failure supression for
deqp/functional/gles3/framebufferblit/default_framebuffer_00.html

TBR=kbr@chromium.org

BUG=angleproject:4632

Change-Id: I5baf02a8a80601dbadd5404fe8c3c3bde6bcc1e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209332Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771065}

https://quiche.googlesource.com/quiche.git/+log/8b78f8815623..7f483b5ee54c

$ git log 8b78f8815..7f483b5ee --date=short --no-merges --format='%ad %ae %s'
2020-05-20 renjietang In QUIC, instead of looking up QuicConnection states, consult the session on whether the connection should be closed on STATELESS_RESET.
2020-05-20 nharper Handle 0-RTT in TlsClientHandshaker
2020-05-20 dschinazi Compute maximum transport parameter size upfront
2020-05-20 dschinazi Remove obsolete stateless reset token length override
2020-05-20 wub In quicconnection::sendallpendingacks, update instead of set the ack alarm. protected by --gfe2_reloadable_flag_quic_update_ack_alarm_in_send_all_pending_acks.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

Change-Id: Iee3a7d338f52619e7afc9dd5029f3604587b39e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206922
Commit-Queue: Renjie Tang <renjietang@chromium.org>
Auto-Submit: Bence Béky <bnc@chromium.org>
Reviewed-by: Renjie Tang <renjietang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771064}

Adds a setting to implement the Mac specific behaviour for
aria-modal="true". The accessibility tree must be pruned of background
content, as outlined in the spec:

https://www.w3.org/TR/core-aam-1.1/#ariaModalTrue

Eventually, this setting may be enabled on other platforms (such as
Android).

Followups to this CL include:
  - add blink tests and inspector protocol tests
  - consolidate logic with HTMLDialogElement

AX-Relnotes: Adds support for aria-modal on Mac, to correctly expose
modal dialogs to AT.

Bug: 1050904
Change-Id: I76b7070e91a71ca7ee890886d9a6aa398911f118
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065779
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Chris Hall <chrishall@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771063}

In WaveShaperCurveValues(), there are 5 work arrays that used to be
allocated on the audio thread.  Move these to the class so we don't do
that anymore.  And while we're at it, make them AudioFloatArray's so
they're appropriately aligned for best SIMD/NEON performance.

Running Spotify's Web Audio Benchmark shows that we get 10% improvement
in speed for WaveShaper-1x, and about 3-4% for WaveShaper-2x and 4x.

No functional changes; all tests pass.

Bug: 1013118
Change-Id: Ide6340ee79d567068e0661abd0b20f14bb064166
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210821
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771062}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/52fe4b9946f7..8ae7f6e09a0b

2020-05-21 chrome-bot@chromium.org Update config settings by config-updater.
2020-05-21 jeroendh@google.com chrome_util: Copy libondeviceassistant.so when deploying Chrome
2020-05-21 bpastene@chromium.org gs: Update known AUTHORIZATION_ERRORS.
2020-05-21 richardfung@google.com Remove android-container-rvc targets
2020-05-20 vapier@chromium.org cros_mark_as_stable: relax self-repo checks in older branches
2020-05-20 wonderfly@google.com chromeos_config: Stand up master-lakitu-release on R81

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel
Tbr: chrome-os-gardeners@google.com
Change-Id: I1fb18ebebc31a217403e36a0a22ee849e94fd318
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212352Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#771061}

//ui/base:base is a big component with many conditional dependencies,
making it difficult to check the correctness of its deps and
public_deps. This CL moves ui/base/cursor/ files into the
//ui/base/cursor:cursor component, to make it easier to add/remove files
and check their dependencies.

As part of this reorganization, this target is limited to Aura builds.

Also, includes were reviewed.

Bug: 1085358
Change-Id: Ic835d0c79492c6a0945b12a82f538733f7e90fdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181210
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771060}

[Reland] - This is effectively a reland, first patchset is unchanged
https://crrev.com/74f12a609316ba81 so compare to that for changes. That
iteration provided some interesting data but used a triggering time of 5
seconds. I've since learned that there's a myriad of known edge-cases in
which events might have delays of 1-20 seconds (!). In our case, we're
specifically looking for issues at the upper end of the UMA metric (60+
seconds) so this caused some unrelated noise. This CL relands with a
higher threshold and some minor changes to the crash keys.

Add a DumpWithoutCrash to KeyPress events where the timestamp of the OS
differs from the current time by more than 60 seconds. We see in UMA
that we often see events in the 95% percentile reaching many seconds of
difference. Hopefully the crash stacks will reveal something about
what's causing this.

A previous iteration of this investigation in
https://crrev.com/c/2111782 showed that we sometimes redispatch events
that have been reinjected back from the renderer. This should never
happen. This CL adds crash keys to dump some of the related app state
to help explain how this happens.

However, not all such stack traces showed reinjection so that can't be
the cause of all these bad timestamps. This CL also adds some timing
information to the existing crash key in NSApp:sendEvent which might
reveal something.

Bug: 1039833
Change-Id: If49b7b8a918f880ed00a7adf219e589ed66daf6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210867
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771059}

This CL converts FrameMsg_TransferUserActivationFrom to
RemoteFrame interface. The |source_routing_id| is also
converted to |source_frame_token| as a UnguessableToken type.

Additionally, this CL renames TransferUserActivationFrom to
TransferUserActivationToRenderer in order to avoid confusing
the existing TransferUserActivationFrom in FrameHost interface.

Bug: 10833390
Change-Id: I08223aa7e9620e899753e3322a01ce0792739beb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208870
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771058}

https://skia.googlesource.com/skia.git/+log/b37105ea6cca..d1285b131bcf

2020-05-21 kjlubick@google.com Upgrade CanvasKit emscripten to version 1.39.16.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: lovisolo@google.com
Change-Id: If9468294797d5590b2500d98c2f474a6210e26bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212351Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#771057}

https://android.googlesource.com/platform/external/perfetto.git/+log/c4e15df5d5da..10792279b603

2020-05-21 treehugger-gerrit@google.com Merge "protozero: Add ProtoZero vs protolite benchmark"
2020-05-21 hjd@google.com Merge "ui: Merge global async slice tracks by name"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I6edd5805618779e6155c3879ed9028bddc252f81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212350Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#771056}

This is a precursor CL before moving the rest of the ui/base/cursor/
files to the target //ui/base/cursor:cursor.

Bug: 1085358
Change-Id: I46811aa42d8ed5688ff10fd24b3dbaab8531c259
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211781Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Cr-Commit-Position: refs/heads/master@{#771055}

Update the following histograms since we're using them to monitor
crash rates.

Platform.AnyCrashesDaily
Platform.AnyCrashesWeekly
Platform.KernelCrashesWeekly
Platform.KernelCrashesPerCpuYear
Platform.KernelCrashesDaily
Platform.KernelCrashInterval
Platform.KernelCrashesPerActiveYear
Platform.KernelCrashesSinceUpdate

Bug: 1084069, 1084072
Change-Id: I45eba9b60aa91cfed2da7916c04caf4d017c6f8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211471Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771054}

e.g. chrome/browser/previews/previews_offline_helper.cc:
    base::PostDelayedTask(
        FROM_HERE,
        {base::MayBlock(), content::BrowserThread::UI,
         base::TaskPriority::LOWEST,
         base::TaskShutdownBehavior::SKIP_ON_SHUTDOWN},
        base::BindOnce(&PreviewsOfflineHelper::RequestDBUpdate,
                       weak_factory_.GetWeakPtr()),
        base::TimeDelta::FromSeconds(30));

While such traits don't make sense. It'll be easier to fix them once
the migration is complete. Hence allow them temporarily to unblock
the migration.

R=altimin@chromium.org

Bug: 1026641
Change-Id: I737e4a874520adc851e808bdc8dad2f0947fe920
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208814Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771053}

The parameter |window_tree_host| is always null and isn't needed.
It was added for mash/mustash, but that project ended over a year ago.

Bug: none
Change-Id: Ie6f30ccd07c28d40b15985d640df8f727d7f01a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211128Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771052}

This CL makes three changes:
1) The TWA disclosure notifications have different IDs depending on
whether they are the initial or subsequent showing. This should prevent
any messiness with subsequent notifications inherit the channel from
the initial notification.
2) The notification has a bigText style set so it can be expanded.
3) The initial channel has sound suppressed and we also set sound to
null on the notification for pre-O devices.

Bug: 1068106
Change-Id: I7090e0e7e0e7eae339476006520a9b8276406623
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207457
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Auto-Submit: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771051}

This is a purely mechanical CL that adds the "const" modifier to the
the following methods in ComboboxModel:
1- GetItemAt()
2- GetDropDownTextAt()
3- IsItemSeparatorAt()

Change-Id: I11ac3034bbed85a1a9e288b6f0ce41343170c84b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212044Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771050}

1. Add error banner
2. Show the failing target
3. Show which targets to add rather than which .jar files to add
4. Show all errors rather than the first from each class.

Example error:
============================= Dependency Checks Failed =============================
Target: //base:base_java
Direct classpath is incomplete. To fix, add deps on:
 * com_android_support_support_compat_java
     * android.support.v4.view.ViewCompat (needed by org.chromium.base.ApiCompatibilityUtils and 1 more)

Bug: None
Change-Id: I26c6ea94d4df4167737519ad181131f8efecc00b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208813
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771049}

This CL puts the testers for android pixel 2 and pixel 2 webview in perf to 'lightweight' mode with 'skip-perf'.

In this case the tester will no longer upload the perf data.

Bug: chromium:1045256
Change-Id: Ib69183462f4530b208c3a410c4ed474199ecdc56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209615
Auto-Submit: Wenbin Zhang <wenbinzhang@google.com>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771048}

This reverts commit a6207513.

Reason for revert: causing build failures on https://ci.chromium.org/p/chromium/builders/try/android_compile_x64_dbg/1504

Original change's description:
> Roll src/third_party/libunwindstack/ dfd3f3d84..de5bb5ebd (1 commit)
> 
> https://chromium.googlesource.com/chromium/src/third_party/libunwindstack.git/+log/dfd3f3d84cfc..de5bb5ebd6d7
> 
> $ git log dfd3f3d84..de5bb5ebd --date=short --no-merges --format='%ad %ae %s'
> 2020-05-19 wittman [Sampling profiler] Include AsmGetRegs asm functions on x86/x64
> 
> Created with:
>   roll-dep src/third_party/libunwindstack
> 
> Bug: 1004855
> 
> R=​etiennep@chromium.org
> 
> Change-Id: If6c111aae6dbfb4bf474b57dba6274e63fb8cbb4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210496
> Commit-Queue: Mike Wittman <wittman@chromium.org>
> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
> Auto-Submit: Mike Wittman <wittman@chromium.org>
> Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#770701}

TBR=wittman@chromium.org,etiennep@chromium.org

Change-Id: I73b4a976214f47e3347cee7483ce7aebe7ec4662
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1004855
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212443Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771047}