- 03 Feb, 2020 40 commits
-
-
Lukasz Anforowicz authored
Before this CL, GuestViewBase::GetOwnerSiteURL would return: owner_web_contents()->GetLastCommittedURL() The code above is incorrect for two reasons: 1. It doesn't account for about:blank URLs 2. It doesn't work before |owner_web_contents()| commit their first navigation. Problem #2 is what happens when a new, blank popup is opened and then written to via document.write. In such scenario, GetOwnerSiteURL would return an invalid URL which incorrectly caused PDF rendering pipeline to fail by rejecting invalid URLs in URLPattern::MatchesURL: URLPattern::MatchesURL() extensions::URLPatternSet::MatchesURL() extensions::SimpleFeature::GetContextAvailability() extensions::SimpleFeature::IsAvailableToContext() extensions::ExtensionsGuestViewManagerDelegate::IsGuestAvailableToContext() ^- IsGuestAvailableToContext passes result of GetOwnerSiteURL to IsAvailableToContext above guest_view::GuestViewBase::Init() guest_view::GuestViewManager::CreateGuest() extensions::MimeHandlerViewEmbedder::CreateMimeHandlerViewGuest() Bug: 1041880 Change-Id: I252a15e464d70a7131c101b4f4889fa9fa968a66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023047Reviewed-by:Charlie Reis <creis@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#737817}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d4f68317fe3a..fb3951000894 git log d4f68317fe3a..fb3951000894 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 jvanverth@google.com Reland "Wrap page index packing in helper methods." 2020-02-03 scroggo@google.com Update link to BreakingTheBuildBots bugs Created with: gclient setdep -r src/third_party/skia@fb3951000894 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: scroggo@google.com Change-Id: I29da2695e2e61bf7a63fa77f16d5898fb9a433c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035838Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737816}
-
Michael Thiessen authored
In migrating the TestWebServer to use GURL, I needed to add a native library to the weblayer shell, allowing it to use the native GURL code. Bug: 783819 Change-Id: I14b13f242b6ddf9367c2b0f29c0a1665eae6da78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026112 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#737815}
-
Weiliang Chen authored
When viz::Display receives swap buffers ack, it checks that |renderer_| is not null. This implies this function could be called after |renderer_| is deleted. By the same logic we would need to check for |overlay_processor_| not being null either. Bug: 1048041 Change-Id: Ib57ee5151eaae3b885c55f478959f747a96ab837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035301Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#737814}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f2be3eff26fd..2181228624d1 git log f2be3eff26fd..2181228624d1 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 ilnik@webrtc.org Revert "[VP9] Shift spatial layers on RTP level to always start from 0." 2020-02-03 kron@webrtc.org Move spec of experimental RTP header extensions to source repository Created with: gclient setdep -r src/third_party/webrtc@2181228624d1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iefbc5649b21fe77f91dd98bbfe726cb9b980f0cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035842Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Iee89da30d7535fbdae672d0ffc754d70a2d6b959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035840Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/784967be4d56..91f38e4aa97b git log 784967be4d56..91f38e4aa97b --date=short --first-parent --format='%ad %ae %s' 2020-02-03 skyostil@google.com TrackEvent: Add support for ids, thread and timestamp overrides for legacy events Created with: gclient setdep -r src/third_party/perfetto@91f38e4aa97b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:147743479 Tbr: perfetto-bugs@google.com Change-Id: I265c8e349e89c74e058085d6aa9f1a598096d074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035841Reviewed-by:
-
Rob Schonberger authored
Bug: 1009290 Change-Id: I55866a8d591153bc1ef978b924cdb93a03c68f2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033057 Auto-Submit: Rob Schonberger <robsc@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#737810}
-
Charlie Hu authored
Since parsing of DocumentPolicy only happens in renderer, there is no need to put Parse as part of DocumentPolicy which gets exposed to browser. This CL separates Parse from DocumentPolicy and puts it in renderer/core. Bug: 993790 Change-Id: I1d7f196c9b47735d947d74c9cd7916f5001ec5b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017925Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#737809}
-
Renato Silva authored
Removed the powerwash/reset screen from the list of screens for which the status area will be hidden. This issue only came to light once the functionality of hiding/showing the status tray became possible for the Mojo-based version of LoginDisplayHost -- LoginDisplayHostMojo. This functionality was added in https://crrev.com/c/1926481 Hiding the status area prevents the user from accessing many options that could be necessary, such as networking and accessibility. Fixed: 1045848, 1045851 Change-Id: Ib8b21c6be9587ef4c0c484c23bac0c1150afaa04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031039Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Auto-Submit: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#737808}
-
Alex Chau authored
- As a follow-up of https://crrev.com/c/2012286, follow go/proto-best-practices-checkers#tag_changed to avoid changing tag numbers and add v2_ suffix. - This also brings back previously reserved sender_id_ fields as deprecated so they can still be used by server clients. Bug: 1044607 Change-Id: Ia3df7c72c554e81f421d8644eceadf92734ff34d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035870 Commit-Queue: Alex Chau <alexchau@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Auto-Submit: Alex Chau <alexchau@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#737807}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1418552cad29..c0feb63a6ff4 git log 1418552cad29..c0feb63a6ff4 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 pfaffe@chromium.org Enable experiments in e2e tests Created with: gclient setdep -r src/third_party/devtools-frontend/src@c0feb63a6ff4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1047677 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iec919ef6335166de5d9b578cd8f311b77ff52186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035112Reviewed-by:
-
Kamila authored
Bug: 1046341 Change-Id: Ia45fa0be8876e043bd5e9922da6f61995c7d3fad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030884 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#737805}
-
Mark Yacoub authored
1. Move DRM SetCrtc and Disable from Crtc Controller Modeset to Plane Manager Atomic/Legacy Modeset to abstract the implementation based on the platform. 2. Move common code from HardwareDisplayController Enable and Modeset to a common function. BUG=987274 TEST=HardwareDisplayPlaneManager*Test.Modeset, HardwareDisplayPlaneManager*Test.DisableModeset Change-Id: Iebc8287d0dad49efa6ddf69306e057c0650e5278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032234 Commit-Queue: Mark Yacoub <markyacoub@google.com> Auto-Submit: Mark Yacoub <markyacoub@google.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#737804}
-
Nicolas Ouellet-Payeur authored
This reverts commit c2b90515. Reason for revert: blocking CQ (crbug.com/1047696) Original change's description: > [Traffic Annotation] Fail on CQ on C++ parsing error > > Previously, CQ would pass if extractor.py failed at parsing the C++ > declaration. With this CL, parsing errors make CQ turn red (to avoid > committing code that will make linux-annotator-rel fail). > > Also, always rerun extractor.py when there's an error to get stderr > contents. Previously, when running with --error-resilient, it wouldn't > re-run the Clang tool. This saved several minutes on CQ, but didn't > report a useful error message. Since extractor.py is _much_ faster, > the tradeoff is different: the error message is more important than > the couple of seconds saved. > > Finally: slightly improve extractor.py's error reporting when it fails > to parse the annotation declaration. This makes it more actionable and > gives better context to the CL author. > > TESTED=traffic_annotation_auditor_unittests, extractor_test.py, > annotation_tokenizer_test.py > > Bug: 1046794 > Change-Id: Id397dcfcced39fbebf72ffcdc6d6549c66c2910f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028707 > Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> > Reviewed-by: Ramin Halavati <rhalavati@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737039} TBR=rhalavati@chromium.org,nicolaso@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1046794 Change-Id: I67764d599a4dd353898c60275c6162c0139961c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033677Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#737803}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 210d8bb5. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I9315401c2c9228a3cf63f88205d2c14e0504b980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035700Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737802}
-
Andrew Grieve authored
And tweak README.md build instructions Bug: None Change-Id: Ic092e33392d30b27dd3666593c1e0d601b5617c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032804Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#737801}
-
Victor-Gabriel Savu authored
dhe_rsa.patch uses some python 2 only constructs, replace with code that is compatible with both 2 and 3. Bug: chromium:1041448 Test: tast run <ip> policy.* Change-Id: I4bba7c77512a2fb51b9b26a05781767f330da97e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035415Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Cr-Commit-Position: refs/heads/master@{#737800}
-
Omer Katz authored
This CL removes the option to initialize a worklist to less than max_tasks. Having a static number of tasks allows replacing some DCHECKs with static_asserts. Bug: 986235 Change-Id: Ia14792bd946f8ef08606138b56617f90be9cc6ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030970Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#737799}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/352de2b8..24046f60 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I465134111910cb15c7a125eb3d3c5198c644e21d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035697Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737798}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8b9cdcbe79ef..094c157fc3f0 git log 8b9cdcbe79ef..094c157fc3f0 --date=short --first-parent --format='%ad %ae %s' 2020-02-01 vapier@chromium.org gs: upgrade gsutil to 4.47 2020-01-31 saklein@chromium.org flash_ap: Fix command run output checking. 2020-01-31 tbegin@google.com packages: update manifest in uprev_ebuild_from_pin Created with: gclient setdep -r src/third_party/chromite@094c157fc3f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I6ca03ef942489cc38cafc3164e81974164ad7e0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035835Reviewed-by:
-
Mike Frysinger authored
This was first deprecated 5 years ago, and then disabled 3 years ago (with the disable hitting stable in Jan 2017 in M56). That is way longer than necessary, and it's annoying people who want to use the old shortcut with extensions (e.g. the linkable extension's default). Bug: 492454, 486198, 498565, 405317 Change-Id: Id24b902ff54601f1cd22f6305df4dc54dbe24d78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015701Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#737796}
-
Peng Huang authored
The AMD GPU GL driver will only use optimal tiling for a memory object, if the memory object is dedicated - the memory object only contains one image. We always create dedicated memory objects with Vulkan API, however GL doesn't know it. We need to tell GL driver about it. Bug: 1046462 Change-Id: I4ae6b69f5f8df12d58d5355c5532f974d45b17a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034033 Auto-Submit: Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#737795}
-
Maksim Ivanov authored
Implement the "progress bar" animation in the smart card PIN dialog shown during the SAML login (the <security-token-pin> Polymer element). The animation is shown while the PIN is being verified by the smart card middleware, and the PIN pad is hidden during that time. Once the verification completes, the animation is stopped and either the dialog is closed or the error message and the PIN pad are displayed. Bug: 1016839 Test: start smart card SAML login, enter PIN, check that the progress bar is shown while the PIN is verified Change-Id: I25e0c7412640f85221e0a73b3a64763c0f61ca18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030411 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#737794}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6dc622fec32c..d6d8abbe40ba Created with: gclient setdep -r src-internal@d6d8abbe40ba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I0cc75436bf7baf7e888c58d5a85c11b8d2a1c5b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035834Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737793}
-
Annie Sullivan authored
Change-Id: Idaa65efb18c2f275d54eb471cf3d3014405fb399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033762Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#737792}
-
Monica Basta authored
The primary account can be butter or sync account depending on the consent level. This CL adds consent level as a parameter to GetPrimaryAccount* and HasPrimaryAccount to indicate the consent level required by the caller. It can be |kNotRequired|, in that case it returns the corresponding info of the primary account if it exists. If consent is |kSync|, it returns the corresponding info if the primary account exists and was granted sync consent. Bug: 1046746 Change-Id: Id69f1f234228166f347e01f044672836fd88d5be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033351 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#737791}
-
Joshua Pawlicki authored
This was an overzealous search & replace in patch set 9 of https://chromium-review.googlesource.com/c/chromium/src/+/2016972 Bug: 1048040 Change-Id: I7fe326b2768d9977984670dd4d9f7f6d8eb0ca7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033675 Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#737790}
-
Michael Ershov authored
Bug: 1045895 Change-Id: I5705970795ecd87e8a474d1d39c7f509ea8c2d7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020705 Commit-Queue: Michael Ershov <miersh@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#737789}
-
Rouslan Solomakhin authored
This patch re-enables the disabled test for card ordering, because the flake has been fixed in https://crrev.com/c/2031046. Bug: 1045774 Change-Id: I6f34b3af384c98da5891adb1ff2029bca08e2e2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031680Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#737788}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c809e8bd6289..f2be3eff26fd git log c809e8bd6289..f2be3eff26fd --date=short --first-parent --format='%ad %ae %s' 2020-02-03 eshr@google.com Move initial frame drop to overuse module Created with: gclient setdep -r src/third_party/webrtc@f2be3eff26fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iaf6df3967b0ddbc03264e1ea1852630f3dd52cd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035833Reviewed-by:
-
Roman Sorokin authored
Fixed: 910529, 947161 Change-Id: I2f6ff33350102c4bf6eaf32a19e065f6bdb68b91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033157Reviewed-by:
-
Anton Bikineev authored
Apple-clang complains about missing initializer in union. This fixes it. Original change's description: > [base] Use dummy class to avoid superfluous initialization in Optional > > The initialization of "char empty_" union-member in Optional is > redundant and causes the compiler to generate extra code to ensure > zero-initialization. Using an empty Dummy class for the union member is > more optimal, since it guarantees that no code for its initialization is > generated. > > Explicitly touching this char member in the constructor also causes a > problem for conservative GC. Compiler is free to split shared and not > shared parts of the union in separate memory locations on stack (or keep > them in different registers). If a conservative GC is triggered at this > moment, stack scanning may not find the correct object (this is exactly > what happened in the bug 1044331). > > This can be tested in a minimized example: https://godbolt.org/z/t5q5ry. > > Bug: 1046776 > > Change-Id: Idab1a0acf7d7d4f45dc9435a611b23f64e3c3c79 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027948 > Commit-Queue: Anton Bikineev <bikineev@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737494} Bug: 1046776 Change-Id: I751878a515647e244059d0ad1ba7bc6542fd1f37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033357Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#737785}
-
Olivier Robin authored
Initialize Audio can take a long time and causes freeze on the main thread during |UIApplication didFinishLaunching:|. Use a simplified WKWebView instead. Bug: 1043879 Change-Id: I5c42f1ecd9bf320fc39728f665b60ce5dab413f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010794 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#737784}
-
Manoj Gupta authored
Fix for crosh not loading on ARM64 Chrome OS. Bug: 1047517 Test: crosh works. Change-Id: Ifce8c65e9e9bd49980204175b990cb304cbf0a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031757Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Commit-Queue: Manoj Gupta <manojgupta@chromium.org> Auto-Submit: Manoj Gupta <manojgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#737783}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9e8d8c4830c1..d4f68317fe3a git log 9e8d8c4830c1..d4f68317fe3a --date=short --first-parent --format='%ad %ae %s' 2020-02-03 robertphillips@google.com Add SW decode of ETC1 and a GM Created with: gclient setdep -r src/third_party/skia@d4f68317fe3a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: scroggo@google.com Change-Id: I7bccf5ff8a846cff2b5edda46d71a63b6820bb04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035609Reviewed-by:
-
Eric Robinson authored
This adds metrics that compute both the total time (post initialization) that a RenderProcessHost is alive, as well as the time that host spends in the background (as computed by RenderProcessHostImpl::UpdateProcessPriority). There's also a small change to the testing infrastructure to consolidate functionality under RenderProcessHostFramePriorityTest. Bug: 1026606 Change-Id: I36863e87fb6606685cac23e6d1a9ab3a4807d8ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994000 Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ie29857750932e744f21ce62295c00f9332f63559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035111Reviewed-by:
-
Miyoung Shin authored
This CL cleans up exposed InterfaceProvider interfaces of Blink. Bug: 990845 Change-Id: I6001b814b0212d658811c35f8312b615ff076007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963600Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#737779}
-
Daniel McArdle authored
This adds fuzzer coverage for wav_audio_handler.cc. Fuzzer coverage report: https://chromium-coverage.appspot.com/reports/737219_fuzzers_only/linux/chromium/src/media/audio/wav_audio_handler.cc.html Change-Id: I60176aba90301bcab648029511a27c16c93ef736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033443Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#737778}
-
