GitLab

SyncChanges now require the location they were created as a parameter. This
is then used in the case that the change violates and invariant. We display
the location and type of erroneous change in about:sync, in addition to
disabling the offending datatype.

TBR=kalman@chromium.org, mnissler@chromium.org, isherman@chromium.org
BUG=135108
TEST=unit_tests


Review URL: https://chromiumcodereview.appspot.com/10766016

TBR=zea@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10698141

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145996 0039d316-1c4b-4281-b951-d872f2087c98

Revert 145969 - Removing last usage of default request context. Fixing up login_utils to not need it by adding a notification so that login_utils only accesses it when the request context getter has been initialized.

BUG=125292, 127693
TEST=unittest, manual

Review URL: https://chromiumcodereview.appspot.com/10657009

TBR=rlp@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10735042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145995 0039d316-1c4b-4281-b951-d872f2087c98

required me to switch it from wrapping a ScriptExecutor to observing one.

Also write a simple test to demonstrate how to test ScriptBadgeController. This was the original point of the change. The associated refactoring turned out to be more useful, but was ultimately unnecessary for the test.

BUG=133139,136301


Review URL: https://chromiumcodereview.appspot.com/10754004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145994 0039d316-1c4b-4281-b951-d872f2087c98

SyncChanges now require the location they were created as a parameter. This
is then used in the case that the change violates and invariant. We display
the location and type of erroneous change in about:sync, in addition to
disabling the offending datatype.

TBR=kalman@chromium.org, mnissler@chromium.org, isherman@chromium.org
BUG=135108
TEST=unit_tests


Review URL: https://chromiumcodereview.appspot.com/10766016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145993 0039d316-1c4b-4281-b951-d872f2087c98

BUG=134959
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10693130

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145992 0039d316-1c4b-4281-b951-d872f2087c98

BUG=133141

Review URL: https://chromiumcodereview.appspot.com/10699033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145991 0039d316-1c4b-4281-b951-d872f2087c98

Since the seccomp filter GPU sandbox blocks access to the file system,
we need to set an env var with the config line found in /etc/drirc on
Chrome OS. This allows games that use S3TC to work inside the sandbox.

BUG=127664
TEST=Bastion works on Chrome OS with '--enable-gpu-sandbox'.


Review URL: https://chromiumcodereview.appspot.com/10690116

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145990 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dmazzoni
Review URL: https://chromiumcodereview.appspot.com/10736016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145989 0039d316-1c4b-4281-b951-d872f2087c98

After a good lunchtime discussion, I went off to implement some sort
of overriding functionality in ExtensionFunctionDispatcher, so that I
could tell it to instantiate Function' instead of Function when an
extension/app asked for function. I then discovered
ExtensionFunctionDispatcher::OverrideFunction(), which was pretty
much exactly what I wanted.

Using this facility, added a fake SerialOpenFunction that overrides
a new CreateSerialConnection method to instantiate a
FakeEchoSerialConnection. As its name implies, this class pretends
to echo bytes over a serial port.

The practical outcome of this CL is we test more of our code without
having a physical serial device attached to the machine.

BUG=135656
TEST=this lays the ground work for testing of crrev.com/10759004

Review URL: https://chromiumcodereview.appspot.com/10702138

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145988 0039d316-1c4b-4281-b951-d872f2087c98

Specifying it seems to push Windows to clear its cache before the changes to the shortcut have actually gone in.

This results in losing Metro properties when the shortcut is modified on Windows 8.

BUG=136567
TEST=Over-install my custom 22.0.1200.0 build over 21.0.1180.15 beta-m (when its default) and make sure the shortcut keeps its Metro properties (I've confirmed many times that it doesn't on the same custom build without my fix).


Review URL: https://chromiumcodereview.appspot.com/10692138

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145987 0039d316-1c4b-4281-b951-d872f2087c98

BUG=132353
TEST=First run bubble should appear if skip_first_run_ui is set to false.

Review URL: https://chromiumcodereview.appspot.com/10756023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145986 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10701121

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145985 0039d316-1c4b-4281-b951-d872f2087c98

Instead of allowing the Sync code to delete the DSP, we instead undelete the DSP. Here we prefer inconsistency to a far worse experience where the DSP is swapped due to a bug.

Tests are updated to reflect this change in functionality.

BUG=132446
TEST=


Review URL: https://chromiumcodereview.appspot.com/10694096

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145984 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83199
TEST=still compiling.


Review URL: https://chromiumcodereview.appspot.com/10748008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145983 0039d316-1c4b-4281-b951-d872f2087c98

The Java file generation rule in java_aidl.gypi assumes the wrong output path
for the generated file. This leads to spurious rebuilds.

The problem is that by default, the aidl tool outputs the Java file to
<output-path>/<package-path>/<input-file-root>.java, not to
<output-path>/<input-file-root>.java as assumed by the rule. This change fixes
the problem by explicitly specifying the output path to aidl.

Also remove superfluous path components on input files.

Review URL: https://chromiumcodereview.appspot.com/10690092

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145982 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136433
TEST=See instructions on the bug report.

Review URL: https://chromiumcodereview.appspot.com/10702126

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145981 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136396
TEST=New VariationsServiceTest.StoreSeed and VariationsServiceTest.LoadSeed tests


Review URL: https://chromiumcodereview.appspot.com/10764005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145980 0039d316-1c4b-4281-b951-d872f2087c98

CID=103980,103981
CID_COUNT=2

R=asargent@chromium.org
TBR=piman@chromium.org
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10762010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145979 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136462


Review URL: https://chromiumcodereview.appspot.com/10753022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145978 0039d316-1c4b-4281-b951-d872f2087c98

BUG=135435
TEST=existing + tsan bots


Review URL: https://chromiumcodereview.appspot.com/10749009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145977 0039d316-1c4b-4281-b951-d872f2087c98

added ImageSkiaOperations and replaced Bitmap with ImageSkiaRep/ImagSkia.

BUG=122992
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/10704113

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145976 0039d316-1c4b-4281-b951-d872f2087c98

In some cases this may result in redundant logging, but this
is needed to log cancellations from third parties.

R=eroman@chomium.org
BUG=108055
Review URL: https://chromiumcodereview.appspot.com/10689142

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145975 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116317
TEST=compiles
Review URL: https://chromiumcodereview.appspot.com/10694115

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145971 0039d316-1c4b-4281-b951-d872f2087c98

variable begin_ and end_ is never being used, and it is generating clang errors

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10704134

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145970 0039d316-1c4b-4281-b951-d872f2087c98

Removing last usage of default request context. Fixing up login_utils to not need it by adding a notification so that login_utils only accesses it when the request context getter has been initialized.

BUG=125292, 127693
TEST=unittest, manual

Review URL: https://chromiumcodereview.appspot.com/10657009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145969 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136463
TEST=media_unittests,seek-sourceabort-crash.html

Review URL: https://chromiumcodereview.appspot.com/10766021

TBR=vrk@google.com
Review URL: https://chromiumcodereview.appspot.com/10690124

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145968 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10701128

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145967 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136463
TEST=media_unittests,seek-sourceabort-crash.html

Review URL: https://chromiumcodereview.appspot.com/10766021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145965 0039d316-1c4b-4281-b951-d872f2087c98

There appears to be some non-determinism in the order that the chrome.runtime
namespace gets set up relative to when the last_error.js file is loaded. This adds a require statement that should hopefully resolve this.

BUG=136352
TEST=Chrome webstore should function normally

Review URL: https://chromiumcodereview.appspot.com/10748011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145964 0039d316-1c4b-4281-b951-d872f2087c98

Note: This requires a WebKit change to not overwrite the user agent.

BUG=134615
TEST=With a Flapper that sets the user agent under the appropriate
     circumstances (not yet available), check that http://10tv.nana10.co.il/
     streams properly. Or sniff and check that requests to port 1935 have
     "Shockwave Flash" as user agent.

Review URL: https://chromiumcodereview.appspot.com/10701119

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145963 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10704135

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145961 0039d316-1c4b-4281-b951-d872f2087c98

This provides a way of getting the last request that was actually (mock) served,
so that WebKit unit tests can, e.g., inspect headers that were "actually" sent
out.

BUG=http://crbug.com/134615 and https://bugs.webkit.org/show_bug.cgi?id=90893
TEST=see WebKit bug (forthcoming WebKit unit test)

Review URL: https://chromiumcodereview.appspot.com/10735037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145960 0039d316-1c4b-4281-b951-d872f2087c98

re-enable it on TSAN/Dr. Memory.  Apply same fix to the corresponding
Spdy 3 test.

Issue was that the tests relied on never reading MockReadData could
not be safely read not being read.  The memory bots slow things down
enough that it was being read, and causing a crash.  Fixed the bad
data, and corrected the ordering of events.

BUG=130874
Review URL: https://chromiumcodereview.appspot.com/10704042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145959 0039d316-1c4b-4281-b951-d872f2087c98

In Windows 8 chrome metro mode if we Alt tabbed away from chrome while a tab was loading, we would end up 
with a desktop mode render widget view window. The RenderWidgetHostViewWin instance is created with a valid
parent window which is the web contents window. We hide it initially and make it visible when the navigation
is completed. In the code for hiding the view we call setparent with NULL to orphan the window and then reparent
it to the original parent when the view is made visible.

This parenting/reparenting code confuses windows 8 metro when we switch focus away to the desktop after the window
is hidden and before it becomes visible.

In any case we won't receive any paint messages after a window is hidden which is already occurring here.

Removing the code to unparent and reparent the RenderWidgetHostViewWin instance.

BUG=136272
R=cpu
Review URL: https://chromiumcodereview.appspot.com/10753017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145957 0039d316-1c4b-4281-b951-d872f2087c98

This is a reland of crrev.com/145933 which was reverted as
it broke ChromiumOS (x86) build.

Having this member was awkward, as it's inconsistent
with other states, which are all stored in |cache_state|.

BUG=136390
TEST=out/Release/unit_tests --gtest_filter=GData*

Review URL: https://chromiumcodereview.appspot.com/10702133

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145953 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136412
R=nsylvain@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10749018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145952 0039d316-1c4b-4281-b951-d872f2087c98

GDataEntry::FromProtoString() fails if incompatible proto is detected
We should return an error rather than DCHECK it.
See crbug.com/142912 for how incompatible proto is rejected.

BUG=127856
TEST=out/Release/unit_tests --gtest_filter=GDataDBTest.*

Review URL: https://chromiumcodereview.appspot.com/10701118

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145950 0039d316-1c4b-4281-b951-d872f2087c98

BUG=133432
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10702038

TBR=junov@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10690120

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145949 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145948 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10698132

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145947 0039d316-1c4b-4281-b951-d872f2087c98