GitLab

Add an [- infoBarWillClose] selector to InfoBarController to give the translate infobar a chance to dismiss the options menu when the infobar is detached from a window.

BUG=67594
TEST=See bug

Review URL: http://codereview.chromium.org/6296003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71575 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71574 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71572 0039d316-1c4b-4281-b951-d872f2087c98

Also bring about_credits.html up to date.

1. licenses.py was failing on Windows because of path separators, so I 
   changed remaining path strings to use os.path.join.

2. I wasn't seeing all DEPS on my system, so I modified DEPS locally to 
   ignore os_deps. That led to several changes to make sure os-specific
   libraries (pdfsqueeze, GTM, for example) get attribution in about_credits.

3. Some of the code we pull in doesn't need attribution in our about_credits
   (windows SDK), so I added new ignore rules.

BUG=none
TEST= dunno. about:credits credits everything we include?
R= evan@chromium.org
Review URL: http://codereview.chromium.org/6263006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71570 0039d316-1c4b-4281-b951-d872f2087c98

The two license attributions are taken from Firefox's about:license page
and correspond to the license headers in the source files.

This change makes licenses.py happy.

R=abarth,evanm
TEST= about:credits includes a qcms section crediting Marti Maria and SunSoft.
Review URL: http://codereview.chromium.org/6262004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71568 0039d316-1c4b-4281-b951-d872f2087c98

before accessing them.

BUG=64813
TEST=see bug 

Review URL: http://codereview.chromium.org/6273006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71564 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71563 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6282003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71562 0039d316-1c4b-4281-b951-d872f2087c98

Affects files that include from chrome/browser/ui/views

BUG=69082
TEST=none

Review URL: http://codereview.chromium.org/6299008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71561 0039d316-1c4b-4281-b951-d872f2087c98

TBR=hayato
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6334005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71560 0039d316-1c4b-4281-b951-d872f2087c98

BUG=69757
TEST=Mac Valgrind goes green
TBR=thestig

Review URL: http://codereview.chromium.org/6297005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71559 0039d316-1c4b-4281-b951-d872f2087c98

(This was a TODO for phajdan.jr).

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/6282002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71558 0039d316-1c4b-4281-b951-d872f2087c98

They were moved to ui/base/animation. Remove them now, since no one is including these files.

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/6243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71557 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71553 0039d316-1c4b-4281-b951-d872f2087c98

BUG=69757
TEST=Valgrind Mac Unit goes green.
TBR=rsesek
Review URL: http://codereview.chromium.org/6331004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71551 0039d316-1c4b-4281-b951-d872f2087c98

BUG=65664
TEST=Valgind Webkit goes green
TBR=scherkus
Review URL: http://codereview.chromium.org/6344003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71550 0039d316-1c4b-4281-b951-d872f2087c98

71435 caused SpecialTabsTest.testSpecialURLTabs to fail, since that
was checking the title for about:sync.

Added more tests for about:sync-internals and chrome://sync-internals.

BUG=69733
TEST=SpecialTabsTest
TBR=nirnimesh

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71549 0039d316-1c4b-4281-b951-d872f2087c98

separate Filter management from MessageLoop management.
This sets the stage for filters to share threads in the
future which will reduce resource consumption when
multiple <video> tags are on the same page.

BUG=69451
TEST=None

Review URL: http://codereview.chromium.org/6171009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71548 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6335001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71547 0039d316-1c4b-4281-b951-d872f2087c98

TBR=hayato
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6335007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71546 0039d316-1c4b-4281-b951-d872f2087c98

Records, which should fit into MSS.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/5966003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71545 0039d316-1c4b-4281-b951-d872f2087c98

adds PP_Instance to the necessary places in the API to make this possible.

String and Object vars used to be PP_Resources. But it is not practical to
assocaited strings with an instance since then we can't have implicit var
constructors and have to litter every string with an instance. So this changes
vars to use their own tracking system associated with the module (i.e. keeping
the current semantics) and making it no longer a resource. I made the internal
Var IDs 32 bits since Neb is about to land his 64->32 change.

Now it force-deletes resources associated with an instance when that instance
goes away. I added some additional code and tracking in ResourceTracker to do
this. I could then remove the Instance::Observer class since the resource can
use the (now renamed) StoppedTracking to know that it's being deleted in
response to the instance being destroyed.

TEST=ppapi ui tests
BUG=none

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71544 0039d316-1c4b-4281-b951-d872f2087c98

BUG=69710
Review URL: http://codereview.chromium.org/6295005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71540 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6361004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71539 0039d316-1c4b-4281-b951-d872f2087c98

We had a ton of unnecessarily duplicated code, most of which could be solved by introducing NewExpectedCallback().

BUG=none
TEST=media_unittests

Review URL: http://codereview.chromium.org/6350001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71537 0039d316-1c4b-4281-b951-d872f2087c98

Rolling this out because it breaks NoticeNotificationChanges on XP for some reason.

BUG=65189
TEST=TaskManagerBrowserTest.KillBGContents

Review URL: http://codereview.chromium.org/6226002

TBR=atwilson@chromium.org
Review URL: http://codereview.chromium.org/6310008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71536 0039d316-1c4b-4281-b951-d872f2087c98

Adding 1 minute of waiting in discover search engine test. And moved _CallFunctionWithNewTimeout to test_utils.

BUG=69619
Review URL: http://codereview.chromium.org/6354004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71535 0039d316-1c4b-4281-b951-d872f2087c98

BUG=61252
TEST=none

Review URL: http://codereview.chromium.org/6249006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71534 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/6221007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71533 0039d316-1c4b-4281-b951-d872f2087c98

causes the latest IE9 developer preview version to crash. Reason being a change in the
interface implementing the NavigateWithBindCtx2 method.

BUG=none
TEST=Covered by existing DownloadFromForm test.
TBR=amit


Review URL: http://codereview.chromium.org/6253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71532 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/6256005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71531 0039d316-1c4b-4281-b951-d872f2087c98

Add methods to browser_tests which allow sharding
control to be used to select the tests that are
called by RunTest().  The same basic process is
used by GTest to decide if a given test should be
run (assuming the suite should be sharded).

Reuse GTEST_TOTAL_SHARDS and GTEST_SHARD_INDEX since
browser_tests is a wrapper around GTest and using the
same variable names will simplify our tools.

BUG=69423
TEST=browser_tests runs fine unsharded, can be run
sharded

Review URL: http://codereview.chromium.org/6333004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71530 0039d316-1c4b-4281-b951-d872f2087c98

TBR=hayato
BUG=69719
TEST=none

Review URL: http://codereview.chromium.org/6338006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71529 0039d316-1c4b-4281-b951-d872f2087c98

exists in the context menu, but now it works well enough to promote to the
main placeholder UI.


BUG=63695
TEST=see bug

Review URL: http://codereview.chromium.org/5275007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71528 0039d316-1c4b-4281-b951-d872f2087c98

for this CL, also keep the old dev interface
around temporarily, to avoid tree breakage.
Add sample_rate to RecommendSampleFrameCount() to the
non-dev audio interface. Currently ignored, but useful
information to use when we need to refine RecommendSampleFrameCount()

Review URL: http://codereview.chromium.org/6279003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71527 0039d316-1c4b-4281-b951-d872f2087c98

Before this change, it's a Singleton that gets passed a pointer to a Profile
during Init(), and holds onto that pointer even after the Profile gets 
destroyed. With this change, it's owned by ExtensionService and is destroyed
when the profile is being destructed.

BUG=67927
TEST=On linux, run 'browser_tests --gtest_filter=ExtensionApiTest.BookmarkManager --gtest_repeat=100 --gtest_break_on_failure'. Before this CL, you'll occasionally get a failure because of the race condition described above.


Review URL: http://codereview.chromium.org/6125003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71526 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/6366001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71525 0039d316-1c4b-4281-b951-d872f2087c98

while processing a navigation update received for a tab loading state change. This is incorrectly
treated as an internal navigation which messes up the history.

Fix is to not treat the tab loading state change notification as an internal navigation.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=69096

BUG=69096
TEST=None at this point.

Review URL: http://codereview.chromium.org/6284002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71524 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/6269001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71523 0039d316-1c4b-4281-b951-d872f2087c98

BUG=64263
TEST=compiled locally, trybots

Review URL: http://codereview.chromium.org/6338002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71522 0039d316-1c4b-4281-b951-d872f2087c98