Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 02 Nov, 2018 26 commits
  3. 01 Nov, 2018 14 commits
    • Harley Li's avatar
      [DevTools] Handle long string in service worker list's script name and clients · 244ff236
      Harley Li authored 
      If the name string of the service worker script or a service worker
client is too long, this patch restricts its width and denote the
overflow with ellipsis. Users can still get the string by hovering
above it, and the string is still clickable.

Bug: 847801
Change-Id: I9d3a07c410af6bb98ae42046894ea3d7223afcbc
Reviewed-on: https://chromium-review.googlesource.com/c/1312973
Commit-Queue: Haihong Li (Harley) <hhli@chromium.org>
Reviewed-by: default avatarErik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604760}
      244ff236
    • dpapad's avatar
      WebUI Polymer 2: Don't include dir-mixin.html in the final bundle. · 9d00b88f
      dpapad authored 
      Locally modify Polymer 2 to exclude dir-mixin.html, since it is unnecessary
currently (we don't directly* use any :dir() CSS rules), and also causes a
performance regression (more notice-able in chrome://md-user-manager), due to a
Regex running over a fairly large amount of text (because of inlined PNG background
images).

*The only usage of :dir() was in paper-input-container.html, which is still used
by ChromeOS <gaia-input> element. Modified <paper-input-container> to directly
use :host-context instead. Also :dir() is not implemented in Chrome, so we should
not be using it in our own code anyway.

Ideally the usage of this mixin should be exposed as a Polymer option, so that
we don't need to manually modify our local Polymer 2 copy.

Bug: 899603
Change-Id: Ia20535fb2adb2c9a6bebf3046e4405a4ca31af6c
Reviewed-on: https://chromium-review.googlesource.com/c/1306515Reviewed-by: default avatarScott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604759}
      9d00b88f
    • Kevin Marshall's avatar
      Fuchsia: Add support for receiving input events from Scenic. · 68f78e87
      Kevin Marshall authored 
      ViewsV2 eschews InputConnection in favor of using Scenic for delivering
input events to applications.

This adds input event handling for pointer and touch events via
ScenicSession.

Keyboard events are already being delivered by the ImeService and
are handled by InputMethodKeyboardControllerFuchsia, so no changes are
needed for receiving keyboard inputs.

      "tiles --input_path=new" switches.

Test: manual test against both "tiles --input_path=old" and
Bug: 900428
Change-Id: I8ba2e0c7d35d0dd9d52ef54379d6d693bd9e82d5
Reviewed-on: https://chromium-review.googlesource.com/c/1308910
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: default avatarSergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604758}
      68f78e87
    • Ryan Sturm's avatar
      Moving Previews Initialization call out of profile_impl_io_data · ec445d80
      Ryan Sturm authored 
      This CL moves the call to Init Previews into ProfileManager alongside
similar calls.

Bug: 896001
Change-Id: If1bcecd73b9b5cab9f4ec101bd1e0e09867dba28
Reviewed-on: https://chromium-review.googlesource.com/c/1308990Reviewed-by: default avatarMatt Menke <mmenke@chromium.org>
Reviewed-by: default avatarTarun Bansal <tbansal@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604757}
      ec445d80
    • Alexei Svitkine's avatar
      Fix UMA/UKM ActualLogUploadInterval metrics some more. · 01f7205e
      Alexei Svitkine authored 
      https://chromium-review.googlesource.com/c/chromium/src/+/1278226
attempted to fix these, but there was still an issue because
last_upload_finish_time_ was being set to TimeTicks() instead of
Now().

Bug: 894909
Change-Id: Ibacc8755e53ed6a67fa0ba5a52cea1f281f32c36
Reviewed-on: https://chromium-review.googlesource.com/c/1310639Reviewed-by: default avatarSteven Holte <holte@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604756}
      01f7205e
    • Yuly Novikov's avatar
      Expand some WebGL test suppressions · f86769a5
      Yuly Novikov authored 
      conformance/rendering/gl-scissor-fbo-test.html
Flaky also in Release (Vulkan Win Nvidia passthrough)
deqp/data/gles2/shaders/swizzles.html
Fail (Vulkan Win Nvidia passthrough debug)

conformance2/textures/image_bitmap_from_video/*
Flaky on Linux Nvidia GL passthrough

TBR=kbr@chromium.org

Bug: 766918, angleproject:2939, angleproject:2940
Change-Id: I608b5a25275db953d8d2e0d2ac2fc5343caa64f0
Reviewed-on: https://chromium-review.googlesource.com/c/1313287Reviewed-by: default avatarYuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604755}
      f86769a5
    • Carlos IL's avatar
      Added UKM metrics for mixed content subresource upgrades · cd4f27c8
      Carlos IL authored 
      Bug: 896865
Change-Id: Ide1f9ae86533d5f2c6296da8b77e35c08d8a264e
Reviewed-on: https://chromium-review.googlesource.com/c/1289675
Commit-Queue: Carlos IL <carlosil@chromium.org>
Reviewed-by: default avatarMike West <mkwst@chromium.org>
Reviewed-by: default avatarSteven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604754}
      cd4f27c8
    • Jimmy Gong's avatar
      Fix crash caused by null callback in MdnsHostLocator · 3d71e5cc
      Jimmy Gong authored 
      - Fixes issue where switching wifi networks while starting Mdns
  HostLocator would crash chrome.

Bug: chromium:900779
Test: end to end
Change-Id: Ide5e1bb53961dcd654aedadbffc6cf2a83c5d998
Reviewed-on: https://chromium-review.googlesource.com/c/1313331Reviewed-by: default avatarBailey Berro <baileyberro@chromium.org>
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604753}
      3d71e5cc
    • Yue Li's avatar
      Add Assistant Voice Match screen · a81383e6
      Yue Li authored 
      Bug: b/116166191
Test: Manual Test
Change-Id: Ia9270ce57d2fd4c2b1f563612c892877ee08e251
Reviewed-on: https://chromium-review.googlesource.com/c/1310913
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: default avatarXiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604752}
      a81383e6
    • ziyangch's avatar
      Add BUILD_FLAG(ENABLE_WIDEVINE) to android_key_systems. · f9e2773c
      ziyangch authored 
      Bug=internal 117626741

Test=locally disable widevine and build on atv.

Change-Id: Ic30c773b8c37d6f2ef500dea0bb3ed2a3e94714b
Reviewed-on: https://chromium-review.googlesource.com/c/1308763Reviewed-by: default avatarXiaohan Wang <xhwang@chromium.org>
Reviewed-by: default avatarYuchen Liu <yucliu@chromium.org>
Commit-Queue: Ziyang Cheng <ziyangch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604751}
      f9e2773c
    • Dirk Pranke's avatar
      Rewrite/update //docs/adding_to_third_party.md. · 568e95c0
      Dirk Pranke authored 
      The page had gotten badly out of date. This CL rewrites most
of it to reflect current policy and practice and stops pointing
to viewvc for other links ;)

Change-Id: I62cc952a6f56954af723f4d57b2fadfd84227bda
Reviewed-on: https://chromium-review.googlesource.com/c/1298650
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: default avatarRobbie Iannucci <iannucci@chromium.org>
Reviewed-by: default avatarChris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604750}
      568e95c0
    • Peter Kvitek's avatar
      Added browser child processes info to DevTools SystemInfo.getProcessInfo() result. · 133f8407
      Peter Kvitek authored 
      
Changed DevTools SystemInfo.GetProcessInfo() process type from enum to string.

Change-Id: I7831d6b3fd9a4d2a1feb8aa4c4541d3f86c91a85
Reviewed-on: https://chromium-review.googlesource.com/c/1312117Reviewed-by: default avatarAlexei Filippov <alph@chromium.org>
Reviewed-by: default avatarDmitry Gozman <dgozman@chromium.org>
Commit-Queue: Peter Kvitek <kvitekp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604749}
      133f8407
    • Scott Chen's avatar
      Nux Onboarding: get hard-coded module list from feature params instead. · 00858246
      Scott Chen authored 
      In this CL, four FeatureParams were added.

These 2 are added for "os_win && google_chrome_build" when
kNuxOnboardingFeature is enabled:

kNuxOnboardingNewUserModules
kNuxOnboardingReturningUserModules

And 2 more are added for when the feature is force-enabled with
kNuxOnboardingForceEnabled on other platforms/non-branded build:

kNuxOnboardingForceEnabledNewUserModules
kNuxOnboardingForceEnabledReturningUserModules

Sample command line to test the changes:

./out/gn/chrome --user-data-dir=/tmp/debug_chrome_1 \
    --enable-features="NuxOnboardingForceEnabled<study" \
    --force-fieldtrials=study/g1 \
    --force-fieldtrial-params=study.g1:new-user-modules/nux-google-apps/returning-user-modules/nux-email

TBR=mpearson@chromium.org

Bug: 874153
Change-Id: I495e6492ee66ce20ec8bfad8743d20c9c55acf53
Reviewed-on: https://chromium-review.googlesource.com/c/1311659
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: default avatarDemetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: default avatarHector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604748}
      00858246
    • Mike Wittman's avatar
      Revert "[MacOs Host] Provide user with a prompt to enable input injection on Mojave" · 7ee7bac4
      Mike Wittman authored 
      This reverts commit 19b1b85c.

Reason for revert: breaks mac-dbg build

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/mac-dbg/1574

In file included from ../../remoting/host/remoting_me2me_host.cc:15:
In file included from ../../base/bind.h:10:
In file included from ../../base/bind_internal.h:13:
In file included from ../../base/callback_internal.h:14:
In file included from ../../base/memory/ref_counted.h:16:
../../base/logging.h:786:26: error: comparison of integers of different signs: 'const unsigned int' and 'const int' [-Werror,-Wsign-compare]
DEFINE_CHECK_OP_IMPL(NE, !=)
~~~~~~~~~~~~~~~~~~~~~~~~~^~~
../../base/logging.h:774:33: note: expanded from macro 'DEFINE_CHECK_OP_IMPL'
    if (ANALYZER_ASSUME_TRUE(v1 op v2))                                      \
                             ~~ ^  ~~
../../base/logging.h:338:36: note: expanded from macro 'ANALYZER_ASSUME_TRUE'
#define ANALYZER_ASSUME_TRUE(arg) (arg)
                                   ^~~
../../remoting/host/remoting_me2me_host.cc:1576:3: note: in instantiation of function template specialization 'logging::CheckNEImpl<unsigned int, int>' requested here
  DCHECK_NE(getuid(), 0);
  ^
../../base/logging.h:960:31: note: expanded from macro 'DCHECK_NE'
#define DCHECK_NE(val1, val2) DCHECK_OP(NE, !=, val1, val2)
                              ^
../../base/logging.h:913:18: note: expanded from macro 'DCHECK_OP'
      ::logging::Check##name##Impl((val1), (val2),                     \
                 ^
<scratch space>:21:1: note: expanded from here
CheckNEImpl
^
1 error generated.


Original change's description:
> [MacOs Host] Provide user with a prompt to enable input injection on Mojave
> 
> This change is required due to new security restrictions in Mojave.  We can no longer
> inject input w/o being added as an accessibility app in the security applet.
> 
> While this sounds like a usefulk speedbump, it causes remote access applications quite
> a bit of trouble:
> 1.) We don't use the restricted API until a user connects so they cannot approve remotely
> 2.) The dialog appears to only show up once (regardless of approve/deny status)
> 3.) Users connecting to a locked machine will never see the dialog
> 
> This is affecting quite a few CRD users, basically everyone who upgrades to Mojave
> will experience this one way or another.  This is the simplest fix (and easiest to merge)
> that I could think of to unblock users.  The prompt will only be shown on 10.14+ platforms
> and the request is only shown if the app has not been approved.  I'd like to look at the
> user feedback after releasing this change to see if more work is needed.
> 
> One problem I anticipate is that the dialog shown doesn't have a lot of context and it
> refers to the wrapper script (org.chromium.chromoting.me2me.sh) instead of Chrome Remote
> Desktop.  If this is confusing, we can wrap the prompt request in a dialog where we control
> the text.  My concern with checking in the feature first is that the new strings won't be
> available for merging.
> 
> Another behavior to call about this impl is that the prompt will be displayed in two instances:
> 1.) When the host is first started (choosing enable via app/website)
> 2.) When the user signs in and the host service is started
> 
> Scenario #2 will have less context but that is the only way to ask for permission for
> users who upgraded and had CRD installed previously.  The dialog is not displayed at the login
> screen (i.e. when no one is signed in).
> 
> One last note, there is no way that I can see to specify this permission in the manifest or
> set up via a script / at install time.  It requires a user action to complete.
> 
> Bug: 901021
> Change-Id: I9dd1b24b6d4d083e7e019af32a0da816f6060a86
> Reviewed-on: https://chromium-review.googlesource.com/c/1313170
> Commit-Queue: Joe Downing <joedow@chromium.org>
> Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#604723}

TBR=jamiewalch@chromium.org,joedow@chromium.org

Change-Id: I7c948b26c00f6c6fc7c4e0a3ec4175dcae17e459
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 901021
Reviewed-on: https://chromium-review.googlesource.com/c/1313747Reviewed-by: default avatarMike Wittman <wittman@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604747}
      7ee7bac4