- 01 Oct, 2020 40 commits
-
-
Daniel Rubery authored
Responses served from the cache follow a very similar code path to responses from the server, but we probably don't want to treat them the same in metrics, so this CL breaks the metric in two. Change-Id: I80fc9ebbfa8afc39237dc57727f13f5be68cabcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438889Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#812895}
-
Yusuf Sengul authored
Bug: 1133036 Change-Id: I9a24db72f8f111c4509dc874aa1de5b44b6f4e22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436780 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#812894}
-
wutao authored
This patch sizes the preview to cover the img element while keeping the aspect ratio. Bug: b/169434370 Test: manual Change-Id: If54cd536d037e1cc9a6a75335fe1ea7e93d24a13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442488Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#812893}
-
David Black authored
Holding space views are failing to repaint when being updated async. Bug: 1134284 Change-Id: I573e44f4256d11a437d5c7a239ed48553443787a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443451 Commit-Queue: David Black <dmblack@google.com> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Auto-Submit: David Black <dmblack@google.com> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#812892}
-
Kartik Hegde authored
Add new util functions needed by HttpsLatency routine. BUG=chromium:956783 TEST=unit_tests --gtest_filter=NetworkDiagnosticsUtilTest* Change-Id: Ieae113b0df25f6b55658d701fd4b39b81948bd91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442329 Commit-Queue: Kartik Hegde <khegde@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#812891}
-
Yann Dago authored
This new policy allows to periodically cleans some browsing data. Bug: 1026442 Change-Id: I33f1d4f8b462b89de54ecdb0a35230b5ed2ec3a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324203 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#812890}
-
Nate Fischer authored
This adds the java_cpp_features GN rule to autogenerate Java String constants representing C++ features. This refactors parts of java_cpp_strings so java_cpp_features can share it. This aims to address the most common syntaxes for declaring C++ features (string literal names, "brace" and "equals brace" initialization, with & without the "base::" namespace). Design: http://go/autogen-java-features Bug: 1060097 Fixed: 1091031 Test: vpython build/android/gpy/java_cpp_strings_tests.py Test: vpython build/android/gpy/java_cpp_features_tests.py Test: tools/md_browser/md_browser.py docs/android_accessing_cpp_features_in_java.md Change-Id: I5311f72f8837c122186148cf183f4219087df96a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412840 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#812889}
-
John Lee authored
Bug: 1105862 Change-Id: Ia3b9cb7d06a88005321806c78f1dbcf93d4ba544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438929Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#812888}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/bce69fefbe63..72a6843cad22 2020-10-01 hjd@google.com Merge "ui: Improve track names even more" 2020-10-01 lalitm@google.com Merge "Update CHANGELOG for v8.0 release" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I84602a5a32b15fad131296c66e83fa0057f0113e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443349Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812887}
-
Bill Carr authored
When DirectCompositionChildSurfaceWin::EnqueuePendingFrame is called if swap_rect_ is non-empty a d3d11 query is created resulting in 3d engine work. Due to an optimization in DirectRenderer::DrawFrame (see https://source.chromium.org/chromium/chromium/src/+/master:components/v iz/service/display/direct_renderer.cc;drc=be67975e bd6cf67bbe1;l=402) we are not however currently clearing swap_rect_ by calling DirectCompositionChildSurfaceWin::SetDrawRectangle with an empty rect when there is no damage to the root. As a result after the first SetDrawRectangle call 3d engine work is performed for each queued frame. To help reduce the amount of 3d engine work we'll reset swap_rect_ at the end of SwapBuffers; allowing the d3d11 query to be skipped until the next new SetDrawRectangle occurs. Bug: 1133916 Change-Id: I84ccf81d18a8e45e1ce871484a763c20e5bb6418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443489 Commit-Queue: William Carr <wicarr@microsoft.com> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#812886}
-
David Bokan authored
A few small improvements found to this test while working on a CL that ended up being unrelated. Replace WaitFor with WaitUntilAnimationEndTimeBased since the former waits using rAF ticks which are artificially made very short in web tests. This means it doesn't actually wait very long in practice. The TimeBased version uses the wall clock so isn't affected by the rAF interval time. Bug: 915926 Change-Id: I5e68d9e6db47da5902538255cc36e5f242bd9a8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442355Reviewed-by:
Liviu Tinta <liviutinta@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#812885}
-
Haiyang Pan authored
This reverts commit 37ba4241. Reason for revert: The test OverflowScrollInterruptedByWheelScroll consistently fails on a couple of android builders. For example: * https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/2386 * https://ci.chromium.org/p/chromium/builders/ci/android-asan/8057 * https://ci.chromium.org/p/chromium/builders/ci/android-arm64-proguard-rel/2773 Original change's description: > Reland "Rewrite scroll interruption tests into browser tests" > > After we finish the scroll unification, the scrolls happens mainly on > the compositor thread, and the scroll code in the main thread will be > removed. eventSender sends the scroll events to main thread, so it > would not work after the scroll unification. We rewrite below tests > fast/scroll-behavior/main-frame-interrupted-scroll.html, > fast/scroll-behavior/overflow-interrupted-scroll.html and > fast/scroll-behavior/subframe-interrupted-scroll.html into browser tests > because we cannot guarantee that the scroll arrives before the animation > completes. > > I disable the test when disable_threaded_scrolling_ is false, because we > do not know what is the final scrollTop value. > > TBR=bokan@chromium.org > > Change-Id: Ia9b68cd2e0c4f198968aa56482698c0c02edf452 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441205 > Reviewed-by: Lan Wei <lanwei@chromium.org> > Commit-Queue: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812517} TBR=bokan@chromium.org,lanwei@chromium.org Change-Id: Ia4f0efbd3a203be16670ea10d54dcf8ae5820aad No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443215Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#812884}
-
Haiyang Pan authored
This reverts commit e855807b. Reason for revert: Likely the cause of the test failures described in crbug.com/1134292. These tests are failing on other android builders as well. For example: * https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/2386 * https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester/27170 Original change's description: > Added a11y state description to ListBox on Android > > This CL updates the behavior of ListBox on Android. > > With this change, the state of a Listbox ("x items") will > now be read during swipe navigation when a node is initially > selected. For ListBoxItem, the state of the item will read > as "in list, item x of y". > > We append the state of the ListBox or items in the > stateDescription element of the node's corresponding > AccessibilityNodeInfo object. > > This CL also updates associated unit test expectations. > > > AX-Relnotes: ListBoxes and ListBoxItems now explicitly announce their count and item index. > Bug: 1101656 > Change-Id: I41bf46d2f11ea9fb0c744ccd3802855c028ecb79 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436382 > Commit-Queue: Mark Schillaci <mschillaci@google.com> > Reviewed-by: Mark Schillaci <mschillaci@google.com> > Reviewed-by: danakj <danakj@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812477} TBR=dmazzoni@chromium.org,danakj@chromium.org,pdr@chromium.org,mschillaci@google.com Change-Id: I2e57b039c81e8a4cdaedd22383ac3d4cf5e60e61 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1101656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443538Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#812883}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c73bff39bd21..a0c82f08df58 2020-10-01 brianosman@google.com Revert "moved SkSL FloatLiteral data into IRNode" 2020-10-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from b042f4e70879 to 5e947adaf26e (4 revisions) 2020-10-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from cc47e0cd to 085332bf (612 revisions) 2020-10-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from ad421a248adb to da5828c06b4c (2 revisions) 2020-09-30 bsalomon@google.com Get GrBackendRenderTarget's sample count from MtlTexture. 2020-09-30 robertphillips@google.com Have the GrShadowRRectOp make use of the thread-safe view cache 2020-09-30 robertphillips@google.com Have GrMatrixConvolutionEffect use the thread-safe view cache 2020-09-30 johnstiles@google.com Update TextureEffect to avoid extraneous out variable. 2020-09-30 brianosman@google.com Add Variable::fBuiltin, to track Variables owned by pre-includes 2020-09-30 bsalomon@google.com Return GrBackendTexture from SkPromiseImageTexture by value. 2020-09-30 johnstiles@google.com Update MatrixEffect to avoid extraneous out variable. 2020-09-30 ethannicholas@google.com moved SkSL ExternalFunctionCall's data into IRNode 2020-09-30 johnstiles@google.com Simplify generated GLSL code for trivial FPs. 2020-09-30 senorblanco@chromium.org Dawn: remove persistent TextureView from GrDawnTexture. 2020-09-30 smoreland@google.com Avoid heap initialization for skia allocations. 2020-09-30 brianosman@google.com Move VariableReference ref-adjusting into helper functions 2020-09-30 robertphillips@google.com Make GrRectBlurEffect use the thread-safe view cache 2020-09-30 johnstiles@google.com Calculate texture clamping X/Y coordinates in parallel. 2020-09-30 johnstiles@google.com Inline trivial single-argument constructors directly. 2020-09-30 michaelludwig@google.com Fix GrClipStackClip::preApply to report kClippedOut 2020-09-30 robertphillips@google.com Make GrRRectBlurEffect use the thread-safe uniquely-keyed view cache (take 2) 2020-09-30 johnstiles@google.com Add ProgramWriter, a non-const version of ProgramVisitor. 2020-09-30 johnstiles@google.com Add unit test for inlining trivial arguments. 2020-09-30 ethannicholas@google.com moved SkSL Extension data into IRNode 2020-09-30 csmartdalton@google.com Don't cast emscripten pointers when assembling WebGL interface 2020-09-30 johnstiles@google.com Update nanobench SkSL tests. 2020-09-30 ethannicholas@google.com Revert "Revert "moved SkSL ExpressionStatement's data into IRNode"" 2020-09-30 bsalomon@google.com Add sample count field to GrD3DTextureResourceInfo. 2020-09-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from ec42b1438fd2 to fa082bb58ba7 (11 revisions) 2020-09-30 johnstiles@google.com Avoid creating temporary variables for nested trivial cases. 2020-09-30 johnstiles@google.com Revert "moved SkSL ExpressionStatement's data into IRNode" 2020-09-30 brianosman@google.com Revert "Make GrRRectBlurEffect use the thread-safe uniquely-keyed view cache" 2020-09-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 44be0942f9a8 to b042f4e70879 (15 revisions) 2020-09-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from b2a4e87ad274 to ad421a248adb (2 revisions) 2020-09-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 339e4ec2 to cc47e0cd (351 revisions) 2020-09-30 johnstiles@google.com Allow more types of expressions to be directly inlined. 2020-09-30 ethannicholas@google.com Revert "Revert "moved SkSL Enum data into IRNode"" 2020-09-29 robertphillips@google.com Make GrRRectBlurEffect use the thread-safe uniquely-keyed view cache 2020-09-29 kjlubick@google.com [canvaskit] Add Initial Typescript definitions/types. 2020-09-29 ethannicholas@google.com moved SkSL ExpressionStatement's data into IRNode 2020-09-29 robertphillips@google.com Make the SW blurred mask path use the thread-safe uniquely-keyed view cache 2020-09-29 johnstiles@google.com Revert "moved SkSL Enum data into IRNode" 2020-09-29 ethannicholas@google.com moved SkSL Enum data into IRNode 2020-09-29 brianosman@google.com Fix swizzle-of-swizzle lvalues in ByteCodeGenerator 2020-09-29 brianosman@google.com Add a benchmark that measures SkSL::Compiler startup time 2020-09-29 jsimmons@google.com Add an API for clearing the SkParagraph font and paragraph caches 2020-09-29 ethannicholas@google.com moved SkSL Constructor's data into IRNode 2020-09-29 robertphillips@google.com Have GrCircleBlurFragmentProcessor make use of thread safe view cache 2020-09-29 bsalomon@google.com Add sample count to GrVkImageInfo. 2020-09-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 2a09e89113af to ec42b1438fd2 (63 revisions) 2020-09-29 herb@google.com minimize includes and forwards for remote glyph cache 2020-09-29 ethannicholas@google.com moved SkSL FloatLiteral data into IRNode 2020-09-29 jvanverth@google.com Move MacOS 10.13 Metal jobs to 10.15. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1018739,chromium:1096746,chromium:1108408,chromium:1130678,chromium:1132366,chromium:1133459,chromium:131355925 Tbr: brianosman@google.com Test: Test: Test: CQTest: Test: Test:Test: Test: CQTest: Test: ContextNoErrorTest31.DrawWithPPOTest: Test: Manual verification of Skia 'gn gen' on WindowsTest: Test: ProgramPipelineTest31.VerifyPpoLinkErrorSignalledCorrectlyTest: Test: angle_end2end_test --gtest_filter=*ETC1CompressedImageNPOT*Test: Test: angle_end2end_tests --gtest_filter=*ETC1CompressedImageDraws*Test: Test: dEQP.GLES31/functional_separate_shader_validation_es31_*Test: Test: removes large hwuimacro regressions w/ heap initialiation Change-Id: Iab1d1bf0753fc3f2dafdb386f9c28aa99155d0cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442930Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812882}
-
Siyu An authored
We found the offer data would be successfully synced down to client but would not be saved. After debugging we found the client tag hash for the offer data is missing in the update response. Similar to wallet data, every time offer data is updated, it will be a full update. So we need to set this manually. Bug: 1112095 Change-Id: I304a078f44f5647d4f3da26b7086f0ddec973ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441939 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#812881}
-
Moe Ahmadi authored
Fixed: 1130864 Change-Id: I5ca24433cb2892a8a1e8f243b6f280f9389b66ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442092 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#812880}
-
Anders Hartvoll Ruud authored
- The insertion point crossing flag needs to be reset in a similar way to the tree crossing flag. Otherwise flags may "leak" from one nested complex selector to another unrelated nested complex selector. - In ExtractInvalidationSetFeaturesFromSelectorList, don't return as soon as we encounter kRequiresSubtreeInvalidation, as this causes selectors following a :host-context to be skipped, for example we would ignore '.b' in ':is(:host-context(.a), .b)'. - We should also not propagate the kRequiresSubtreeInvalidation value from nested complex selectors, as it causes whole subtree invalid for _everything_ in the top-level rightmost compound, even the parts unrelated to kRequiresSubtreeInvalidation. For example, for ':is(:host-context(.a), .b)', .b would be marked as whole subtree invalid. Instead we rely on this being handled locally inside each call to UpdateInvalidationSetsForComplex. Bug: 568705 Change-Id: If54b7c006a4c1d886513a0bfb3e075fd4f71be63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438417 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#812879}
-
Yusuf Sengul authored
Bug: 1133586 Change-Id: I791e4e900936fbc9349d0742c93bc2a3f13700d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439675Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Commit-Queue: Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#812878}
-
Klaus Weidner authored
Adds support for a per-view viewport scale factor, dynamically configurable on a per-frame basis. The feature is controlled by the WebXRViewportScale Blink feature, and can be enabled via chrome://flags#webxr-incubations or the --enable-features=WebXRIncubations command line flag. See https://github.com/immersive-web/webxr/pull/1132/files for the related spec changes. This CL does not yet implement a recommended scale factor which is an optional feature in the spec. The attribute just returns base::nullopt for now. In addition to the Blink experimental feature flag, the device backends also need to opt in by setting XRSession.supports_viewport_scaling via mojo response. Currently, only the GVR device enables the feature. Bug: 1133381 Change-Id: I5ccf3fd613eb78475e1f4512025cc3eab6fd149d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438207 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#812877}
-
Aya ElAttar authored
- Changed ClipboardDlpController to a singleton to decouple its ownership and lifetime from ui::Clipboard, which was previously unexpectedly destructed by DestroyClipboardForCurrentThread. - Removed Clipboard::GetDlpController and Clipboard::SetDlpController. - Changed DlpRulesManager to be responsible for controlling EnterpriseClipboardDlpController lifecycle. Bug: 1102332 Change-Id: I603f5d61c218290dbcc74a9292f89e78f08d7dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424086 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#812876}
-
Yao Xiao authored
Switched to do ReadVarint64 from CodedInputStream. Each blocklist check would involve a file scan on the background. Bug: 1062736 Change-Id: I6b0153e8a8e39025a4bf9485a837897767b3abde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440305 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#812875}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/75b9ab6751f3..dba4db5668d6 2020-10-01 landrey@webrtc.org Revert "Reland "Reduce the amount of howling reduction in AEC3"" 2020-10-01 perkj@webrtc.org Refactor reporting of VideoBitrateAllocation 2020-10-01 peah@webrtc.org Reland "Reduce the amount of howling reduction in AEC3" 2020-10-01 landrey@webrtc.org Revert "Reland "Activating AVX2 support by default"" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I0780bbb6fadb565c077cda665017c63b7d6f1499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443272Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812874}
-
Rune Lillesveen authored
Check that a dark color-scheme meta results in a dark content background color for the web view. Bug: 1103667 Change-Id: If71c3211a4ae54af9826d925517a7ec79cdef76d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440595Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#812873}
-
Elaine Chien authored
Bug: 772945 Change-Id: I61ac71e470cc79734ca775c7294b46f6a87a92ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436576Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#812872}
-
Manas Verma authored
AutofillManager now accesses AutofillOfferManager via the AutofillOfferManagerFactory, which will be used for updating credit card suggestions to display offers. AutofillOfferManager will be a BrowserContextKeyedService, with one instance per profile. Bug: 1093057 Change-Id: Ia065577c702ad2784d54031b781eec0cdc74b89d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419238 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Siyu An <siyua@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#812871}
-
Scott Violet authored
The following sequence leaves the layer associated with RenderWidgetHostViewAndroid hidden: 1. window hides 2. view is removed from window. 3. view added back to window 4. window is shown. The bug occurs because StopObservingRootWindow() assumes the window is shown, so that in step 4 when OnRootWindowVisibilityChanged() is called the code early outs, leaving the layer hidden. BUG=1075744 TEST=RenderWidgetHostViewAndroidTest.HideWindowRemoveViewAddViewShowWindow Change-Id: I7ba61189b0be4882335721cf6fdc5ae2253c5827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437718Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#812870}
-
Xiaohan Wang authored
This is now the same as `is_linux`. Replace it with `is_linux` everywhere to avoid confusion. We'll remove it after all third_party code are updated as well. Bug: 1132395 Change-Id: I6a4a765e5166f60567667460f4426b21f29f172b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432052 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#812869}
-
Mehran Mahmoudi authored
As per UX review, this CL disables the progressbar when paint preview is shown. It also fakes a progress fill animation on upgrading to the live tab. Bug: 1131497 Change-Id: I8054f2aacaaea7d76423017b89057f811895e548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441188 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#812868}
-
Xianzhu Wang authored
Some web sites create huge layers with tiny scale. Previously because the scale was clamped to minimum scale, causing too many tiles with too big scale and out of tile memory. This CL contains the following changes: 1. Remove LayerTreeSettings::minimum_contents_scale. It was added when we used layer coordinates in PicturePile and needed to expand record / invalidation rects by 1/scale pixels to ensure all affected texels were covereda. The minimum scale avoided problems caused by too many pixels to expand when the ideal scale was too small. Now we use texel coordinates in PictureLayerTiling and all rects in layer coordinates will be mapped into texel coordinates by scaling the rect then getting the enclosing int rect, which ensures coverage of affected texels, so the minimum scale is no longer useful. 2. Adjust scale clamping for will-change:transform. a) If the ideal scale is much smaller than the native scale, don't clamp to the native scale; b) Update raster contents scale only if it's too small compared to the ideal contents scale. Without this, we would update tiny raster contents scale when the ideal scale changes which would defeat the optimization for will-change:transform. Bug: 1132991 Change-Id: I3a31f654fe4a5ccc925aaad3a2b75748c4e37164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438756Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#812867}
-
Austin Sullivan authored
uses saturated_cast Bug: 116075 Change-Id: I228a00f77bd2df3b429b16a58c15eb47285c055b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435282Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: enne <enne@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/master@{#812866}
-
Mei Liang authored
TabUiFeatureUtilities.isTabGroupsAndroidEnabled() does not guarantee TabModelFilterProvider().getTabModelFilter() returns TabGroupModelFilter. It can return null before TabModelSelectorBase#initialize() is called. This CL early returns when TabModelFilterProvider().getTabModelFilter() is not a TabGroupModelFilter to avoid the casting exception. This CL is gated by Finch parameter "enable_launch_polish" under flag "enable-tab-grid-layout", with gate function TabUiFeatureUtilities#isLaunchPolishEnabled. Bug: 1133922 Change-Id: I9766d4f0f54c954f8205866aa0c514b508d7a5a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442479 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#812865}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e2764fee10f6..30ea8e724567 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC karandeepb@google.com,aaronhk@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1061119,chromium:1099917,chromium:1099982,chromium:1133575 Tbr: karandeepb@google.com,aaronhk@google.com Change-Id: I825aee916705c51b03fd4e8321c996f30218564d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443270 Commit-Queue: Michael Moss <mmoss@chromium.org> Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812864}
-
George Burgess IV authored
As discussed on https://groups.google.com/a/chromium.org/g/cxx/c/iow8Ugo7190, adding these sounds like a good idea. Bug: None Change-Id: Ic7a721d8c94e5e5f0629bdc50b6d466c7b344ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438310 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#812863}
-
cfredric authored
This will be used to analyze how much entropy leaked by this API can be used for cross-site tracking. Bug: 973801 Change-Id: I3741e7bf887e0d7b07b203531afac230ca7dcf70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441324Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Auto-Submit: Chris Fredrickson <cfredric@google.com> Cr-Commit-Position: refs/heads/master@{#812862}
-
Mark Schillaci authored
This CL updates some test expectations that include the new state description to fix failing content_browsertests Related change: https://crrev.com/c/2432089 AX-Relnotes: N/A Bug: 1133354, 1134201 Change-Id: I981eb7b465971e818df87efb04c21f1ccc3480d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443071Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#812861}
-
Olivier Yiptong authored
This changes the page info string to match the UI recommendation as necessary to ship in Origin Trial. Bug: 1043306 Change-Id: I77133f0a3e95c87d1a261043d596f669bbde62c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441955 Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#812860}
-
Dirk Pranke authored
This reverts commit 11eba3d1. Reason for revert: re-landing with fix. Original change's description: > Revert "Change blink_web_tests and blink_python_tests test types." > > This reverts commit 71c10e67. > > Reason for revert: Breaking Dawn's CQ. This CL likely needs to > update webgpu_blink_web_tests as well. > > Original change's description: > > Change blink_web_tests and blink_python_tests test types. > > > > This CL changes the GN blink_web_tests and blink_python_tests > > targets to use a new script_test() GN template. > > > > A script_test is a kind of test target that implements the > > [test executable API](//docs/testing/test_executable_api.md) > > via a Python script (rather than being an executable target). > > > > :blink_web_tests, :blink_python_tests are examples of this type > > of test; other targets will be switched over in future CLs as well. > > > > Most importantly, using script_test() will ensure that > > the $root_build_dir/bin/run_$target_name test wrappers are > > generated with all of the appropriate arguments, simplifying the > > invocation of the test both for devs and for the bots. > > > > Bug: 816629 > > Change-Id: Ib4bfd2342d762db24cdef75b64ed5dd7fbf3c10e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380936 > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > Reviewed-by: Robert Ma <robertma@chromium.org> > > Reviewed-by: Rakib Hasan <rmhasan@google.com> > > Cr-Commit-Position: refs/heads/master@{#812523} > > TBR=dpranke@google.com,robertma@chromium.org,rmhasan@google.com > > Change-Id: I16c0d8bfaebbeabbeee7dd98a0f4bb083403444f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 816629 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442872 > Reviewed-by: Austin Eng <enga@chromium.org> > Commit-Queue: Austin Eng <enga@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812694} TBR=robertma@chromium.org,rmhasan@google.com # Not skipping CQ checks because this is a reland. Bug: 816629 Change-Id: I78f30594215fe5c9a4dcd60a6ba49ae101a69abe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441351 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#812859}
-
Andy Paicu authored
HidConnectionImpl is self-owned and will self-destruct on disconnection of the HidConnection or HidConnectionWatcher. This CL modifies the FakeHidConnection used in tests so it behaves the same way. BUG=1126689 Change-Id: I8bbdcca7c77699749c6022f01b8a456c4891cdb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441151 Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#812858}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/68377adad5ae..98218e9219b1 2020-10-01 kimstephanie@google.com Revert "Add optional enforce_fetch kwarg to fetch and refresh git cache" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1129235 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I38cb06e701babe192893cab0021740c22cbcf775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443232Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812857}
-
Istiaque Ahmed authored
Bug: None Change-Id: Ib69f766773c55d231d52f3eb7100cc71c61e561e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442149 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#812856}
-