- 27 Feb, 2020 40 commits
-
-
Jose Lopes authored
This callback is used in 2 places but in different ways. The service uses this callback as a once callback (explained below). And the provider uses it as a repeating callback because the provider works like a factory class. So this CL splits the callback definition into 2 separate callbacks. A detailed explanation of why the service behaves like a once callback. This callback is executed in an IPC handler: * https://cs.chromium.org/chromium/src/media/mojo/services/mojo_video_encode_accelerator_service.cc?rcl=389b555af3ca96ce205c8e231429119a59aab50b&l=47 This callback is used to create an encoder, and once the class holds a valid encoder the Initialize method can no longer be called because of the check in: * https://cs.chromium.org/chromium/src/media/mojo/services/mojo_video_encode_accelerator_service.cc?rcl=389b555af3ca96ce205c8e231429119a59aab50b&l=53 In theory, if the method fails it could be called repeatedly until it succeeds. But looking at the callers it seems this doesn't happen. The only mojo caller is in: * https://cs.chromium.org/chromium/src/media/mojo/clients/mojo_video_encode_accelerator.cc?g=0&l=123 And that method is documented that it can only be called once: * https://cs.chromium.org/chromium/src/media/video/video_encode_accelerator.h?g=0&l=237 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: I1f51ff76b679c891740d2848e9d4c573ef315db0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069329Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Jose Lopes <jabolopes@google.com> Cr-Commit-Position: refs/heads/master@{#744977}
-
Jack Franklin authored
`String.prototype.toBase64` is being removed from the DevTools frontend [1] and this test has been moved into unit tests in frontend. Bug: 1032561 Change-Id: I8b6d75d2751404c9a012fe8a9fda63a4b2039052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061757 Commit-Queue: Jack Franklin <jacktfranklin@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/master@{#744976}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3f0406a3..f58705e5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4a3f76d357a584332d18d24e9cd3f0d955f986cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075241Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744975}
-
Gauthier Ambard authored
UseWKWebViewLoading is launched and the code has been removed. The field trial config can now be removed. Bug: none Change-Id: Ia41383a4c6016c8bce57c1f31ec01b04bafae691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074879Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#744974}
-
Hiroki Nakagawa authored
This CL adds tests for dedicated/shared worker creation in data URL contexts (iframe and dedicated worker) whose origins are opaque. For dedicated worker creation: 1. Creating a dedicated worker in a data URL iframe 2. Creating a dedicated worker in a data URL dedicated worker 3. Creating a data URL dedicated worker in a data URL iframe 4. Creating a data URL dedicated worker in a data URL dedicated worker Expected behavior: - For 1 and 2, they are expected to asynchronously fail worker construction because the same-origin policy is supposed to be checked during the fetch algorithm based on request's "same-origin" mode. - For 3 and 4, they are expected to succeed in worker construction because fetching a data URL from a data URL context is allowed. Chrome behavior - For 1 and 2, Chrome synchronously fails the cases because the same-origin policy is checked in the Worker constructor (i.e., SecurityOrigin::CanReadContent() call in AbstractWorker::ResolveURL()). See issue 1055697. For shared workers: 5. Creating a shared worker in a data URL iframe 6. Creating a data URL shared worker in a data URL iframe Expected behavior: - For 5, this is expected to asynchronously fail worker construction because the same-origin policy is supposed to be checked during the fetch algorithm based on request's "same-origin" mode. - For 6, this is expected to succeed in worker construction because fetching a data URL from a data URL context is allowed. Chrome behavior - For 5, Chrome synchronously fails worker construction because the same-origin policy is checked in the SharedWorker constructor. This is the same as 1 and 2. See Chrome behavior for 1 and 2. - For 6, Chrome synchronously fails worker construction because of issue 1055693. Chrome doesn't support creating shared workers in dedicated workers and vice versa, so this CL doesn't contain those cases. Note that these are allowed in the HTML spec, so it would be nice to have WPTs for the cases, but it's out of the scope of this CL. Bug: 1053382, 1055693, 1055697 Change-Id: I8480b6079d4fb271855656cedcffc86e6e6c0fc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043533 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Eriko Kurimoto <elkurin@chromium.org> Cr-Commit-Position: refs/heads/master@{#744973}
-
Luciano Pacheco authored
This CL removes the animation when updating the thumbnail image. This animation is very quick and hardly noticed and some code paths weren't even using the animation. This fixes 2 issues: 1. Old images weren't removed when there animation wasn't used. 2. The event listener for 'animationend' wasn't removed. No change in functionality for the user, so no new tests added. Test: Manually checked that file list and grid display and update their thumbnails. Bug: 1056443 Change-Id: I8a6bd050c2bbb358387934ff9371c075a6703508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076749 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#744972}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c3a0d11aff58..d8e762cd820b git log c3a0d11aff58..d8e762cd820b --date=short --first-parent --format='%ad %ae %s' 2020-02-27 yangguo@chromium.org Add Jack to OWNERS Created with: gclient setdep -r src/third_party/devtools-frontend/src@d8e762cd820b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I49bac170b9a14b46b19f921651eaf3853152b1a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076809Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744971}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e763c61a2c3b..3caf4532c490 git log e763c61a2c3b..3caf4532c490 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 04383ff2..b53f5caa (392 commits) Created with: gclient setdep -r src/third_party/skia@3caf4532c490 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: I4257574dce0b918c648e87f1739792dae48d2bcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076806Reviewed-by:
-
Matthew Mourgos authored
Bug: 976949 Change-Id: Iceabe5a61f3ced8bc6a4c03dd05c460a35552dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068007Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#744969}
-
Eriko Kurimoto authored
This CL adds util::PassKey<ModuleScriptLoader> to the arguments of ModuleScriptFetcher constructor. ModuleScriptFetcher is allowed to be called only from ModuleScriptLoader but currently it can be called from elsewhere as an implementation. To prohibit accessing from other classes, we use PassKey. PassKey value must be private, but we allow accessing this value from outside only for testing via ModuleScriptLoader::CreatePassKeyForTest(). Also, ModuleScriptFetcher::Fetch() must be called only once and this change clarifies this restriction as the comments. Change-Id: If284f4d5ff4ab21fe7f672ac98017d3835497889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071336Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@google.com> Cr-Commit-Position: refs/heads/master@{#744968}
-
Gauthier Ambard authored
This CL removes the code that was doing the switch for the feature to use the WKWebView loading property. The property is enabled to 100%. Bug: 1006012,767092 Change-Id: Id4a4ca3ad18b24cb97e79c32aece943470d9d0a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074641 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#744967}
-
chromium-autoroll authored
Roll ChromeOS orderfile from 82-4044.15-1581938780-benchmark-82.0.4065.0-r1 to 82-4044.25-1582542147-benchmark-82.0.4065.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Id108e556b062cecba010571d1cf23e51852f8783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076810Reviewed-by:
-
chrome://flagsAlexey Baskakov authored
This flag enables the new Web Applications platform, independent of Chrome Extensions (Project BMO). Bug: 877898 Change-Id: I1120418f858d8cfedc01a7ccac3e94e46220accf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076753 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#744965}
-
Henrique Ferreiro authored
ui::Cursor::GetBitmap/Hotspot() depend on CursorLoader. This CL extracts those methods as functions in cursor_lookup.h/.cc as a precursor for creating a separate target for ui::Cursor that will allow its usage in Blink. Bug: 1040499 Change-Id: I7c0e4469261621877305996daae0585354fdd4d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052783 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#744964}
-
Andreas Haas authored
DOMArrayBufferView can be used instead of the ArrayBufferView, and the ArrayBufferView is fetched from the DOMArrayBufferView anyways. R=haraken@chromium.org Bug: chromium:1008840 Change-Id: I288ddddf43641e9afae3c9e8e5b4b986279e51b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075377Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#744963}
-
Takashi Sakamoto authored
This reverts commit 04f3c8a3. Reason for revert: LoadingPredictorBrowserTestWithOptimizationGuide.UsesPredictionsFromOptimizationGuideIfAvailable is still flaky on linux-chromeos-rel and deterministically fails (TIMEOUT) on linux-chromeos-chrome Sample build: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3532 3532, 3533, ..., and 3539 also reports the test's failure. Sample log: https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8887348194941922560/+/steps/browser_tests/0/logs/Deterministic_failure:_LoadingPredictorBrowserTestWithOptimizationGuide.UsesPredictionsFromOptimizationGuideIfAvailable__status_TIMEOUT_/0 Original change's description: > Reland "Reland "Add support for loading predictor to use hints from optimization guide"" > > This is a reland of 9a31f5ab > > Original change's description: > > Reland "Add support for loading predictor to use hints from optimization guide" > > > > This is a reland of eed7024d > > TBR=tbansal@chromium.org for chrome/browser/predictors/... > > > > Original change's description: > > > Add support for loading predictor to use hints from optimization guide > > > > > > Will add metrics in a subsequent CL. This shouldn't affect any current > > > metrics since the support is all behind a feature flag. > > > > > > Bug: 1050101 > > > Change-Id: If6f98dbae86bb5842803cdb3c1b052d99711e62f > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067241 > > > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > > > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > > > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#743767} > > > > Bug: 1050101 > > Change-Id: I796d2bbd322fee835bfc42f3f3bc903b65554291 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068313 > > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#744088} > > Bug: 1050101 > Change-Id: I3450fa6cab159b22d0659532ea8f2524bf4944fc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071380 > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744839} TBR=tbansal@chromium.org,sophiechang@chromium.org,ryansturm@chromium.org Change-Id: I7c1fc5920524e193f0f1d68656f89f55ff111c64 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1050101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076868Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#744962}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8b8dc561f00f..cb7f5f4a2acc git log 8b8dc561f00f..cb7f5f4a2acc --date=short --first-parent --format='%ad %ae %s' 2020-02-27 ianelliott@google.com Vulkan: Updated expectations after SwS fixed 4259 Created with: gclient setdep -r src/third_party/angle@cb7f5f4a2acc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: geofflang@google.com Change-Id: I97439eed923d76a9ad2866d7e038fcc0d8424dcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076803Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/4d40271e3f09..4b34ee3de531 git log 4d40271e3f09..4b34ee3de531 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 jmadill@chromium.org Fix comparison of specialization constant keys. Created with: gclient setdep -r src/third_party/swiftshader@4b34ee3de531 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I4957f3c629371ee6b8bc23488ad0182df549c13d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076676Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/d3db56259396..cd2eb2e2d632 git log d3db56259396..cd2eb2e2d632 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 dschuff@chromium.org Add DEPS to hashed build system sources in toolchain_build Created with: gclient setdep -r src/native_client@cd2eb2e2d632 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/nacl-autoroll Please CC mseaborn@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: mseaborn@chromium.org Change-Id: I9e4e80f712d2557c416aa71ffa976fd2d7a520a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076802Reviewed-by:
-
Koji Ishii authored
This patch supports FragmentItem in |NGBoxFragmentBuilder:: GetChildOffset()|. Fixes 1 NOTREACHED failure. Note, |GetChildOffset| was moved to |NGBoxFragmentBuilder| in <crrev.com/c/2076745>. Bug: 982194 Change-Id: I5e3d00b551b84ae0efa90228369b6aa5f0c8fc21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076824 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#744958}
-
Jiewei Qian authored
This CL adds support to allow individual origins in content settings. Also force allow chrome-untrusted://terminal origin to Clipboard API. Bug: 1035255 Change-Id: Id69840764fdb8c3aba85b6671e913f077f5ea015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064230 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#744957}
-
Tal Pressman authored
Change-Id: I1e28b5287fcbfb706e8c50dad6227161e16855a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076220Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#744956}
-
Eric Willigers authored
The test suite HostedOrBookmarkAppTes is renamed to HostedOrWebAppTest. The test now run with and without the DesktopPWAsWithoutExtensions flag enabled. Bug: 1055236 Change-Id: I91721a970d88f6f056a06a919749d2d78ef825d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076640 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#744955}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/913a2ec17514..e763c61a2c3b git log 913a2ec17514..e763c61a2c3b --date=short --first-parent --format='%ad %ae %s' 2020-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader da659b374113..4d40271e3f09 (2 commits) Created with: gclient setdep -r src/third_party/skia@e763c61a2c3b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: I20bd7d11968c9f35e1afb629e99b6b9839fea793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076673Reviewed-by:
-
Hirokazu Honda authored
This is a workaround of the failure at 1080p video encoding test on grunt. Originally vaCreateImage is created with a coded frame size. However, it causes SEGV_MAPERR on vaPutImage, which copies vaImage to vaSurface. As a result of experiments, the vaImage size needs to be the same as va surface size. Since this is not stated in VA-API document, so this might be a bug of AMD gallium driver. Besides of the workaround, this CL copies visible size area of VideoFrame to the VAImage. Bug: 1048908 Bug: 1050377 Bug: b:148744040 Test: video.EncodeAcel.* on grunt, eve and soraka Test: camera.* on grunt, eve and soraka Change-Id: I1ee853964387846d2452e72cfbd4c939f0a18f62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041382 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#744953}
-
Toni Barzic authored
Introduces a new hotseat state for hotseat inside the clamshell shelf. This state was previously covered by kShown state. While the widget placement within the shelf does not change too much for the new state, the distinction between "shown" state in tablet mode and "shown" state in clamshell (i.e. the new hotseat state) is useful for animating hotseat state related shelf transitions. For example, HotseatTransitionAnimator should not animate the shelf background when transitioning in or out of tablet mode, and is currently keeping track of whether a tablet mode transition is in progress using tablet mode controller observers - it sets the "in tablet mode transition" flag when the transition starting observer is called, and resets it when the transition end observer is called. This approach is fragile, given that the hotseat state transition can changed by other tablet mode observers (so whether the animator correctly detects whether tablet mode is transitioning depends on the tablet mode controller observer order). Having separate state for the clamshell state makes it easier to detect that the shelf/hotseat state is changing as part of tablet mode transition, without having to worry about in which order tablet mode controller observers are added. BUG=1054647,1056478 Change-Id: I3bc83b2c586206c6734bc6cfde913178818eed0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067553 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#744952}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f0a0e26ccade..50148dbfcb7b git log f0a0e26ccade..50148dbfcb7b --date=short --first-parent --format='%ad %ae %s' 2020-02-27 fancl@chromium.org Reusing sheriff-config client Created with: gclient setdep -r src/third_party/catapult@50148dbfcb7b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1052720 Tbr: sadrul@google.com Change-Id: I77b5fd4359b6d0248aad9cae5d808bab6811117e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076674Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1d6607890c47..c3a0d11aff58 git log 1d6607890c47..c3a0d11aff58 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@c3a0d11aff58 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icde177cfc0d83a3de92fb40a7db5118bb0a09443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076675Reviewed-by:
-
Alexey Baskakov authored
Make PwaInstallViewBrowserTest extensions-agnostic. However, we still need to use ExtensionBrowserTest to implement ListedRelatedChromeAppInstalled case, which requires "related chrome app" extension. Bug: 1052722 Change-Id: Ie91fa306a8612ef486a53ed7390538dcd9d15040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076042Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
-
Jeremie Boulic authored
The row for "Apps and Extensions" should be sentence case, only the first word is capitalized, so it should be "Apps and extensions". Bug: 1039916 Change-Id: I12819c89c9b115e3707e11df282b9cea4510d1c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076038 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#744948}
-
Eriko Kurimoto authored
This CL uses constructor origin for outside settings security origin. Previously, we were using script_request_url to calculate security origin because script url usually has the same origin with the constructor. However, it differs sometimes, for example, when script url is data URL. By using constructor origin, HTTPState can be calculated correctly for data URL and works as same as before for normal url like https://example.com. In this CL, WPTs covers dynamic import and static import for data url and HTTP(s) Scheme scripts. WPTs for fetch API with data URL worker and iframe is added from external Github. Pull Request: https://github.com/web-platform-tests/wpt/pull/21877 (This PR is already merged.) Bug: 1048619, 881202 Change-Id: I78ef9a501b80fe03ad8b3d59d5e6b4d3b8ba2f6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046803 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
-
Daniel Hosseinian authored
Chromium is trying to move away from deprecated CUPS APIs, but RHEL/CentOS 7 continues to use an 8 year old version of CUPS. Bug: 1055208 Change-Id: Ie91b134c11f780cb235e08c9598c7ee5b489f547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072580 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#744946}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8f58baae1a1d..8d1f44cb67cc Created with: gclient setdep -r src-internal@8d1f44cb67cc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I953712701fe79b1a12c4d24aa32339e6349602a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076792Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744945}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I30d87446d2514238c67b5b28630415afdc7738e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076671Reviewed-by:
-
Koji Ishii authored
This patch moves |GetChildOffset| from |NGContainerFragmentBuilder| to |NGBoxFragmentBuilder|. The function needs to read |NGFragmentItemsBuilder| to support |NGFragmentItems| but the member is only available in |NGBoxFragmentBuilder|. All existing usages are for |NGBoxFragmentBuilder|, so no changes to callers. This patch has no behavior changes. Bug: 982194 Change-Id: Icacd18d12634bc4324d5f56eb70710903e7d942a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076745 Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ccb3a54defb5..37a2a3416ade git log ccb3a54defb5..37a2a3416ade --date=short --first-parent --format='%ad %ae %s' 2020-02-27 treehugger-gerrit@google.com Merge "Assert the profiling target process does not crash." Created with: gclient setdep -r src/third_party/perfetto@37a2a3416ade If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I022717726d305299b3bdc35d5bd09ea2234bdf4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076335Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e7fcd7dde1d9..1d6607890c47 git log e7fcd7dde1d9..1d6607890c47 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@1d6607890c47 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib05f10006d0d71771f780f4fbb873355f27d0951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076666Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0a450363dbdc..8b8dc561f00f git log 0a450363dbdc..8b8dc561f00f --date=short --first-parent --format='%ad %ae %s' 2020-02-27 ynovikov@chromium.org Fix Android component build. 2020-02-27 ianelliott@google.com Vulkan: Implement Android pre-rotation 2020-02-27 geofflang@google.com Always use commit_id.py to generate commit.h 2020-02-27 jmadill@chromium.org Vulkan: Document command access APIs. Created with: gclient setdep -r src/third_party/angle@8b8dc561f00f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: geofflang@google.com Change-Id: I053a9bf7e41cf35bad4646ad3a3661778b137442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077017Reviewed-by:
-
Daniele Castagna authored
|DrawQuad::visible_rect| can be used to clip geometry at draw time. Display::RemoveOverdrawQuads resizes visible_rect to reduce overdraw. Currently |visible_rect| is ignored when drawing TextureDrawQuad via GLRenderer. After this CL the quad will be clipped to visible_rect if visible_rect differs from rect. Bug: 1022544 Test: viz_unittests --gtest_filter=*TextureDrawQuadVisibleRect* Change-Id: If0457e8fbb9761c1cfdf623ffb09650577818f8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069137Reviewed-by:
Sasha McIntosh <sashamcintosh@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#744939}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/60a026a7..3f0406a3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idc67fc12e5f95df84f98d19434253d6b4a685f6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076360Reviewed-by:
-
