- 02 Nov, 2020 40 commits
-
-
Trent Begin authored
This adds the existing network-diagnostics cr_component into the connectivity diagnostics app and pipes in the necessary dependencies from chrome. Bug: chromium:1140611 Change-Id: I7fa82ab611be6da4a7b93031e2c9ffa4efbd3925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490981 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#823243}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7411aeba4d3b..4cd11945c5a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I40dd6cdaf7c30d0c4ec07ea81abd78811ff8fe98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514078Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823242}
-
Chunlei Niu authored
Change-Id: I29ad465db87724e9731d19aaac246afb5af8b7bd Bug: b/161484971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311065 Commit-Queue: Chunlei Niu <niuchl@google.com> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Auto-Submit: Chunlei Niu <niuchl@google.com> Cr-Commit-Position: refs/heads/master@{#823241}
-
Joe Downing authored
I am working on some ETW stuff for Chrome Remote Desktop and I noticed that this parameter is unused and a default value of 16KB is always used. This isn't a big deal as the only caller appears to be its unit tests but it seemed like the value passed in should do something. The other approach would be to remove the param but adjusting the buffer size seems like a reasonable thing to expose (assuming the param is actually used). Change-Id: I453ac2417d68f6c16fecd517cf1cd74c5aa15731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511290 Commit-Queue: Joe Downing <joedow@google.com> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#823240}
-
Gang Wu authored
This metric is added to record that users come back to app menu and select a similar menu item in short period (10 seconds) of time. Bug: 1143780 Change-Id: I5f5522e4b77103d324b6ebe02a2f832d43d81a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508351 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#823239}
-
John Lee authored
This is a temporary solution to prevent crashes that occur from when a tab's context menu is opened from a tab that is no longer in the tab strip. The tab should be visible in another window's tab strip already. Bug: 1141573 Change-Id: I211bf3e3c31b20d61fd924f74471a40c26f5aa45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511332 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#823238}
-
Peter Boström authored
Removes use of GridLayout to agree on column width for textfields. This is replaced by linking textfield views together to make them agree on a shared width. This is a prerequisite for dynamically adding/removing items to DialogModel as GridLayout does not support inserting/removing rows. Remaining GridLayout dependencies are that the dynamic row spacing is set up using padding rows. Bug: 1106422 Change-Id: I76a3823c12dab20aa047e263e27dfbda53003b24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508158Reviewed-by:
Keren Zhu <kerenzhu@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#823237}
-
Lijin Shen authored
Add an observer to notify mediator that message is ready to be shown when browser controls are fully visibly. Bug: 1123947 Change-Id: I46396310824a3b10cfafdabcffcc56b6a3104295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507401Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#823236}
-
Tommy Li authored
This reverts commit f38ba55f. Reason for revert: Caused a bot breakage here: https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-lacros-dbg/2115? Original change's description: > Roll ANGLE from ed916ddf61cc to f34ba6464f31 (7 revisions) > > https://chromium.googlesource.com/angle/angle.git/+log/ed916ddf61cc..f34ba6464f31 > > 2020-11-02 amy.liu@arm.com Fix maxShaderAtomicCounters value. > 2020-11-02 xiaoxuan.liu@arm.com Add support for Linux vulkan backend with VK_KHR_display > 2020-11-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 34ae8a475754 to f7da52775714 (8 revisions) > 2020-11-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from f673b4e6ebf3 to e46399ddd2c7 (11 revisions) > 2020-11-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 740ae9f60b00 to 142cb87f803d (1 revision) > 2020-11-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from e6c9497255c6 to 7751fe38f474 (3 revisions) > 2020-11-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Headers from 320af06cbdd2 to 87451c55aa8b (1 revision) > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/angle-chromium-autoroll > Please CC courtneygo@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 > Bug: None > Tbr: courtneygo@google.com > Test: Test: dEQP-GLES31.functional.shaders.opaque_type_indexing.atomic_counter.*vertex > Change-Id: Ie1e5d3152a5f2fed7abf91fdd6a42c536c42dfab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513791 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#823214} TBR=courtneygo@google.com,chromium-autoroll@skia-public.iam.gserviceaccount.com Change-Id: Iae15ab51252d8bcefff8c0544feba22327ac50d3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514668Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#823235}
-
David Maunder authored
In the code as is, there exists the possibility mModel will change before the callback returns which would mean the price is set on an incorrect or out of bounds index. In addition, it better from a resource utilization perspective to only acquire the price when it is actually needed. Bug: 1139031 Change-Id: I2f46851745b70bf6ddfceb33a09c5ef5700b2880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476811Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#823234}
-
Avi Drissman authored
It's been fully launched. Fixed: 1084222 Change-Id: I2f0ede68468e1abac295f902fa64962fba15bc8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514498 Commit-Queue: Avi Drissman <avi@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#823233}
-
Kyle Milka authored
Bug: 1009124 Change-Id: I15e44a37d0b1ea030ad1afa75bdecd8997bc41a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500362Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#823232}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/93f7621b08d3..86f1234a4be8 2020-11-02 bsheedy@chromium.org deploy_chrome: Retry test binary deployment 2020-11-02 ahassani@chromium.org xbuddy: Put Translate function back 2020-10-31 manojgupta@google.com cros_setup_toolchains.py: Enable llvm libraries for i686 target 2020-10-30 meiring@google.com packages: Move pita tests to tast-tests-private. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I234b8769bf29b920b481460f4944ac8ead57df77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514235Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823231}
-
Sylvain Defresne authored
The downstream iOS bots import a gn file from $root_build_dir/args.gn that would not be correctly parsed by //build/gn_helpers.py as: 1. define some values of type scope (`{ a = "value"}`), 2. it uses comments in many places (before all variables that are defined, above individual items in lists, ...). To ensure that the file $root_build_dir/args.gn could be parsed, fix //build/gn_helpers.py to support the scope values and to consider comments as valid in any location where whitespace would have been. Bug: 1144711 Change-Id: I0c48167f1bc818dc9f6253287c2c967d13756523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513217 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#823230}
-
Yuta Hijikata authored
Bug: None Change-Id: Iac42558aef5f1d74c884acc9d95cfde979285b3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513811 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#823229}
-
Jesse Doherty authored
This will need a follow up cleanup cl once the parameter is changed in the variations config. BUG=b/160157778 Change-Id: I6f29d98223eeb04de880e302870af642e6e73292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507340Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#823228}
-
Vidhan authored
This CL introduces a feature flag for enabling the use of AlternativeStateNameMap for the filling of state fields, comparison of profiles and sending votes to the server. Bug: 1111960 Change-Id: I03ef197ae4d5efd99c46228f6a2f0ec3c9009590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505887 Commit-Queue: Vidhan Jain <vidhanj@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#823227}
-
Weblayer Skew Tests Version Updates authored
Skew tests are being added for the following versions: 1, 87.0.4280.38 TBR=estaab@chromium.org Bug: 1041619 Change-Id: I7b7b797fcf34126905f8b0b9e1ad672aab80442a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511693Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#823226}
-
Chris Sharp authored
Bug: 1018157 Change-Id: I73b2cbd29dac8b3ca25a0ade44d1caa9648b572d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502849 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#823225}
-
philipel authored
Related WebRTC CLs: https://webrtc-review.googlesource.com/c/src/+/190680 https://webrtc-review.googlesource.com/c/src/+/190860 Bug: webrtc:9378, webrtc:7408 Change-Id: I9a4a672ea2e68bd2d1991a78a509439c9b36d05e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510130Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Joe Downing <joedow@google.com> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Philip Eliasson <philipel@chromium.org> Cr-Commit-Position: refs/heads/master@{#823224}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/0a374dce6653..71d2e1d23d49 2020-11-02 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 74023424daa4 to fc5a9cfaf70c (1 revision) 2020-11-02 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 5bee67fced90 to 74023424daa4 (1 revision) 2020-11-02 cwallez@chromium.org Suppress -Wdeprecated-copy-dtor for Skia. 2020-11-02 bclayton@google.com Migrate tint to use new parser constructor If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC sarahmashay@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: sarahmashay@google.com Change-Id: Ieaf65da389035839d5de7f4f89c7b635be953f53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514174 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823223}
-
Francois Doray authored
The command-line flag is still used by Chrome Devs for testing, but it doesn't need to be exposed to many users in about:flags. Bug: 726937 Change-Id: I9b7a98fd5524abc64b659cff1211abbd8b5cee4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514497 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#823222}
-
Matt Menke authored
SpawnedTestServer is being slowly (very slowly) phased out, since it has been responsible for a large number of issues leading to flake on the tree, and doesn't work on mobile platforms. Bug: 492672 Change-Id: I106c01f5fb47a11655274f59da0ca622d36a0508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510794Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#823221}
-
Sigurd Schneider authored
Change-Id: Ib32fc920c7ebd25a927082686487ed2403ffebfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513208 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#823220}
-
Ramin Halavati authored
UKM browser test for Guest profiles is updated to cover ephemeral Guest profiles. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: Id387d285a1c1d629030824920b3f4465c3a463e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514152Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#823219}
-
Owen Min authored
Revert crrev.com/c/2456509 behind the feature flag for debugging purposes. The feature is off by default. Also fixing an potential issue in keychain_data_helper_mac.mm by replacing kSecClassCertificate with kSecClassGenericPassword. As we want to delete password but not certificate. Bug: 1142956 Change-Id: I7c566cd6cd1520fbd3470f9caef0822d9394d697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508340Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#823218}
-
Charlie Harrison authored
Change-Id: I7894409cc127f7f35d36eec5ad7b7a533c017377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514170Reviewed-by:
David Van Cleve <davidvc@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#823217}
-
cfredric authored
Bug: 1143931 Change-Id: I348fcd036907f4fb56c00ec853f2602b99d5b8e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514361Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@google.com> Cr-Commit-Position: refs/heads/master@{#823216}
-
Joe DeBlasio authored
Target Embedding is launched, but I'd still like users to be able to disable it via flags, at least for a bit longer. Safety Tips is working to launch, but hasn't launched yet, so it's useful to have it be toggle-able manually for testing, etc. Change-Id: I5a9e76aeb25595766f5433577b6179e2dcc4c791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513438Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#823215}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ed916ddf61cc..f34ba6464f31 2020-11-02 amy.liu@arm.com Fix maxShaderAtomicCounters value. 2020-11-02 xiaoxuan.liu@arm.com Add support for Linux vulkan backend with VK_KHR_display 2020-11-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 34ae8a475754 to f7da52775714 (8 revisions) 2020-11-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from f673b4e6ebf3 to e46399ddd2c7 (11 revisions) 2020-11-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 740ae9f60b00 to 142cb87f803d (1 revision) 2020-11-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from e6c9497255c6 to 7751fe38f474 (3 revisions) 2020-11-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Headers from 320af06cbdd2 to 87451c55aa8b (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Test: Test: dEQP-GLES31.functional.shaders.opaque_type_indexing.atomic_counter.*vertex Change-Id: Ie1e5d3152a5f2fed7abf91fdd6a42c536c42dfab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513791Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823214}
-
Ben Pastene authored
This is similar to crrev.com/c/2490549, but for the internal VM bots. Will move this single suite over just to test things out, then likely more the rest over in a follow-up. Bug: 1132206 Change-Id: I8c52aaa624d1d4b3ca5771380deb29fae69318ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511854Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#823213}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/813ef3dc0d5e..fcafd5b49266 2020-11-02 rharrison@google.com Roll 6 dependencies (#1144) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: If81b91776cce18dabffaf0eb9b6b37a697054d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514172Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823212}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5a41e47b6f39..5d35d2afddac 2020-11-02 alexrudenko@chromium.org Add justify-content icons to the styles panel 2020-11-02 aerotwist@chromium.org TypeScriptify JavaScriptREPL.js 2020-11-02 aerotwist@chromium.org TypeScriptify CookieItemsView.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1139945 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3903b007259087e46d99fa49a5e7c5102a16b096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514175Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823211}
-
Patrick Noland authored
This will allow it to continue to function as logic migrates out of LocationBarLayout. SearchActivity-specific logic remains in SearchActivityLocationBarLayout for now. Change-Id: I1a32a6fbfd584590b982ecb4c8639664e752819d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495785 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#823210}
-
Sam Maier authored
This is a reland of ecd51275 This reland should be safe - the revert looks to be for an unrelated problem, probably a 2 sided patch that temporarily broke. Original change's description: > Re-enabling aar .info file checker > > Bug: 1143257 > Change-Id: I88d02690152aa3dabeece3d6cd937d1e3f61a1a4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508329 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Sam Maier <smaier@chromium.org> > Commit-Queue: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822760} Bug: 1143257 Change-Id: Id9af6e8b9f00a3cb0554ecd1fa9250983af0e74c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514358 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#823209}
-
Ying Ye authored
Devices sometimes need to upload extra debugging information within a crash report. This CL makes it optional for devices to upload additional states. Bug: internal b/171233251 Test: triggered crash and checked crash report Change-Id: I696fa84e6719a3e6ec336bd2b3f07d622e7fd75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507576Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Ying Ye <yingye@google.com> Cr-Commit-Position: refs/heads/master@{#823208}
-
Mason Freed authored
With this CL, several changes will be shipped: 1. There is now an ElementInternals.shadowRoot attribute, which gives custom element authors access to the element's shadowRoot, even in the case of closed shadow roots. Note that shadow roots that are attached prior to the custom element constructor being run will *not* be accessible via this attribute. 2. The attachInternals() API can no longer be called *prior* to the custom element constructor being run. This preserves the security of the ElementInternals interface, by preventing inline script from "stealing" it before the custom element is upgraded. This feature now has landed specs [1]/[2] and three LGTMs on the I2S thread [3]. Shipping it! [1] https://github.com/whatwg/html/pull/5909/files [2] https://github.com/whatwg/html/pull/5912/files [3] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/uWcvDbzyIBk Fixed: 1140609 Bug: 1042130 Change-Id: I634fa8e9b45ec501fc87d5c05728b96e7f409d9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508849Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#823207}
-
Jordan Oroshiba authored
Updating the icons and removing headline used for previous Page Info page Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=1077766#c75 Bug: 1077766 Change-Id: Ib9463a832bc3680b45ec4b69c01d3e8e119ca2be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468343 Commit-Queue: Jordan Oroshiba <oroshiba@google.com> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#823206}
-
Dave Tapuska authored
This mode is only used for flash. So we can now remove this dead code. BUG=1143755 Change-Id: Ice89932b0060c3170fc2707caf888fce59d0fd1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508289Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#823205}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/dcd4fb3a509b..584ab491091a 2020-11-02 jmadill@chromium.org GN: Export tracing include directory. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1144469 Tbr: sadrul@google.com Change-Id: I435cd4c6540ed6bdc0f4d221135467a945cb0fa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514166Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823204}
-