- 02 Aug, 2019 40 commits
-
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f63c4e51101a..59d55a331c46 git log f63c4e51101a..59d55a331c46 --date=short --no-merges --format='%ad %ae %s' 2019-08-02 srisser@google.com Update ANGLE docs to match MakeCurrent status Created with: gclient setdep -r src/third_party/swiftshader@59d55a331c46 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: If43ca942232891232dcd01a1a73b2e82e986af46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733448Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683591}
-
Ovidio Henriquez authored
This change adds an entry for the Native File System API write permission in the Page Info dialog box. This permission controls whether the current site is allowed to ask for permission to save changes to the original file that was selected by the user through the API. Bug: 983726 Change-Id: I5e61d6a899b6ca09d9c8108cdc7239d0acb87152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718353 Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#683590}
-
Yasmin authored
This refactoring is needed for other features which reuse the same logic. Bug: 988461 Change-Id: I658318864ba6fb86c918411954943cf2fd6fd20e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730459Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#683589}
-
Jérôme Lebel authored
When sign-in with a new gmail account, the Chrome identity was initialized with no hosted domain since the SSO profile was not fetched yet. The property was never updated later. Even when the AuthenticationFlow was fetching hosted domain using the AuthenticationFlowPerformer. During the sign-in process To fix the issue, -ChromeIdentity.hostedDomain is remove. ChromeIdentity stays just a proxy for SSOIdentity. ChromeIdentityService::GetCachedHostedDomainForIdentity() is added to get the hosted domain. Bug introduced with: + crrev.com/c/1687254 + crrev.com/i/1434627 + crrev.com/c/1687254 Related to: => crrev.com/c/1732084 (adding new API) <= + crrev.com/i/1560989 (adding new implementation) + crrev.com/c/1732085 (switching implementation) + crrev.com/i/1560990 (old implementation cleanup) + crrev.com/c/1732101 (cleanup API) Bug: 987380 Change-Id: I2dab7a36927530ca400bdf6e99d645ff325159c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732084Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#683588}
-
Caitlin Fischer authored
Change-Id: I8940a62ceb8d6586a9551607aaaa9e0b63fcac9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731989 Auto-Submit: Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#683587}
-
Jérôme Lebel authored
Opening an URL using |DispatcherForActiveBrowserViewController()| takes extra time in: + testSignInCancelIdentityPicker + testSignInCancelAuthenticationFlow + testSignInCancelFromBookmarks + testSignInCancelAddAccount This is a quick fix for iOS 13. This need to be solved correctly by adding a method in ChromeEarlGrey to simulate opening an URL with UIApplication. See bug: crbug.com/990259 Change-Id: Icb1c122d5d3a94ffabad2b6056e9ea10a608cf41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731831Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#683586}
-
Jann Horn authored
Currently attempts to report non-ASAN crashes (e.g. CHECK() failure) from an ASAN build fail because iov[6] is {.iov_base=NULL, .iov_len=kMaxAsanReportSize + 1}, causing sendmsg() to fail with -EFAULT. Since the protocol relies on everything being fixed-length, fix it by supplying an "ASAN report" consisting of nullbytes only. Test: build with is_asan=true, run with ASAN_OPTIONS=detect_odr_violation=0 and --enable-crash-reporter-for-testing, navigate to chrome://checkcrash/. Bug: 984778 Change-Id: Icfb1de2d6b99ef19c5b2b08cdeba7eba22746bf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705196Reviewed-by:Robert Sesek <rsesek@chromium.org> Commit-Queue: Jann Horn <jannh@google.com> Cr-Commit-Position: refs/heads/master@{#683585}
-
Tim Volodine authored
Remove code that is not used anymore with the network service enabled, second iteration. In particular updates/removes: - android_protocol_handler - aw_url_request_context_getter - init_native_callback - aw_safe_browsing_ui_manager - aw_download_manager_delegate - aw_settings and all related call sites and usages. Also removes code and checks which check for features::kNetworkService being enabled/disabled. BUG=989104 Change-Id: I9d18af050cb262ad0f07e64a3e850e5c7fb56f81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731929 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#683584}
-
Matthias Körber authored
[PasswordManager] Added password-requirement attributes and generated-password-changed flag to internal logging. Change-Id: If3f022fd7951e2c1a785abb12db94a0a1949db7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730060 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#683583}
-
Edvard Thörnros authored
Move tests that can be wp-tests to the corresponding folder. The tests should stay exactly the same. Bug: 985335 Change-Id: I61b76803c935c6dd4cc69241d7de76720eaf668e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730457 Commit-Queue: Edvard Thörnros <edvardt@opera.com> Auto-Submit: Edvard Thörnros <edvardt@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#683582}
-
Jan Wilken Dörrie authored
This change implements the necessary change to the renderer to suppress the soft keyboard in case the Touch To Fill UI should be shown. It does so by adding an always_hide_ime field to RenderWidget and TextInputState and modifying ImeAdapterImpl.java to always hide the IME if this flag is set. Bug: 957532 Change-Id: I835f89991aeca931c8c963ce6e8e165187188ed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619788 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#683581}
-
Eric Willigers authored
The logical overscroll-behavior-* properties do not inherit. https://drafts.csswg.org/css-overscroll-behavior/#property-index Change-Id: Ia9b69006d8d908f43be600a4862f23670db14dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731339 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#683580}
-
Christopher Grant authored
generate_breakpad_symbols.py uses sys.platform as the default platform if one isn't specified. For me, using crashpad_stackwalker is now assuming Linux, and failing to generate symbols. Since crashpad_stackwalker is an Android tool, we can be explicit about what platform symbols are being generated for. Bug: None Change-Id: Iead76cd68b7ffff2b6d4f05d919fa2974687c6e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730581Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#683579}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/59bbd6556111..054e3bbbe792 git log 59bbd6556111..054e3bbbe792 --date=short --no-merges --format='%ad %ae %s' 2019-08-02 chxg@google.com Reland "Replace the implementation of `GetContributingSources()` on the audio side." Created with: gclient setdep -r src/third_party/webrtc@054e3bbbe792 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: If582ccea3c440fa0418b3f6020686878aa779c7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733199Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/a0eb5efd2bad..3cea2e5882e3 git log a0eb5efd2bad..3cea2e5882e3 --date=short --no-merges --format='%ad %ae %s' 2019-08-02 cepheus@frii.com Bump revision and give the bots another chance to work. Created with: gclient setdep -r src/third_party/glslang/src@3cea2e5882e3 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,geofflang@google.com Bug: None Change-Id: I08e8b4c6224a038825ff6e07b3833531c07c6d58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733197Reviewed-by:
-
Charlie Andrews authored
This is needed for Android support of stack sampled metrics (SSM). SSM takes stack samples, which requires unwinding the stack. Ahead-of-time compiled Java unwind instructions are stored in an xz-compressed section of MiniDebugInfo. This is why libunwindstack, the library that we'll be using for unwinding, requires lzma to support decompression. These files are separated into their own static library. This allows them to be shipped independently from the rest of the lzma SDK. SSM is only enabled for Chrome dev/canary now and will only ever roll out to a small portion of stable users, if any. Because of this, it makes sense not to ship the extra ~15kB required for lzma xz decompression to the vast majority of Chrome Android users. More context is available in the broader design doc at http://bit.ly/2YjttvL R=grt@chromium.org Bug: 989100 Change-Id: I3a2a6c1b8d89779b94f92cb02f72b13adb1d7d2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730793Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#683576}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e52728367fa3..36fb019c0657 git log e52728367fa3..36fb019c0657 --date=short --no-merges --format='%ad %ae %s' 2019-08-02 fmayer@google.com Add intern table for source files. Created with: gclient setdep -r src/third_party/perfetto@36fb019c0657 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: chromium:138725313 Change-Id: I4878a85e9aab926283f3712914692094e23a02b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733200Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ccb8f1c82e61..fdd03910d6c6 git log ccb8f1c82e61..fdd03910d6c6 --date=short --no-merges --format='%ad %ae %s' 2019-08-02 nathanrogers@google.com Add a TRACE_EVENT for SkGpuBlurUtils::GaussianBlur Created with: gclient setdep -r src/third_party/skia@fdd03910d6c6 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: None Change-Id: I59cf53c197e36b191873408d3b0a887f3ec7a4d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733196Reviewed-by:
-
Pavol Marko authored
Bug: none Change-Id: I6bf4514fdef5339b76e188c5f50dba9c2d8e38a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731843 Auto-Submit: Pavol Marko <pmarko@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#683573}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9ccf13eb..33faa512 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5f624222d6794088d6e76676652164db2e355d80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731341Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683572}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ec6ed57a688e..4f68ff26e4e9 git log ec6ed57a688e..4f68ff26e4e9 --date=short --no-merges --format='%ad %ae %s' 2019-08-02 perezju@chromium.org Revert "[Telemetry] Fix GetRecentMinidumpPathWithTimeout log spam" 2019-08-01 rmhasan@google.com [Typ] Expectation tags in tag declaration lists are not case insensitive 2019-08-01 crouleau@chromium.org Revert "Reland "[Telemetry] Do not allow iterating over results while running stories"" 2019-08-01 ianstruiksma@google.com Add quiet mode option to wpr to skip verbose logging on replay. 2019-08-01 bsheedy@chromium.org [Telemetry] Fix GetRecentMinidumpPathWithTimeout log spam 2019-08-01 perezju@chromium.org [Telemetry] Remove Run-/AddProcessArgs from benchmark module 2019-08-01 rnasri@google.com Add rects based speed index metric Created with: gclient setdep -r src/third_party/catapult@4f68ff26e4e9 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:985530,chromium:973936,chromium:973837,chromium:990036,chromium:988509,chromium:985530,chromium:985712,chromium:982025 Change-Id: I48f21fc3010e5154a3bda9ab82bb6501c03e8078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733198Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e1cff9e2ff2c..9873ee0de15a Created with: gclient setdep -r src-internal@9873ee0de15a The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None Change-Id: Ia3623e531917d3eb65c40566c3f122229c02accd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733195Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683570}
-
Armando Miraglia authored
The current implementation limits the capabilities of already opened devices to the currently configured settings. For example, if a device is opened with echo cancellation enabled, it is not possible to reopen the same device with echo cancellation disabled. This CL aims at allowing to open the same device using getUserMedia for echo cancellation (excluding HW echo cancellation). TEST=manually tested with https://codepen.io/anon/pen/EzwjoG and https://codepen.io/anon/pen/mYRjZJ BUG=796964 Change-Id: I0b26e787df3af125939500ea9d4e5cd2757f1229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624908 Commit-Queue: Armando Miraglia <armax@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#683569}
-
Chromium WPT Sync authored
Using wpt-import in Chromium dac741fb. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" 6790530d "[WPT/common/security-features] Make subresourceContext unmodified" 219bce7d "Worker: Add upgrade-insecure-requests tests for top-level classic shared worker script loading" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Idd7159e7e49362ff43c06de1064405fe2e75c0af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732172Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683568}
-
Varun Khaneja authored
See https://crbug.com/973928#c21 for details for the reason for speculation. R=dvadym Bug: 973928, 948767 Change-Id: I760fcb8ed2bcbd75975a0638b70f4a035e4293a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731698 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
-
Boris Sazonov authored
This CL removes redundant support for the consent bump flow from SigninFragmentBase. Bug: None Change-Id: I186534994d01aae525857dfa84f4f7382cc2c613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731938 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
-
Guido Urdaneta authored
Adds extra expectations with respect to reverted https://chromium-review.googlesource.com/c/chromium/src/+/1715811 Bug: 976696 Change-Id: If36df0fd21b059c2eb212a0d1869c9ff82951c66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732088Reviewed-by:
Armando Miraglia <armax@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#683565}
-
Maksim Moskvitin authored
New tests exercises that USS implementation of Nigori can load custom passphrase from prefs, while it was persisted by Directory implementation. This scenario ensures, that we can migration from Directory implementation to USS silently, without asking user for custom passphrase. Bug: 922900 Change-Id: I0da9dd7e3a1ea919a9fc1d2e63a3633a1ad32f8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729636 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#683564}
-
Justin Miron authored
Ad detection in AdsPageLoadMetricsObserver was previously done through keeping track of ads with an override to OnSubframeNavigationEvaluated and storing the ad frames in the set unfinished_subresource_ad_frames_, and removal from the set when later checking if it is the frame is an ad. ContentSubresourceFilterThrottleManager now has an accessible public IsFrameTaggedAsAd() method that makes ad detection within AdsPageLoadMetricsObserver redundant. BUG=958757 Change-Id: I0286984f81569ab35c01f92ff87303a4753b46b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716253 Commit-Queue: Justin Miron <justinmiron@google.com> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#683563}
-
Marc Treib authored
After https://crrev.com/c/1713560 this isn't used anymore. This also lets us deprecate the kLocalProfileId pref, and remove password_manager_util_linux.h/cc. Bug: 950269 Change-Id: Ib0cdc5a0552430a0c087b637eadd7f18e24ea19e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720639Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#683562}
-
Sami Kyostila authored
Record crash keys before the point we check if a task was cancelled to diagnose unexplained crashes. Bug: 990245 Change-Id: I485ee8cc0b38259aa2d228f9f03fcb98656a62ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731898 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#683561}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/c1583a558c58..54b4df706968 git log c1583a558c58..54b4df706968 --date=short --no-merges --format='%ad %ae %s' 2019-08-02 beaufort.francois@gmail.com s/isPIXEventRuntimeLoaded/IsPIXEventRuntimeLoaded/g 2019-08-02 cwallez@chromium.org Implement most texture formats on OpenGL 2019-08-02 beaufort.francois@gmail.com Handle debug markers commands for compute pass encoder 2019-08-02 beaufort.francois@gmail.com Make fragment stage optional in RenderPipeline Created with: gclient setdep -r src/third_party/dawn@54b4df706968 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: Ifa8fc0523cff41f59f34a6f0e0767c3b89ee019c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733192Reviewed-by:
-
Javier Ernesto Flores Robles authored
Needs https://chromium-review.googlesource.com/c/chromium/src/+/1719005 to be submitted before this compiles. Bug: 987174 Change-Id: I7b2df6be33e844b1cdda43a6ba8c0ea151baf97b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720629 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#683559}
-
Maksim Moskvitin authored
Nigori might be downloaded several times during the sync configuration, so removing it from |to_download| based on InitialSyncDone state is not valid. It also means that PassiveApplyUpdates could be called several times for Nigori, so we remove DCHECK inside this function. This CL allows to pass EnableDisableSingleClientTest.DoesNotRedownloadAfterKeepData with enabled USS Nigori implementation. Bug: 922900 Change-Id: Ie7a8caba35d0244859d2a5c88fcf9f859b9409ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730417 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
François Beaufort authored
Following https://dawn-review.googlesource.com/c/dawn/+/9680 change, this CL adds debug markers methods (pushDebugGroup, popDebugGroup, and insertDebugMarker) to GPUComputePassEncoder and GPURenderPassEncoder. Bug: 877147 Change-Id: Id833eaff5ed98a842b1cabc7d4c8c08098e0853e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732077Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#683557}
-
François Beaufort authored
Following spec change at https://github.com/gpuweb/gpuweb/pull/381, this CL removes `= null` for depthStencilState in GPURenderPipelineDescriptor and depthStencilAttachment in GPURenderPassDescriptor. Bug: 877147 Change-Id: I86f60e91073fe046289484d51c91488b9dbded7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731893Reviewed-by:
-
Jenny Blessing authored
Bug: 987177 Change-Id: Ib30b9e9945c2795a8e584517275d2cf2c9750457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724757 Commit-Queue: Jenny Blessing <jblessing@google.com> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#683555}
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=boliu@chromium.org, tsepez@chromium.org Bug: 968047 Change-Id: I346372d16a3856186ea74d14e0dd8a12f7cacae5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729589 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:Tom Sepez <tsepez@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#683554}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0c67c80ac3fd..59bbd6556111 git log 0c67c80ac3fd..59bbd6556111 --date=short --no-merges --format='%ad %ae %s' 2019-08-02 titovartem@google.com Add ToString method for AudioProcessing::Config 2019-08-02 titovartem@webrtc.org Revert "Sanitize the codec list before sending it to the media engine" 2019-08-02 asapersson@webrtc.org ReportBlockStatsTest: Remove usage of RTCPReportBlock (no longer used). 2019-08-02 ssilkin@webrtc.org Sync download_tools.py with changes in gclient_utils module. 2019-08-02 sakal@webrtc.org Improve thread safety of AndroidVideoTrackSource::SetState. 2019-08-02 oprypin@webrtc.org Reland "Don't use all_dependent_configs for sdk frameworks" 2019-08-02 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2d438beb..01452feb (683346:683465) 2019-08-01 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9c759119..2d438beb (683187:683346) Created with: gclient setdep -r src/third_party/webrtc@59bbd6556111 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:987598,chromium:none,chromium:none,chromium:None,chromium:None,chromium:None Change-Id: Ied378e87c191628867c8f7ace08a50b9478c57af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733193Reviewed-by:
-
Lowell Manners authored
This method allows tests to force not using the BackForwardCache, this is useful when: * Tests rely on a new document being loaded. * Tests want to specifically test the document not being in the cache. * Any other reason BFCache doesn't make sense for a particular test. Change-Id: I07fbc0a31023a78109268c100e5f454dbfbed13f Bug: 973855,965925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657836Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#683552}
-
