GitLab

NativeWidgetAndroidis very similar to NativeWidgetAura. It
owns a WindowTreeHost and FocusController which initialized
from AndroidFocusRules. Aura on Android should use this
native widget for top level windows. It should create and host
the Widget in a native Android window.

BUG=507792

Review URL: https://codereview.chromium.org/1403293003

Cr-Commit-Position: refs/heads/master@{#360645}

Issue:
- press Search+Shift+Q+Q (to switch to Next).
- press Search+Q (to switch to Classic)
- press Search+Shift+Q+Q (to again switch to Next)
- press another key like right arrow.

result:
toogleChormeVoxVersion gets issued again and you get flipped back to classic.
cvox.ChromeVox.sequenceSwitchCodes contains a lot of stale information; most importantly, it now considers Cvox+Q a sequence when it isn't one in Next.

TEST=Verify the above is fixed.

Review URL: https://codereview.chromium.org/1459263002

Cr-Commit-Position: refs/heads/master@{#360644}

This patch enables 'window.open([path], [target], "noopener")' as defined
in step 13 of https://html.spec.whatwg.org/#dom-open. The behavior
matches the 'noopener' link relation which landed in
https://codereview.chromium.org/1443663003.

Intent to Implement and Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/hqW3RGDV8WI/bGe64uK-AQAJ

BUG=551884

Review URL: https://codereview.chromium.org/1459603002

Cr-Commit-Position: refs/heads/master@{#360643}

BUG=548797

Review URL: https://codereview.chromium.org/1419103010

Cr-Commit-Position: refs/heads/master@{#360642}

This refactor isolates the logic dealing with delayed tasks,
making it easier to support multiple independent virtual
time sources.

BUG=546953

Review URL: https://codereview.chromium.org/1432263002

Cr-Commit-Position: refs/heads/master@{#360641}

This test checks that self.onpush() works correctly from an
  extension ServiceWorker when a gcm message is sent.

Caveat:
PushMessagingDispatcher::DoSubscribe() only looks at the web
  manifest, so we list the manifest in the extension page
  (page.html). However, this also means we cannot use
  PushMessaging from a service worker of a background page.

BUG=545535

Review URL: https://codereview.chromium.org/1440873004

Cr-Commit-Position: refs/heads/master@{#360640}

Get //base and //crypto. This revealed an IWYU problem in //components/policy,
so go and convert that too.

BUG=556678

Review URL: https://codereview.chromium.org/1441543002

Cr-Commit-Position: refs/heads/master@{#360639}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f6d90d29..61776894

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1465543002

Cr-Commit-Position: refs/heads/master@{#360638}

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/1461863002

Cr-Commit-Position: refs/heads/master@{#360637}

Revert of Mark WebappSplashScreenIconTest#testShowSplashIcon as flaky (patchset #1 id:1 of https://codereview.chromium.org/1436163003/ )

Reason for revert:
dfalcantara@ fixed a larger issue with web apps tests on N4 devices. Reverting this in case of his CL fixed the problem.

Original issue's description:
> Mark WebappSplashScreenIconTest#testShowSplashIcon as flaky
>
> Added in https://codereview.chromium.org/1414873004
>
> TBR=dfalcantara@chromium.org
> BUG=554929
>
> Committed: https://crrev.com/567ee4cbb84855641304da750f4865b95eb18054
> Cr-Commit-Position: refs/heads/master@{#359304}

TBR=dfalcantara@chromium.org,dgn@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=554929

Review URL: https://codereview.chromium.org/1453243005

Cr-Commit-Position: refs/heads/master@{#360636}

This enables compositor-thread property trees for all clients of cc.
It also replaces the existing --enable-compositor-property-trees flag
with a --disable-compositor-property-trees flag.

BUG=481585
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1449143004

Cr-Commit-Position: refs/heads/master@{#360635}

Revert of Disable failing tests on Mac 10.10 Release (ATI) (patchset #1 id:1 of https://codereview.chromium.org/1456863003/ )

Reason for revert:
Per research and discussion on http://crbug.com/557929, we are pretty sure the bot is to blame and NOT the CLs or these tests.

Original issue's description:
> Disable failing tests on Mac 10.10 Release (ATI)
>
> Failing tests on Mac OS:
>   CastStreamingApiTestWithPixelOutput.EndToEnd
>   TabCaptureApiPixelTest.EndToEndThroughWebRTC
>   TabCaptureApiPixelTest.EndToEndWithoutRemoting
>
> BUG=557929
> TBR=hubbe@chromium.org, miu@chromium.org
>
> Committed: https://crrev.com/872e59f9875efaad8b73b44cf2707c0a57d52244
> Cr-Commit-Position: refs/heads/master@{#360460}

TBR=hubbe@chromium.org,hcarmona@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=557929

Review URL: https://codereview.chromium.org/1462603003

Cr-Commit-Position: refs/heads/master@{#360634}

BUG=554289

Review URL: https://codereview.chromium.org/1455333002

Cr-Commit-Position: refs/heads/master@{#360633}

Hopefully this is really the last one... unfortunately, several
waterfall configurations lack trybot coverage, and practical
experience has shown that it's possible for new regressions to be
introduced in the time taken to build the different configs on the
waterfall.

BUG=none
R=danakj
TBR=jrummell

Review URL: https://codereview.chromium.org/1462843002

Cr-Commit-Position: refs/heads/master@{#360632}

This CL makes PageSerializer safe wrt OOPIFs, by making it operate on
single, local frames only.  This CL moves iterating over all frames from
PageSerializer into 1) WebPageSerializer.cpp and 2) PageSerializerTest.cpp.
This is a preparatory step for a future CL that will need to move this
iteration from WebPageSerializer.cpp into the browser process (this
future CL will remove duplication of the iteration code between
WebPageSerializer.cpp and PageSerializerTest.cpp).

Changes made by this CL to WebPageSerializer.cpp use the more granular
MHTMLArchive methods introduced by crrev.com/1415463007 (these methods
allow generating snippets of MHTML for individual MHTML parts [i.e.
frames or resources] rather than for the whole page / view).
This in turn means that the non-granular MHTMLArchive::generateMHTMLData
method is no longer called from product code.  This method has been
therefore removed from MHTMLArchive and inlined into the remaining test
code that still needed this functionality.

BUG=538766

Review URL: https://codereview.chromium.org/1436683002

Cr-Commit-Position: refs/heads/master@{#360631}

https://chromium.googlesource.com/skia.git/+log/c0604609cef6..a37662937cb0

$ git log c0604609c..a37662937 --date=short --no-merges --format='%ad %ae %s'
2015-11-19 msarett Fix BMP RLE bug: attempt 2
2015-11-19 mtklein Modernize SkRecordPattern.h
2015-11-19 kkinnunen Fix maybe unintialized warning for GrAutoLocaleSetter
2015-11-19 reed add --write option to dump_record
2015-11-19 bsalomon Change prealloc number of child FPs be 1 rather than 2
2015-11-19 bsalomon Preallocate room for 2 child processors in FPs
2015-11-19 jvanverth Shift up bottom path in smallpaths GM.
2015-11-19 fmalita Unit test for conic weight GrPath key collision
2015-11-19 mtklein Add SkRecord::defrag().
2015-11-19 egdaniel Move glsl onto EmitArgs struct for emitCode

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/1459233002

Cr-Commit-Position: refs/heads/master@{#360630}

https://chromium.googlesource.com/angle/angle.git/+log/5576734..daa8c27

BUG=554520,531296,541551,432959
TBR=geofflang@chromium.org
TEST=bots

Review URL: https://codereview.chromium.org/1457833002

Cr-Commit-Position: refs/heads/master@{#360629}

This CL removed the |task_runner| passed on construction to
FFmpegVideoDecoder since: "... is used in just one location
for PostTask()ing. The class itself is otherwise mostly single
threaded (except perhaps construction), and passing a
|task_runner| as ctor argument is confusingly indicating the
opposite. A |thread_checker_| basically tells that a(ll) methods
are run in a given thread, whichever this is."
(from discussion in http://crrev.com/1438233003, which has
sadly been reverted for unrelated issues, and is going to be
relanded as http://crrev.com/1447343004).

Removal of this |task_runner| is also necessary for using these
two classes from WebRtc, see the linekd bug.

BUG=554737

TEST=This is a tiny change, all unittest and content_browsertests should cover it.

Review URL: https://codereview.chromium.org/1456993004

Cr-Commit-Position: refs/heads/master@{#360628}

Doesn't make sense to have both if they are the same value, as described in the bug.

BUG=419239
TEST=AutofillExternalDelegateTest

Review URL: https://codereview.chromium.org/1458903003

Cr-Commit-Position: refs/heads/master@{#360627}

When clicking the datalist arrow the full list would briefly flash before it was filtered down according to the existing entry.

We now filter in all cases on the existing entry. A separate bug will be filed for autofill/datalist interaction when clicking the arrow.

BUG=501161
TEST=manual

Review URL: https://codereview.chromium.org/1455093004

Cr-Commit-Position: refs/heads/master@{#360626}

Add FilterEffect::applyEffectBoundaries and use that to replace the
three chunks that does the same thing.
Drop a redundant null-check in FETile::createImageFilter.

Review URL: https://codereview.chromium.org/1463513002

Cr-Commit-Position: refs/heads/master@{#360625}

BUG=554521

Review URL: https://codereview.chromium.org/1448283003

Cr-Commit-Position: refs/heads/master@{#360624}

When in classic mode, we can't eat the keys that come from the SpokenFeedbackRewriter because it needs to make its way back to the browser to be dispatched eventually to the content script, where then finally it gets handled.

TEST=execute some ChromeVox commands with the same bindings between classic and next like cvox+o+(o).

Review URL: https://codereview.chromium.org/1460913005

Cr-Commit-Position: refs/heads/master@{#360623}

enable check-layout.js to be used with testharness.js. This CL
adds a copy (check-layout-ht.js) and modifies two sample tests
 (one passing, one with failures).

The remaining tests can be updated incrementally, and then the
duplicate script can be retired.

R=eae@chromium.org
BUG=554650

Review URL: https://codereview.chromium.org/1458553005

Cr-Commit-Position: refs/heads/master@{#360622}

BUG=None
TESTED=chromevox_tests
R=dtseng@chromium.org

Review URL: https://codereview.chromium.org/1458463002

Cr-Commit-Position: refs/heads/master@{#360621}

This way we can execute it from the command line like the following:

$ ./tools/gn/bin/roll_gn.py

Otherwise, on Linux you have to call python directly, like:

$ python ./tools/gn/bin/roll_gn.py

BUG=None
TEST=see above
R=dpranke@chromium.org
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/1458603010

Cr-Commit-Position: refs/heads/master@{#360620}

BUG=558402

Review URL: https://codereview.chromium.org/1462923002

Cr-Commit-Position: refs/heads/master@{#360619}

BUG=557635

Review URL: https://codereview.chromium.org/1443033004

Cr-Commit-Position: refs/heads/master@{#360618}

Moves
credential_manager.h
credential_manager.mm
js_credential_manager.h
js_credential_manager.mm
js_password_manager.h
js_password_manager.mm
resources/credential_manager.js
resources/password_controller.js
from the downstream to ios/chrome/browser/passwords.

This is the upstream part of the internal CL 310987013.

BUG=514241

Review URL: https://codereview.chromium.org/1456983002

Cr-Commit-Position: refs/heads/master@{#360617}

Adding strings for proxy authentication.

BUG=49994

Review URL: https://codereview.chromium.org/1460873003

Cr-Commit-Position: refs/heads/master@{#360616}

See https://codereview.chromium.org/1455163004.

BUG=skia:3562

Review URL: https://codereview.chromium.org/1461073003

Cr-Commit-Position: refs/heads/master@{#360615}

BUG=558434
TBR=dpapad@chromium.org

Review URL: https://codereview.chromium.org/1460863003

Cr-Commit-Position: refs/heads/master@{#360614}

https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/502e81a238a8..b8dd754b4fa0

$ git log 502e81a23..b8dd754b4 --date=short --no-merges --format='%ad %ae %s'
2015-11-18 jiayl Update libsrtp to upstream commit be95365fbb4788b688cab7af61c65b7989055fb4
2015-08-25 jiayl Set "use_openssl" gyp variable to 1 if it is undefined

This CL updates libsrtp 1.5.x to the latest upstream commit in the
"1_5_x_throttle" branch.

Notable changes:
- Increase maximum tag length to 16 bytes to allow for GCM cipher suite.
- Prevent potential DoS attack due to lack of bounds checking on RTP header
  CSRC count and extension header length. Credit goes to Randell Jesup and
  the Firefox team for reporting this issue.

Review URL: https://codereview.chromium.org/1457903002

Cr-Commit-Position: refs/heads/master@{#360613}

Currently it just blacks the screen so we should disable it until
the implementation is complete.

BUG=557918

Review URL: https://codereview.chromium.org/1457823002

Cr-Commit-Position: refs/heads/master@{#360612}

The InitToBlack function used in this unit tests has been chagned. The elapsed_time argument has been removed.

Review URL: https://codereview.chromium.org/1462003002

Cr-Commit-Position: refs/heads/master@{#360611}

This service will provide content that will be displayed on the NTP
initially on mobile platforms (iOS and Android). This CL just creates
the necessary scaffolding, the API will be added and refined in
subsequent CLs.

BUG=547046

Review URL: https://codereview.chromium.org/1438043008

Cr-Commit-Position: refs/heads/master@{#360610}

Unlike most things in third_party and like Blink, BoringSSL is unversioned and
maintained by us. It is rolled via DEPS in third_party/boringssl/src, but still
has Chromium-specific build files checked into the third_party/boringssl
directory. Shush presubmit complaining on DEPS rolls when those files change.

The one time we might wish to update README.chromium is if something about the
license changes, but that would be signaled via a DEPS change and not picked up
by this PRESUBMIT rule anyway.

BUG=none

Review URL: https://codereview.chromium.org/1454303002

Cr-Commit-Position: refs/heads/master@{#360609}

This CL makes the "process_java_prebuilt" and "compile_java" templates follow the
convention:
"Local variables in a template should be prefixed with an underscore"

BUG=535290

Review URL: https://codereview.chromium.org/1457113002

Cr-Commit-Position: refs/heads/master@{#360608}

https://chromium.googlesource.com/skia.git/+log/fbe1c110acf2..c0604609cef6

$ git log fbe1c110a..c0604609c --date=short --no-merges --format='%ad %ae %s'
2015-11-19 egdaniel Fix leak in drawBitmapNine

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/1464463002

Cr-Commit-Position: refs/heads/master@{#360607}

RTCVDFactory does not know where RTCVideoDecoder is created (it is
created in one of the parameter's task runner), however it knows
where to destroy it. Address this imbalance by offering an
RTCVideoDecoder::Destroy() where the threading is explicit, since
it lives next to RTCVideoDecoder::Create().

BUG=554737
TEST= tiny change, all unit tests passing.

Review URL: https://codereview.chromium.org/1458683002

Cr-Commit-Position: refs/heads/master@{#360606}