GitLab

This adds support for loading/re-indexing multiple rulesets in
FileSequenceHelper.

No behavior changes are made in this CL. This is in preparation of adding
support for dynamic rules and possibly multiple static rulesets.

BUG=930961

Change-Id: I13c99a3e5a89f7615317a04e08ecd5fc52464a45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519548
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Auto-Submit: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641033}

The Open button in the quickview panel was changed from an icon
to text to match the main FilesApp panel.

This change removes the tooltip, since it's redundant.

Bug: 941956
Change-Id: I1cd38e8787a56fe9a8647a5793314dbfcb1866fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525248
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641032}

This reverts commit fb08feb5.

Reason for revert: caused a crash (http://crbug.com/939667)

Original change's description:
> app_list: Set AppList as parent of uninstall dialog
> 
> Currently, when the uninstall dialog is opened from the Launcher, the Launcher
> is dismissed, which is confusing to the user. By parenting the dialog to the
> Launcher, the UX is much better.
> 
> Because we cannot directly access Ash windows anymore, this fix requires us to
> explicitly set the dialog's parent window via MUS properties.
> 
> TEST=manually verified + new browser tests
> BUG=814619
> 
> Change-Id: Ic25cb376191aaba8048f95fa5d0032b0328b8bc8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496447
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Tim Song <tengs@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#638016}

TBR=xiyuan@chromium.org,tengs@chromium.org,rdevlin.cronin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 814619
Change-Id: I7dd1c47d2edfc19fddd4302ae0b7fb1e42d835ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525273Reviewed-by: Vladislav Kaznacheev <kaznacheev@chromium.org>
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641031}

Make HomeScreenController responsible for determining home screen
visibility instead of AppListControllerImpl, including updates based on
window dragging and wallpaper preview.

The app list controller now implements
HomeScreenDelegate::ShowHomeScreen() to show the full-screen app list
window.

Also adds IsHomeScreenAvailable() which should be used to determine
whether to use the home screen instead of checking tablet mode directly.

Bug: 937549
Change-Id: If864614e7dcc4a818dc5368cf5e68e9475afacb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504847
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641030}

Fix directory tree context menu for removable partitions when they're
grouped with a common root, where the "format" option wasn't shown.

Directory tree has 2 context menus root and non-root menus, when
partitions are grouped it's using a non-root menu which didn't have the
"format" command. This CL add the "format" command to non-root menu and
fix the condition to only display for removable root.

Bug: 941174
Change-Id: I27ff6f8e1813f84d76341c6abd4376a0743c14d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522508Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641029}

Followup to http://crrev.com/c/1444011, which corrected remote sessions for
slimnav, but not for legacy nav.

Bug: 942139
Change-Id: I824bd4f7b45fac99d97ef78f53d84563086775b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525054Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641028}

Based on https://crrev.com/c/1524907 by Hector Carmona <hcarmona@chromium.org>

Bug: 941882
Change-Id: Iea5cd2c0bd22bb57eafa6a4d507c93b045e50c31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525196Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Auto-Submit: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641027}

BUG=714018,940130
TBR=sky@chromium.org

Change-Id: I330f1a83003019ce1af35cf554fb7116e3da5bd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525271Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641026}

Bug: 942241
Change-Id: I39e2bf63413a0bf2b646d465a9f694f411b0b0fb
Tbr: akihiroota@chromium.org,dtseng@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525006Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641025}

Before this CL, the video capture service, on ChromeOS, would run in a
separate utility process unless the HAL v3 service was being used.

This CL changes this so that on ChromeOS the video capture service always
runs in the browser process. This is to mitigate an issue with screen
rotation events only being available in the browser process.

Bug: 891961
Change-Id: I4764f7cf131fff819e9e0f726d45bb86af09ed9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506604
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ricky Liang <jcliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641024}

This is a reland of 5b33ce1b

Original change's description:
> Update Crashpad to 1bb8ca4059d8bcc933478e02d7869dda7daa0263
> 
> 48ee086ca4c4 fuchsia: Update to run crashpad_test as package rather than
>              from /system
> 2271f00fe076 Add missing BUILD.gn for third_party/apple_cf
> 3332ae354672 compat: Provide <elf.h> and <mach-o/loader.h> for everyone
> 708367f5badf POSIX: ScopedMmap length refinement
> 5a21d038c9c9 Work around libcrashpad_handler_trampoline.so ASan trunk
>              clang problem
> c8fdad4fe58f Update DEPS for buildtools and GYP
> 2a47ea4663dd Obtain the Fuchsia SDK from the correct (updated) location
> 36f9051cafca Enable clang -Wextra-semi in POSIX/Fuchsia clang builds
> 348022def8d5 Fuchsia: Proper Fuchsia-on-macOS cross build support
> aa160f658175 [fuchsia] Update header include
> 1bb8ca4059d8 Silence some warnings
> 
> Change-Id: Ic40aa09f581c5b1339ac7d7c0a50a55f2d15ea99
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524084
> Commit-Queue: Scott Graham <scottmg@chromium.org>
> Commit-Queue: Mark Mentovai <mark@chromium.org>
> Auto-Submit: Scott Graham <scottmg@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#640817}

Change-Id: If37cdebfafda6ae1526c665f9362a86b5a59ed68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525281
Commit-Queue: Scott Graham <scottmg@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Auto-Submit: Scott Graham <scottmg@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641023}

Because tab thumbnailing logic will be using standard tab size as part
of its calculation of how large of a thumbnail to create (to be used in
tab hover cards) the core properties of a tab need to be available in
c/b/ui rather than just c/b/ui/views. Otherwise, an illegal dependency
is created.

The updated thumbnailing logic will be added in a later CL.

Bug: 928954
Change-Id: Ie51ef3057828a0baad670fd1459df3cb6784651e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519322
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641022}

Due to limitations in how gclient works, we currently need to
duplicate entries in //DEPS and //buildtools/DEPS, and it is
possible for them to not be kept in sync. We don't want that.

This CL adds a presubmit check so that if you modify the relevant
lines in one file you are required to modify them in another.

If we ever fix the linked bug so that we don't need to duplicate
the content, we can remove these presubmit checks.

This CL also gets rid of deps_revisions.gni in //buildtools,
and switches to passing the libcxx_revision value from gclient
to GN via gclient_gn_args.

In order for this to work correctly, anyone using both
//buildtools and //build in GN will need to *also* export the
variable from their DEPS files.

Bug: 941824, 930836
Change-Id: I438c9966c497737cd4984a14cdb0c8993ffcad9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522466
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641021}

OnFilePickerDestroy() needs to also destroy the pointer it receives.

BUG=714018,940130

Change-Id: Ib0402575a7115b0e8b125e1131b61238561e95f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524879
Auto-Submit: Robert Liao <robliao@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641020}

Technically, if we violated this assertion, we'd do an invalid cast before
calling a member function, leading to undefined behavior.

This also switches to using the generic View* base type in cases where the
subtype is not needed, which allows using standard Views accessors more.

Bug: none
Change-Id: I40b51579273b0b1f3c64d0cf15beeaed4708957e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524540
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Weiyong Yao <braveyao@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Weiyong Yao <braveyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641019}

This reverts commit 48e48116.

Reason for revert: To unblock libassistant roll

Original change's description:
> [protobuf] remove deprecated deps parameter
> 
> I replaced all appearance of deps with proto_deps or link_deps.
> 
> Bug: 938011
> Change-Id: I95b8d6363358ecd8c350f095baaa10b12a968e3e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506915
> Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> Commit-Queue: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#640063}

TBR=pkasting@chromium.org,xyzzyz@chromium.org,tikuta@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 938011
Change-Id: Idccc769b22a11b46a8db421c6d62e09ce012b67d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524744Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641018}

Don't send metrics for unrelated crashes, only for GWP-ASan crashes and
error reports. The unrelated crashes are uninteresting and obscure the
other (smaller) numbers of reports that I am interested in.

Bug: 896019
Change-Id: Ic205f5fb0798b489889c2fa639fc2464f066bb6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518755
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641017}

This is a speculative fix.

We create a KVO for -[NSRunningApplication isTerminated] on the IO
thread, where the NSRunningApplication is created. In the observer, we
post a task to the UI thread, and we remove the KVO in that callback.
This removal causes a crash claiming that no such observer exists.
Note that the observer is also called with the initial value, because
of the NSKeyValueObservingOptionInitial argument.

I can see two potential problems here:
1. This code assumes that the KVO is only called once.
    - This is a boolean property that will only ever to NO->YES, so this
      would seem a safe assumption.
    - If this were not true, then we would call removeObserver twice,
      which is what we're seeing occur. We would also use-after-free the
      TerminationObserver.
2. The callback on the UI thread could potentially be made before the
   call to addObserver on the IO thread is complete.
    - This would call removeObserver from within addObserver, which is
      not allowed.

Fix the two problems by:
1a. In onTerminated, early-out if |callback_| has already been issued.
1b. Use a scoped_nsobject for the task posted to the UI thread.
2.  Call both addObserver and removeObserver on the UI thread (so that
    they won't become reentrant).
X.  Only create the observer if -[NSRunningApplication isTerminated] is
    NO. This is not needed to fix any bugs, but limits the cases in
    which we create a TerminationObserver.

Bug: 941909
Change-Id: Id3b36900ac0c46a7ec48d4c7d2e3600cc5c61ef8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524340Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641016}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7677b798..3f6dd8f7

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I4c3a802251af5656fa7f6ac064265dd0708a99f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524916Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#641015}

Should fix a flaky testLongPressGestureFollowedByTapDoesntSelect test
which seems to work fine on M phones, and hopefully later versions
of Android too.

BUG=837998

Change-Id: I4233b6eda177ff1bde9449581f32b8029d4b41bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524092
Auto-Submit: Donn Denman <donnd@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641014}

The old JS-based bindings for extension messaging had a handful of
native helpers, which are now obsolete with the full native
implementation. Remove the JSRendererMessagingService and ExtensionPort
classes entirely, and remove the vast majority of MessagingBindings.
MessagingBindings::BindToGC() is used outside of messaging, and so needs
to remain (but we should rename the class or move the method in a
follow-up).

Bug: 938998
Change-Id: Ia697f4e19b8ac03ef87a62d9b8385cced8f08fbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523981Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641013}

This CL:
1. Moves the ScopedVisibility tracker to chrome/browser
2. Adds it to the PageLoadMetricsObserverDelegate
3. Updates the http/s engagement observer to use the new delegate
   method.
4. Updates ScopedVisibilityTracker::GetForegroundDuration to be
   properly const.

This CL is in preparation for another page load metrics observer
that needs this kind of capability. It shouldn't have any behavior
change.

Bug: 937298
Change-Id: I685b05e191ccc04915eb5be7685332d800fda278
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525182Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641012}

Change-Id: I73c538d0ebf1e4b1aa71e91f32d8102e1fd0c435
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1510696Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641011}

This is important if first attempt to upload CL has failed for some reason, e.g.
presubmit failure, and on the second try we only need to execute git-cl-upload.

R=perezju@chromium.org

Bug: 895891
Change-Id: If55e2143365ae4b1135e0d65bdaf2fc5a4edcb4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520679
Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641010}

Bitrate caps were set only during OnStatsDelivered(), which is
connected to the ICE connection state, not the signalling (SDP) state.

This CL sets the global (PeerConnection) bitrates after
SetRemoteDescription() is called. And it sets the Sender bitrates when
the (Video)Sender is created.

Since the relay status is (probably) not known at those times, the
bitrates are also set in OnStatsDelivered() if the relay status has
changed.

By setting the min/max caps sooner, this may improve BWE performance.

Bug: 941217
Change-Id: Ic623eb78544d22b1ebc94dcef906fd85e4d289b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524690Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Seth Hampson <shampson@chromium.org>
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641009}

BUG=940130
TBR=sky@chromium.org

Change-Id: I62f09fa321aec2fabb551a38b216e3dd0aef281c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525189Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641008}

In future this will prioritize them and make starup slightly faster.

Bug: 863341
Change-Id: Ie38780ac22b83ec754a6c1b924a8ad0cfd25c641
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524046
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641007}

This reverts commit eb14a6d1.

Reason for revert: Broke Pixel2 bots

Original change's description:
> [Perf] Update Pixel2 FYI perf bot to MonoChrome6432.aab.
> 
> This will update the Pixel2 bots to use the MonoChrome6432.aab which is a 64bit
> browser. In making this change a new 'exact_browser' option is added to
> tester_config in perf_data_generator to allow specifying a particular binary to
> be run rather than guessing.
> 
> BUG=934251
> 
> Change-Id: I2cd42eb3d7d6c4f36f4d15e36e4a605bf6f86e2f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511455
> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
> Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
> Reviewed-by: Matthew Cary <mattcary@chromium.org>
> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#639530}

TBR=rmcilroy@chromium.org,perezju@chromium.org,crouleau@chromium.org,mattcary@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 934251
Change-Id: I9c541463d9ff94e1f08f83842aa8d58072167870
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524287Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641006}

print-preview-app and print-preview-model owned properties used
exclusively by destination-settings. This CL moves these properties
and the user-info element into destination-settings. It also converts
recent destinations to a setting, so that sticky settings updates
can be done the same way they are for other settings, and so that
destination-settings can own this property as well.

This CL also adds a new destinationState for the print-preview-app to
correctly update its state based on destination events.

These changes will facilitate more easily refactoring print-preview-app
in future, by reducing the properties and logic it is responsible for.

Bug: 942345
Change-Id: I1cbad055b40a2ba1ca4e067284320c2752f47c6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517045
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641005}

This paves way for it to also be used in run_performance_tests.py

BUG=867155
TEST=bots
R=kbr@chromium.org,crouleau@chromium.org

Change-Id: Ib6f88708e3a292649719fef87729240f3b683786
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521792Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641004}

The current guidance recommends a construct that generates a global
constructor / destructor, which is forbidden. Since this is similar
enough to the previous section on inner classes, just remove it since a
separate section shouldn't be needed.

Change-Id: Ie3150e6e85bb700d17f802fbe71c244329feb660
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524338
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641003}

Bug: 934294
Change-Id: I3737b1560f138250206f9f1b8648d32ada9f0392
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520702Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641002}

dom_distiller_store now uses the new leveldb_proto API, which enables
migrating to a shared leveldb database.

TBR=sdefresne@chromium.org

Bug: 870813
Change-Id: Iee75d947149165e4408902e44d4e31fbaa83cbcd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504170
Commit-Queue: Salvador Guerrero <salg@google.com>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: ssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641001}

This reverts commit 889a9665.

Reason for revert: broke Mac ASan 64: https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Builder/78868

Original change's description:
> Use DWARF4 for mac and ios simulator builds, use DWARF3 for ios device builds.
> 
> Removes some special-case code and potentially makes debug info a bit smaller.
> 
> Also stop passing -g2 to (non-pnacl) nacl compiles on mac, like already the case
> on linux -- this helps with build determinism.
> 
> Bug: 942155,899438,906741,429358
> Change-Id: Ic4c7138d232813e12426de2c161c78121bd3fc80
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525041
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#640963}

TBR=thakis@chromium.org,mark@chromium.org

Change-Id: Ie941d4661c81d97a79ac93f86e8f39df0be467e4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 942155, 899438, 906741, 429358
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525280Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641000}

BUG=940130
TBR=sky@chromium.org

Change-Id: I667c1f9a46409a427f7665a199e52dd879389b11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525283Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#640999}

TBR=vakh@chromium.org

Bug: 928236
Change-Id: I0907d71ab816be59acf670c2f477b6d545c2b67a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525014Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#640998}

With ChannelLayout, IsValidConfig() can determine if the config
is valid without the workaround.

Bug: internal b/126765436
Merge-With: eureka-internal/249019
Test: mannually compile and cast.
Change-Id: Ib96054cb2e83cfdb03898d90d5ac823ca917e540
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500015Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Guohui Deng <guohuideng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#640997}

This flag is introduced in
https://chromium-review.googlesource.com/c/chromium/src/+/1507232 and
it switches the wire encoding for devtools to a binary protocol within
browser and renderer. Definining these two test suites gives us test
coverage until we make this setting the default.

Change-Id: I81b5dd2850e07a9e0fb57c6e03c45578f49a4a49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1510117
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#640996}

Reland "Reland "Reland "[DevTools] Add a flag --enable-devtools-binary-protocol for DevToolsSession."""

This reverts commit fc637deb.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Revert "Reland "Reland "[DevTools] Add a flag --enable-devtools-binary-protocol for DevToolsSession."""
> 
> This reverts commit 8f3ff476.
> 
> Reason for revert: Depends on reverted change https://chromium-review.googlesource.com/c/chromium/src/+/1522494
> 
> Original change's description:
> > Reland "Reland "[DevTools] Add a flag --enable-devtools-binary-protocol for DevToolsSession.""
> > 
> > This is a reland of a741fa4a
> > 
> > Original change's description:
> > > Reland "[DevTools] Add a flag --enable-devtools-binary-protocol for DevToolsSession."
> > > 
> > > This is a reland of 6ab25825
> > > 
> > > Original change's description:
> > > > [DevTools] Add a flag --enable-devtools-binary-protocol for DevToolsSession.
> > > > 
> > > > When the flag is enabled, we send messages to agents / handlers as CBOR,
> > > > even if the cient sends us JSON. We convert responses back to JSON if
> > > > needed.
> > > > 
> > > > Change-Id: I6123e38262d6eeb82206d28a936a32f7db8235b8
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507232
> > > > Commit-Queue: Johannes Henkel <johannes@chromium.org>
> > > > Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
> > > > Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#638897}
> > > 
> > > Change-Id: I20975e3119d3ac65a3e4294ea7cf0bf2d9516389
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512336
> > > Reviewed-by: Johannes Henkel <johannes@chromium.org>
> > > Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
> > > Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#639164}
> > 
> > Change-Id: I94019b6915a99e6b101892c5b3d451718250ba53
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521466
> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
> > Commit-Queue: Johannes Henkel <johannes@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#640487}
> 
> TBR=dgozman@chromium.org,caseq@chromium.org,pfeldman@chromium.org,johannes@chromium.org
> 
> Change-Id: Ie10a272952b579fd168d2bf54978c31c95c22837
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522496
> Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
> Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#640618}

TBR=dgozman@chromium.org,aboxhall@chromium.org,caseq@chromium.org,pfeldman@chromium.org,johannes@chromium.org

Change-Id: Ia569dd8f17ab84bae00acb32ef3a0bf42ae80a7d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525402Reviewed-by: Johannes Henkel <johannes@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#640995}

https://chromium.googlesource.com/angle/angle.git/+log/094c40dce601..2fb6563bf503


git log 094c40dce601..2fb6563bf503 --date=short --no-merges --format='%ad %ae %s'
2019-03-14 syoussefi@chromium.org Vulkan: Fix CommandGraph barrier nodes w.r.t to first node
2019-03-14 syoussefi@chromium.org Vulkan: Fix copySubImage to non-cube-complete images.
2019-03-14 geofflang@chromium.org Mark RGB HALF_FLOAT_OES as renderable with EXT_color_buffer_half_float and WebGL
2019-03-14 raul@tambre.ee Support Python 3 in //scripts/file_exists.py


Created with:
  gclient setdep -r src/third_party/angle@2fb6563bf503

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:941671,chromium:941669
TBR=geofflang@chromium.org

Change-Id: I56d4b149923b55db9b8dc7cab4cc9cee67edaec6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525141Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#640994}