GitLab

Review URL: https://chromiumcodereview.appspot.com/10186009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133507 0039d316-1c4b-4281-b951-d872f2087c98

This is working towards getting unit_tests linking for Android
platform.

BUG=117407
TEST=


Review URL: http://codereview.chromium.org/10169022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133506 0039d316-1c4b-4281-b951-d872f2087c98

Call ScriptGetFontProperties() lazily, only right
before its output is needed. This makes sure that
the correct font's properties are used to determine
if there are missing glyphs when going through the
fallback / linking path.

BUG=124453, 105550
TEST=See http://crbug.com/124453.

Review URL: http://codereview.chromium.org/10189001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133505 0039d316-1c4b-4281-b951-d872f2087c98

BUG=124027
TEST=pyauto:policy.PolicyTest.testStartupOptionsHomepage


Review URL: http://codereview.chromium.org/10035043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133504 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/10164020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133503 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://code.google.com/p/chromium/issues/detail?id=120837
TEST=variuos nacl audio samples


Review URL: http://codereview.chromium.org/10165016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133502 0039d316-1c4b-4281-b951-d872f2087c98

BUG=124498
TEST=added


Review URL: http://codereview.chromium.org/10168021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133501 0039d316-1c4b-4281-b951-d872f2087c98

To introduce a real KeyPath type, the return type of keyPath accessors 
needs to change from a String to an IDBKeyPath. To do this requires 
temporarily moving the methods aside. The WebKit API change (which must
land first) is at: https://bugs.webkit.org/show_bug.cgi?id=84208

R=darin@chromium.org,dgrogan@chromium.org
BUG=112308


Review URL: http://codereview.chromium.org/10041014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133500 0039d316-1c4b-4281-b951-d872f2087c98

Adds an automation hook WaitUntilNavigationCompletes() which blocks until pending navigation completes.

Once this call returns it is safe to call the ExecuteJavascript() family of automation hooks.

BUG=124438
TEST=functional/apptest.py


Review URL: http://codereview.chromium.org/10168019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133499 0039d316-1c4b-4281-b951-d872f2087c98

This change treat jobs that receive MIGRATION_DONE response from the
server as a failure, so that they will be retried.  Otherwise we could
end up unnecessarily dropping nudges or notifications.  This was already
effectively the case for jobs that committed items for types that were
being migrated due to a detail of the way ProcessCommitResponse errors
were detected.

This also modifies the handling of configuration done notifications in
the ProfileSyncService so it no longer causes the scheduler to briefly
transition back to NORMAL mode in mid-migration.  The old way of doing
things would often lead to pending nudges being executed while the
migration was still in progress.

Finally, this change reroutes the backend migrator's OnConfigureDone
callback thorugh ProfileSyncService.  Now we can guarantee that the
ProfileSyncService's callbck gets executed first.  This should be less
brittle than hoping that the notifications arrive in a certain order.

BUG=123954,94882
TEST=


Review URL: http://codereview.chromium.org/10167017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133498 0039d316-1c4b-4281-b951-d872f2087c98

BUG=118067
TEST=

Review URL: http://codereview.chromium.org/9566036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133497 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/10138003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133496 0039d316-1c4b-4281-b951-d872f2087c98

Continuation of reverted CL http://codereview.chromium.org/10025039
Relanding this patch exposed a new issues on cros:
1) KioskModeTest.EnableKioskModeTest fails (did unrelated cleanup).
2) Some bubbles crash OnWidgetMove (make |move_with_anchor_| opt-in).
3) Some bubbles crash OnWidgetClosing (cache |anchor_widget_|).

2nd patch description:
Continuation of reverted CL http://codereview.chromium.org/10021029
The original CL was reverted due to a naming conflict between:
WidgetDelegate::OnWidgetMove and Widget::Observer::OnWidgetMove.
I renamed the new Observer method to OnWidgetMoved.

Original description:
Propagate OnNativeWidgetMove to delegate/observers, etc.
NativeWidget[Aura|Win] calls new Widget::OnNativeWidgetMove.
Widgets alert delegates and new Widget::Observer::OnWidgetMove.

TabDragController2: consume new observer method, simplify.
Nix BrowserWindowMoveObserver; use Widget::Observer instead.
Replace move_loop_browser_view_ with move_loop_widget.
Replace GetAttachedBrowserView with GetAttachedBrowserWidget.

BubbleDelegateView: consume new observer method.
Make bubbles move with their anchor_view's Widgets.
SchedulePaint on BubbleFrameView when mirroring its arrow.

BUG=105151,116336,124310,124324,124352,chromium-os:29747
TEST=Bubbles can move with the browser window (inspecting extension popups, etc.); no Ash / --enable-tab-browser-dragging regressions.

Review URL: http://codereview.chromium.org/10162017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133495 0039d316-1c4b-4281-b951-d872f2087c98

Removes the svn:executable bit on non-executable python files. 

R=nirnimesh@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/10176002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133494 0039d316-1c4b-4281-b951-d872f2087c98

Removes the svn:executable bit on non-executable python files.

R=scherkus@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/10176003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133493 0039d316-1c4b-4281-b951-d872f2087c98

CID=103838
R=estade@chromium.org

BUG=
TEST=


Review URL: http://codereview.chromium.org/10166012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133492 0039d316-1c4b-4281-b951-d872f2087c98

Revert 133490 - Make sure the WebContents has focus after being attached to a WebView, if that WebView was focused.

Reverting because PrintPreviewUIUnitTest.PrintPreviewData failed on
Chrome OS, with a stack trace including views::WebView::AttachWebContents().

http://crbug.com/123995
TEST=none. I need to add a set of unit tests to views for WebView, but that requires creating a new exe that can depend on content. I've filed http://crbug.com/124662 for this.
Review URL: https://chromiumcodereview.appspot.com/10186007

TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10181007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133491 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/123995
TEST=none. I need to add a set of unit tests to views for WebView, but that requires creating a new exe that can depend on content. I've filed http://crbug.com/124662 for this.
Review URL: https://chromiumcodereview.appspot.com/10186007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133490 0039d316-1c4b-4281-b951-d872f2087c98

We were hitting an assertion failure that indicated that WebKit accessibility
was enabled, but RendererAccessibility's mode was that accessibility is off.
Note that WebKit accessibility is a global flag, once enabled, it is never
turned off. This could happen if a new RenderViewImpl is created in the
same process where WebKit accessibility was previously enabled, but the
newly-created RendererAccessibility mode is off.

The fix is to never call handle accessibility notifications if
RendererAccessibility's mode is off, regardless of WebKit's accessibility
notification flag.

BUG=123649
TEST=none


Review URL: http://codereview.chromium.org/10162028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133489 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:29612
TEST=


Review URL: http://codereview.chromium.org/10083045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133488 0039d316-1c4b-4281-b951-d872f2087c98

like a complete example (rather then autogenerate them).
This reverts part of r133327.

Bail out for PNaCl for now, until we turn on these tests.

BUG= none
TEST= trybots

Review URL: https://chromiumcodereview.appspot.com/10191008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133487 0039d316-1c4b-4281-b951-d872f2087c98

R=kkania@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/10175007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133486 0039d316-1c4b-4281-b951-d872f2087c98

BUG=119473
TEST=added some unittests

Review URL: http://codereview.chromium.org/10007008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133485 0039d316-1c4b-4281-b951-d872f2087c98

Also adding unittests to FileUtilProxy.

BUG=123558,77454
TEST=FileUtilProxyTest.*


Review URL: http://codereview.chromium.org/10095028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133484 0039d316-1c4b-4281-b951-d872f2087c98

Add a Profile* member to TemplateURL.  This makes some invocations of ReplaceSearchTerms() a bit less verbose, and will be useful later when UIThreadSearchTermsData starts taking a Profile*.

One downside is that there are a number of const_cast<>()s added when we try to access the profile() of a const TemplateURL*.  These will all go away soon when TemplateURLService is switched to using "const" much less, so I didn't worry too much about them.

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10173001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133483 0039d316-1c4b-4281-b951-d872f2087c98

Reverted because it failed to find "flapper.h" in pepper_flash_component_installer

Review URL: http://codereview.chromium.org/10123016

TBR=viettrungluu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10193001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133482 0039d316-1c4b-4281-b951-d872f2087c98

This is part of Chrome for Android upstreaming.

This CL makes ListenSocket an abstract class instead of a concrete class
implementing a TCP Listen Socket. This abstraction will be used later to make
HttpServer seamlessly operate on TCP sockets and Unix domain sockets (will be
upstreamed in a separate CL).

The TCP Listen socket implementation, previously in listen_socket.{cc,h}, is
now in tcp_listen_socket.{cc,h}.

TEST=net_unittests


Review URL: http://codereview.chromium.org/10108015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133480 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/10183006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133479 0039d316-1c4b-4281-b951-d872f2087c98

DeepCopy creates a ListValue*, which swap (correctly) doesn't free.

CID=103840
R=brettw,raymes

BUG=
TEST=


Review URL: http://codereview.chromium.org/10168015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133478 0039d316-1c4b-4281-b951-d872f2087c98

BUG=124374
TEST=PolicyServiceTest.NotifyObservers is green


Review URL: http://codereview.chromium.org/10174003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133476 0039d316-1c4b-4281-b951-d872f2087c98

Fixed all tests on Windows.

Ignore \Device\Mup on Windows.

Still saw some flakiness on tracing on Windows, to be addressed in a separate
patch.

R=nsylvain@chromium.org
BUG=98834
TEST=Run all the isolate tests on Windows or OSX


Review URL: http://codereview.chromium.org/10091011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133475 0039d316-1c4b-4281-b951-d872f2087c98

R=viettrungluu@chromium.org
TEST=
BUG=


Review URL: http://codereview.chromium.org/10162022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133474 0039d316-1c4b-4281-b951-d872f2087c98

Some users liked it, others hated it, others wanted to be able to toggle it.
This patch just disables the current behavior and should be merged to the
M19 branch, then I'll try a new approach in the trunk.

BUG=112944
TEST=none


Review URL: http://codereview.chromium.org/10146031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133473 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/10123016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133472 0039d316-1c4b-4281-b951-d872f2087c98

Minor cleanups from my working copy.

BUG=None


Review URL: http://codereview.chromium.org/10146017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133471 0039d316-1c4b-4281-b951-d872f2087c98

This includes unit tests for the API, but no uses yet.

This change also involves exposing a new MakeGroupNameId static helper in FieldTrial to assist with the usage of this new API.

BUG=121988
TEST=Ensure that unit_tests GoogleExperimentsTest.* pass.


Review URL: http://codereview.chromium.org/10165014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133470 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=sky
Review URL: https://chromiumcodereview.appspot.com/10183007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133469 0039d316-1c4b-4281-b951-d872f2087c98

This CL fix the wallpaper fade animation problem. The problem was when user
switched to a new wallpaper, it seems there is a white flashing before new
wallpaper fade in.
The reason was I started the hide animation before loading new wallpaper. And it
took around 300ms to load while the animation finished around 200ms. So there is
100ms period where the background color (white) showed up.
I delayed the hide animation, but then another problem showed up. Now the show
and hide animation happened at the same time. At some point in the animation,
the background color will have 25% opacity and it also cause a flashing.

To fix all, this CL only animate on Show new wallpaper and delete the old widget
after the Show animation completed.

BUG=118651
TEST=Change wallpaper in chromeos, and verify if the animation is smooth.

Review URL: http://codereview.chromium.org/10146016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133468 0039d316-1c4b-4281-b951-d872f2087c98

Remove DOMView.

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10171006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133467 0039d316-1c4b-4281-b951-d872f2087c98

Trivial change to add Ben to owners.

TEST= none
BUG= non
Review URL: https://chromiumcodereview.appspot.com/10139024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133466 0039d316-1c4b-4281-b951-d872f2087c98