- 31 Jan, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/539e9740e1cd..bb93f7b380bc Created with: gclient setdep -r src-internal@bb93f7b380bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I4e499a0168f4e51809b7f8cb88bb5dd359e68842 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033411Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737402}
-
Jeremy Apthorp authored
The only issue seems to be handling arguments :) Change-Id: I1574bf3fdb50b15c9599adb63395c83bc28681a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018125Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Jeremy Apthorp <jeremya@chromium.org> Cr-Commit-Position: refs/heads/master@{#737401}
-
Dale Curtis authored
This prevents the "skip already uploaded frame" logic from actually working. Though it seems to be broken in some other way currently. Bug: 776222 Change-Id: I58dc0490c976588d1c0d9a37210330fcfa399474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031720Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#737400}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ae2b962ce583..4ada8ab49f7b git log ae2b962ce583..4ada8ab49f7b --date=short --first-parent --format='%ad %ae %s' 2020-01-31 sdefresne@chromium.org [roll] Fix the command in the commit message Created with: gclient setdep -r src/third_party/depot_tools@4ada8ab49f7b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I7c21af65ce5df0d787b2c38b09e04ea1f4839260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033406Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737399}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3c0114c6399a..f768708f30f0 git log 3c0114c6399a..f768708f30f0 --date=short --first-parent --format='%ad %ae %s' 2020-01-31 lomitch@microsoft.com Fixed localization issue with compositing reasons in the layers tool. Created with: gclient setdep -r src/third_party/devtools-frontend/src@f768708f30f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:946860 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4e3df6ad5582a6bac2c97279c9edcf0c8562bed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033408Reviewed-by:
-
Dale Curtis authored
We've long used now > dur as an implicit signal, but with poorly muxed media this can be unreliable. Since EndedPlayback() is used for a few important signals, we should ensure it's always right. As such, switch to using the explicit signal known by the WebMediaPlayer. This has been the source of a lot of flakiness over the years and we've been thinking about doing this since 2014. The only tricky part is in handling seeks to the end of file correctly; our pipeline previously required that play be called before we would trigger a real pipeline ended event. Instead we relied on HTMLME just declaring the playback ended at now >= dur. Now we will "render" end of stream even if playback hasn't started if we have nothing to play. Bug: 409280, 1035472 Test: Updated unittests, all existing tests pass. Change-Id: I1fbea34e8ac9e772d5b3573cd57df5d8c065e9c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021292Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#737397}
-
Sergey Silkin authored
- Don't require availability of SW H264 (webrtc_h264_sw_enabled) on android. Allow H264 processing with HW only. - Don't pass SW encoder factory to SEA if SW encoder of given type is not available. Bug: webrtc:11244, 1046501, 599650 Change-Id: I96991c9f40402d6dd723b10fd272b2dfe3120af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027848Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#737396}
-
Garrett Beaty authored
Also enable branch CQ/CI for Phase C builders. Bug: 1024643,1047744 Change-Id: If63fcdb223938b0c72b61502d0e61827dd1b70fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028258Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#737395}
-
Rob Schonberger authored
Update for further 6 months. Bug: 1036935 Change-Id: Ib9fcab37731ac55c69a71b8a941733a0b91cdf2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029481 Auto-Submit: Rob Schonberger <robsc@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#737394}
-
Xida Chen authored
TBR=odejesush@chromium.org NOTRY=true Bug: 1047760 Change-Id: Idcca8c22fcb2133b4553dbbbd9258fa8a3af0ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033433Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#737393}
-
Connie Wan authored
Minimum repro: 1) Open 1 tab. 2) Open 3 more tabs and add them to a group. 3) Navigate the 3 grouped tabs to: - https://www.google.com/gmail/about/# - https://www.google.com/gmail/about/# - https://www.google.com/imghp?hl=en&tab=ri&ogbl (Order doesn't matter. These links just came from the top right of the New Tab Page.) 4) Close all three grouped tabs at the same time, either via ctrl+W or right click + Close or other. Observe a crash. On local builds, there is an issue with either not finding a group or grabbing an index outside the view model. Root cause: - This only happens with URLs that qualify for RunUnloadListenerBeforeClosing: https://cs.chromium.org/chromium/src/chrome/browser/ui/tabs/tab_strip_model.cc?l=1665&rcl=2abf9b055a62f339f09785bb5f96187d9fcdb512 (in this case, the Images URL.) - This UngroupTab() call would happen between the first and second set of closed tabs: https://cs.chromium.org/chromium/src/chrome/browser/ui/tabs/tab_strip_model.cc?l=467&rcl=2abf9b055a62f339f09785bb5f96187d9fcdb512 - That would change the grouped state of the tab: https://cs.chromium.org/chromium/src/chrome/browser/ui/tabs/tab_strip_model.cc?l=1935&rcl=5aa34a3af25ca337f5d9604c24d63bc873572196 - Which would then confuse the TabStripLayoutHelper: https://cs.chromium.org/chromium/src/chrome/browser/ui/views/tabs/tab_strip_layout_helper.cc?l=477&rcl=9bce6a24f278f92b1a71b178b7e8acc6e8c02a9c - Which would grab and close the wrong slot, causing interference either with the group header closing or the next tab closing. Fix: - Prevent the tab itself from getting ungrouped during close (though the rest of the TabGroup bookkeeping still needs to happen behind the scenes). - Prevent a closing tab from querying group metadata, since the group may also be closing at the same time. Change-Id: I0cc69cb157ba5485c4d9c1a85ff0a393cdc6ce3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020908Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#737392}
-
Thomas Tellier authored
Also, getting rid of experimental accessibility features as this was the last one using it. Bug: 867474 Change-Id: Ibec61de069342dbc30e96a4a3c62c0f7332300ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783440 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#737391}
-
Robert Ogden authored
Adds the integration to the last CL and a couple tests. Bug: 1023486 Change-Id: Ia0999fa09282df394944756e350f413867f45f09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033426 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#737390}
-
Nazerke authored
This CL removes public properties for BrowserState and dispatcher values and updates the coordinators implementation to get them from self.browser. The refactored coordinators: - Advanced Signin Settings Coordinator - Google Services Settings Coordinator - Signin Interaction Coordinator. Bug: 1029346 Change-Id: I9c7dda862e3d26898a84dd6c6d52f464d66441d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033256 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#737389}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5de415c5e3f9..c73475fb3c99 git log 5de415c5e3f9..c73475fb3c99 --date=short --first-parent --format='%ad %ae %s' 2020-01-31 syoussefi@chromium.org Vulkan: Fix UtilsVk dirtying driver uniforms descriptor set binding Created with: gclient setdep -r src/third_party/angle@c73475fb3c99 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tobine@google.com Change-Id: I69f40ef43c62b45b5f5ddd671e155c8d41471723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033123Reviewed-by:
-
Donn Denman authored
Adds support for new Contextual Search Resolve-request parameters to provide translation hints from the client. The server uses these params as additional hints from the Chrome Language Model for the user's preferred language and the language of the selection and page content. This means the returned Search Term may be translated or be accompanied by a Translation Card. The parameters we send in the Resolve request are the same parameters we currently send to force a translation one-box in the Search request: "&tlitesl=" for source language and "&tlitetl=" for the target language. BUG=952401 Change-Id: Ia79d8c0cf3706009c2b6213895ad8f6df543c24c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032058 Commit-Queue: Donn Denman <donnd@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#737387}
-
Scott Violet authored
This adds using base::android::Foo in a couple of places that make extensive use of the type. BUG=none TEST=none Change-Id: I798aa724cbbe5c18de1af538aea43bba0f6b3a38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033330 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#737386}
-
Mark Yacoub authored
1. Get "CRTC_ID" DRM property for Connector. 2. Get "ACTIVE" and "MODE_ID" DRM props for CRTC. 3. Add Connector Props are part of MockDrmDevice. BUG=987274 TEST=HardwareDisplayPlaneManagerTest, HardwareDisplayControllerTest, DrmOverlayValidatorTest Change-Id: I9b500ade01ad9179e1417a6bc0471b3d9b412cad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031741Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Auto-Submit: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#737385}
-
James Cook authored
SplitSettingsSync will allow the user to opt-out of browser sync. However, IdentityAccessor::GetPrimaryAccountInfo() assumes the user has consented to browser sync. ARC has its own consent, unrelated to chrome browser sync consent. Switch to using the "unconsented" primary account. This account is always the main GAIA account for the signed-in user, and exists whether or not the user has consented to browser sync. This requires updating: * ArcAuthService * ArcSupportHost * ArcAndroidManagementChecker See go/cros-primary-account and go/cros-sync-mock for details. TBR=droger@chromium.org Bug: 1042400 Test: updated existing unit tests and browser tests Test: Set --use-unconsented-primary-account and --enable-features=SplitSettingsSync and verify Play Store runs and is signed in after: * Login with consumer @gmail.com * Enroll to @google.com and signin with @google.com * Enroll to @managedchrome.com and signin with managed guest Change-Id: I48abe048a95d6aa234d4b87e76b2d70c5e88aebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029307 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#737384}
-
danakj authored
Mojo IPC channels are dropped when the main frame RenderWidget is deleted and recreated, so even though it maintains the same legacy IPC routing ID, IPCs sent toward the old RenderWidget will not be received by the new one for Mojo IPCs. Thus there is no race to guard against those IPCs arriving after a provisional frame with the same routing ID is created. R=avi@chromium.org Bug: 419087 Change-Id: If3e08de13e1ed20d97abc8d77c53c942fe6ac724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004790 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
Virender Singh authored
This change modifies IDS_PDF_PAGE_INDEX string to follow formatting rules defined in: http://userguide.icu-project.org/formatparse/messages Bug: 1043505 Change-Id: Iba763c3d6c7229603d8bea28d81ff2a91f473024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032690Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Virender Singh <virens@microsoft.com> Cr-Commit-Position: refs/heads/master@{#737382}
-
Connie Wan authored
Tabs are groupable if they aren't all in the same group. Otherwise, they will show as Grouped and be ungroupable. Bug: 1039924 Change-Id: Ifff4fff3a5c4274877595912c520107a1ed5edc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026695Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#737381}
-
Bo Liu authored
Apparently view becoming visible races with launching the activity. So do a poll instead of a simple check. Bug: 1035894 Change-Id: Icc62f70035af10318c5611f4bff3a0e0fbc4ab5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031434Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#737380}
-
Eugene But authored
The bug appeared after crrev.com/1986242 because identityDisk is now placed on toolbar. Toolbar sits underneath the doodle and doodle simply covers the toolbar and steals the gesture. This CL swaps z-index for toolbar and doodle and disables user interactions for toolbar in landscape. This way the user can still tap on that toolbar in portrait and tap on doodle in landscape. Bug: 1046303 Change-Id: I76d49f9c440c1f4cf6be8ee24513ec78848b2b26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028741Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#737379}
-
Mustaq Ahmed authored
Bug: 1047473 Change-Id: I5ccf13f3c11e0740498913712c324230d103c9da TBR: kenrb@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031187 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#737378}
-
Michael Thiessen authored
Replaces usages of java.net.URI with GURL. Bug: 783819 Change-Id: I1fbcabd96afaa3b55165f1bcff926d9b31d6a3f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031559 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#737377}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I0b52e557c30b657d17bebf51e106b2f1025b6998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031910Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737376}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/631e93892acf..22ab8b24f234 git log 631e93892acf..22ab8b24f234 --date=short --first-parent --format='%ad %ae %s' 2020-01-31 taylori@google.com Merge "perfetto-ui: Stop selection marker overflowing" Created with: gclient setdep -r src/third_party/perfetto@22ab8b24f234 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I98ad0ac46313a6799b55fa3916256206fdcfe47c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033404Reviewed-by:
-
Joshua Pawlicki authored
The main thing here is to move get_parts into the parts.py. Bug: 926234 Change-Id: Icf7d9129281ef45438d1dfa27c992c011d0306bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016972 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#737374}
-
Ioana Pandele authored
TBR=xidachen@chromium.org Bug: 1047205 Change-Id: I67dac7a120396be9f1b260e1226cc202b9730d4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033444Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#737373}
-
Aaron Leventhal authored
Chrome attempts to fire the event on an ignored parent of the text, and the method returns early. The event needs to be fired on an unignored ancestor. Bug: 1041290 Change-Id: I12cda65ec23c8ff3a771da3fe1c29ebf4b8cb0ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015606 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Adam Ettenberger <adettenb@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#737372}
-
Gavin Williams authored
-Disable the Add button so the user can't save a printer if the Manufacturer or Model dropdowns have incorrect values. Fixed: 950887 Change-Id: I533748488b777eca7ac2329d2cb2e5402cca72be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018093Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#737371}
-
Torne (Richard Coles) authored
Pull in the latest BuildCompat implementation from androidx-master-dev and include R in the version list. Change-Id: I6c6242923d975538364ceb62962215d670902dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031433 Commit-Queue: Richard Coles <torne@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Auto-Submit: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#737370}
-
Sahir Vellani authored
It is possible to now observe changes to content box and border box of an element that is being observed. However, changes to an element's content box without a change in its border box can not be observed yet, and will be addressed in a subsequent change. Bug: 1042537 Change-Id: I6415fc4f5cec783cc717051c11b2fdd95d3a28e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004051Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Cr-Commit-Position: refs/heads/master@{#737369}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b2cf1247bee6..539e9740e1cd Created with: gclient setdep -r src-internal@539e9740e1cd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1046782 Tbr: jbudorick@google.com Change-Id: I5d7b964fe8ff296c18983c7fec370a663d6a3be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033121Reviewed-by:
-
Mikel Astiz authored
In particular, GUIDs are now validated against the client tag hash (if available), and all sync metadata is thrown away in situations like local bookmarks having duplicate GUIDs upon started (theoretically unreachable). In order to achieve this, the code is refactored to move some additional logic into SyncedBookmarkTracker, in particular because the mapping from local nodes to sync metadata entries must be available in order to enforce more strict validation logic. Change-Id: I0e084d2f53a4a5447192f9e3667b70df8630493e Bug: 978430,1032052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029370 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#737367}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/023284c1ce32..3c0114c6399a git log 023284c1ce32..3c0114c6399a --date=short --first-parent --format='%ad %ae %s' 2020-01-31 robertma@chromium.org Declare tags in expectation files Created with: gclient setdep -r src/third_party/devtools-frontend/src@3c0114c6399a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:986447 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iacb9a39d0c27615b18ac506b33d9bbe059274ace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033122Reviewed-by:
-
Adam Langley authored
This change adds a hover button to the new transport selection sheet that allows the native Windows API to be triggered. This change is feature-flag protected behind WebAuthenticationPhoneSupport. BUG=1002262 Change-Id: I709186edb1d73014155b180c5c10fa7d68e46a28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032013Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#737365}
-
Reilly Grant authored
Bug: 1020746 Change-Id: I6744bfd35bef56b5edc3c8e0963e3fd8459e7bb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032178 Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#737364}
-
Alex Clarke authored
and other embedders. There doesn't appear to be any existing tests for this functionality and I'm not sure how to easily test it. Bug: 1025612 Change-Id: I81354ff16a6bb9c9bc3a9ada99018ad1e2c82031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959034Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#737363}
-
