GitLab

Inline the one internal reference in LayerImpl.

BUG=709137
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2882543002
Cr-Commit-Position: refs/heads/master@{#471161}

BUG=718386
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2873823002
Cr-Commit-Position: refs/heads/master@{#471160}

Replacing eventSender by pointerActionSequence is not trivial. The deprecation
message should be a warning, so that CLs with eventSender can be at least
uploaded for reference or discussion purposes.

BUG=n/a

Review-Url: https://codereview.chromium.org/2872133011
Cr-Commit-Position: refs/heads/master@{#471159}

For an absolute positioned element, if its containing block is the body
it's not supposed to move as scroll. However, on low dpi devices, it
doesn't get composited if its ancestor is isolated composited therefore
it moves unexpectedly.

BUG=719533
TEST=third_party/WebKit/LayoutTests/compositing/overflow/absolute-element-in-isolated-composited-ancestor.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2869813002
Cr-Commit-Position: refs/heads/master@{#471158}

Move "Field is required" to content of editors
Change Cancel button in editors to "Cancel Payment"

BUG=718548

Review-Url: https://codereview.chromium.org/2882463002
Cr-Commit-Position: refs/heads/master@{#471157}

BUG=718925

Review-Url: https://codereview.chromium.org/2865963003
Cr-Commit-Position: refs/heads/master@{#471156}

Order of operations might matter, so tighten that up.

BUG=NONE

Review-Url: https://codereview.chromium.org/2879633003
Cr-Commit-Position: refs/heads/master@{#471155}

BUG=712895

Review-Url: https://codereview.chromium.org/2872813003
Cr-Commit-Position: refs/heads/master@{#471154}

https://skia.googlesource.com/skia.git/+log/ec8f8b064340..e6c210ae0113

$ git log ec8f8b064..e6c210ae0 --date=short --no-merges --format='%ad %ae %s'
2017-05-11 msarett Fix Ubuntu-Clang-x86_64-Release-Mini
2017-05-11 jvanverth Classify spot shadows for general shapes
2017-05-11 herb Evenly space gradient stage.
2017-05-11 mtklein proposed: inclusive gradients, exclusive images
2017-05-11 mtklein spin off: always clamp linear gradients
2017-05-11 robertphillips Setup for another attempt to split up opLists

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=stani@chromium.org

Change-Id: I304771b32863a9f92d229f45f06ddb0f432d79ea
Reviewed-on: https://chromium-review.googlesource.com/503494Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#471153}

This CL adds a README.md to modules/imagecapture;
it gathers some links and also addresses some points
that were not evident, as gathered from the experiences
of fbeaufort@.

BUG=655107

Review-Url: https://codereview.chromium.org/2866593002
Cr-Commit-Position: refs/heads/master@{#471152}

Just a small cleanup.

BUG=635619

Review-Url: https://codereview.chromium.org/2870253002
Cr-Commit-Position: refs/heads/master@{#471151}

For testing protected content we need to bypass the prompt
for permission to play protected content. This change add the
switch --unsafely-allow-protected-media-identifier-for-domain
which will disable the info bar when protected content needs
permission when playing from localhost.

BUG=718608

Review-Url: https://codereview.chromium.org/2816773002
Cr-Commit-Position: refs/heads/master@{#471150}

Currently we use an InMemoryStore for the FeatureEngagementTracker,
which doesn't persist feature Events beyond the scope of the application
lifetime.  However once we move beyond demo mode, the feature engagement
conditions will span months, so we need to track the data for longer
than a single session.

This CL implements the Store interface and backs it with a
leveldb_proto::ProtoDatabase.

BUG=706309

Review-Url: https://codereview.chromium.org/2876633002
Cr-Commit-Position: refs/heads/master@{#471149}

GetNode, IsAXInlineTextBox, Detach.
These will most likely be needed for adding SetSelection support to this class.
R=dmazzoni@chromium.org, cbiesinger@chromium.org

Review-Url: https://codereview.chromium.org/2855043003
Cr-Commit-Position: refs/heads/master@{#471148}

BUG=576197
R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2878513002
Cr-Commit-Position: refs/heads/master@{#471147}

This change improves the logic for deciding whether to track a subframe nav.

1. only track if the nav's main frame matches the main frame of the currently
   committed load in the web contents
2. otherwise, always return early, since we don't want to run any of the
   subsequent MWCO::DidFinishNavigation logic on subframes.

BUG=721526

Review-Url: https://codereview.chromium.org/2876793004
Cr-Commit-Position: refs/heads/master@{#471146}

This removes the ConnectionParams constructor which implies
TransportProtocol::kLegacy and updates all callers to specify the
protocl explicitly.

No functional change, so TBRing.

BUG=696031
TBR=jam@chromium.org
TBR=jcivelli@chromium.org

Change-Id: Ifb02e7b49eabefa94b1cf29388ea728dd5962177
Reviewed-on: https://chromium-review.googlesource.com/503610Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#471145}

This will (1) make render tests perform pixel-wise
comparison and generate diff images, (2) allow you
to specify output directory for where to dump the
result images on the device, and (3) upload the results
to be visible from buildbot status page.

Review-Url: https://codereview.chromium.org/2866103002
Cr-Commit-Position: refs/heads/master@{#471144}

The DelayedPersistentAllocation added an atomic field to the
PersistentHistogramData structure that cannot be copied using
operator= (at least not without redefining it).  Copies of only
some of the fields are needed so explicitly copy only those; the
atomic field is not one of them.

BUG=721352

Review-Url: https://codereview.chromium.org/2875643004
Cr-Commit-Position: refs/heads/master@{#471143}

The C-style comments were confusing a regex.
No behavior change.

BUG=675877

Review-Url: https://codereview.chromium.org/2872133004
Cr-Commit-Position: refs/heads/master@{#471142}

Now that support for the GET_ALLOWED_ORIGINS request is optional WebUSB
devices may only support the GET_URL request used for reading the
landing page from the device. This patch fixes the descriptor reading
logic so that this is supported.

(Note, the logic to send the GET_ALLOWED_ORIGINS request will be removed
entirely as part of issue 711443.)

BUG=721546

Review-Url: https://codereview.chromium.org/2876463008
Cr-Commit-Position: refs/heads/master@{#471141}

They all had the same underlying cause: we were firing accessibility events
based on changes to the accessibility tree, but before we had finished
making changes to BrowserAccessibilityWin. To fix this, queue up events
caused by tree changes and fire them after the tree is loaded.

We should probably use this technique more in the future. For now this
just re-enables some good tests.

BUG=719030

Review-Url: https://codereview.chromium.org/2857743006
Cr-Commit-Position: refs/heads/master@{#471140}

This allows flywheel to know when it's safe to switch resources.

BUG=504194

Review-Url: https://codereview.chromium.org/2842763003
Cr-Commit-Position: refs/heads/master@{#471139}

The memory-exhaustion loop could cause DbgHelp's SymFromAddr() to hang
in certain build configs (32-bit Windows Clang debug builds), causing
MetricsServiceBrowserTest.OOMRenderers to hang while generating the
backtrace after the OOM exception. Reducing the allocation size seems to
help.

BUG=692564
TBR=jochen

Review-Url: https://codereview.chromium.org/2882513003
Cr-Commit-Position: refs/heads/master@{#471138}

BUG=705331

Review-Url: https://codereview.chromium.org/2867683002
Cr-Commit-Position: refs/heads/master@{#471137}

The code guarded by it hasn't been compiling for a while, and this
code was added over 5 years ago. It probably isn't used any longer.

BUG=675877

Review-Url: https://codereview.chromium.org/2869953003
Cr-Commit-Position: refs/heads/master@{#471136}

This CL implements the viewport fling animation for iOS client. This
re-impements Android client's FlingAnimationJob and impements a simplified
version of Android's Scroller in C++.

BUG=714193

Review-Url: https://codereview.chromium.org/2869723007
Cr-Commit-Position: refs/heads/master@{#471135}

To correctly paint a float from LayoutNG we need to know the BFC offset
of the container to which we are attaching this float. It's used to
calculate {@code left_offset}, {@code top_offset}.
In most situations {@code (left|top)_offset} equals to float's logical
offset except the cases where a float needs to be re-attached to a non-zero
height parent.
Example:
  <body>
    <p style="height: 60px">Example</p>
    <div id="zero-height-div"><float></div>
Here the float's logical offset is 0 relative to its #zero-height-div
parent. Because of the "zero height" div this float is re-attached to the
1st non-empty parent => body. To paint this float correctly we provide the
modified {@code (top|left)_offset} which is relative to the float's new
parent.
I.e. for our example {@code top_offset} == #zero-height-div's BFC offset
                     - body's BFC offset + float's logical offset

BUG=635619
TESTS=Fixes 8 tests in CSS2/floats-clear, 1 in CSS2/floats,
1 in CSS2/positioning, 2 in fast/block/margin-collapse,
2 in fast/block/float. Total: 14

Review-Url: https://codereview.chromium.org/2850893003
Cr-Commit-Position: refs/heads/master@{#471134}

See https://html.spec.whatwg.org/multipage/infrastructure.html#safe-passing-of-structured-data

And the web platform test here:
https://github.com/w3c/web-platform-tests/blob/master/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/serialization-via-history.html

BUG=chromium:718193

Review-Url: https://codereview.chromium.org/2857303003
Cr-Commit-Position: refs/heads/master@{#471133}

Change-Id: Idfb49bbd33b9813ef84a3f24904d57e53462f6d8
Reviewed-on: https://chromium-review.googlesource.com/499013Reviewed-by: Brett Wilson <brettw@chromium.org>
Commit-Queue: Mike Bjorge <mbjorge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#471132}

A Surface may be submitted with many CompositorFrames, Surface and Frame
are not the same concept.
Here use CompositorFrameSinkSupport::EvictFrame to destroy a Surface is
misleading, so rename to CompositorFrameSinkSupport::EvictCurrentSurface.

BUG=691649
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2872883002
Cr-Commit-Position: refs/heads/master@{#471131}

This CL changes the url string to "chrome://settings/#Bluetooth".

BUG=720248

Review-Url: https://codereview.chromium.org/2873963007
Cr-Commit-Position: refs/heads/master@{#471130}

Add new constructors for mojo::DataPipe and content::ResourceRequestCompletionStatus to do this.

BUG=717714

Review-Url: https://codereview.chromium.org/2875143002
Cr-Commit-Position: refs/heads/master@{#471129}

This CL wires the GetPhotoCapabibilities() method for Mac and fills in
the only available capability, the photo resolution, which is equal to
the "live" capture resolution.

This CL also fills in the Linux/CrOs capture reoslution as the only
supported PhotoCapabilities.{height,width}.

BUG=721478

Review-Url: https://codereview.chromium.org/2868393004
Cr-Commit-Position: refs/heads/master@{#471128}

We should not SwitchToLastActiveUser() when there is only one user logged in.
This covers restart on signin, when last_active_user may be outdated.

BUG=714250

Review-Url: https://codereview.chromium.org/2872133009
Cr-Commit-Position: refs/heads/master@{#471127}

Create OKButton shared matcher, since this button is likely used
other places.

Bug: 
Change-Id: Ib45265f6be2ebc2d59f3e912bc4d6e6fb628771d
Reviewed-on: https://chromium-review.googlesource.com/503493Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mike Baxley <baxley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#471126}

Add a render process mojo interface exposed to the browser for
receiving process-wide spellcheck control and updates from the
browser process.

Fold the enable IPC into the Initialize() mojo API (the enable
IPC was only ever called right after an Init IPC) by adding an
|enable| argument. Mojo does not support set<> so use vector<>
instead on the mojo APIs. Use a binding set on the server-side
to automate mojo request disconnect and clean-up.

Update the browser test to use mojo instead of IPC in the mock
renderer and add a test for a custom dictionary update. Change
the InitSpellcheck helper: spellcheck->InitForRenderer() isn't
needed (creating a SpellcheckService does that for us).

Bug:714480

Change-Id: I5365c42fc10c7766054c5b80fb366ceaa4d59159
Reviewed-on: https://chromium-review.googlesource.com/487341Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#471125}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/59e58189c55d..1ff6ffc1f618

$ git log 59e58189c..1ff6ffc1f --date=short --no-merges --format='%ad %ae %s'
2017-05-11 simonhatch Dashboard - Post a task in migrate_test_names to add tests from patterns.
2017-05-11 simonhatch Dashboard - Remove unused args from getCheckedOrAllAlerts

Created with:
  roll-dep src/third_party/catapult
BUG=713335


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I0860054268acd2d93b9f65a3c4367b1ec18817f8
Reviewed-on: https://chromium-review.googlesource.com/503611
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#471124}

Since native/ has been entirely moved into browser/, the target should
move as well. Cleaned up a few unneeded DEPS as well.

BUG=716604

Change-Id: I77fb632279b96318e5aa6d4eefe70046df41188f
Reviewed-on: https://chromium-review.googlesource.com/503647Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Bo Liu <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#471123}

Create a link to flakiness dashboard for each test case, so that engineers will see the flakiness level for that test case.

BUG=717631

Review-Url: https://codereview.chromium.org/2873723002
Cr-Commit-Position: refs/heads/master@{#471122}