- 25 Oct, 2019 40 commits
-
-
Chris Palmer authored
Performance regressions, alas. Bug: 1005070, 1013329, 1013326, 1013324 Change-Id: I15c0a539d5adde6f86de98ceec301863708307f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880145Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#709322}
-
Meredith Lane authored
TBR=michaelpg@chromium.org Bug: 1018012 Change-Id: If3de2ca1745a674f2a4b972fcf72b683cde61bac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880408Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#709321}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/6da1770507ec..1fdcb16b6995 git log 6da1770507ec..1fdcb16b6995 --date=short --no-merges --format='%ad %ae %s' 2019-10-24 cwallez@chromium.org Make dawn_wire use the webgpu.h header 2019-10-24 cwallez@chromium.org Vulkan: Implement initial version of the suballocation 2019-10-24 cwallez@chromium.org Preliminary changes to Vulkan memory suballocation 2019-10-24 cwallez@chromium.org Vulkan: Use the ResourceMemoryAllocator for all resources Created with: gclient setdep -r src/third_party/dawn@1fdcb16b6995 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: If9cb48571562c569436a2a2658f9fa8bb6e26f90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879584Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709320}
-
Devlin Cronin authored
Clean up the BrowserActionTestUtilViews implementation a bit. - Remove the TestToolbarActionsBarHelper base class from BrowserActionTestUtil; there's no need for it to be (conceptually) cross-platform. - Cache the BrowserActionsContainer pointer on the BrowserActionTestUtilViews instance to avoid always doing a look-up through the GetContainer() method (and remove GetContainer()). - Avoid caching the Browser on the object; it's only necessary for creating the overflow bar, and can be easily passed in to those calls (of which there are few). - Finesse the constructors to make it clear when a BrowserActionsContainer is owned (through a manufactured view) vs not (by accessing one on the BrowserWindow). Bug: 984654 Change-Id: Ibab94e0562fd04026f1b2642d6dbc170c049ead4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877447 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#709319}
-
Yusuke Sato authored
As noted in b/143229899, a stale VmStopped signal can be sent to Chrome if StopAllVms() call sent by session_manager takes a long time to finish. Without this CL, such a signal could confuse the VM adapter. BUG=b:143229899 TEST=new tests pass Change-Id: I72b918aebfc8b1218d25c931ce61bde728614a32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877603 Auto-Submit: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#709318}
-
Xinghui Lu authored
The metrics are added for debugging crbug.com/1016546. Bug: 1016546 Change-Id: I688e0f3a5464e6e6acee09c5d8fc14bb385af300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879822 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#709317}
-
Kenichi Ishibashi authored
The class seemed to be gone as a part of the Onion Soup. Remove references to the class and update comments. Bug: N/A Change-Id: Ia093586c40295d09bffcf713d6156a20e96b43c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877489 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#709316}
-
Devlin Cronin authored
Do a couple small cleanups in ExtensionsMenuView: - Update includes and forward declarations (removing unused, adding missing) - Add function comments - Remove unused function CreateFixedSizeIconView() (the last usage was removed in crrev.com/7127b171) Bug: None Change-Id: I83513678011b6adf825377def47003a677e5fb17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879605 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#709315}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c09baddc696f..98c55a366e1b Created with: gclient setdep -r src-internal@98c55a366e1b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I9d303d1ef772c72d0f8fa8eaa6b5d0533a43da97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879580Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709314}
-
Yusuke Sato authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/4ed26a9a6564..8014da0ebf8c $ git log 4ed26a9a6..8014da0eb --date=short --no-merges --format='%ad %ae %s' 2019-10-10 bgeffon debugd: Add Kstaled Enable/Disable method 2019-10-23 yusukes system_api: Add |cid| field to VmStoppedSignal message 2019-10-21 pmalani system_api: Add proto_library compile flag for fuzzers Created with: roll-dep src/third_party/cros_system_api BUG=b:143229899 TEST=try Change-Id: Ic72b6d0282c1f8f5d4ae0201e4afa7e95f00e4c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880327 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Commit-Queue: David Jacobo <djacobo@chromium.org> Auto-Submit: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#709313}
-
Daniel Rubery authored
This function was originally added when there was a "silent" mode for WebProtect uploading. Users would see no change if ShouldDelayVerdicts returns false. With pre-delivery mode implemented, we should be showing that UX when the admin does not block delivery. Fixed: 1016896, 980779 Change-Id: Ie82416f365668af6ec135d7b142d35ad23db07d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874203 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#709312}
-
Jonah Ryan-Davis authored
More tests have become flaky. Will suppress until the root cause is found. conformance/ogles/GL/radians/radians_001_to_006.html conformance/ogles/GL/reflect/reflect_001_to_006.html conformance/ogles/GL/refract/refract_001_to_006.html Bug: 1017162 Change-Id: I5a089af9192fa242e883ab9bdda6564301bee55a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879850Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/master@{#709311}
-
Matt Menke authored
I'm going to add NetworkIsolationKey key as an argument (And eventually make it non-optional, defensively). Getting rid of the legacy constructor makes that a bit easier. Also inline HostCache::Key() initial values in the header file, while I'm here. Bug: 997049 Change-Id: I995eac63434e0f673ea31669977f4aacfc2a1982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874512 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#709310}
-
meacer authored
This character (þ) can be confused with both b and p when used in a domain name. IDN spoof checker doesn't have a good way of flagging a character as confusable with multiple characters, so it can't catch spoofs containing this character. As a practical fix, this CL restricts this character to domains under Iceland's ccTLD (.is). With this change, a domain name containing "þ" with a non-.is TLD will be displayed in punycode in the UI. This change affects less than 10 real world domains with limited popularity. Bug: 798892, 843352, 904327, 1017707 Change-Id: Ib07190dcde406bf62ce4413688a4fb4859a51030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879992 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#709309}
-
Maks Orlovich authored
We will be requiring cookies marked to permit access in 3rd-party contexts to be secure; and this test was creating an insecure one, so change it. Bug: 1016512 Change-Id: I4205508d7ff145f7d81fe36fcfa5854963462de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879192 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#709308}
-
Ryan Hansberry authored
The dialog was incorrectly displaying "Connecting to..." when the keyboard supported and provided "keys entered" events. We should always continue to prompt the user to enter the passkey as they enter the passkey. Bug: 1007375 Change-Id: Ia5cf9d226fe17d902e01aaa24f642a1dab635af6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875382 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#709307}
-
Robbie McElrath authored
//aw/apk is where all standalone webview code should live (things not run in another app's process as a result of starting a webview). Since services run in webview's process, they belong in the apk folder. This also moves the aidl files to //aw/java/.../common/services. Test: Manually verify starting SystemWebView still starts the service. Bug: 934152 Change-Id: I4e3c2f43c4dfbab41b8f187d82dbd03ce09147da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864317Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#709306}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1ac605ab1a88..ff7d06ba71fd git log 1ac605ab1a88..ff7d06ba71fd --date=short --no-merges --format='%ad %ae %s' 2019-10-24 lalitm@google.com trace_processor: add fast path for eq constraints on id columns Created with: gclient setdep -r src/third_party/perfetto@ff7d06ba71fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I10b824d39c411a4ef7e99e42ed483c431f31bd2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879581Reviewed-by:
-
Collin Baker authored
Bug: 1009122 Change-Id: I64e48c638b403911a8879ff1fa7b290628373bd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877454 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
-
David Tseng authored
In the attached bug (which has recently been re-introduced), 1. focus is requested on a node 2. in response, the page triggers some type of re-flow which causes the layout object of the node to be invalidated 3. some amount of non-determinism occurs where we might call AXObject CacheImpl::GetOrCreate on a node (keyed by layout object). This sometimes results in us creating a brand new AXLayoutObject or AXNodeObject for a Node that hasn't been destroyed. 4. when it arrives in the browser or in ChromeVox, the target of the focus looks like it was destroyed, so the focus event never gets fired. Test: browser_tests --gtest_filter=Automation*.ForceLayout Bug: 885244 Change-Id: I2f7747a98d15a6ae5b3ed75638a93d1078526015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872422 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#709303}
-
Christopher Cameron authored
We are already doing this in the GPU process as the histogram Gpu.Metal.TestShaderCompileSucceeded. That histogram indicates that we fail to compile the shader from the GPU process within 6 seconds 2% of the time. The new histogram Browser.Metal.TestShaderCompileTime histograms the shader compile time, up to 1 minute, whereupon it uses the max bucket (3 minutes). Also add a DumpWithoutCrashing on timeout. This will have to be removed after one promotion to dev (to not drown out real crashers), but will help gather more information about crashing machine profiles. Move the test shader code into the metal_util component so that it can be used by both locations (the previous implementation was in /viz/). Landed at crrev.com/708870 R=avi,isherman Reverted at crrev.com/708991 Because of DCHECK that shader compilation succeeds, which does not happen on some bots. Added separate return value for this case. TBR=avi Bug: 974219 Change-Id: Icab8dab3293d897500e7f7774a02f99fc39cf831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879968Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#709302}
-
Manu Cornet authored
* Make the app list controller the only class that observes home launcher changes. * Move "home launcher animation state" cached field to the app list controller. * Rejiggle a bit the flow of information between our various observers (overview, app list visibility, home launcher gesture, etc.) so that more classes are generally aware of the final state of a transition sooner than previously. * Add a "will start" API to the overview observer. * Add a couple of "const" where appropriate. Bug: 1012760,1013737,1012353,1016012,1012767,1009550,1006013,1016511 Change-Id: I15bc0fb519713145beffb9933295564b0d8a5f6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872102 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#709301}
-
Carlos Knippschild authored
Change-Id: I3d10b7e233015b291681200cda2e42c7706571d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880276 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#709300}
-
Xiaoqian Dai authored
If the shelf is hidden or auto-hide hidden shelf, the user needs to swipe up the shelf and then second swipe to do the window dragging. Bug: 997885 Change-Id: I765cf813943d4bc209b4e1c9a023586a12c69145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877257 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#709299}
-
tby authored
The framework implementation will involve some breaking changes to the code. I'm disabling collection for now, with plans to re-enable it once the new API is done. Bug: 1016655 Change-Id: I862294a4020c3d6f25c726c4799cd4ffa4dc4e47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872081Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#709298}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/cb771c6c486e..25df51372600 git log cb771c6c486e..25df51372600 --date=short --no-merges --format='%ad %ae %s' 2019-10-24 chrome-bot@chromium.org Update config settings by config-updater. 2019-10-24 vapier@chromium.org gn_helpers: pull python 3 updates from upstream Created with: gclient setdep -r src/third_party/chromite@25df51372600 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I1754d308c1ab627b416878ca1fbd87072dd90351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879576Reviewed-by:
-
Yulun Wu authored
Bug: 1016946 Change-Id: Ia4b3a2a5f10bcac12c21f040cde81f7710be9b54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879652Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#709296}
-
minch authored
scroll_x() of gesture event is not reliable after checked on physical device. Get the x drag amount from touch events as y drag amount. Fling event is supported, which means the |drag_progress_| might hasn't reached full progress while COMPLETING the drag. Bug: 1002733 Change-Id: I66dfb4110e2e8f34445d67a5e5cc25681b3f8708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879821 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
-
Meredith Lane authored
This reverts commit bbe3cdf3. Reason for revert: AXPlatformNodeAuraLinuxTest.TestAtkValueChangedSignal has been failing consistently. https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/15401?blamelist=1#blamelist-tab Original change's description: > Reland "Fix emission of AtkValue property change signal" > > This version checks at runtime for atk_value_set_value during testing. > This should allow the change to work on bots running trusty. > > Original commit message: > > > The introduction of text-change signals for the omnibox included a > > regression that prevented the emission of AtkValue property change > > signals. Fix this error and also add an implementation of > > atk_value_set_value. The implementation is used in a test to verify the > > correct behavior. > > > > The fix is that we correct the misuse of a logical operator and now > > always try to emit AtkValue property change events when receiving the > > kValueChanged event in AXPlatformNodeAuraLinux. > > Bug: 1015387 > Change-Id: I486b44f9d0f212d951487bdc9f953401a94f9dff > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876850 > Commit-Queue: Martin Robinson <mrobinson@igalia.com> > Reviewed-by: Joanmarie Diggs <jdiggs@igalia.com> > Cr-Commit-Position: refs/heads/master@{#709023} TBR=mrobinson@igalia.com,jdiggs@igalia.com Change-Id: I319a1d3b6d73c313d47fe92952ddbabe021e7407 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1015387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880487Reviewed-by:
-
Jordy Greenblatt authored
This is step one of the two part task of ensuring that settings subpage buttons in cr-link-rows announce that they are subpage buttons. As is, they are called 'link's [1], which almost always implies opening a new tab in both browser and OS settings. This change allows elements containing a cr-link-row to provide a string to be passed down to the link row's nested cr-icon-button as the button's role description. As a practical test, this change also migrates the OS settings' main page's 'Languages and input' row [2] to use a cr-link-row [3] with the new role description "subpage button" injected [4]. ---- Note: I initially missed an error resulting in a regression that caused the act of routing to and then back from the Languages and input subpage via this row to send DOM and a11y focus to the full page instead of back the its previous location on the subpage button. This was fixed in Patchset 7 by updating line 33 of os_languages_section to reflect the change to the DOM caused by this CL. See [5] for a demonstration of the correct routing behavior once Patchset 7 was implemented. [1] https://drive.google.com/file/d/1tBGDSoeaRBRO3nJ4h7IMPtiiGMDGB10L/view?usp=sharing [2] https://screenshot.googleplex.com/dsGjkF0e93c [3] The migration to cr-link-row was planned anyway as part of crbug.com/1012565 so it was a good trial case for the task of using the "subpage button" language on all settings 'cr-link-row's, i.e. crbug.com/1012104. [4] https://drive.google.com/file/d/1Lsil-tybwB_cwSLN0TyabfCq_DFNpUSo/view?usp=sharing [5] https://drive.google.com/file/d/13VYF-XPAryQYfI1paU8vi9KBC3J5fvhM/view?usp=sharing Bug: 1012103, 1012104, 1012565 Change-Id: I7ac02205bbdd8a352fdbc7e920c1729acf634ba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846397 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#709293}
-
Peng Huang authored
When Vulkan and GL interop is not supported, we are using separate gl texture and vk image in ExternalVkImage. We need sync content between gl and vulkan textures. Without this change, we only sync content to gl or vulkan texture which decided by the first begin read access. However, with recent change promise image caching in viz, concurrent read may happen, If the second access is for a different texture, the content could be out of sync. This change fixes the problem by always sync the content to both gl and vulkan texture with the first begin read access. Bug: 1014236 Change-Id: I00ad75f0ffe5f87f98d2e298a687743e2e8e1947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879556 Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#709292}
-
Xiaoqian Dai authored
Remove kDragWindowToHomeOrOverview mode from HomeLauncherGestureHandler and migrate tests. No functional change. Bug: 997885 Change-Id: I727e1c6bbc11d88416eb3e92a8f113c7d4c8e4ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879818 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
-
Carlos Knippschild authored
Bug: 999454 Change-Id: Ic64485af9f8989980282a87d86e3a2b63cdb3684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879657 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Auto-Submit: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
-
Tobias Sargeant authored
This enables us to set the browser package info during intialization without having to reflect to look up the object again. Change-Id: I2a66494dde72a1d6c64140e9ac68b310f970be50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879887Reviewed-by:
-
RJ Ascani authored
This is the first change in a soft transition change in the fuchsia.media.drm APIs. The LicenseSession OnKeysChanged event is being renamed to OnKeyStatesChanged. This adds an identical handler to the FuchsiaCdm::CdmSession. Implementations will send one or the other, but not both events. Bug: fxb/38522 Change-Id: I07b370f18f38b223c11a89bdc68fddc6955a2b21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879521Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: RJ Ascani <rjascani@google.com> Cr-Commit-Position: refs/heads/master@{#709288}
-
Ryan Hansberry authored
Alert the user when the Bluetooth device is being connected to, requires passkey entry or confirmation, or fails to connect (an existing notification already alerts the user when the device successfully connects). Bug: 1007364 Change-Id: Icbca5b4ff3c5c645c4e21f17ef040acb107e9352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876470Reviewed-by:
-
Tim Song authored
As part of the new UI redesign fo the system tray, we no longer render shadows around the tray bubbles. This includes the quick settings, sliders, and autoclick bubbles. Legacy bubbles (e.g. palette) are not affected. Note that we need to add a new border to the message center bubble, which will be done in a follow-up CL. TEST=manually verified all bubbles BUG=976952 Change-Id: I5e52b272262064044f52c79ababd14725111a735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877137 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#709286}
-
Rakib M. Hasan authored
Blinkpy originally checked for leaks in the actual driver output twice, and therefore returned two FailureLeak instances. This caused typ to raise an exception when writing the leak log twice. Bug: chromium:1017068 Change-Id: I345fc0151e2130fcd7d38ea63a1423f1fc1f939c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879768Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#709285}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b1a96724321f..de9e3cabe60e git log b1a96724321f..de9e3cabe60e --date=short --no-merges --format='%ad %ae %s' 2019-10-24 ehmaldonado@chromium.org presubmit: Make ThreadPool surface exceptions on CallCommand. Created with: gclient setdep -r src/third_party/depot_tools@de9e3cabe60e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I363ac38edcb0b9332e8349b0f517f42b7c10db37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879571Reviewed-by:
-
khmel@chromium.org authored
This is required to identify the reason of the main account resolution failures. BUG=b:143167303 TEST=Locally, status is reported in histograms. Change-Id: I57540c82606eb7f86b00bdae69b7b753afe7cf15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874589 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Josh Horwich <jhorwich@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#709283}
-
