GitLab

Change created by following existing patterns and reading:
http://www.chromium.org/developers/design-documents/ui-localization

BUG=448585,381246

Review URL: https://codereview.chromium.org/811193005

Cr-Commit-Position: refs/heads/master@{#311396}

Review URL: https://codereview.chromium.org/852643003

Cr-Commit-Position: refs/heads/master@{#311395}

BUG=447642, 443766
TEST=TrayIMETest.PerformActionOnDetailedView, TrayIMETest.HidesOnA11yEnabled, TrayIMETest.HiddenWithNoIMEs

Review URL: https://codereview.chromium.org/843603004

Cr-Commit-Position: refs/heads/master@{#311394}

Immediately deletes the Incognito profile's cookies from the cookie
jar as soon as Profile is notified that a profile has been deleted.
The CookiesFetcher will confirm the incognito profile is missing,
then schedule them for deletion.

Also does general cleaning and renaming to less confusing method names.

BUG=447267

Review URL: https://codereview.chromium.org/833533004

Cr-Commit-Position: refs/heads/master@{#311393}

BUG=426119

Review URL: https://codereview.chromium.org/852433002

Cr-Commit-Position: refs/heads/master@{#311392}

BUG=

Review URL: https://codereview.chromium.org/850833002

Cr-Commit-Position: refs/heads/master@{#311391}

Rejig the watcher to run a message loop on the main thread, and to
do the blocking wait on a dedicated background thread.

BUG=412384

Review URL: https://codereview.chromium.org/848033005

Cr-Commit-Position: refs/heads/master@{#311390}

BUG=303818,433583

Review URL: https://codereview.chromium.org/846543002

Cr-Commit-Position: refs/heads/master@{#311389}

Get all font unittests running with DirectWrite on Windows 7+

Fixes as per below:-
1. Remove the addition of the fLeading value when calculating the height for the font
   with DirectWrite. fAscent + fDescent is the height of the font and adding the fLeading
   value to it returns the spacing between lines which is not what we are looking for.

2. The FontListTest.Fonts_GetHeight_GetBaseline unittest has a condition which basically validates
   whether the difference between the font height and the baseline is different for Arial and Symbol
   fonts. This fails for DirectWrite and fails for GDI with font sizes like 50, etc. Replaced this check
   with a check for the font heights are different.

3. Reworked the PlatformFontWinTest.DeriveFontWithHeight test to ensure it passes for DirectWrite and GDI.

4. Ensure that the PlatformFontWin::DeriveFontWithHeight function honors the minimum font size constraint
   in all cases.

BUG=442010
R=msw

Review URL: https://codereview.chromium.org/853553002

Cr-Commit-Position: refs/heads/master@{#311388}

This change upstreams the DownloadManagerService and OMADownloadHandler class, along with java tests.

BUG=15902
R=dtrainor@chromium.org, jbudorick@chromium.org

Review URL: https://codereview.chromium.org/848803002

Cr-Commit-Position: refs/heads/master@{#311387}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/bb928a0..a7f1191

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/846303003

Cr-Commit-Position: refs/heads/master@{#311386}

Some component apps and extensions use private extension APIs to
communicate with their browser components. This CL adds the mojoPrivate
API as a way to use mojo directly from Javascript without needing to
create a private API.

BUG=448565,448569

Review URL: https://codereview.chromium.org/649003003

Cr-Commit-Position: refs/heads/master@{#311385}

Combined GetAnyChromePath and GetChromeSxSPath into one function that
takes a bool |is_sxs|. Avoids the need to have a wrapper function that
conditionally calls GetAnyChromePath or GetAnyChromeSxsPath.

BUG=428600

Review URL: https://codereview.chromium.org/685103004

Cr-Commit-Position: refs/heads/master@{#311384}

This forces WeakPtrs to be invalidated before other members' destructors run.
See the bug or the documentation of WeakPtrFactory for more information. I'm
in the process of trying to turn on a clang check for this (see the bug).

BUG=303818
R=derat@chromium.org
TBR=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/816973003

Cr-Commit-Position: refs/heads/master@{#311383}

Related code is also being updated to the new version of LaunchProcess.

BUG=417532

Review URL: https://codereview.chromium.org/846753002

Cr-Commit-Position: refs/heads/master@{#311382}

This forces WeakPtrs to be invalidated before other members' destructors run.
See the bug or the documentation of WeakPtrFactory for more information. I'm
in the process of trying to turn on a clang check for this (see the bug).

BUG=303818
R=groby@chromium.org

Review URL: https://codereview.chromium.org/803963005

Cr-Commit-Position: refs/heads/master@{#311381}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0fda955..55561f5

TBR=hayato@chromium.org,zmo@chromium.org

Review URL: https://codereview.chromium.org/825953004

Cr-Commit-Position: refs/heads/master@{#311380}

Revert of Implemented explicit resizing from guestview. (patchset #6 id:120001 of https://codereview.chromium.org/847893002/)

Reason for revert:
Broke out of process PDF.

Original issue's description:
> Implemented explicit resizing from guestview.
>
> A guest can now be explicitly resized (in addition to autosizing) from guest_view.js, using the new |setSize| function. This new function combines autosizing and normal resizing, as described in: https://docs.google.com/document/d/1EJfmJSK0JJsxKptSRhepnsOOwvXJNv5nnJ1pZdjGDRQ
>
> BUG=434226
>
> Committed: https://crrev.com/681a4fc1d1ac77a17c69ba23fa6710a0e3aa206f
> Cr-Commit-Position: refs/heads/master@{#311286}

TBR=paulmeyer@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=434226

Review URL: https://codereview.chromium.org/800543005

Cr-Commit-Position: refs/heads/master@{#311379}

In working on importing a newer version of SQLite, I found that I could
not find a copy of the previous version.  This makes it harder to figure
out if we have any mods which need to be tracked or unwound.

This import should be a non-event, since most of the files are identical
to the files in third_party/sqlite/src/ , so git will just add a reference.

BUG=340757

Review URL: https://codereview.chromium.org/826543003

Cr-Commit-Position: refs/heads/master@{#311378}

Also, removing special case where certain metrics where summed instead of averaged since they are now handled in the dashboard by averaging, no longer making them special cases.

BUG=447588

Review URL: https://codereview.chromium.org/847273002

Cr-Commit-Position: refs/heads/master@{#311377}

This forces WeakPtrs to be invalidated before other members' destructors run.
See the bug or the documentation of WeakPtrFactory for more information. I'm
in the process of trying to turn on a clang check for this (see the bug).

BUG=303818
R=asargent@chromium.org

Review URL: https://codereview.chromium.org/846153005

Cr-Commit-Position: refs/heads/master@{#311376}

Compile of app_list_unittests on toolkit-views enabled Mac regressed in
r311143 because it accessed aura::Window and there is no Aura on Mac
yet.

The MouseHoverToHighlight passes on Mac - it just needs to initialize
the event generator differently.

TapGestureToHighlight is disabled on Mac, since there are no touch
events on desktop Mac.

BUG=441573, 445520, 365977

Review URL: https://codereview.chromium.org/840373003

Cr-Commit-Position: refs/heads/master@{#311375}

This regressed in r311208.

AppListBackground constructor no longer takes two arguments.

BUG=365977

Review URL: https://codereview.chromium.org/789333004

Cr-Commit-Position: refs/heads/master@{#311374}

This forces WeakPtrs to be invalidated before other members' destructors run.
See the bug or the documentation of WeakPtrFactory for more information. I'm
in the process of trying to turn on a clang check for this (see the bug).

BUG=303818
R=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/841103003

Cr-Commit-Position: refs/heads/master@{#311373}

This reduces duplciation and allows for hooks (e.g. tracing)
at the kernel proxy boundary.

R=binji

Review URL: https://codereview.chromium.org/757293005

Cr-Commit-Position: refs/heads/master@{#311372}

Recent changes to CDM_7 removed |destination_url| as it is no longer
used in the EME spec. However legacy applications using the prefixed
EME API depend on it, so adding it back in so that it is available
to those applications.

BUG=448242
TEST=existing EME tests pass + Play movies play

Review URL: https://codereview.chromium.org/813683005

Cr-Commit-Position: refs/heads/master@{#311371}

BUG=448596
TBR=ncbray@chromium.org
CC=sbc@chromium.org,rch@chromium.org,teravest@chromium.org

Review URL: https://codereview.chromium.org/851843002

Cr-Commit-Position: refs/heads/master@{#311370}

BrowsingDataAppCacheHelper no longer needs to be able to cancel its callback,
so remove the "CancelableCallback" member. The current code is also not
correct usage of CancelableCallback, because the callback can be deleted on a
different thread than where it was created. This was making a DCHECK fail when
trying to fix a problem in CancelableCallback (see
https://code.google.com/p/chromium/issues/detail?id=433583#c1).

BUG=433583
R=michaeln@chromium.org

Review URL: https://codereview.chromium.org/851553003

Cr-Commit-Position: refs/heads/master@{#311369}

When toolkit_views flips on Mac, the browser UI will still be Cocoa.

This audits the remaining TOOLKIT_VIEWS #defines under
chrome/browser/ui. Mostly constants designed for the views browser UI
that will introduce UI glitches while the Cocoa UI is still used on Mac.

For many of these the #elif defined(TOOLKIT_VIEWS) is redundant, but it
is kept as something to grep for when the browser UI eventually becomes
Views-based.

BUG=439882

Review URL: https://codereview.chromium.org/844333003

Cr-Commit-Position: refs/heads/master@{#311368}

The contents of this file seems to be all legacy
stuff.  These days all the build products end up in
the 'out' directory.

Review URL: https://codereview.chromium.org/835233004

Cr-Commit-Position: refs/heads/master@{#311367}

BUG=448439

Review URL: https://codereview.chromium.org/847043004

Cr-Commit-Position: refs/heads/master@{#311366}

BUG=417463

Review URL: https://codereview.chromium.org/848973002

Cr-Commit-Position: refs/heads/master@{#311365}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2a7b861..0fda955

TBR=hayato@chromium.org,zmo@chromium.org

Review URL: https://codereview.chromium.org/853463005

Cr-Commit-Position: refs/heads/master@{#311364}

BUG=428729

Review URL: https://codereview.chromium.org/810193007

Cr-Commit-Position: refs/heads/master@{#311363}

This adds the UMA call to record when SSL warnings are caused by self-
signed certs.

It also updates the histogram name: SSLNonAttackCauses is no longer
an appropriate name because a self-signed cert very well might be an
attack.

BUG=392310
R=palmer@chromium.org

Review URL: https://codereview.chromium.org/808053007

Cr-Commit-Position: refs/heads/master@{#311362}

BUG=412384

Review URL: https://codereview.chromium.org/843113002

Cr-Commit-Position: refs/heads/master@{#311361}

BUG=
TEST=chromevox_tests (and manualy on Sheets format panel).

Review URL: https://codereview.chromium.org/841453005

Cr-Commit-Position: refs/heads/master@{#311360}

BUG=443392

Review URL: https://codereview.chromium.org/809713006

Cr-Commit-Position: refs/heads/master@{#311359}

The gin::Runner should be destroyed when the JS context is so that its
weak pointers are invalidated and any outstanding callbacks that
interact with the JS context can detect its destruction. Currently,
ScriptContext implements gin::Runner but is not immediately destroyed
when the JS context is. This CL moves this gin::Runner implementation
into a separate class which is destroyed when the ScriptContext is
invalidated.

Review URL: https://codereview.chromium.org/831423005

Cr-Commit-Position: refs/heads/master@{#311358}

A bug in onc_translator_onc_to_shill.cc is triggering a DCHECK when
a property is set in a previously non-existent dictionary.

This is a trivial fix to code that is subtle but clearly incorrect
by inspection.

BUG=none

Review URL: https://codereview.chromium.org/838043003

Cr-Commit-Position: refs/heads/master@{#311357}