- 06 Dec, 2019 40 commits
-
-
Liquan (Max) Gu authored
Context: This is regarding the Bottom-sheet Payment Handler UI. In slow connection, the toolbar on the UI appears empty and shows no indicator of the current loading status, hardly distinguishing from a state of freezing. Old behavior: upon opening the PaymentHandlerUI, its toolbar shows nothing but the payment app's url. Change: set the minimum loading progress to be 5%. Apply it to the initialization and the progress update. New behavior: upon opening the PaymentHandlerUI, its toolbar shows the payment app's url as well as a progress bar starting from at least 5%, which reassures users that the UI is busy loading the page. Bug: 1029815 Change-Id: I05147c15e9c732c75a039c9c20fd021382ec8a72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951649Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#722498}
-
Tommy Li authored
The below CL introduces a bug, where ZeroSuggestProvider can create a match with duplicate text classifications. This triggers a DCHECK as described in the linked bug. https://chromium-review.googlesource.com/c/chromium/src/+/1947765 This CL fixes it and adds a test. Bug: 1030741 Change-Id: If59fbd320d720e2a7ff8d2f66d9ee92e11bb9a68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951557 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#722497}
-
Martin Robinson authored
Trusty comes with a version of ATK that does not support the checkable attribute, so we must specifically deny this in the test. A followup change will make this global in order to avoid having to add it to many tests. Original commit message: > Users of ATs on AuraLinux use the default action to know whether or not > to activate nodes via the keyboard or a simulated mouse event. When a > node with a button role cannot receive keyboard focus, have the default > action be click. This heuristic helps ensure that when there is an ARIA > button that cannot be activated via the keyboard, users know to simulate > a mouse click. Bug: 1025264 Change-Id: Ib8e66b369e30c771ce8533de24050f99e32ab579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953709Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#722496}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ee780985a9cd..97228c73dff9 git log ee780985a9cd..97228c73dff9 --date=short --first-parent --format='%ad %ae %s' 2019-12-06 treehugger-gerrit@google.com Merge "Fix process metadata query to avoid empty Package" 2019-12-06 treehugger-gerrit@google.com Merge "Add unique session name to log" Created with: gclient setdep -r src/third_party/perfetto@97228c73dff9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I29d00e65748cce0ff83b3a650b753812684d6be4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955653Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722495}
-
Omer Katz authored
When deleting an entry is a hash table which is garbage collected, the entry is zeroed out (so that stale values won't be traced). However, An entry might be deleted while it is being traced. To avoid a data race in such cases, during tracing garbage collected objects should be atomically set to zero size_t by size_t (if the size of the entry is not a multiple of sizeof(size_t), the remainder of entry can be zeroed using memset as it is guaranteed not to hold a pointer). Bug: 986235 Change-Id: Id1a6d2fd82fcc31a18caf13764a3488e57b23177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949466 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#722494}
-
Dominic Battre authored
This CL restores the communication of Chrome on iOS with the Autofill server. It broke by commit fc59bb21 which assigned trusted_params to the network request. However, the URLLoaderFactory originated from BrowserState and was therefore shared and not trusted. As per the documentaiton of trusted_params: "Setting these from an untrusted URLLoader will cause the request to fail." This CL removes the trusted_params to bring Autofill back to a working situation. Maybe the iOS or network stack folks can see whether we want to have special URLLoaderFactories for components on iOS. I don't see a precedence for that. Bug: 1031136 Change-Id: Ic2e04f37f3a30e8adb98e23f19205be09fa5375a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953707Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#722493}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Ia2a516c7c0ab06e8e8c7cce9e2c4d8b75d24914f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955162Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722492}
-
Elly Fong-Jones authored
This change removes overrides of DialogDelegate::GetDialogButtons and DialogDelegate::GetDialogButtonLabel from CrostiniAnsibleSoftwareConfigView in favor of the new setters for these properties. Bug: 1011446 Change-Id: Id1b90b7b62719562138db8c1eddbb53a63cb07ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954665Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Olya Kalitova <okalitova@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#722491}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/60a2f6cf5b21..d2d2d7630206 git log 60a2f6cf5b21..d2d2d7630206 --date=short --first-parent --format='%ad %ae %s' 2019-12-06 vapier@chromium.org cbuildbot: lkgm_manager/patch_series: drop more unused code 2019-12-06 vapier@chromium.org partial_mock: SetDefaultCmdResult: switch to stdout/stderr arg names 2019-12-06 vapier@chromium.org cros_build_lib.run: support file objects with stdout/stderr 2019-12-06 vapier@chromium.org hwtest_results: drop unused module 2019-12-06 vapier@chromium.org cidb: drop hwtest support 2019-12-06 andrewlamb@chromium.org replication_lib: Requre paths relative to the source root. 2019-12-06 lamontjones@chromium.org toolchain: start adding PrepareForBuild/Bundle endpoints. 2019-12-06 tomhughes@chromium.org portage_util.py: Add cros-ec to _ECLASS_IMPLIES_TEST 2019-12-06 bpastene@chromium.org cros_gdb: Fix broken paths to the sysroot and GDB binary in Simple Chrome cache. 2019-12-05 vapier@chromium.org clactions: drop unused module 2019-12-05 mutexlox@google.com crash: Add "crash-user-access" group. 2019-12-05 vapier@chromium.org rewrite_git_alternates: use UTF-8 encoding 2019-12-05 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@d2d2d7630206 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: Ie6a35654deb3e9f6eb0eb18ffdee0497c9ca94b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955652Reviewed-by:
-
Kevin McNee authored
<extensionoptions> is used to display extension options pages embedded in chrome://extensions. There currently exists an extension permission "embeddedExtensionOptions" which would allow an extension that requested it to also use <extensionoptions>. This permission is restricted to trunk. This was last changed in 2014. According to issue 420926, there is no longer a need for this permission as it is enough to whitelist usage for WebUI. We remove this permission and the related tests that were specific to the use of <extensionoptions> by other extensions. Note that we still keep the <extensionoptions> tests related to the extension management WebUI as that is separate from the permission. The tests that were implemented in terms of extensions and are still relevant to the extensions WebUI have been reimplemented in terms of WebUI. Also note that there is a switch with the same name (--embedded-extension-options), but this does not relate to the permission. It controls the default value of |open_in_tab| if not specified in the extension manifest. Bug: 420926, 415949 Change-Id: I91081ca3056fdd5bb1e14e5852ec067ed26f455a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864519 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#722489}
-
Danan S authored
This also updates WebDialogView to expose an additional state: ShouldCloseDialogOnEscape(). This new state is important because it allows overriding the action of the Escape key in the webview, instead of forcing the high-priority Close() action. The motivation for this change are a11y requirements. There are scenarios where we must use the Escape key to close a dialog or a drop-down menu. Escape should only close the window if we are not navigating through modal content. ShouldCloseDialogOnEscape() returns true by default, so this doesn't affect existing clients. Bug: 1017385 Change-Id: I8e4402749532f7349c7e151eb04b1f4cb88f8653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877088 Commit-Queue: Dan S <danan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dan S <danan@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#722488}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 014afcc4. With Chromium commits locally applied on WPT: 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" 85b61e6b "[resource-timing] Ensure workerStart is protected by TAO" a75430aa "Fix appcache tests." a50e7e60 "Move `Sec-Fetch-User` to SetSecFetchMetadataHeaders." 83e4a43b "Refactor VRPose to fit better with WebXr concepts" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/IndexedDB NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I1ade7796619025ca96b7b8e619ee2faf6694e8b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953390Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722487}
-
Charlie Hu authored
The issue of allow/sandbox attribute timing originates from bug crbug.com/972089. The initial fix to that bug only deals with feature policy replication problem on renderer side. This CL adds a wpt test that targets a feature(camera) that is tested on browser side. A test on similar issue with sandbox attribute is added as well but as tentative. On browser-side: Frame policy value is captured at RenderFrameHostImpl::BeginNavigation, and travel through the whole navigation process in NavigationRequest::commit_params. Finally it will reach NavigatorImpl::DidNavigate which is called by RenderFrameHostImpl::DidCommitNavigationInternal. NavigatorImpl will then use the value captured from the beginning of navigation in commit_params to set the active frame policy instead of using currently pending frame policy, which could be further modified by the time the navigation commits. This CL also gets rid of separate handling of remote frame container policy in document.cc by capturing pending frame policy at NavigationControllerImpl:: CreateNavigationRequestFromLoadParams. Quick Example: 1. we start on frames A(B), where A applies frame_policy P1 to B. 2. A changes policy to P2. 3. B starts navigation to C. 4. A changes policy to P3. 5. Navigation to C commits. 6. C navigates to D and commits. Previously, we would have committed with policy P3 in both steps 5 and 6. Now, we'll commit with P2 in step 5, and P3 in step 6. Bug: 1012786, 972089, 1026627 Change-Id: Ib944ee204ca82e1ede6052ca58187fe97f0aab00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852905Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#722486}
-
Caleb Rouleau authored
Note that this will cause some of the stories of the system_health.memory_mobile benchmark to stop being run on nexus5x bot. It will also move some stories from one physical machine to another of the same model. Since the silicon lottery principle means that devices of the same model sometimes have different performance characteristics this may cause false positive improvements or regressions do not revert this change if those regressions happen. Note even though bot_platforms.py can do automatic resharding, I decided to do the resharding manually to avoid shuffling unrelated benchmarks and because it seems that the sharding system is for some reason expecting system_health.memory_mobile to run faster than it already does (which is likely because that benchmark has a rather long metrics calculation phase, which I suspect is not covered in the timing data.) I ran ./run_benchmark list system_health.memory_mobile --browser=android --json=~/listed.json to figure out that there are 28 stories in system_health.memory_mobile with the health check tag, so that's how I know how to manually reshard. Bug: 1030788 Change-Id: I0735adc781c860a1dbbbbc3608e740e34f5f48ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954354Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#722485}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c347585927b2..1518fd34d888 git log c347585927b2..1518fd34d888 --date=short --first-parent --format='%ad %ae %s' 2019-12-06 ivoc@webrtc.org Add support for setting a custom NetEqFactory in PeerConnection level tests. 2019-12-06 hofbauer@webrtc.org Expose methods to validate and merge FieldTrial strings. Created with: gclient setdep -r src/third_party/webrtc@1518fd34d888 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Id6719bb8c026063d5c0a8d78c5af74b0c1d9ec0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955648Reviewed-by:
-
Dominic Battre authored
Change-Id: I37607523487c0c8b06e7ecdcf0b623512bd47201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954015 Auto-Submit: Dominic Battré <battre@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#722483}
-
Kramer Ge authored
context_group_ has a memory tracker, which can be constructed if not on webview. Change-Id: I89fee9e7f96a5503a4db4b838c45a64c066fc6e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951579Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#722482}
-
Yuki Shiino authored
The old implementation counted the number of "unique scope chains". This patch counts the number of "unique direct child scopes" which makes more sense to decide where a symbol definition should be inserted. Bug: 839389 Change-Id: I04eb2c2179fb8b95a97f1e85068dee9c4b4fa1d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955249Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#722481}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7118a76a9b59..d45b969a0906 Created with: gclient setdep -r src-internal@d45b969a0906 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:657076 Tbr: jbudorick@google.com Change-Id: I6a49fdcc49dab241703f56323814ff4a182743a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955650Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722480}
-
Yann Dago authored
Bug: 1030787 Change-Id: I54f6686cd01799d26f258ea3224ed4b5358401f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951483Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#722479}
-
Samuel Huang authored
resource_ids seems to have been corruped in https://chromium-review.googlesource.com/c/chromium/src/+/1931102 and causes update_resource_ids to fail. This CL manually fixes the problem, then calls update_resource_ids to update numeric ranges. Change-Id: I45fd22dd8da5117c33f76a5a6c451af7f35dfd8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954880Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#722478}
-
Yuki Shiino authored
Makes bind_gen/interface.py use code_node_cxx.py. Bug: 839389 Change-Id: Ibae38811ba9817b10a0ea2edf2d1183df5242efe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950723 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: If8327a53b27def616b0c81f033c9e92796facd6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955645Reviewed-by:
-
Peng Huang authored
Bug: 1029066 Change-Id: Ib9379b4b9db880a87b0b66ffa7e6473a3dc05a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953575Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#722475}
-
Ella Ge authored
The test was disabled due to crash on asan bot. The issue was fixed. enable the test. Bug: 1030589 Change-Id: I89e34c32f406e4bb1cfa31436cdf5924ab2e0169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955172Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#722474}
-
Yuki Shiino authored
Implements Cxx<X>Node family based on CompositeNode. Bug: 839389 Change-Id: I048ef15239111248bb37d3b58b10d4c0c5c997a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952784Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a14bec084302..ee780985a9cd git log a14bec084302..ee780985a9cd --date=short --first-parent --format='%ad %ae %s' 2019-12-06 lalitm@google.com Merge "trace_processor: migrate counter table to new database tables" 2019-12-06 lalitm@google.com Merge "trace_processor: correctly propogate empty messages" 2019-12-06 treehugger-gerrit@google.com Merge "trace_processor: rewrite span join to be clearer" Created with: gclient setdep -r src/third_party/perfetto@ee780985a9cd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Iaebf6828ba68b2b79d17fd1884f4c318a98accb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955646Reviewed-by:
-
Saman Sami authored
In my previous CL, I updated the name in histograms.xml but I forgot to actually change the code. Change-Id: Ie7eb42a0303d9c98d46a2a1dff126dfd498a719f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954300 Auto-Submit: Saman Sami <samans@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#722471}
-
Fredrik Söderquist authored
When vector-effect=non-scaling-stroke applies to an element we need to adjust the stroke width used to compute the local coordinate space for a marker with markerUnits=strokeWidth. Remove our old (pixel)test in favor of two new WPTs. Fixed: 1031203 Change-Id: I569fadca7806d9bef03c5407a2a6ff5d0ca4faef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955586Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#722470}
-
Mihai Sardarescu authored
We are in the process to migrate from using email as the account identifier to using the Gaia ID of the account. This CL changes the AccoutnManagerMigrator to support this migration. Bug: 1028512 Change-Id: I2c8ddc53e524d3d04a11c6e10ca7a24ae99f5590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954467 Auto-Submit: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#722469}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/06f8a9063b3b..7118a76a9b59 Created with: gclient setdep -r src-internal@7118a76a9b59 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ibd90b2973dd8e1ac48d4456687494a418eac4fd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955478Reviewed-by:
-
Adam Kallai authored
Affected tests are RotatedFilter, RotatedShadowFitler from LayerTreeHostFilterPixelTest and RotatedClippedCircle, RotatedClippedCircleUnderflow from LayerTreeHostMaskAsBlendingPixelTest. These tests show some pixels difference on Windows on ARM64. Bug: 1029728, 1029729, 1030244 Change-Id: I738749370c5bcae71fe2bd530872ee2af3633c27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947728Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#722467}
-
Antonio Gomes authored
This way we are avoid raw pointers referencing to it (see rtc_peer_connection_handler.cc|h). BUG=787254 R=guidou@chromium.org Change-Id: I0b3375336c6051d6ac21776335ae325a849a3d7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944370 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#722466}
-
Daniel Cheng authored
base::Hash() is deprecated and is being replaced by base::FastHash(). The output of base::FastHash() is only fixed within the lifetime of a single process, so if the code depends on the mapping of inputs to hash outputs not changing over time, base::PersistentHash() must be used instead. Bug: 1025358 Change-Id: I1b1a46ce59260bb0c9f41a32f8e96f88ff8bf260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954454 Auto-Submit: Daniel Cheng <dcheng@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
This CL replaces the favicon service that tried to fetch icons natively in favor of the LargeIconBridge which provides higher quality icons if available and simplifies creating fallbacks for non-existent or low- resolution icons. This causes favicons to be in line with what NTP and history use and improves contrast in dark mode (since the black globe is gone). In order to do that, the accessory sheet data changed in: * always having an origin for a password * using a IsPslMatch indicating whether the icon is a PSL match Screenshots are in the linked bug. Bug: 1028590 Change-Id: If27065e5695ae4514465d26f668c5315d8faaea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953823Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#722464}
-
ckitagawa authored
This CL serves to enable the ability to capture paint previews of the main frame. Support for OOP subframe capture is not yet available. The code for this CL is behind the buildflag ENABLE_PAINT_PREVIEW to avoid a moderate binary size regression until the remainder of the feature is ready. The buildflag is setup such that tests will still run on all bots not doing official builds. Bug: 1014955 Change-Id: Ic16cad5a8a72af84033f00847ce2ed58e77d36d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952392Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#722463}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/15a09a9cfafc..a14bec084302 git log 15a09a9cfafc..a14bec084302 --date=short --first-parent --format='%ad %ae %s' 2019-12-06 hjd@google.com Merge "Reland: Reland: Add statsd logging to perfetto_cmd" Created with: gclient setdep -r src/third_party/perfetto@a14bec084302 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I23832342415935c4251eff072e194e475a701175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955476Reviewed-by:
-
Jan Wilken Dörrie authored
This change adds an entry for Biometric Touch To Fill to password_manager::features and exposes it to Android. Bug: 1031483 Change-Id: If4d558590f39fc1ab8b96d2a88427c52edae5743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954473Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8701dc4489e9..629b743dd803 git log 8701dc4489e9..629b743dd803 --date=short --first-parent --format='%ad %ae %s' 2019-12-06 swiftshader.regress@gmail.com Regres: Update test lists @ b9f03f47 Created with: gclient setdep -r src/third_party/swiftshader@629b743dd803 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I26f80d291be3efd33a03285089d23dde356cd604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955475Reviewed-by:
-
Roman Sorokin authored
Temp solution to get rid of flickering. Fixed: 1016259 Change-Id: Ic8da146fa235537c64f31d3cfafa1e69752a3b73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953106Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#722459}
-
