GitLab

"...NintendoDataFetcher"

This is a reland of 6edcc8d4

Original change's description:
> In NintendoDataFetcher::GetGamepadData we call GetPadState to
> get a pointer to an unused PadState slot. This pointer may be
> null if there are no more unused slots (Chrome supports at most
> four connected gamepads).
>
> This CL adds a null check so we don't try to dereference the
> null PadState and crash.
>
> BUG=996052
>
> Change-Id: I48cb1611b1c557e5eaa1a5791bf68d5acf8841ad
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762603
> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
> Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#689709}

BUG=996052

Change-Id: I499f223063c6889ec996c10890c5bd47e3260540
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769413Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691817}

Change-Id: I40958c0e0effa107414e0ef3677cc5c46e075173
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775114
Auto-Submit: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691816}

With SlimNavigationManager enabled, navigating back to a restore URL after a
cold launch DCHECKs because the webUI is not cleared.

Bug: 996221
Change-Id: I2c754f2e95dd6fad3cb7861eaff275602154671d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773700Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691815}

GetOrCreate(LayoutObject*) can return nullptr if the node is an area
element. Added null check.

Bug: 996451
Change-Id: Id94b88dcdd521b98abdc24cd17e907801b79ae7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774828Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Jacques Newman <janewman@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#691814}

Following https://crrev.com/c/1748123, we stopped picking up the
preferenceTheme attribute on v26+, causing incorrect styling. This
change fixes that, and slightly reorganizes the Preference themes into
base styles to avoid some repetition.

Bug: 860848
Change-Id: Ib6b3b0b4394f483ef219deb2b8b1d9c63622b258
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774315Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691813}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/8aaeffd8edef..d28bb6a6a5c4

git log 8aaeffd8edef..d28bb6a6a5c4 --date=short --no-merges --format='%ad %ae %s'
2019-08-29 zamorzaev@chromium.org cbuildbot: Add legacy-suite to RunSkylabHWTestPlan
2019-08-29 chrome-bot@chromium.org Update config settings by config-updater.

Created with:
  gclient setdep -r src/third_party/chromite@d28bb6a6a5c4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I86dd18f5b9f4bb0d24e7ce70d7588a9b962ea190
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776585Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#691812}

https://chromium.googlesource.com/catapult.git/+log/43bcbe51555d..8a6f1eb1b962

git log 43bcbe51555d..8a6f1eb1b962 --date=short --no-merges --format='%ad %ae %s'
2019-08-29 simonhatch@chromium.org Pinpoint - Replace special characters in story filter
2019-08-29 bsheedy@chromium.org Reland "Reland "Support minidump symbolization on ChromeOS""

Created with:
  gclient setdep -r src/third_party/catapult@8a6f1eb1b962

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC skyostil@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=skyostil@google.com

Bug: chromium:997227,chromium:978952
Change-Id: Id47e2b7be3e83ade538d39d5399b840f24b8d3d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776709Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#691811}

If the client drops the notification data and pass a nullptr to the
callback before showing the notification. We should gracefully handle
that and don't show or track the notification.

Bug: 963288
Change-Id: If80dcde8578e4567f04c0ce44d3c22833e0055cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773354Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691810}

Subdirs are added to profile dir over time. Subdirs such as
"Storage" could contains many files and are not critical to
bring up chrome. It could make profile flushing take a longer
time and stuck during shutdown. This CL changes to only
flush files directly under profile dir.

Bug: 998677
Change-Id: I5cf3e858c4f60ee6c9b4983431533bc9a07854ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776782Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691809}

Create new classes of WebauthnOfferDialog (view, controller, delegate).

Reusing AuthenticatorRequestSheetView for the detailed contents in
the dialog as required.
Mock: https://docs.google.com/presentation/d/16gfVy4EJ0hPibnOWZ8pqMF09Uy6uCWW2mCd1et9ILDw/edit#slide=id.g5dd211cc3b_0_67

This change is protected by experiment flag
kAutofillCreditCardAuthentication that if flag is disabled, the |
offer_fido_opt_in| in CreditCardAccessManager will always be false.

Browser tests will be added once the flow is complete and testable. This
is a base CL introducing the dialog.

Bug: 991037
Change-Id: Ie496b71c353cc20751adc290a5c83a82fa358cab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769531
Commit-Queue: Siyu An <siyua@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#691808}

HTML tag doesn't need background color as background color is applied
pn body.

theme.css adds background color to local_ntp HTML tag from theme
properties but doesn't get updated on theme change which results in
funky effects described in the bug.

Bug: 998482
Change-Id: Idbb6c7df15af029fdaa9e229ffa4889ce1ee02e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775189
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691807}

The Xbox Wireless Controller behaves like an XInput gamepad over
USB but like a HID gamepad over Bluetooth. Chrome supports this
gamepad in both modes, but previously vibration was only available
in USB mode. This CL adds support for vibration in Bluetooth mode.

BUG=984155

Change-Id: I634149f445560b8275361fbdddcd6b8c0a656de9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755057Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691806}

(Trivial; it just bothered me when I saw it.)

Change-Id: I21796eb6c6a4fe7b6bfa4d723f2a02e4715655aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775211Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691805}

crrev.com/c/1700356 introduced a regression that, when there's a
non-negative <time> and <angle> CSS property whose value is a negative
math expression, the negative value isn't clamped to 0. In particular,
the old code before the regression uses DoubleValue(), which contains
clamping, while the new code after the regression doesn't have clamping.

So this patch adds back the clamping.

Bug: 999008
Change-Id: Ifdce020865788297b479a3d907a072b3e46b0962
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776403
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691804}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4d747ae4be07..b56e461a7ced


Created with:
  gclient setdep -r src-internal@b56e461a7ced

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:284015,chromium:None
Change-Id: I111345185ac6bdae413181e5e5b6db83d870dd41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776587Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#691803}

This changes Certificate Transparency to only be enforced
for official Chrome builds, disabling Certificate Transparency
for Chromium, as well as any Chromium-derived builds that are
not using the //src/content layer.

The motivations are captured within
//net/docs/certificate-transparency.md , and in particular,
"Supporting Certificate Transparency for Embedders". This
change ensures that Chromium-derived browsers (i.e. those that
take and customize //chrome rather than using //content), as
well as distro-customized Chromium distributions, do not
encounter connection errors due to relying upon an out-of-date
Certificate Transparency Log list.

This is temporary; future work will seek to enable a clearer
communication about the date at which the log list was based
on, as well as the ability to update out of band, which will
facilitate both Chromium distributors and those Chromium-derived
browsers that support the component updater.

TBR=pmarko@chromium.org

Bug: 973378
Change-Id: Ia72c88320ffba7582efdf4bcaf062174cca4ad16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774327Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691802}

Change-Id: I6ffa192ddfdbdae250e84dacb6f1d5d639addce8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776599
Auto-Submit: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691801}

Update tools/polymer/polymer.py so that files with content wrapped in:
(() => {
...
})()
are processed the same way as files with content wrapped in:
(function() {
...
})()

Also add a test.

Bug: 965770
Change-Id: I55e7e2bf76e243fbac100ac8e1368fe599df03df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775747Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691800}

https://skia.googlesource.com/skia.git/+log/3783375c4d41..e26413128902

git log 3783375c4d41..e26413128902 --date=short --no-merges --format='%ad %ae %s'
2019-08-29 senorblanco@chromium.org Dawn: Implement RenderPipeline caching (optimization).
2019-08-29 egdaniel@google.com Fix updating of current task index in GrResourceAllocator
2019-08-29 bsalomon@google.com Make GrSurfaceProxy derive from GrNonAtomicRef and remove GrIORefProxy.
2019-08-29 fmalita@chromium.org [skottie] Refactor/generalize text selector shape generators
2019-08-29 brianosman@google.com Move common particle code to an automatically-injected header
2019-08-29 senorblanco@chromium.org Dawn: submit all command buffers in a single call.

Created with:
  gclient setdep -r src/third_party/skia@e26413128902

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC stani@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=stani@google.com

Bug: chromium:996610
Change-Id: I1de2bea4464eaa35a2dbd114922bd4e89efe1f8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776590Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#691799}

Previously, having the caBLE transport in the list of transports was
special and indicated that a caBLE discovery should be created. Also,
unlike all over discoveries, the caBLE discovery was created in the
GetAssertion request handler, not the base class.

This change makes the caBLE transport no longer special because, in the
future, we'll want to create a caBLE discovery without the extension. It
also regularises the handling of the caBLE transport to match all other
transports. As a consequence, the caBLE discovery data becomes the
property of the FidoDiscoveryFactory and two tests become inapplicable
at the level at which they were being tested.

Change-Id: Ibcd758fa9304a7cb8a868b1bcf2c692c15f72221
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756951
Auto-Submit: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691798}

Rather than including the CDMs in the base install directory, move them
into subdirectories (e.g. Widevine would be located in
<installdir>/WidevineCdm/_platform_specific/linux_x64/libwidevinecdm.so).
This allows the LICENSE and manifest.json file to be bundled with Chrome
on Linux. Future CL's will use the manifest.json file to determine
the capabilities of the CDM (rather than having them hardcoded as they
are today).

In addition to the unittests below, ran EME browser_tests (both ECK
and Widevine) to check that the library can be loaded from it's new
directory, and built "installer" (although I don't know if whatever
package it creates is installable).

Bug: 971433
Test: CdmPath media_unittests pass
Change-Id: If87f97e3200341941438ccbcbb4a918b1e5d0b50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767596Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691797}

Bug: 839091
Change-Id: I50f4edc74be0cbb197ed26281744e0c85f46f322
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776227
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691796}

Bug: 975708

Change-Id: I01eebebbd0a049ac9f71ef119fe3763a25e0a122
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776679
Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691795}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I9bb41f6167702b8491b68dd87fa867b9255618ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775113Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#691794}

... to assure DevTools protocol callbacks are always invoked (and destroyed) on the
correct thread.

Change-Id: Ie94c67d754138161ba22192bb76891f4021ad280
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775501
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691793}

Prior to
https://chromium-review.googlesource.com/c/chromium/src/+/1706829,
PendingTask::delayed_run_time was set by SequenceManager for
non-delayed tasks when "set queue time for tasks" was enabled. The
jank histograms depend on that behavior, and have regressed since it
changed.

To ensure that we can track of the evolution of jank over time
and detect regressions, this CL restores the previous behavior of
setting PendingTask::delayed_run_time for non-delayed tasks when
"set queue time for tasks" is enabled. We could explore changing
that behavior in a separate CL.

Test: Launch Chrome on a fast machine. After 30 seconds, navigate
to chrome://histograms. The value recorded for
Browser.Responsiveness.JankyIntervalsPerThirtySeconds.Startup should
be equal or very close to zero.

Bug: 997203
Change-Id: I60649e9415579e62a2fe2206c8307ed7a4e66668
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775660Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691792}

https://dawn.googlesource.com/dawn.git/+log/18b2cb51d7b8..f018c05e44f0

git log 18b2cb51d7b8..f018c05e44f0 --date=short --no-merges --format='%ad %ae %s'
2019-08-29 rharrison@chromium.org Rolling 5 dependencies
2019-08-29 beaufort.francois@gmail.com Make vertex input descriptor optional

Created with:
  gclient setdep -r src/third_party/dawn@f018c05e44f0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
TBR=cwallez@google.com

Bug: None
Change-Id: I8c862e36917ef9ce1b099d8ae02cd37931d4626f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776584Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#691791}

This also renames kThirdPartyVPN -> kExtension and kArcVPN -> kArc

This is in preparation for merging vpn_list.mojom into
cros_network_config and using it in Ash and Settings.

Bug: 979314
Change-Id: I2a74156080d59a4ae2f757c8410e01036dedcd68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775319Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691790}

This changes MakeCredentialTask such that requests returned by
GetTouchRequest() get converted into a CTAP2 command if the
authenticator supports CTAP2.

Currently, all touch-only requests are downgraded to U2F. That breaks
with certain types of FIDO2 security keys that require a fingerprint
even for U2F operations, but seem to honor that an empty pinAuth
parameter implies getting a touch only (even if a fingerprint has been
set up).

Also change GetTouchRequest() to set the pinProtocol parameter. At least
the CTAP2.0 spec doesn't seem to provide any kind of guarantees for
pinAuth without pinProtocol (§5.1 only mentions the case of the supplied
pinProtocol being "unsupported" by the device). CTAP2.1 has an explicit
mention of the "empty pinAuthUvParam" case in 5.1, but doesn't mention
whether pinUvAuthProtocol should be set or not. Empirically, it doesn't
make a difference.

Tested on my collection of authenticators by doing the following:
 - reset
 - create() with uv=required (should collect a touch, then set a PIN if
     CTAP2; or collect the touch, then fail if U2F-only)
 - if CTAP2, create() uv=required again (should collect a touch, then
     prompt the PIN).

Bug: 998281
Change-Id: Ifaa96ef1ea8f12ee2791967d454cf0e78c438f4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773723
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691789}

screenshot:
https://screenshot.googleplex.com/9q3asZAtYiH.png

Bug: 998460
Change-Id: I021aa83013cce477564de5205ce9339172518728
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775056Reviewed-by: Kyle Milka <kmilka@chromium.org>
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691788}

The thread ServiceWorkerContextCore lives on (the "core thread") will
move from the IO thread to the UI thread when the ServiceWorkerOnUI
feature is enabled.

This CL makes Content Index aware of the core thread instead of assuming
the IO thread. This makes ContentIndex* browser_tests pass when the
feature is enabled.

Bug: 824858
Change-Id: I03e81a564b27ee888a3402fdff11d8b51f3489a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775882Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691787}

- Opens a new tab to chrome://settings/ClearBrowserData when clicking
"Browser Data" in OS-Settings > Device > Storage.

Bug: 998012
Change-Id: I0dd740b08725d8befbef9bd1c1aa5b6b0f0b6814
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775207
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Auto-Submit: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691786}

They are first converted with a script in
https://chromium-review.googlesource.com/c/chromium/src/+/1772308,
then checked, tested and modified manually.

Make layer list mode the default mode for LayerTreeHostCommonTest.

Tests still in layer tree mode are under
LayerTreeHostCommonTestWithLayerTree. Some tests can't be converted
into layer list mode because:
- They are testing features that for ui compositor;
- They are testing PropertyTreeBuilder; or

Also haven't converted tests that create layer tree in main-side,
and build property trees with the main-side PropertyTreeBuilder.

The tests still in layer tree mode using impl-side PropertyTreeBuilder
will be converted to use main-side PropertyTreeBuilder.

109 of 167 tests have been converted.

Bug: 994361
Change-Id: I04444c861c6f0e8aefa71b6cff2879b54429bc1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775746Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691785}

- Prevent race condition in CastAudioOutputStream to prevent
FillNextBuffer() from calling AudioSourceCallback::OnMoreData() after
AudioOutputStream::Close() is called.
- FillNextBuffer() will now acquire running_lock_ for the entirety of
its scope.
- CastAudioOutputStream::Close() will synchronously block on
running_lock_ until FillNextBuffer() has completed before setting
running_ to false and continuing its close sequence.
- Subsequent calls to FillNextBuffer() will early return without calling
AudioSourceCallback::OnMoreData().
- Add infrastructure in CastAudioOutputStream unittests to pause and
resume the audio thread.
- Add a test in CastAudioOutputStream unittests to ensure that a call to
Close() will synchronously prevent any further callbacks.

mutex synchronization is removed, race condition is difficult to
reproduce in real-world testing.

Bug: 138695782
Test: Builds, unit tests pass, new unit test passes and fails when the
Change-Id: I11cdd64c0987298ba3fc6a9090359bd2715e6f03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761483Reviewed-by: Olga Sharonova <olka@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Hari Nandagopal <hnandagopal@google.com>
Cr-Commit-Position: refs/heads/master@{#691784}

It's only called in unittests.

Bug: 992765

Change-Id: I1e5ef83618d089e4ff2d3571a7d26482d8e69974
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775807
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691783}

The AssistantStateProxy is only used by Assistant service now, move it
from Ash to Service and move pref related logics into the Proxy.

Bug: b/138679823
Test: Run existing tests
Change-Id: Ife1ded72321c5d0357870a57ffcd15d94b930655
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774833Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691782}

This reverts commit 0817d44b.

No changes other than rebasing. The issue with the original CL was fixed by
crrev.com/c/1775268 (verified locally running monochrome_public_bundle).

Original change's description:
 JNI refactor: @NativeMethods conversion (//chrome/android/features).

 To create this change:
   * cd chrome/android/features
   * base/android/jni_generator/jni_refactorer.py -R --nonstatic
   * base/android/jni_generator/jni_refactorer.py -R
   * Change the native side of VrShellDelegateJni#recordVrStartAction
     to not pass the Java object

TBR=agrieve@chromium.org

Binary-Size: More native methods now in base module. See bug/doc.
Bug: 929661
Change-Id: I3ce3404bee4516da68028d3946dc8bfc33b8a807
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775754
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691781}

This change fixes crbug/998959 by setting inSystemMenu_
to false when the system menu (i.e. the right-click
or context menu) is removed from the page.

Bug: 998959
Change-Id: I391b634217513247c4f4215f5a47ffb028886bc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775381Reviewed-by: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Commit-Queue: Sophie Yang <sophyang@google.com>
Cr-Commit-Position: refs/heads/master@{#691780}

Also remove support for Mac OS X 10.9, which is no longer supported.

Bug: 998881
Change-Id: I8aca9c7e43ec2555f4b19f77c94db8ecabb75f2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776218Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691779}

The option to schedule tasks at exact times will be added to the
BackgroundTaskScheduler. Because these types of tasks will be scheduled
with AlarmManager, additional information needs to be added to the
BackgroundTaskScheduler storage.

This CL makes the necessary changes to the Protocol Buffer that stores a
scheduled task.

Bug: 970160
Change-Id: Ica396c0fa3ec27b1ffe50f99d56e0f5c83ac38fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765850Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Commit-Queue: Ioana Stefan <ioanastefan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691778}