- 16 Jun, 2020 40 commits
-
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1592308721-1b82af9218c1227df371704a4e2d7009912d341c.profdata to chrome-mac-master-1592330368-995f9d40f9200b48ea66f14ee9d22a1bdedc987c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I5a278ec35ffc6768122a00b8fad3e0f241a90521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248447Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#778934}
-
Frank Liberato authored
This reverts commit 441c07ab. Reason for revert: may be causing test failures on: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests/26119 Change-Id: I34333c1edd483f33e8cd82f23506c91908b7f62b TBR: tsepez,beccahughes,steimel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248128Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#778933}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I5423eaa2b1cce8ea0db2ebee5ab7afd7d2c4c0e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247088Reviewed-by:
-
Mugdha Lakhani authored
These are modified from chrome/browser/prefetch/prefetch_browsertest.cc to pick the tests applicable to WebLayer and use WebLayer-specific set-up. Bug: 1057771 Change-Id: I7771854d981e2892406f497c191b2ac606cdf516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241536Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#778931}
-
Andrew Xu authored
ShelfConfig::app_icon_group_margin_ is the smallest distance between hotseat and other shelf components (such as status area widget). Currently, this margin is set inside scrollable shelf view through |base_padding_insets_|. It complicates the code. This CL ensures that the gap between shelf components is set correctly by ShelfLayoutManager. The code related to Scrollable- ShelfView::|base_padding_insets_| is erased and ScrollableShelfView:: |extra_padding_insets_| is renamed. Bug: 1095678 Change-Id: I24d285a0e405f21788628a148f6f67fc8505d8c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245659 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#778930}
-
Yue Zhang authored
When conditional tab strip is enabled, the length of the current tab card is smaller than other cards. This is because that when the entering animation is created, the code thinks the bottom control is still showing. However, bottom control is later hidden when OverviewModeObserver#onOverviewModeStartedShowing signal is dispatched. Without adjusting any existing call ordering, this CL fixes this issue by adding a feature-specific fix which hard-codes the assumption that the bottom control will eventually be hidden when entering stack tab switcher for conditional tab strip. Bug: 1092316 Change-Id: I7b0df80ef7741ffeca23e81ced6d99341ee477b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246738Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#778929}
-
Sam Bowen authored
Bug: 1064751 Change-Id: If9b53316c9ad4c92f7fa6f44ce8d785b039a390c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241947Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Sam Bowen <sgbowen@google.com> Cr-Commit-Position: refs/heads/master@{#778928}
-
Daniel Nicoara authored
aura::Window defines the root window as the window that has a WindowTreeHost associated with it. Since this gets the window from WindowTreeHost, it is getting the root window. Calling GetRootWindow() on the root window will return the same window. Bug: None Test: Ran cast_graphics_unittests Change-Id: If2ec69710fa94e6f0ac44342f51ea89e47c414bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248158Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#778927}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ic34496375f6deba180de886fdbb24bb516951107 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248539Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#778926}
-
Sven Zheng authored
Adds an ignore=1 key/value pair to the JSON uploaded as part of the gtest-based pixel tests. This will cause the results to be ignored in Gold, which has the effect of preventing new images from triggering automated comments on CLs. Bug: 1081962 Change-Id: Ic9341bf8a3bfe9f4011036f46f5ac66b84f5f9ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242251 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#778925}
-
Bruce Dawson authored
This change updates the toolchain package used to build Chromium with the 10.0.19041.0 (2020-04) SDK and VS 16.6.1. The d3dcompiler_47.dll DLLs for x86 and x64 were swapped out for the 10.0.17134 versions (as usual). The Debuggers directory was not swapped out this time because the problem with loading dbghelp.dll on Windows 7 (https://crbug.com/1021650) has been resolved. The output for the cdb copy step was updated because one additional UCRT DLL is now copied. Packaging was done on a Windows Server 2019 VM, cleanly created for this purpose. The package was created by downloading the VS Professional 2019 installer from https://visualstudio.microsoft.com/downloads/ (free trial, not preview) and then running the installer like this: $ PATH_TO_INSTALLER.EXE ^ --add Microsoft.VisualStudio.Workload.NativeDesktop ^ --add Microsoft.VisualStudio.Component.VC.ATLMFC ^ --add Microsoft.VisualStudio.Component.VC.Tools.ARM64 ^ --add Microsoft.VisualStudio.Component.VC.MFC.ARM64 ^ --includeRecommended --passive Then the latest Windows 10 SDK was downloaded and installed from https://developer.microsoft.com/en-us/windows/downloads/windows-10-sdk/ Then the packaging script was run like this: python3 depot_tools\win_toolchain\package_from_installed.py 2019 -w 10.0.19041.0 Since the new d3dcompiler_47.dll uses the UCRT and we want to avoid shipping that (https://crbug.com/920704) the final packaging step was to unzip the package, copy over the two copies of that DLL from the previous toolchain's win_sdk\Redist, and then repackage the toolchain with: > python3 package_from_installed.py --repackage=<full-path-to-toolchain-dir> UWP and ARM64 support and Python 3 compatibility were previously added to package_from_installed.py. Future changes will require the new SDK, but for now the previous SDK can also be used to build Chromium. The failures on the win*msvc* bots are unrelated. This was proven by creating crrev.com/c/2245914 which is a NOP toolchain test. The existing toolchain was repackaged with a single text file added and that caused identical failures. Bug: 920704, 1014701, 10216507, 1089996 Change-Id: Ie496354582458aa8c1292ed4ef63d949ee2eb15d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225224 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#778924}
-
Garrett Beaty authored
The overview consoles currently appear in the middle of the console list mixed in with all of the per-master consoles. This will change it so that consoles that specify a title will be sorted before consoles that do not specify a title, which will move the overview consoles to the top since they specify a title and the per-master consoles do not. Change-Id: I5bd4d872f4edf435ab8af70946da9d96e51ce8aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242232Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#778923}
-
Francois Beaufort authored
This CL simply adds a boolean pan_tilt_zoom_supported to VideoInputDeviceCapabilities that will be used in an upcoming CL in getUserMedia constraints processing. Change-Id: I5b271eefea52d6c9293476d15a0c102342f4bb9d Bug: 934063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245900Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#778922}
-
Callum May authored
The SQLitePersistentReportingAndNelStore recovery logic for DoMigrateDatabaseSchema() won't recover the db if there's corruption in the metadata table. The base::nullopt return value prevents the db recovery. Remove that check and add a test for it. Bug: 1093598 Change-Id: I1030acc1978e6e6a75e3673c870e4268a8627da9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242167 Commit-Queue: Callum May <camay@microsoft.com> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#778921}
-
Rakib M. Hasan authored
Bug: 1050760, 1050754 Change-Id: I55ef2d830bb2b02936ce0f44912fe563d71551d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247148Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#778920}
-
Frank Liberato authored
This reverts commit aa42f61e. Reason for revert: may be causing failures in: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/6294 http/tests/devtools/layers/no-overlay-layers.js http/tests/inspector-protocol/overlay/overlay-setshowhinge.js TBR=caseq,petermarshall,mathias,alexrudenko Change-Id: Id25ef930195dfe2b9b8103bf2620c9e7bf005a87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245883 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
-
Wan-Teh Chang authored
Have blink::AVIFImageDecoder pass premultiply_alpha to premultiply_alpha input parameter was added to ConvertVideoFrameToRGBPixel() in commit 61813e65, default to true: media: :PaintCanvasVideoRenderer::ConvertVideoFrameToRGBPixel(). The https: //crrev.com/c/2243866 Change-Id: Ie273d67bcc940513983b5318ad9542f10c2d4b92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247556Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#778918}
-
Sharon Yang authored
CreateViewWithViewRef was added to the ViewProvider FIDL. Update the two implementations in Chrome Fuchsia, WebComponent and CastComponent, to include this function. Test: CQ Bug: 1078935 Change-Id: Ia341675da6729f1c5d2a8984a9692cb463b15385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210975 Commit-Queue: Sharon Yang <yangsharon@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#778917}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ca72cad60197..4569f66309b6 2020-06-16 bsalomon@google.com Remove coverage-as-alpha flag from GrAlphaThresholdFP If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: djsollen@google.com Change-Id: I83d7e9027150ae886a868076583e2f6a989d32b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248036Reviewed-by:
-
Devlin Cronin authored
If extension APIs get arguments that they don't think should be possible from a renderer, the renderer will be killed for sending a bad message (this is WAI). The [browserAction|pageAction].setIcon() API has been killing renderers for sending invalid data. Some early metrics added indicate that this happens when the arguments passed include neither an iconIndex nor imageData key (which theoretically shouldn't happen). After some investigation, it seems this *could* happen if there are some tricky getters or settings on the Object prototype, which would prevent us from construction an object with the proper values. Defend against this by using a gin::DataObjectBuilder in the renderer (which uses v8::Object::CreateDataProperty() internally, which doesn't hit the Object prototype), as well as assigning a null prototype to the resulting arguments. Also add a regression test. Bug: 1087948 Change-Id: I45d34024f8f3066eb547b974d564c1e41f064993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246836Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#778915}
-
Javier Ernesto Flores Robles authored
Add a11y label to the ConfirmationAlertViewController help button. Merge after: https://chromium-review.googlesource.com/c/chromium/src/+/2241999 Bug: N/A Change-Id: I5387d0cc732aee368c91d612ba3b2a6fab8e1bf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241972Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#778914}
-
Bailey Berro authored
This change creates a new pref, prefs::kAudioDevicesGainPercent, to store the gain values for each of a user's input devices. A new pref is created because the default value for input gain was changed to 50 rather than 75, and any users of mic gain before the switch will have the old value stored in prefs rather than the new one. Bug: b:158677629 Change-Id: I536b375dba02c00fa021688be09881eb59a81adf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246231 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Hsinyu Chao <hychao@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#778913}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9d178021d3b7..fbbd9ca81f96 2020-06-16 sadrul@chromium.org rendering: Fix alerts for dropped frames. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1095186 Tbr: eseckler@google.com Change-Id: I48cdc33e46650e4d9b1a627566a7d0f3ce978a26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248440Reviewed-by:
-
Andrew Grieve authored
Bug: None Change-Id: Iede91c33f4a17e8451b4977e95047f56675fb824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245050 Commit-Queue: Gang Wu <gangwu@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#778911}
-
Darwin Huang authored
Sqlite is using v3.32.1 now. Change-Id: I2a0aece45733c23482cc2cf597bf9f9031e06a87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247172Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#778910}
-
Mikhail Khokhlov authored
Adds a simple TBMv3 metric with power estimation based on CPU usage for comparison with power rails metric. Bug: b/155073796 Change-Id: I61a6ee52280a4c6542fee1f9f26cb67760f9f87a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247025 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#778909}
-
Sergey Ulanov authored
Previously SkiaOutputDeviceBufferQueue has dependency on gl::GLSurface. That made it impossible to reuse that class on platforms that don't have native GL implementation, particularly Fuchsia. Added a new interface OutputPresenter that abstracts display buffer allocation and presentation. OutputPresenterGL implements that interface on top of GLSurface. Fuchsia will use a different implementation. Bug: 1090447 Change-Id: Ib92916319af670906514a3a5ad0033e84bd4ad06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236232Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#778908}
-
Anastasia Helfinstein authored
Currently, when a secondary color is used with a dashed focus ring, it is hard to see, because its width is split across both sides of the primary color. This change increases the width on either side to increase visibility. AX-Relnotes: n/a. Bug: 1094069 Change-Id: If68505b4f374c3e0af0f09c8c7649d819edc7126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244192Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#778907}
-
zhaoyangli authored
Built a special EG2 host app target with the test application delegate. Adapted chrome_test_case test filtering logic to EG2. Created the EG2 suite. Bug: 1093981 Change-Id: Ie210dd9ad55c1e3cda57ef25e43c4f0bd7d35277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243583Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#778906}
-
Jordan Bayles authored
This patch includes several cleanups of the mirroring service. TBR=mfoltz@chromium.org Bug: 1015458, 1002603 Change-Id: I5df1a99694b17641388ecf6387805e24058c6fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240907 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#778905}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 29 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2020-12-13. TBR=chromium-metrics-reviews@google.com Change-Id: I44077a33d243d6340f2b41e88eb689f15c1e69d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248378Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#778904}
-
Clark DuVall authored
The popup blocked infobar uses the ConfirmInfoBar, so we will need the equivalent functionality in WebLayer. Since ConfirmInfoBar inherits from InfoBar which was forked in http://crrev.com/c/2224869, we also need to fork ConfirmInfoBar. The layout for non-compact infobars was componentized in http://crrev.com/c/2243579 and can be used between both Chrome and WebLayer. The initial patchset here has a clean copy of the Chrome files, and the subsequent patchsets have changes for WebLayer. Bug: 1019922 Change-Id: I76e093e6113c26990dd1041ac4c901690489bad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248538Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f88dd4d00256..103a73ea1ff1 2020-06-16 mbonadei@webrtc.org Remove unneeded GN import. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I8fbbf4c08dabbfeb50442d3e7448338df86f441d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248030Reviewed-by:
-
Mohamed Heikal authored
TBR=martiniss@chromium.org Change-Id: I4c3cf635944dfbded42c6cc2851dcbb8ad8e3ec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248123Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#778901}
-
Lei Zhang authored
- Use early returns in HandleGetPasswordCompleteMessage(). - Consolidate some checks in HandleResetPrintPreviewModeMessage(). - Change SetTwoUpView() to HandleSetTwoUpViewMessage() and consistently validate the message like other handlers. Also mark this message handler private. - Make comment style consistent through out the file. Change-Id: Ie437086adf83015f90858a864e1acdb9e826bf34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242853 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#778900}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592297885-4df3e1395ccce5fa6318db5c6c03cffe6093fff6.profdata to chrome-win32-master-1592318647-7dde799a5671d21565d3d7d630fb811f29f03533.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I76b8587dabbac4c3df0030432b00723744073343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248034Reviewed-by:
-
Sebastien Lalancette authored
Adding histograms for Sharing scenarios and actions. The first histogram "Mobile.Share.EntryPoints" is used to view at an aggregate level what type of sharing occurs the most in Chrome, and the other per-entry-point histograms (two right now) show which actions are used the most per scenario. Googlers may visit go/bling-share-metrics-revamp for more details. Change-Id: Iee0c58dadc9daf20a8a5b410ca8bcb49bbbe6d01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225843 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#778898}
-
Roman Aleksandrov authored
Bug: 1093879 Change-Id: Ia12ff9a9d337bb9e425b5e5aa06e9d5bf5ecb352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247885Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#778897}
-
Mehran Mahmoudi authored
This fixes a problem where paint preview player view was not displayed on Chrome startup. Bug: 2231179 Change-Id: If5bea69fcac0563ed1aeaf091e2caa1e45098106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246980 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#778896}
-
Robbie Gibson authored
Currently, part of the ios cookie blocking implementation relies on injected Javascript to block access to various Javascript data accessors (e.g. document.cookie). However, future WebKit changes could cause these overrides to fail. Failures should be tracked to alert us if cookie blocking starts to fail. Fixed: 1082151 Change-Id: I4dee8c8c5eab93981556d211ad8cbea33f9fdcfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246143 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#778895}
-
