GitLab

I wanted to wire up a WebPreferences modifying testRunner method, and XSSAuditorEnabled will make >100 tests pass

BUG=111316
TEST=most of http/tests/security/xssAuditor passes


Review URL: https://chromiumcodereview.appspot.com/11316244

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170439 0039d316-1c4b-4281-b951-d872f2087c98

BUG=36778
TEST=manual tests on Lumpy


Review URL: https://chromiumcodereview.appspot.com/11415201

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170438 0039d316-1c4b-4281-b951-d872f2087c98

This fixes the following issue:
- TestSharder.SetupSharding() in run_java_tests.py wasn't calling
  the super class' SetupSharding() method which kills host_forwarder. The call
  to Forwarder.KillHost() was moved to RunShardedTest() which isn't supposed to
  be overridden. This should be more robust.

Additionally in case '$ host_forwarder kill-server' failed for any reason,
Forwarder.KillHost() now falls back to pkill.

BUG=163036


Review URL: https://chromiumcodereview.appspot.com/11421149

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170437 0039d316-1c4b-4281-b951-d872f2087c98

On some platforms, we want to unschedule after a swap until the ack, but the
DeferDraws mechanism allows us to delay the unschedule until we actually need to
access the back buffer. Up to now, only commands that *write* to the framebuffer
were considered, however we also need to consider *reads*. This fixes that.

BUG=None


Review URL: https://chromiumcodereview.appspot.com/11412262

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170435 0039d316-1c4b-4281-b951-d872f2087c98

The pointer can be NULL when the detailed view creation
failed (SystemTrayBubble::UpdateView => !bubble_view_->has_children() => Close).

BUG=163518

Review URL: https://codereview.chromium.org/11428100

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170434 0039d316-1c4b-4281-b951-d872f2087c98

IBusConfigClient can not always initialize synchronously, because there is a case that the ibus-config daemon is not running.

BUG=158265
TEST=ran chromeos_unittests

Review URL: https://chromiumcodereview.appspot.com/11413165

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170432 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170431 0039d316-1c4b-4281-b951-d872f2087c98

BUG=157916

Review URL: https://chromiumcodereview.appspot.com/11299261

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170429 0039d316-1c4b-4281-b951-d872f2087c98

We fire update/change notifications to the observers attached to the FileSystemOperationContext, but the current code creates a new FileSystemOperation (and thus FileSystemOperationContext) for the source URL. This results in no update/change modifications in the destination filesystem in cross-filesystem operation cases.

BUG=163540
TEST=manual

Review URL: https://codereview.chromium.org/11316265

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170428 0039d316-1c4b-4281-b951-d872f2087c98

BUG=160939


Review URL: https://chromiumcodereview.appspot.com/11316133

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170427 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163548
TEST=n/a

Review URL: https://chromiumcodereview.appspot.com/11316266

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170426 0039d316-1c4b-4281-b951-d872f2087c98

Note: The link in the bubble takes you to the chrome://extensions page but does not highlight the extension you clicked on. 

BUG=153137
TBR=ben
TEST=Install an extension with a content script, such as Google Dictionary or Turn of the lights. You should see a puzzle piece in the Omnibox indicating how many content scripts are running on the page. Click the puzzle piece to see a list of extensions running the content scripts.


Review URL: https://chromiumcodereview.appspot.com/11348304

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170425 0039d316-1c4b-4281-b951-d872f2087c98

Based on the EME spec, init_data is optional in GenerateKeyRequest(). Update AesDecryptor to support this.

BUG=162759
TEST=added test in AesDecryptorTest to test this case.


Review URL: https://chromiumcodereview.appspot.com/11434025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170424 0039d316-1c4b-4281-b951-d872f2087c98

It's already included by base/gtest_prod_util.h

TBR=jam@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11428090

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170423 0039d316-1c4b-4281-b951-d872f2087c98

When --enable-encrypted-media is not set, NeedKey event should not be fired from media pipeline. Also, the decoder should declare decode error or unsupported error instead of waiting for decryptor to be set/initialized.

BUG=
TEST=tested EME test page with --enable-encrypted-media set and not set.


Review URL: https://chromiumcodereview.appspot.com/11414138

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170422 0039d316-1c4b-4281-b951-d872f2087c98

BUG=162571


Review URL: https://chromiumcodereview.appspot.com/11419243

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170421 0039d316-1c4b-4281-b951-d872f2087c98

LauncherModel.AddIndices is failing in the bots: http://build.chromium.org/p/chromium.win/builders/Win%20Aura/builds/24835/steps/ash_unittests/logs/stdio

BUG=160605
TEST=LauncherModel.AddIndices, LauncherViewTest.AddPanelHidesTabbedBrowser, LauncherViewTest.PanelsHideLast


Review URL: https://chromiumcodereview.appspot.com/11348201

TBR=flackr@chromium.org
Review URL: https://codereview.chromium.org/11299272

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170420 0039d316-1c4b-4281-b951-d872f2087c98

- Add and fix comments
- Make some members private
- Make some members const
- Move GetResponseHeadersAsString() to anonymous namespace

BUG=163544
TEST=none

Review URL: https://codereview.chromium.org/11421170

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170419 0039d316-1c4b-4281-b951-d872f2087c98

The smoothness benchmark mean frame times were off because they would attempt to smoothScrollBy to the scrollHeight, but you need to subtract the viewport height to get the correct scrolling distance. Because smoothScrollBy doesn't stop when you hit the bottom of the page, the duration of the scroll gesture was longer than it should be. This made the numbers worse for shorter pages.

BUG=162922
TEST=Run a smoothness_benchmark.

Review URL: https://codereview.chromium.org/11412266

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170418 0039d316-1c4b-4281-b951-d872f2087c98

This is a step to getting DMP running in Windows.

BUG=159993


Review URL: https://chromiumcodereview.appspot.com/11418237

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170417 0039d316-1c4b-4281-b951-d872f2087c98

TBR=wez@chromium.org

BUG=163542

Review URL: https://codereview.chromium.org/11411279

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170416 0039d316-1c4b-4281-b951-d872f2087c98

This makes the ChromeOS keyboard F<number> keys produce keycodes such as
BROWSER_BACK, VOLUME_UP, POWER, etc. We can then remove special-cases for
ChromeOS accelerator bindings, and allow the same bindings to work on all
platforms including ChromeOS. The ChromeOS keyboard, and external keyboards
with these extra keys will also rely on and fire the same bindings for these
keys, unifying the code path.

The other advantage of this, is that now ChromeOS does not need to bind
F<number> keys in a non-standard way. So, an external keyboard plugged
into a Chromebook can still use the F<number> keys in the same way as they
would when it was plugged into their desktop. This behaviour isn't yet
possible, as the event rewritter is not aware if the event came from the
ChromeOS keyboard or an external keyboard, but is a 1-line change once this
information is known.

Lastly, when the Search key acts as Function key option is enabled from
https://codereview.chromium.org/11421055/ then Search-1 through Search-0
produce the keycode F1 through F10, and Search-- and Search-= produce F11 and
F12. This allows applications to easily rely on these keys and consume them the
same way on desktop as on a Chromebook.

R=yusukes@chromium.org
BUG=162268
TEST=unit_tests:EventRewriter.TestRewriteFunctionKeys
Depends on: https://codereview.chromium.org/11421055/

Review URL: https://chromiumcodereview.appspot.com/11417144

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170415 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11414221

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170414 0039d316-1c4b-4281-b951-d872f2087c98

We record how long the rendering thread takes to render each PicturePile,
accumulate in TileManager, and report through LayerTreeHostImpl; telemetry
queries this information and dumps the output.

BUG=163324
R=reveman
TBR=enne

Review URL: https://codereview.chromium.org/11434033

Review URL: https://codereview.chromium.org/11418250

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170413 0039d316-1c4b-4281-b951-d872f2087c98

In practice, this particular call to FindTabbedBrowser will only happen for Ash-in-metro, so using the default host desktop type (as was done in http://crrev.com/168064) is guaranteed to be the wrong choice. Forcing HOST_DESKTOP_TYPE_ASH would be correct for this specific case, but using the currently active desktop (which will always be Ash) will also work and is more consistent with other places where a browser needs to be found.

BUG=129187
TBR=aa@chromium.org

Review URL: https://chromiumcodereview.appspot.com/11412151

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170412 0039d316-1c4b-4281-b951-d872f2087c98

This extends cc_perftests to run perf tests based on a json dump of a layer tree
with minimal code changes and adds a tree representing a tab switch UI with
two stacks of 10 layers each.

BUG=


Review URL: https://chromiumcodereview.appspot.com/11418235

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170411 0039d316-1c4b-4281-b951-d872f2087c98

To allow for easier testing.

BUG=7624

TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/11421169

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170410 0039d316-1c4b-4281-b951-d872f2087c98

This patch batches multiple calls to DrawQuad inside GlRenderer when the calls draw textured quads that have the same texture.  These quads differ only in transform for both position and UV.  This patch extends the vertex shader used for drawing textures to use one of 8 matrices and UV transforms.  By batching up to 8 DrawQuads into a single draw quad, we reduce the number of times many different OpenGL ES state calls are made.

The implementation maintains a cache of up to 8 quads that contain the same texture and drawing parameters (e.g. opacity).  If a 9th textured quad with the same parameters or a different kind of quad is drawn or any GL state (e.g. scissor rect) is changed or the new finishDrawingQuadList() function is called then the the quads are drawn in a single call and the cache is flushed.

BUG=161372

Review URL: https://chromiumcodereview.appspot.com/11415161

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170409 0039d316-1c4b-4281-b951-d872f2087c98

Adds a test for CreateProfileShortcutFlags() and another test for when
a second profile is created without shortcut, which verifies the first
profile's icon got renamed and badged (via icon).

Also, refactors RenameProfile() to a helper function and makes
ValidateProfileShortcutAtPath() check the icon that was set on the shortcut.

BUG=none
TEST=this adds some

Review URL: https://chromiumcodereview.appspot.com/11280240

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170408 0039d316-1c4b-4281-b951-d872f2087c98

R=jhawkins@chromium.org
BUG=158290
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/11418231

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170407 0039d316-1c4b-4281-b951-d872f2087c98

BUG=160605
TEST=LauncherModel.AddIndices, LauncherViewTest.AddPanelHidesTabbedBrowser, LauncherViewTest.PanelsHideLast


Review URL: https://chromiumcodereview.appspot.com/11348201

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170406 0039d316-1c4b-4281-b951-d872f2087c98

The parameter was not used.

BUG=163308
TEST=none

Review URL: https://codereview.chromium.org/11419248

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170405 0039d316-1c4b-4281-b951-d872f2087c98

BUG=


Review URL: https://chromiumcodereview.appspot.com/11418092

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170404 0039d316-1c4b-4281-b951-d872f2087c98

list, instead of passing the list of pointers around.

In ThreadProxy::beginFrame, we unlink all evicted textures, so that
the call to updateLayers will know to re-paint the evicted layers.

In ThreadProxy::scheduleActionCommit, we determine if we can draw now
by checking to see if there exist any linked evicted textures. If there
are none, we can draw what we are in the process of committing.

This assumes that once we get to m_layerTreeHost->willBeginFrame()
in ThreadProxy::beginFrame, the next frame to be commited by
ThreadProxy::scheduleActionCommit be at or after the frame that is
being produced by that call to ThreadProxy::beginFrame.

BUG=158747


Review URL: https://chromiumcodereview.appspot.com/11411251

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170403 0039d316-1c4b-4281-b951-d872f2087c98

The prior implementation did an entire inverse() operation when not needed.
The new version does much less computation taking advantage of assumptions to
shortcut the math.

BUG=163062


Review URL: https://chromiumcodereview.appspot.com/11411270

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170402 0039d316-1c4b-4281-b951-d872f2087c98

This gesture comes from the Android framework with a 150 ms delay already.
We don't need the deferral on gesture_event_filter.

BUG=162767


Review URL: https://chromiumcodereview.appspot.com/11414208

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170401 0039d316-1c4b-4281-b951-d872f2087c98

BUG=153137
TBR=sail@chromium.org

Review URL: https://codereview.chromium.org/11412267

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170400 0039d316-1c4b-4281-b951-d872f2087c98

AuthOperation was only used in auth_service, hence there is no need to have
this class in base_operations.h

Along the way, remove an unused function Authenticate() from OperationRunner,
and make some functions private there.

Remove AuthenticateStub from MockDriveService as well.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/11316262

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170399 0039d316-1c4b-4281-b951-d872f2087c98

Tests show that when pressing 'enter' key, content shell
and test shell only receive the action 'ACTION_DOWN'.

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/11299196

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170398 0039d316-1c4b-4281-b951-d872f2087c98

BUG=161158


Review URL: https://chromiumcodereview.appspot.com/11316231

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170397 0039d316-1c4b-4281-b951-d872f2087c98