GitLab

This CL renames VideoCaptureHostTest to VideoCaptureTest, since it
really is an integration test of a bunch of classes, as detailed in
the class-comments.  I've tried a few times to disentangle this
mess, in which VideoCaptureHost references MediaStreamManager knowing
that the latter is a singleton; MediaStreamManager publicly allows
everyone to access its VideoCaptureManager; VideoCaptureManager
is a concrete class owning pairs of VideoCaptureController -
VideoCaptureDevice; and VideoCaptureController uses via naked pointer
VideoCaptureHosts.  Not worth it for this unit test.

BUG=651897

Review-Url: https://chromiumcodereview.appspot.com/2435393003
Cr-Commit-Position: refs/heads/master@{#427001}

This patch fixes the timeline scrollbar offset for the canvas timeline
experiment.

R=dgozman
BUG=653738

Review-Url: https://chromiumcodereview.appspot.com/2438683004
Cr-Commit-Position: refs/heads/master@{#427000}

The enum definitions in our schemas can either be in the form of a list
value with string entries (e.g. "enum": ["foo", "bar", "baz"]) or in the
form of a dictionary with a name entry (e.g. "enum": [{"name": "foo"}]).

Adjust ArgumentSpec to account for the latter, and add tests.

BUG=653596

Review-Url: https://chromiumcodereview.appspot.com/2439263003
Cr-Commit-Position: refs/heads/master@{#426999}

Add zlib dependency in third_party/freetype2/BUILD.gn, as it is
already done in third_party/freetype-android/BUILD.gn to fix the
following compilation error:

  ../../src/third_party/freetype2/src/src/gzip/ftgzip.c:49:18: fatal
    error: zlib.h: No such file or directory

BUG=none

Review-Url: https://chromiumcodereview.appspot.com/2442733003
Cr-Commit-Position: refs/heads/master@{#426998}

The progression is seen in fast/text/ellipsis-at-edge-of-rtl-text-in-ltr-flow.html
and fast/css/text-overflow-input.html. We also now show an exta character of
text before the ellipsis where space is available.

BUG=650083

Review-Url: https://chromiumcodereview.appspot.com/2392433002
Cr-Commit-Position: refs/heads/master@{#426997}

Adds a new 'media_remoting' watchlist and cleans-up several miu@-owned
lists (due to file adds/moves/renames).

Review-Url: https://chromiumcodereview.appspot.com/2444693002
Cr-Commit-Position: refs/heads/master@{#426996}

Once the builder is added only the:
NGConstraintSpace(NGWritingMode, NGDirection, NGPhysicalConstraintSpace*)

should remain, this mirrors the NGFragment constructor which is just a "view"
on top of the NGPhysicalFragment.

This mirrors:
NGFragment(NGWritingMode, NGDirection, NGPhysicalFragment*)

BUG=635619

Review-Url: https://chromiumcodereview.appspot.com/2442123002
Cr-Commit-Position: refs/heads/master@{#426995}

With this CL, SequencedWorkerPool generates an event in the "toplevel"
category when it runs a task. This is the same behavior as MessageLoop,
TaskScheduler and WorkerPool.

BUG=611818

Review-Url: https://chromiumcodereview.appspot.com/2429863002
Cr-Commit-Position: refs/heads/master@{#426994}

BUG=648391

Review-Url: https://chromiumcodereview.appspot.com/2416293002
Cr-Commit-Position: refs/heads/master@{#426993}

Cr-Commit-Position: refs/heads/master@{#426992}

Revert of Move Layout Tree Construction code into Element::rebuildLayoutTree() (patchset #12 id:240001 of https://codereview.chromium.org/2398293003/ )

Reason for revert:
Suspected to cause crbug.com/658322.

Original issue's description:
> Move Layout Tree Construction code into Element::rebuildLayoutTree()
>
> This patch uses the two dirty bits (NeedsReattachLayoutTree and
> ChildNeedsReattachLayoutTree) on Node and adds the relevant
> getters/setters for them.
>
> It makes rebuildLayoutTree() public to be accessed in Document.cpp.
>
> It also moves reattachWhitespaceSiblingsIfNeeded() to rebuildLayoutTree() and
> uses dirtyBits to call either reattachLayoutTree() on node itself or call
> rebuildLayoutTree() on children nodes.
>
> Also added some comments explaining some design decisions. Will be removed
> upon completion of separation.
>
> BUG=595137
>
> Committed: https://crrev.com/09b7a8cf0647abca732b3718987a629d12a67fee
> Cr-Commit-Position: refs/heads/master@{#426353}

TBR=esprehn@chromium.org,bugsnash@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=595137

Review-Url: https://chromiumcodereview.appspot.com/2439973005
Cr-Commit-Position: refs/heads/master@{#426991}

Because of the cast of the RHS, |u|, a copy would be generated, with
code and cycle bloat as the result. In some cases this can even have
prevented inlining. Particularly nasty examples:

 bool compareEqual(const Vector<LengthPoint>&, const Vector<LengthPoint>&) [210 bytes]
 bool compareEqual(const Vector<CSSPropertyID>&, const Vector<CSSPropertyID>&) [274 bytes]
 bool compareEqual(const Vector<GridTrackSize>&, const Vector<GridTrackSize>&) [182 bytes]
 bool compareEqual(const HashMap<String, GridArea>&, const HashMap<String, GridArea>&) [308 bytes]
 bool compareEqual(const TransformOperations&, const TransformOperations&) [441 bytes]
 bool compareEqual(const LengthBox&, const LengthBox&) [249 bytes]

Remove the U->T cast in compareEqual to avoid the copies. Nothing seems
to require this coercion (anymore?) This eliminates the above symbols
entirely. A total binary size reduction of >30k (x86-64; non-official) also
indicates even the simpler cases/types may have benefited.

Review-Url: https://chromiumcodereview.appspot.com/2438353002
Cr-Commit-Position: refs/heads/master@{#426990}

We were storing the index in the DOM for the grid items
in m_gridItemsIndexesMap. However, we can already store the index
following the order-modified document order.

This allows us to simplify the sorter in painting,
as we don't need to check the order property now,
just simply use the stored index.

No new tests, as it's already covered by current tests.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://chromiumcodereview.appspot.com/2438253003
Cr-Commit-Position: refs/heads/master@{#426989}

Cr-Commit-Position: refs/heads/master@{#426988}

BUG=657438
R=pdr@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/2445463002
Cr-Commit-Position: refs/heads/master@{#426987}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/27ca97928854..6962f5c0344a

$ git log 27ca97928..6962f5c03 --date=short --no-merges --format='%ad %ae %s'
2016-10-21 benjhayden Add --html --json args to valueset2html.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/2439233003
Cr-Commit-Position: refs/heads/master@{#426986}

PVer4: Add UMA metrics for time taken to: load DB, do prefix check, and network time to do full hash check

SB2.DatabaseOpen: The time it takes to read, parse, and load the database from disk into memory.
SB2.FilterCheck: The time it takes to check the prefix hashes for a match. I tested a known phishing URL.
SB2.Network: The time it takes to get the full hash response from the server and parse it.

This is anecdotal, but I ran the two DB managers in parallel mode 5 times (5 different launches of Chrome) and got the following results:
+ SB2.DatabaseOpen is consistently faster for PVer4 by 59% (0.0919344s vs 0.0375474s). The PVer4 version is called: SafeBrowsing.V4DatabaseOpen.Time

+ SB2.FilterCheck is consistently faster for PVer4 by 30% (0.0093838s vs 0.00659247s). The PVer4 version is called: SafeBrowsing.V4GetPrefixMatches.Time

+ SB2.Network is consistently *slower* for PVer4 by 4.94% (0.2113358s vs 0.221783s). -- This slowness needs to be investigated but is somewhat acceptable since this is only used for 1/1000 hash checks. The PVer4 version is called: SafeBrowsing.V4GetHashNetwork.Time

Adding these metrics would allow us to do a more reasonable comparison.

BUG=543161

Review-Url: https://chromiumcodereview.appspot.com/2441923003
Cr-Commit-Position: refs/heads/master@{#426985}

In an effort to unify Mus+Ash and Chrome terminology, this CL replaces
all WindowSurface references with ui::(Server)WindowCompositorFrameSink.

This CL is a followup to https://codereview.chromium.org/2430653002/

BUG=656975
TBR=tsepez@chromium.org for renaming of methods in mojoms.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://chromiumcodereview.appspot.com/2429173005
Cr-Commit-Position: refs/heads/master@{#426984}

Modifies padding on top of collate box so that it does not cause a
flicker when it appears next to the new copies input field.

BUG=658400
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://chromiumcodereview.appspot.com/2442743003
Cr-Commit-Position: refs/heads/master@{#426983}

This patch adds support of left/right floats in LayoutNG code.

Things that are not supported yet:
 - top aligning floats
 - clearing
 - child blocks in the same formatting formatting context

BUG=635619
TEST=virtual/layout_ng/fast/block/float, NGBlockLayoutAlgorithmTest::PositionFloatFragments

Review-Url: https://chromiumcodereview.appspot.com/2435803005
Cr-Commit-Position: refs/heads/master@{#426982}

BUG=none

Review-Url: https://chromiumcodereview.appspot.com/2431373006
Cr-Commit-Position: refs/heads/master@{#426981}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/b7d8fe883c16..27ca97928854

$ git log b7d8fe883..27ca97928 --date=short --no-merges --format='%ad %ae %s'
2016-10-21 alexandermont Turn on eslint rule no-multi-spaces and fix existing errors.
2016-10-21 alexandermont Turn on eslint rule quotes and fix existing errors.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/2443673003
Cr-Commit-Position: refs/heads/master@{#426980}

This will give an estimate of the % of iframes that we can defer
loading.

We can defer offscreen frames unless they are probably used for
cross-origin communication.

Reland of https://codereview.chromium.org/2389023002

BUG=635105
TBR=isherman@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/2437193002
Cr-Commit-Position: refs/heads/master@{#426979}

NOTRY=true
BUG=657839
TEST=none
TBR=msarett

Review-Url: https://chromiumcodereview.appspot.com/2439183003
Cr-Commit-Position: refs/heads/master@{#426978}

When the debugger session in Visual Studio finished, the console window closed
by default. For console applications, such as unit tests, it is possible not to
close the console window immediately. This is controlled by the property
"SubSystem" on "Link" page in project settings. This patch set property
"SubSystem" in generated *.vcxproj file based on the "ldflags" field.

R=brettw@chromium.org
BUG=

Review-Url: https://chromiumcodereview.appspot.com/2428013002
Cr-Commit-Position: refs/heads/master@{#426977}

This CL removes period for some of the single line strings that are
used by WebBluetooth chooser on Android.

BUG=658097, 658093

Review-Url: https://chromiumcodereview.appspot.com/2440213002
Cr-Commit-Position: refs/heads/master@{#426976}

Inertness of a scroller can change without causing it to be laid out, if a
dialog is added or removed from Document::m_topLayerElements.  Checking
inertness in PLSA::updateScrollableAreaSet led to stale compositing state.

This patch updates PLSA to ignore inertness.  This means scrollers will remain
in FrameView::m_scrollableAreas even when covered by a dialog.  That should be
ok, since the ::backdrop element prevents them from actually receiving input.

BUG=633520
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://chromiumcodereview.appspot.com/2437303002
Cr-Commit-Position: refs/heads/master@{#426975}

https://pdfium.googlesource.com/pdfium.git/+log/5532835aeb88..3cad596c55cd

$ git log 5532835ae..3cad596c5 --date=short --no-merges --format='%ad %ae %s'
2016-10-21 npm Add CPDF_Document::GetPage() unittests
2016-10-21 tsepez Remove dead code in CPDF_CustomAccess

BUG=638513

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/2440263002
Cr-Commit-Position: refs/heads/master@{#426974}

This code is just copy pasta from v8, this patch copies a newer version
of the pasta.

https://chromium.googlesource.com/v8/v8/+/374a4da83e6f4e05d31640b23b5ca92f0bbf0586/src/strtod.cc#249

BUG=637044, 629034

Review-Url: https://chromiumcodereview.appspot.com/2438383003
Cr-Commit-Position: refs/heads/master@{#426973}

GPU rasterization has been disabled on this configuration.

BUG=653538
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=zmo@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/2442963002
Cr-Commit-Position: refs/heads/master@{#426972}

We'd like to get an idea of what MITM proxies tend to do with the TLS
Feature Extension (colloquially known as Must-Staple). If MITM proxies
blindly copy the extension into generated certificates, then deploying
Must-Staple will cause a lot of breakage, due to MITM proxies generating
Must-Staple certificates but not stapling OCSP responses.

This CL adds an UMA metric for the presence of the TLS Feature Extension
in certificates that chain to private roots, as a baby step in this
investigation. (Note that this conflates misbehaving MITM proxies with
private PKIs that are using Must-Staple, so it's only a starting point
for an investigation.)

A new asn1::HasTLSFeatureExtension() function is used to record this
histogram.

BUG=633732

Review-Url: https://chromiumcodereview.appspot.com/2436233002
Cr-Commit-Position: refs/heads/master@{#426971}

We no longer need this data and/or the historical data should be
sufficient if we need it in the future.

BUG=644396

Review-Url: https://chromiumcodereview.appspot.com/2447463002
Cr-Commit-Position: refs/heads/master@{#426970}

And clean up uses of this interface.

DidAbortSwapBuffers becomes DidLoseCompositorFrameSink. Android uses
this to tell the browser that it has no pending frames and can make
a new frame. Ash was using this to end crossfade maximize animations.
I've removed this and dropped "aborting" compositing from the Compositor
observer.

DidPostSwapBuffers becomes DidSubmitCompositorFrame which represents
itself better. RenderWidgetCompositor was telling RenderWidget about
this just to make a trace event, so deleted that.

DidReceiveCompositorFrameAck is duplicated in LayerTreeHostClient
and was not actually called on this interface anymore, so just deleted
it.

R=piman@chromium.org
TBR=sky
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://chromiumcodereview.appspot.com/2444563002
Cr-Commit-Position: refs/heads/master@{#426969}

https://chromium.googlesource.com/angle/angle.git/+log/336b147..f017315

BUG=chromium:657859,chromium:653454,chromium:653694,chromium:656485
TEST=bots
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://chromiumcodereview.appspot.com/2442143002
Cr-Commit-Position: refs/heads/master@{#426968}

Review-Url: https://chromiumcodereview.appspot.com/2435153003
Cr-Commit-Position: refs/heads/master@{#426967}

This change exchanges the 2nd and 3rd parameters to std::memset() in a
number of places where the value to set and the length of the buffer
were inverted. The resulting incompletely initialized buffers triggered
MSan failures.

BUG=375297
TBR=dmurph@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/2447473002
Cr-Commit-Position: refs/heads/master@{#426966}

https://pdfium.googlesource.com/pdfium.git/+log/a804fd48b716..5532835aeb88

$ git log a804fd48b..5532835ae --date=short --no-merges --format='%ad %ae %s'
2016-10-21 tsepez Re-enable CHECK() than only 0-numbered objects are released.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/2440153003
Cr-Commit-Position: refs/heads/master@{#426965}

BUG=658479
TEST=none
TBR=wangxianzhu

Review-Url: https://chromiumcodereview.appspot.com/2432043010
Cr-Commit-Position: refs/heads/master@{#426964}

https://chromium.googlesource.com/chromium/src/+/f1449449b

BUG=657839
TBR=pkasting@chromium.org

Review URL: https://codereview.chromium.org/2440253002 .

Cr-Commit-Position: refs/heads/master@{#426963}

Cr-Commit-Position: refs/heads/master@{#426962}