GitLab

BUG=404187

Review URL: https://codereview.chromium.org/478753002

Cr-Commit-Position: refs/heads/master@{#290031}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290031 0039d316-1c4b-4281-b951-d872f2087c98

By default there is no change in behavior, but autofilling can now be disabled
for the sync credential entirely or just disabled for reauth pages that support
transactional reauth.

Note that this also changes GetSyncUsername() to not return the username if
password sync is disabled if it is possible to determine. This makes GetSyncUsername() a little inconsistent depending on the state of sync setup, but it's important to be as specific as possible when disabling autofilling, since it's a
usability hit.

BUG=386692
R=isherman@chromium.org

Review URL: https://codereview.chromium.org/451853003

Cr-Commit-Position: refs/heads/master@{#290030}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290030 0039d316-1c4b-4281-b951-d872f2087c98

Before r272790 the host was sending empty packets 30 times a second
when nothing is changing on the screen. After that change and r281677
the frequency was decreased to 5 frame per second. It looks like those
changes degraded performance for some users. This change partially
restores previous behavior. Empty packets are send for each captured
frame even when nothing is changing on the screen. Keep-alive packets
are sent every 200ms when there are no other video packets, e.g. when
the video stream is paused.

Review URL: https://codereview.chromium.org/477103004

Cr-Commit-Position: refs/heads/master@{#290028}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290028 0039d316-1c4b-4281-b951-d872f2087c98

As a boosted fling may suppress a new scroll sequence in anticipation of a
follow-up fling event, it's important that scrolling properly resume if the
boosted fling terminates during said suppressed scroll. Normally, a synthetic
GestureScrollBegin is used to kickstart the scroll in such cases. However, if
the fling naturally terminates by either overscrolling or ticking beyond its
lifetime, we failed to resume touch scrolling. This led to unexpected cases
where a GestureScrollUpdate would be processed without an antecedent
GestureScrollBegin. 

Address this by always inserting the appropriate synthetic GestureScrollBegin
if the fling terminates for any reason.

BUG=402077

Review URL: https://codereview.chromium.org/473053002

Cr-Commit-Position: refs/heads/master@{#290027}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290027 0039d316-1c4b-4281-b951-d872f2087c98

the library was not freed at the end of the test. Another
unrelated unit test was expecting the dll to not be loaded.

Using GetModuleHandle now to avoid the ref count increment.

BUG=401854

Review URL: https://codereview.chromium.org/471223002

Cr-Commit-Position: refs/heads/master@{#290025}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290025 0039d316-1c4b-4281-b951-d872f2087c98

- remove the border radius on the tray bar items, as it makes the
divider look rounded
- fix the font size so that the background isn't clipped (header-bar-item
inherited the wrong font size from body)

See bugs for screenshots of the original problems

BUG=402964,402960

Review URL: https://codereview.chromium.org/476253002

Cr-Commit-Position: refs/heads/master@{#290024}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290024 0039d316-1c4b-4281-b951-d872f2087c98

The previous algorithm was limited to jumps of ~64, the new algorithm
can handle jumps of ~127.

Review URL: https://codereview.chromium.org/458313003

Cr-Commit-Position: refs/heads/master@{#290023}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290023 0039d316-1c4b-4281-b951-d872f2087c98

Chromecast application cache is disabled due to storage constraints
on device flash.

Aside: removes "enable-webrtc-hw-decoding", which doesn't exist, and "enable-threaded-compositing", which is now enabled by default.

R=lcwu@chromium.org,damienv@chromium.org
BUG=336640

Review URL: https://codereview.chromium.org/468223004

Cr-Commit-Position: refs/heads/master@{#290022}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290022 0039d316-1c4b-4281-b951-d872f2087c98

- remove the profile preference that used to keep track of showing the
tutorial any time the user manager was shown for a particular profile.

- show the upgrade bubble for local profiles as well (so that local profiles
have a chance to see the tutorial)

- for the local profiles upgrade bubble, don't show the "Not you?" link as
it doesn't really make sense.

BUG=399679
TBR=rpetterson@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288817

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289005

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289636

Review URL: https://codereview.chromium.org/454153002

Cr-Commit-Position: refs/heads/master@{#290021}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290021 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401163

Review URL: https://codereview.chromium.org/477953002

Cr-Commit-Position: refs/heads/master@{#290020}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290020 0039d316-1c4b-4281-b951-d872f2087c98

- Add API to get/set/clear the pairing info into user prefs;
- Add an onTurnFlowFinished event so that the app can clear its state;
- Extend EasyUnlockService to store pairing info and provide
  turn-off flow support;
- Update settings UI to trigger turn off flow and observe
  the turn-off flow status to show pending/error or dismiss when done;
- Add EasyUnlockToggleFlow to wrap api calls to server;
- Update OAuth2ApiFlow to support application/json content-type and
  handle 204 as success;

BUG=397356,394640

Review URL: https://codereview.chromium.org/475483003

Cr-Commit-Position: refs/heads/master@{#290019}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290019 0039d316-1c4b-4281-b951-d872f2087c98

Change how QUIC negotiates pacing from congestion feedback to QUIC
connection option.

Merge internal change: 73061068
https://codereview.chromium.org/471613002/


Add max_bandwidth and max_bandwidth_timestamp to QUIC source address
token.

Merge internal change: 73055131
https://codereview.chromium.org/463093003/


Don't print (SCUP) in log message, the DebugString that follows contains
this already.

Merge internal change: 73054570
https://codereview.chromium.org/464893003/


Do not support Quic timestamp feedback type in the framer.

Merge internal change: 72905602
https://codereview.chromium.org/467893002/


Change QUIC's delayed ack timer from 100ms to 25ms.

Rationale: This delay kicks in when the receiver is waiting for a second
data packet before sending an ack, and 100ms seems inordinately long for
this wait. The timer fires per-packet in low-bandwidth network paths
(BW < ~384 kbps), where more frequent acks helps with (i) ack clocking,
and (ii) better bw estimation for BBR.

Merge internal change: 72788368
https://codereview.chromium.org/461183002/


QUIC - clean up changes to keep in sync with internal source tree.
https://codereview.chromium.org/454263002/

R=rch@chromium.org
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/471293002

Cr-Commit-Position: refs/heads/master@{#290018}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290018 0039d316-1c4b-4281-b951-d872f2087c98

Revert of ChromeOS: should not show "Language changed" notification for certain languages. (patchset #6 of https://codereview.chromium.org/382973002/)

Reason for revert:
Link failure of browser_tests on ChromiumOS build bot:

http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20Builder%20%28dbg%29&number=50192


Original issue's description:
> ChromeOS: should not show "Language changed" notification for certain languages.
> 
> BUG=317718
> TEST=manually tested
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289985

NOTREECHECKS=true
NOTRY=true
TBR=alemate@chromium.org, nkostylev@chromium.org, jshin@chromium.org

Review URL: https://codereview.chromium.org/471403005

Cr-Commit-Position: refs/heads/master@{#290017}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290017 0039d316-1c4b-4281-b951-d872f2087c98

BUG=403504

Review URL: https://codereview.chromium.org/475123003

Cr-Commit-Position: refs/heads/master@{#290016}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290016 0039d316-1c4b-4281-b951-d872f2087c98

This enables figuring out which thread is blocking shutdown just by looking
at the UI thread stack.

BUG=403610
R=sky@chromium.org

Review URL: https://codereview.chromium.org/478563002

Cr-Commit-Position: refs/heads/master@{#290015}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290015 0039d316-1c4b-4281-b951-d872f2087c98

This information is already being collected and stored in UMA, but
has been kept internal. Updating public proto to match the internal
proto.

R=isherman@chromium.org,asvitkine@chromium.org,ghines@chromium.org
CC=lcwu@chromium.org
BUG=400925

Review URL: https://codereview.chromium.org/465133003

Cr-Commit-Position: refs/heads/master@{#290012}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290012 0039d316-1c4b-4281-b951-d872f2087c98

Since we use priority_for_tree_priority to get the priority_bin,
we might end up in situations where we have a non-now priority_bin
with a tile that is required for activation (this is because
required for activation property is read off the pending priority).

In particular in smoothness takes priority, if a tile is only
available on the pending tree, then it will have EVENTUALLY
priority_bin with inf distance. However, at the same time
it can be required for activation (NOW on the active tree).

We need to ensure that this is handled explicitly and correctly.
This patch adds the extra required categories, as well as
makes an array instead of separate variables for each of
the categories.

R=reveman

Review URL: https://codereview.chromium.org/471833002

Cr-Commit-Position: refs/heads/master@{#290011}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290011 0039d316-1c4b-4281-b951-d872f2087c98

Original fix:
https://codereview.chromium.org/427723004/

The original fix was reverted, however it actually shouldn't have been because it was mostly correct. This fix is the same as the old one, with an additional change. The call to DidStopLoading() in Instance::DocumentLoadComplete was moved to an earlier part of the function, causing DidStopLoading to be called before the print preview request.

BUG=376969

Review URL: https://codereview.chromium.org/467343003

Cr-Commit-Position: refs/heads/master@{#290010}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290010 0039d316-1c4b-4281-b951-d872f2087c98

- bytes read / written per socket
- total bytes read / written across all sockets

Also changed the Logger class to hold a Log proto instead of individual
fields.

BUG=343228

Review URL: https://codereview.chromium.org/475463002

Cr-Commit-Position: refs/heads/master@{#290009}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290009 0039d316-1c4b-4281-b951-d872f2087c98

When split-view mode, make sure dragging the tiel to switch between
windows works as expected.

BUG=397272
R=mfomitchev@chromium.org, mukai@chromium.org

Review URL: https://codereview.chromium.org/468763002

Cr-Commit-Position: refs/heads/master@{#290008}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290008 0039d316-1c4b-4281-b951-d872f2087c98

BUG=385295
TEST=Press Ctrl+Shift+F3, screen rotates.

Review URL: https://codereview.chromium.org/431183003

Cr-Commit-Position: refs/heads/master@{#290007}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290007 0039d316-1c4b-4281-b951-d872f2087c98

This name seems to be used in super old default profiles (I think it may
have been used before First User came around).

BUG=403881

Review URL: https://codereview.chromium.org/478543002

Cr-Commit-Position: refs/heads/master@{#290006}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290006 0039d316-1c4b-4281-b951-d872f2087c98

This saves the logic in PluginURLFetcher and WebURLLoader that has to replicate
the method-munging, referrer-munging, and first-party-URL-munging logic that is
already done in net/.

BUG=384609

Review URL: https://codereview.chromium.org/398903002

Cr-Commit-Position: refs/heads/master@{#290005}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290005 0039d316-1c4b-4281-b951-d872f2087c98

Add a metric for measuring the time it takes to process the very first
gesture scroll update input event. The first scroll gesture can often
get delayed by work related to page loading, which is what we hope to
improve with the Blink scheduler. This metric will help us track the
effectiveness of those improvements.

Original patch from Simon Pick <picksi@chromium.org>

BUG=391005

Review URL: https://codereview.chromium.org/467343002

Cr-Commit-Position: refs/heads/master@{#290004}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290004 0039d316-1c4b-4281-b951-d872f2087c98

The method usage is added here: https://chrome-internal-review.googlesource.com/172629

BUG=403891
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/479573002

Cr-Commit-Position: refs/heads/master@{#290003}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290003 0039d316-1c4b-4281-b951-d872f2087c98

This CL only turns on the non-nullable check for validation tests.

There will be separate CLs for:
- add DCHECK at the sending side.
- make the existing APIs pass the non-nullable check and turn on the check everywhere.

BUG=324170
TEST=New and revised validation tests.

Review URL: https://codereview.chromium.org/466613002

Cr-Commit-Position: refs/heads/master@{#290002}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290002 0039d316-1c4b-4281-b951-d872f2087c98

Now when performing single tap, the tap timer to begin one finger passthrough is not started. This problem originally arose because touch explore released state and single tap released state are treated similarly in the code, but one finger passthrough should be a state reachable only from single tap released.

Another state change is that if the user presses in single tap/touch explore released and there is no previous touch exploration location, the user is redirected to the wait state.

TEST=TouchExplorationTest.SingleTapLongPress
BUG=402544

Review URL: https://codereview.chromium.org/465543003

Cr-Commit-Position: refs/heads/master@{#290001}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290001 0039d316-1c4b-4281-b951-d872f2087c98

R=lcwu@chromium.org,byungchul@chromium.org
BUG=403104,403101

Review URL: https://codereview.chromium.org/467043002

Cr-Commit-Position: refs/heads/master@{#290000}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290000 0039d316-1c4b-4281-b951-d872f2087c98

This doesn't do anything effective anymore.

BUG=245900

Review URL: https://codereview.chromium.org/469003006

Cr-Commit-Position: refs/heads/master@{#289998}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289998 0039d316-1c4b-4281-b951-d872f2087c98

Nothing registers for the callback in WasShown if using
synchronous compositor, so this does not change any behavior.
So this is only removing unneeded RequestVSyncUpdate

BUG=

Review URL: https://codereview.chromium.org/476233002

Cr-Commit-Position: refs/heads/master@{#289997}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289997 0039d316-1c4b-4281-b951-d872f2087c98

Application of special storage policy is split out into chrome/browser/net/quota_policy_channel_id_store. 

TEST=net_unittests --gtest_filter=SQLiteChannelIDStoreTest*
TEST=unit_tests --gtest_filter=QuotaPolicyChannelIDStore*

BUG=397545

Review URL: https://codereview.chromium.org/381073002

Cr-Commit-Position: refs/heads/master@{#289996}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289996 0039d316-1c4b-4281-b951-d872f2087c98

The webui cert viewer was still using x509_certificate_model::GetCertChainFromCert instead of X509Certificate::GetIntermediateCertificates. This was fixed in the gtk cert viewer in r135231, but the webui cert viewer was missed. (x509_certificate_model::GetCertChainFromCert was not implemented on OpenSSL, and on NSS the chain it returned may differ from the the chain that was actually used.)

BUG=77757,338887

Review URL: https://codereview.chromium.org/376753002

Cr-Commit-Position: refs/heads/master@{#289994}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289994 0039d316-1c4b-4281-b951-d872f2087c98

BUG=403872

Review URL: https://codereview.chromium.org/478453002

Cr-Commit-Position: refs/heads/master@{#289993}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289993 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289988}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289988 0039d316-1c4b-4281-b951-d872f2087c98

This updates the entries in DEPS for the w3c repos to track the
tip-of-tree on the 'blink' branch.

This is patch 4 of 6 in the roll.

TBR=phoglund@chromium.org
BUG=404022

Review URL: https://codereview.chromium.org/475173003

Cr-Commit-Position: refs/heads/master@{#289987}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289987 0039d316-1c4b-4281-b951-d872f2087c98

BUG=398062
R=sadrul@chromium.org
TBR=volick@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/473113002

Cr-Commit-Position: refs/heads/master@{#289986}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289986 0039d316-1c4b-4281-b951-d872f2087c98

BUG=317718
TEST=manually tested

Review URL: https://codereview.chromium.org/382973002

Cr-Commit-Position: refs/heads/master@{#289985}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289985 0039d316-1c4b-4281-b951-d872f2087c98

Introduce WindowListProviderImpl that simply works with the stacking order of
child windows of the container. This changes the behaviour of repeated bezel
swipes from the left edge to swipe between the last two active windows, which
is the desired behaviour.

BUG=403444
R=mfomitchev@chromium.org, oshima@chromium.org

Review URL: https://codereview.chromium.org/470083004

Cr-Commit-Position: refs/heads/master@{#289984}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289984 0039d316-1c4b-4281-b951-d872f2087c98

BUG=403868
R=sadrul@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/464213006

Cr-Commit-Position: refs/heads/master@{#289982}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289982 0039d316-1c4b-4281-b951-d872f2087c98

SearchProvider enforces that if the user is in keyword mode, the
only suggestions allowed to be the default match are keyword mode
suggestions, lest they break the user out of keyword mode.

Previously, this constraint was applied with an after-the-fact
correction to allowed_to_be_default_match.  This change sets
allowed_to_be_default_match correctly when the AutocompleteMatches
are created.

All tests pass.  (And yes, this constraint enforcement is tested.
Here you can see the tests that were added when the constraint was put
in place: https://codereview.chromium.org/67693004 .)

BUG=398135
R=msw@chromium.org

Review URL: https://codereview.chromium.org/476263002

Cr-Commit-Position: refs/heads/master@{#289981}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289981 0039d316-1c4b-4281-b951-d872f2087c98