- 29 Sep, 2017 40 commits
-
-
Tomasz Garbus authored
In this CL I added an image view on auto sign-in snackbar, displaying user's avatar. Until avatar is fetched, a placeholder image is shown. For network traffic annotation tag, I used this sample: https://cs.chromium.org/chromium/src/tools/traffic_annotation/sample_traffic_annotation.cc?l=120 Image view size is 24x24pt, fetched image is scaled accordingly. Screenshot with fetched icon: https://screenshot.googleplex.com/ruQRUXGOLN9.png Screenshot with placeholder: https://screenshot.googleplex.com/bYUnFR0pFru.png Screenshot with big (1024x1024) icon: https://screenshot.googleplex.com/4OwJuwCdj3J.png Bug: 435048 Change-Id: Ib74ef74716d81ab661ee2aa4b7246e27ebab3276 Reviewed-on: https://chromium-review.googlesource.com/681254 Commit-Queue: Tomasz Garbus <tgarbus@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#505356}
-
Zentaro Kavanagh authored
- All files generated by libfuzzer. - Contains no code. BUG=chromium:22532 Change-Id: I4710f81f670b2a0287280ae04bb055c0fdc60093 Reviewed-on: https://chromium-review.googlesource.com/632876 Commit-Queue: Zentaro Kavanagh <zentaro@google.com> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#505355}
-
Tomasz Garbus authored
This CL introduces a notification view appearing on the bottom of the screen when user is automatically logged in. It also includes an EG test for this behavior. Here is a screenshot with the notification: https://screenshot.googleplex.com/267O2QU93YA.png iPhone X screenshots: vertical: https://screenshot.googleplex.com/0bitXQFqbR2.png horizontal: https://screenshot.googleplex.com/v0i7GbVwdBL.png Bug: 435048 Change-Id: Ic871148a970c36e8ce89922319720637a54cabbc Reviewed-on: https://chromium-review.googlesource.com/665119 Commit-Queue: Tomasz Garbus <tgarbus@chromium.org> Reviewed-by:
Mike Baxley <baxley@chromium.org> Reviewed-by:
Rohit Rao (ping after 24h) <rohitrao@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#505354}
-
Guido Urdaneta authored
BUG=761622 Change-Id: I9428919041a0c5a0779bec18b911b253c82fece3 Reviewed-on: https://chromium-review.googlesource.com/690377 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#505353}
-
Maxim Kolosovskiy authored
Prompt should have labels: "Username" and "Password" Username and password will be on separate lines. See screenshots in the bug. Since both owners are OOO, but the CL should be landed before feature freeze, the CL will be landed only with TBR. TBR=vasilii@chromium.org Bug: 769666 Change-Id: I9f43163ff4286e6f7c3ef526572f3ca4ae971fab Reviewed-on: https://chromium-review.googlesource.com/690344 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#505352}
-
Elly Fong-Jones authored
TabbedPane's focus indicator line should have been mirrored in RTL so it was under the focused tab, but it was not. Bug: 733115 Change-Id: I25e663300e75aee849aa3804a8e1a5d13f97acf8 Reviewed-on: https://chromium-review.googlesource.com/690796Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#505351}
-
Alexander Timin authored
R=skyostil@chromium.org Change-Id: Ia45c1c39077bbdd451af091d2589e1b11e77c617 Reviewed-on: https://chromium-review.googlesource.com/680796Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#505350}
-
Gauthier Ambard authored
The NTP view cannot use the safeAreaInsets property directly as it is snapshotted before being inserted in the view hierarchy, and the safe area is only available for views in the view hierarchy. This CL introduces a property mirroring the safe area once the view is in the view hierarchy. But it is also set up with the value used in the first frame, allowing the snapshot to be done as if the view was in the view hierarchy. Reland of https://chromium-review.googlesource.com/c/chromium/src/+/681942 It was reverted because the NTP wasn't working correctly when opening the recent tabs from the tool menu. Bug: 767869 Change-Id: Ibf57b84dd6aa4447101c0d0828e5f9af3d76670d Reviewed-on: https://chromium-review.googlesource.com/691727 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao (ping after 24h) <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#505349}
-
Greg Kraynov authored
Change-Id: I03198f177aa936c3ba21dc5aabfc8d27cdfb2c54 Reviewed-on: https://chromium-review.googlesource.com/690156Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Grigoriy Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#505348}
-
Mike West authored
This reverts commit 6ad728b1. Reason for revert: The revert in https://chromium-review.googlesource.com/c/chromium/src/+/691794 should have fixed the underlying problem. So we don't need to disable the test. :) Original change's description: > sheriff: Disable PasswordsAndFormsBrowserTest.uiTests > > TBR=dpapad@chromium.org > > Bug: 770047 > Change-Id: Iced8b09b937f2a6b202bea47b99dcf6fbe137749 > Reviewed-on: https://chromium-review.googlesource.com/691694 > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#505329} TBR=dpapad@chromium.org,ortuno@chromium.org Change-Id: I60d94fdf0cf77ed04d0b02f4193b54be66e270bd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 770047 Reviewed-on: https://chromium-review.googlesource.com/691994Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#505347}
-
Lucas Gadani authored
Bug: 769754 Change-Id: I909fed33dd12215b30c13b5d5c913337b56ef717 Reviewed-on: https://chromium-review.googlesource.com/690656Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#505346}
-
Paweł Hajdan, Jr authored
This was requested in https://chromium-review.googlesource.com/c/chromium/src/+/690346 TBR=agable,dpranke Bug: 570091 Change-Id: I74ceecb35236cc4c346f47f1b6e9e8755bd2b689 Reviewed-on: https://chromium-review.googlesource.com/691665Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org> Cr-Commit-Position: refs/heads/master@{#505345}
-
Bernhard Bauer authored
The navigation selector will now hide immediately when moving the bottom sheet down from the half state (full state for small screens), instead of 96dp before the peek position. Preview: https://drive.google.com/open?id=0B8YGYtFin7saZ2VDNmhnZGZJWTg Bug: 759130 Change-Id: I326d9baf0f8f837b782a51f6daa84c13fac1074a Reviewed-on: https://chromium-review.googlesource.com/689999 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#505344}
-
Henrik Grunell authored
Changes: https://webrtc.googlesource.com/src.git/+log/7e9c614..bbceb76 $ git log 7e9c614..bbceb76 --date=short --no-merges --format=%ad %ae %s 2017-09-28 ehmaldonado@webrtc.org Add support for conditions on DEPS file. 2017-09-28 agable@chromium.org Make Gerrit the default for WebRTC changes 2017-09-27 steveanton@webrtc.org Move clients of WebRtcSession to use PeerConnection 2017-09-28 davidben@webrtc.org Mark methods_stream as const. 2017-09-28 davidben@webrtc.org Switch from SSL_CIPHER_get_rfc_name to SSL_CIPHER_standard_name. 2017-09-28 kwiberg@webrtc.org Convert PayloadUnion from a union to a class, step 2 2017-09-28 jtteh@webrtc.org Fix occassional hang in iOS 11 when calling VTDecompressionSessionInvalidate. 2017-09-28 kwiberg@webrtc.org Convert PayloadUnion from a union to a class, step 1 2017-09-28 sakal@webrtc.org Revert "Use injectable hardware video decoder/encoder in AppRTCMobile." 2017-09-28 ssilkin@webrtc.org Adding test for SingleNalUnit mode 2017-09-28 sakal@webrtc.org Use injectable hardware video decoder/encoder in AppRTCMobile. 2017-09-28 denicija@webrtc.org Fix memory leak in nv12 metal renderer 2017-09-28 brandtr@webrtc.org Detach SequencedTaskChecker in MediaCodecVideoEncoder::Release. 2017-09-28 solenberg@webrtc.org Remove various IDs: 2017-09-28 kthelgason@webrtc.org Add equality method for RTCVideoCodecInfo. 2017-09-27 philipel@webrtc.org Calculate VP9 references to wrap at kPicIdLength instead of 16 bits. 2017-09-28 oprypin@webrtc.org Change DEPS URL for catapult to match Chromium 2017-09-28 ssilkin@webrtc.org Updating OpenH264 to v1.7.0 2017-09-27 danilchap@webrtc.org Trigger rtt and stats update on report block rather than receiver report. 2017-09-25 sakal@webrtc.org Reland "Improve unit testing for HardwareVideoEncoder and fix bugs." 2017-09-28 henrika@webrtc.org Adds WebRTC.Audio.EncodingTaskQueueLatencyMs TBR=grunell@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng Bug: Change-Id: I16d9436bb54c7b8c5da988f6dd7b2d75d23039c8 Reviewed-on: https://chromium-review.googlesource.com/691723Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#505343}
-
Nicolas Dossou-gbete authored
Look at the content view dimensions to see if the orientation change happened as expected. Bug: 768779 Change-Id: I364f1fb13e1b88bb69542f584204dc295be32677 Reviewed-on: https://chromium-review.googlesource.com/689995 Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#505342}
-
Gyuyoung Kim authored
This CL has done below ones, - Replacing base::MakeUnique|WTF::MakeUnique with std::make_unique - Replacing PtrUtil.h with <memory> Bug: 755727 Change-Id: I78c514e53fa7902172a6f6b5b5c66d74d8efb0d8 Reviewed-on: https://chromium-review.googlesource.com/687374 Commit-Queue: Gyuyoung Kim <gyuyoung.kim@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#505341}
-
Matt Falkenhagen authored
Most tests started passing after script url loader was implemented in r502227. Bug: 715640 Change-Id: I38f366923243c764219853a8bf51356e12c38fd8 Reviewed-on: https://chromium-review.googlesource.com/691757Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#505340}
-
Kent Tamura authored
According the current coding style guide, function names should start with capital letters. - Update ElementTypeHelpers.h.tmpl - Replace exising calls for isFooElement() with IsFooElement() - Remove some unnecessary ASSERT_TRUE(isFooElement()) followed by toFooElement(), which contains the SECURITY_DCHECK. Bug: 710278 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I4fa5a4fced83a1015816ecdeb0636fde9b832c21 Reviewed-on: https://chromium-review.googlesource.com/689875 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#505339}
-
Daniel Bratell authored
Several test classes in scheduler have implemented NopTask and this patch uses unique namespaces to prevent them from clashing in jumbo builds. Bug: 745732 Change-Id: I8c3ecc80ab0696fbe4634d330dfe1e942dbcfa8b Reviewed-on: https://chromium-review.googlesource.com/690345Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#505338}
-
Edward Jung authored
have any content Currently only a small subset of 4xx and 5xx HTTP errors show a net error interstitial when the server responds with no content. This CL adds generic messaging for the other cases. Bug: 632778 Change-Id: If39bf0ba1c89ac5e2b5a27f5973e1accc25dc0fa Reviewed-on: https://chromium-review.googlesource.com/685674Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Edward Jung <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#505337}
-
Mike West authored
This reverts commit 19e812ea. Reason for revert: Starting in https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/45183, `AppListTest.PressAppListButtonToShowAndDismiss` has been failing. It doesn't look like the result of that test should have changed, reverting so folks who know what they're doing can have a look. :) Original change's description: > ChromeOS: Enable ShelfModel synchronization by default. > > Synchronize two ShelfModels between Ash and Chrome by default. > Can be disabled for debugging/testing in classic ash: > --ash-disable-shelf-model-synchronization > "Disable shelf model synchronization" (in about:flags) > > Bug: 557406 > Test: No Chrome OS shelf behavior changes; please file any bugs! > Change-Id: I47c7c7b6c9d38f9aaa4ea89a1dc8ce333e49f8bd > Reviewed-on: https://chromium-review.googlesource.com/682340 > Commit-Queue: Michael Wasserman <msw@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#505317} TBR=jamescook@chromium.org,msw@chromium.org Change-Id: Idcc1058f4b11a2ebc491f4c168e073692cd16910 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 557406, 770138 Reviewed-on: https://chromium-review.googlesource.com/691816 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#505336}
-
Jean-François Geyelin authored
This CL: -Adds a compatibility header to obtain a view's safeAreaInsets. -Removes the unnecessary |imageViewContainer_| from the infobar view. -Takes into account the safeAreaInsets where needed in the infobar view: * leftMarginOnFirstLine returns the space from the left edge of the screen to where the infobar's text should start. It handles 2 cases: A) When there's an icon (e.g. a translate icon) The old code was using |frameOfIcon|, which now already takes into account the safeArea. The logic needed to be changed, and it's now: icon.x + icon.width + margin. B) When there's no icon The safeAreaInset is taken into account. * rightMarginOnFirstLine is the space from the right edge of the screen to where the infobar's text should start. The safeAreaInset is taken into account. * heightThatFitsButtonsUnderOtherWidgets does not use leftMarginOnFirstLine nor rightMarginOnFirstLine because it handles views not on the first line. When not on the first line you have more space because the icon and the close button are not in the way. This function still needs to have an idea of how much horizontal space is available, and thus needs to take into account the horizontal safeArea (both left and right). * computeRequiredHeightAndLayoutSubviews returns the total height of the infobar. We add the safeAreaInset.bottom to the total computed height, which makes the infobar taller. This allows us to have more white space at the bottom of the infobars. * frameOfCloseButton is updated so that the close button is moved left to be in the safe area. * frameOfIcon is updated so that the icon is moved right to be in the safe area. https://drive.google.com/open?id=0Bw-kA2pwDsU-OXlJSUE3VmxMZGc Bug: 765415 Change-Id: I35c1718ca170ccef245f51f28fa7eed63f1d9042 Reviewed-on: https://chromium-review.googlesource.com/671353Reviewed-by:Rohit Rao (ping after 24h) <rohitrao@chromium.org> Commit-Queue: Jean-François Geyelin <jif@chromium.org> Cr-Commit-Position: refs/heads/master@{#505335}
-
Michael McGreevy authored
This means that ReportStatus is only called in one place (apart from AppBannerManagerDesktop::ShowBannerUi), making it easier to verify that it is called the appropriate number of times. It also removes the need for hacks such as pre-updating the state to COMPLETE in AppBannerManager::DisplayAppBanner. Bug: 770016 Change-Id: Iedf93b7a3c6c211b2188032259906bd49bcd4555 Reviewed-on: https://chromium-review.googlesource.com/691494 Commit-Queue: Michael McGreevy <mcgreevy@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#505334}
-
Erik Luo authored
The console spec says that the %o specifier should produce "optimally useful formatting" as opposed to the %O "generic JavaScript object formatting". To make this distinction clearer and align log() to %o and dir() to %O, this CL will format arrays/objects with previews when using %o. Please see crbug for screenshot. Bug: 751850 Change-Id: I927e1c34667f1d11bc13e98a86d38419b7012940 Reviewed-on: https://chromium-review.googlesource.com/607576 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#505333}
-
Naoki Fukino authored
We generate data URL for ARC intent handler's icon in 16x16 pixel PNG format. It is not good enough when the device scale factor is bigger than 1. We should apply the scale factor when generating PNG data. The source bitmap which is passed from Android system is big enough. (48x48 pixels for 1x scale factor, and 96x96 pixels for 2x scale factor.) Bug: 751362 Change-Id: I370bf32b2c0f4e9e19dc267b03965663546a03bf Reviewed-on: https://chromium-review.googlesource.com/688524 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Kazuhiro Inaba <kinaba@chromium.org> Cr-Commit-Position: refs/heads/master@{#505332}
-
Julien Isorce authored
Instead it always selects angle, like if --use-gl=angle was set which makes --use-gl=egl useless. My understanding is that --use-gl=egl is supposed to select the defaults libEGL.so.1/libGLESv2.so.2 available on the system. Regression introduced by 06a905b5 "Fixed fallback to software for tests" https://chromium-review.googlesource.com/517912 BUG=726075 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Idf3cfb1b5480a112f73b7e7c20f4d4ade1cc2a51 Reviewed-on: https://chromium-review.googlesource.com/690074Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Julien Isorce <julien.isorce@chromium.org> Cr-Commit-Position: refs/heads/master@{#505331}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/8b059bd946d9..1ee6631ad3a8 $ git log 8b059bd94..1ee6631ad --date=short --no-merges --format='%ad %ae %s' 2017-09-29 angle-deps-roller Roll skia/third_party/externals/angle2/ db3422764..a9c60e9f9 (1 commit) 2017-09-28 angle-deps-roller Roll skia/third_party/externals/angle2/ c71ea661e..db3422764 (5 commits) Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I32fcc84538d7fee8649c2200dcd66c903d8eec6b Reviewed-on: https://chromium-review.googlesource.com/691440Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#505330}
-
Giovanni Ortuño Urquidi authored
TBR=dpapad@chromium.org Bug: 770047 Change-Id: Iced8b09b937f2a6b202bea47b99dcf6fbe137749 Reviewed-on: https://chromium-review.googlesource.com/691694Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#505329}
-
vitaliii authored
This is a followup to https://chromium- review.googlesource.com/c/chromium/src/+/601790. There I delete the provider code from BUILD.gn as well as its tests, but did not delete the provider files themselves. This CL just deletes provider's .h and .cc. I've checked and everything else seems to be deleted in the previous CL. AFAIK this code was always behind a feature, which was not enabled in M61. It was not used (removed from BUILD.gn) in M62. Bug: 770059 Change-Id: I07939d75157200c0dbe0374bc18d36f4de4f7e49 Reviewed-on: https://chromium-review.googlesource.com/691657Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#505328}
-
Mike West authored
This reverts commit 206bdc85. Reason for revert: Several paint-related tests have begun crashing on "Linux Trusty (dbg)" after landing this patch, flakily hitting a CHECK in `PaintController.cpp` (see the log in https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Trusty__dbg_/5565/layout-test-results/paint/invalidation/video-mute-repaint-stderr.txt). It looks like this kind of crash happened while landing the patch as well, at least on https://storage.googleapis.com/chromium-layout-test-archives/linux_layout_tests_slimming_paint_v2/6682/layout-test-results/results.html). I'll revert it. Original change's description: > Fix false-positives of under-invalidation checking in layout tests > > In the following few cases we intentionally allow under-invalidations in > cached subsequences: > - offscreen image animation > - media buffered range > > We intentionally don't update each time the contents change to improve > performance or avoid complex implementation of real time change > notification. > > Now allow cache skipping in cached subsequences. > > Enable under-invalidation checking for tests that would have reported > under-invalidation with the checking enabled. > > This also helps clusterfuzz not to trigger under-invaldiation checking > failures when it creates a test for the above cases. > > Bug: 769729 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I2149e9d2304dbad5d7486c822d5452c5dba237fe > Reviewed-on: https://chromium-review.googlesource.com/690851 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#505281} TBR=wangxianzhu@chromium.org,chrishtr@chromium.org Change-Id: Id0ddbc90d9cf4436fe10dc81485d9f13edef6f1a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 769729, 769879 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/691814Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#505327}
-
Xi Cheng authored
Change-Id: I8f8c232c5916da49dff2b2c1251f9c48f598a31a Reviewed-on: https://chromium-review.googlesource.com/691157 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#505326}
-
Yuki Yamada authored
After fixed crbug.com/736697 , we have to record PWA's WPR again with new perf benchmarks. Suumo did not registered service worker in previons url, so also Replaced it by top page to check service worker performance before recording wpr-go. Also removed some urls which are not used in loading.mobile . Bug: 765058 Change-Id: Iaf7da788f7a57078ca9475b6283b338f3facb7a3 Reviewed-on: https://chromium-review.googlesource.com/688995 Commit-Queue: Yuki Yamada <yukiy@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#505325}
-
Koji Ishii authored
This patch adds UseFirstLineStyle() to NGConstraintSpace, and removes NGBaselineAlgorithmType::kAtomicInlineForFirstLine. The distinction between kAtomicInline and kAtomicInlineForFirstLine are not available in many cases, and these values are exclusive. Having UseFirstLineStyle() in NGConstraintSpace is more reasonable. Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I19e4124e82b86ba87318f6a08aa47e958dbf53ad Reviewed-on: https://chromium-review.googlesource.com/688259 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#505324}
-
Patti authored
Per-site exceptions for Protected Content / Protected Media Identifier only exists for CrOS / Android, but r503968 changed the Javascript internally so that it was defined on all platforms, and updated Site Details to only use it on CrOS. This introduced a crash when Chrome tries to get the exceptions for protected content on non-CrOS in All Sites, so fix by updating All Sites to check for CrOS before using it. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5c209cedfb6efbaee327a97d448ea9deab737b2d Bug: 769242 Reviewed-on: https://chromium-review.googlesource.com/688914 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#505323}
-
Patti authored
Since permissions are only shown if they're non-factory-default, show them first (over showing certificate and cookie information, which are always shown). Bug: 535074, 718553 Change-Id: I842e684d43c1f7655f8952b07e590affcbc36a39 Reviewed-on: https://chromium-review.googlesource.com/686199 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Lucas Garron <lgarron@chromium.org> Cr-Commit-Position: refs/heads/master@{#505322}
-
Mike West authored
This reverts commit 4981992a. Reason for revert: It appears that this patch caused `browser_test` failures on 'Linux ChromiumOS Tests (dbg)', starting at [build 30664][1]. The [errors][2] read `[8882:8882:0928/213724.538975:ERROR:CONSOLE(48)] "Uncaught TypeError: Cannot read property '_createRipple' of undefined", source: chrome://resources/cr_elements/cr_link_row/cr_link_row.js (48)`, which this patch alters. [1]: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/30664 [2]: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chromiumos%2FLinux_ChromiumOS_Tests__dbg__1_%2F30664%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FPasswordsAndFormsBrowserTest.uiTests%2F0 Original change's description: > MD Settings: Migrate settings-toggle-button to use cr-toggle. > > Bug: 768073 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: If3efa3993d9ff75cce73eb48d583adb0ea5db543 > Reviewed-on: https://chromium-review.googlesource.com/686041 > Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> > Reviewed-by: Scott Chen <scottchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#505269} TBR=dpapad@chromium.org,scottchen@chromium.org Change-Id: I6e7e68d3a2989898df9aac3364de489fd5b05cd3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 768073 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/691794Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#505321}
-
Paweł Hajdan, Jr authored
They're using a condition now, which has same effect. Bug: 570091 Change-Id: Ia47a6f55e3d757990a43ce15e7fd326f1f25e06b Reviewed-on: https://chromium-review.googlesource.com/690346Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Cr-Commit-Position: refs/heads/master@{#505320}
-
Erik Luo authored
Bug: 759765 Change-Id: I9f5e3de6493d878e1913298f1b65a0b3ceac85ae Reviewed-on: https://chromium-review.googlesource.com/647372Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#505319}
-
Gyuyoung Kim authored
- Replacing base::MakeUnique|WTF::MakeUnique with std::make_unique - Replacing PtrUtil.h with <memory> Bug: 755727 Change-Id: I7199bc382a3f9e81abaad7fc24b33d730d6c4909 Reviewed-on: https://chromium-review.googlesource.com/689816 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#505318}
-
Mike Wasserman authored
Synchronize two ShelfModels between Ash and Chrome by default. Can be disabled for debugging/testing in classic ash: --ash-disable-shelf-model-synchronization "Disable shelf model synchronization" (in about:flags) Bug: 557406 Test: No Chrome OS shelf behavior changes; please file any bugs! Change-Id: I47c7c7b6c9d38f9aaa4ea89a1dc8ce333e49f8bd Reviewed-on: https://chromium-review.googlesource.com/682340 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#505317}
-