GitLab

BUG=353792
TEST=
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/203493006

git-svn-id: svn://svn.chromium.org/blink/trunk@169498 bbb929c8-8fbe-4397-9dbb-9b2b20218538

On linux and windows

BUG=353790
TEST=
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/203483006

git-svn-id: svn://svn.chromium.org/blink/trunk@169497 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This captures following spec chagne: https://www.w3.org/Bugs/Public/show_bug.cgi?id=24905
The essential part of the change is in HTMLImportsController.cpp.
Anything else is to make it work with redirect.

The problem here is that allowCredentials flag is held both
by ResourceLoaderOptions and ResourceRequest and these two
can go out-of-sync. This change tries to make them in sync.

Such a state duplication should be resolved eventually, but
that is another story.

BUG=348671
TEST=import-cors-credentials.html
R=abarth, dglazkov@chromium.org

Review URL: https://codereview.chromium.org/196043002

git-svn-id: svn://svn.chromium.org/blink/trunk@169496 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Correcting placement and clipping of sub-pixel offset
composited layers by properly adding the accumulated sub-
pixel offset from composited parents.

BUG=347521

Review URL: https://codereview.chromium.org/204053002

git-svn-id: svn://svn.chromium.org/blink/trunk@169495 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The assert was a result of an off-by-one error in both the array's definition and the assert itself.

BUG=353577

Review URL: https://codereview.chromium.org/203343004

git-svn-id: svn://svn.chromium.org/blink/trunk@169494 bbb929c8-8fbe-4397-9dbb-9b2b20218538

(Left overs from 3-sided patches)

BUG=245025

Review URL: https://codereview.chromium.org/198483002

git-svn-id: svn://svn.chromium.org/blink/trunk@169493 bbb929c8-8fbe-4397-9dbb-9b2b20218538

media/encrypted-media/encrypted-media-playback-setmediakeys-after-src.html flaky on Linux
fast/files/workers/worker-read-blob-async-crash.html times out randomly

BUG=353770,353208
TEST=
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/203303005

git-svn-id: svn://svn.chromium.org/blink/trunk@169492 bbb929c8-8fbe-4397-9dbb-9b2b20218538

SelectorCheckingContext.elementStyle is used to store the RenderStyle for
the element we are currently computing styles for. It is among other things
used for setting flags on the RenderStyle if we may match :hover,
:first-child, or some other pseudo classes. When we go past a combinator
during matching, we set the elementStyle to null to tell we are not
currently looking at the target element for the selector matching.

The :ancestor pseudo is a special case in the sense that it will select
styles for the shadow host element, but its sub-selectors may actually match
ancestor elements of the host element, behaving as if we had a descendant
combinator. This CL resets elementStyle to 0 when matching ancestors of a
shadow host for the :ancestor pseudo class in order to set flags for :hover,
:first-child, etc on the correct RenderStyle objects.

R=dglazkov@chromium.org
BUG=353503

Review URL: https://codereview.chromium.org/201573003

git-svn-id: svn://svn.chromium.org/blink/trunk@169491 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=169467

BUG=350978
TBR=dcheng@chromium.org

Review URL: https://codereview.chromium.org/195893040

git-svn-id: svn://svn.chromium.org/blink/trunk@169490 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Gardening: http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-same-url-block.html flaky

BUG=353763
TEST=
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/203293008

git-svn-id: svn://svn.chromium.org/blink/trunk@169489 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=248938
TEST=
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/203593006

git-svn-id: svn://svn.chromium.org/blink/trunk@169488 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=245644
TEST=
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/204083002

git-svn-id: svn://svn.chromium.org/blink/trunk@169487 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=345027

Review URL: https://codereview.chromium.org/203623006

git-svn-id: svn://svn.chromium.org/blink/trunk@169486 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Mark two flaky tests:
fast/scrolling/hover-during-scroll.html
http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-same-none-block.html

BUG=353751,353754
TEST=
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/201153017

git-svn-id: svn://svn.chromium.org/blink/trunk@169485 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=248938
TEST=
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/203693005

git-svn-id: svn://svn.chromium.org/blink/trunk@169484 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=353746
TEST=
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/203223011

git-svn-id: svn://svn.chromium.org/blink/trunk@169483 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It fails on platforms other than debug from time to time

BUG=352377
TEST=
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/204023003

git-svn-id: svn://svn.chromium.org/blink/trunk@169482 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It times out on linux from time to time

BUG=248938
TEST=
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/203983003

git-svn-id: svn://svn.chromium.org/blink/trunk@169481 bbb929c8-8fbe-4397-9dbb-9b2b20218538

fast/forms/number/number-appearance-spinbutton-disabled-readonly.html
fast/forms/select/listbox-appearance-basic.html

These two fail consistently on this bot only, not the WebKit Linux ToT bot.

BUG=353736
TEST=
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/203443006

git-svn-id: svn://svn.chromium.org/blink/trunk@169480 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/194073002

git-svn-id: svn://svn.chromium.org/blink/trunk@169479 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This cleans up the remaining compositing/ display() calls, other than
two tricky cases (squash-animated-gif.html and
video-with-invalid-source.html) which are in different CLs for ease of
review and landing.

BUG=345027

Review URL: https://codereview.chromium.org/196653012

git-svn-id: svn://svn.chromium.org/blink/trunk@169478 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=24182
TEST=
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/203723004

git-svn-id: svn://svn.chromium.org/blink/trunk@169477 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The <select> preview is set with yellow background inline with Input and
TextArea Element preview css settings.

R=dhollowa@chromium.org, isherman@chromium.org, jhawkins@chromium.org, tkent@chromium.org
BUG=58719

Review URL: https://codereview.chromium.org/138433002

git-svn-id: svn://svn.chromium.org/blink/trunk@169476 bbb929c8-8fbe-4397-9dbb-9b2b20218538

virtual/stable/http/tests/websocket/workers/worker-reload-repeated.html
http/tests/websocket/workers/worker-reload-repeated.html
virtual/threaded/animations/keyframe-timing-functions-multiple-properties.html

BUG=353727,349537
TEST=
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/203673004

git-svn-id: svn://svn.chromium.org/blink/trunk@169475 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Move Canvas2DLayerBridgeTest.cpp, Canvas2DLayerManagerTest.cpp and
DrawingBufferTest.cpp.

BUG=353585

Review URL: https://codereview.chromium.org/203513002

git-svn-id: svn://svn.chromium.org/blink/trunk@169474 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=345027
R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/203173006

git-svn-id: svn://svn.chromium.org/blink/trunk@169473 bbb929c8-8fbe-4397-9dbb-9b2b20218538

calculateTransformationToOutermostCoordinateSystem() should stop at the
first composited layer to match its backing resolution. Currently, we
are incorrectly taking the layer transform into account (the stop
condition is off by one).

R=pdr@chromium.org,schenney@chromium.org,senorblanco@chromium.org

BUG=345441

Review URL: https://codereview.chromium.org/196413023

git-svn-id: svn://svn.chromium.org/blink/trunk@169472 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Forward positional rules only affect selector matching of siblings when
nodes are added to or removed from the DOM. However, selectors with indirect
adjacent combinators may affect sibling evaluation without node addition or
removal. For instance if a class selector left of an indirect adjacent
combinator is set on an element.

Since the indirect adjacent combinator was considered as a forward
positional rule, we were recalculating sibling styles in the presence of an
nth-selector. We now split indirect adjacent selector matching as a separate
flag to be able to optimize recalc in the presence if nth-selectors and
skip sibling recalc for forward positional rules if no mutations happened.

ElementRareData and ShadowRootRareData do not increase in size since they
were already padded in the relevant parts.

R=ojan
BUG=160212

Review URL: https://codereview.chromium.org/198783003

git-svn-id: svn://svn.chromium.org/blink/trunk@169471 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Android builders fail compile

One exampel: http://chromegw.corp.google.com/i/chromium.webkit/builders/Android%20Builder/builds/36609

> Move deferred loading logic from WebMediaPlayerClientImpl to HTMLMediaElement.
> 
> BUG=350571
> TEST=All layout tests still pass.
> 
> Review URL: https://codereview.chromium.org/192013002

TBR=acolwell@chromium.org

Review URL: https://codereview.chromium.org/203213006

git-svn-id: svn://svn.chromium.org/blink/trunk@169470 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use them to avoid data races in the SafePointBarrier discovered by TSAN and guarantee that compiler does not move any memory accesses around m_unparkedThreadCount and m_canResume loads.

This change is likely to affect only ARM with its weakly ordered memory model.

BUG=347559

Review URL: https://codereview.chromium.org/199413012

git-svn-id: svn://svn.chromium.org/blink/trunk@169469 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added missing null ptr check.

BUG=353248

Review URL: https://codereview.chromium.org/203293005

git-svn-id: svn://svn.chromium.org/blink/trunk@169468 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This regression was introduced in r168256. The previous behavior
depended on whether Frame had already been garbage collected after being
removed from the DOM. If it had not been garbage collected yet, then it
would return a Performance object, but if it had, then it would return
null.

This patch adds the now-necessary check that frame is non-null and makes
the behavior consistent whether or not the underlying Frame object has
already been garbage collected, which makes Firefox's behavior.

BUG=350978
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/203053002

git-svn-id: svn://svn.chromium.org/blink/trunk@169467 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION() macro that generates better
type helpers for HTML Elements:
- Generates more isHTML*Element() helpers that are consistent with the ones
  in HTMLElementTypeHelpers.h so that there is no different in behavior /
  supported arguments.
- Supports more efficient isHTML*Element() helpers that take an HTMLElement
  in argument and thus don't need to check the namespace URI, only the local
  name.

R=esprehn, adamk
BUG=346095

Review URL: https://codereview.chromium.org/202813005

git-svn-id: svn://svn.chromium.org/blink/trunk@169466 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=350571
TEST=All layout tests still pass.

Review URL: https://codereview.chromium.org/192013002

git-svn-id: svn://svn.chromium.org/blink/trunk@169465 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These should be replaced by SkColorType and SkImageInfo.
In many cases, shortcut methods like SkBitmap::allocN32Pixels can be used.

BUG=

Review URL: https://codereview.chromium.org/201213002

git-svn-id: svn://svn.chromium.org/blink/trunk@169464 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If the same url is revalidated multiple times, the first revalidation may end
up being incorrectly left in an LRU list after it is deleted. This is because
we have an early exit in removeFromLRUList() when the resource's accessCount()
is zero, even though we unconditionally put the resource in an LRU list when
it is added to the cache. We increment accessCount for the new resources case
in add(), but not the successful revalidation case in replace().

(All of these bugs are most likely the same root cause, but it's not absolutely certain)
BUG=353035,352538,352444
TEST=MemoryCacheTest.MultipleReplace

Review URL: https://codereview.chromium.org/202243003

git-svn-id: svn://svn.chromium.org/blink/trunk@169463 bbb929c8-8fbe-4397-9dbb-9b2b20218538

sheets.

Comment on the cases where the raw pointers cannot be removed at this point.

Leave the raw pointers in inspector/ alove. They are safe as they are
now because the inspector leaks all the CSSStyleSheets it is inspecting
via Persistent handles at this point (and used to leak them all via
RefPtrs.)

Review URL: https://codereview.chromium.org/196513007

git-svn-id: svn://svn.chromium.org/blink/trunk@169462 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fix handling of BDO (bidirectional override) elements by explicitly
checking for bidi override in RenderText and using the specified
direction instead of resolving based on content.

R=leviw@chromium.org
BUG=352160
TEST=fast/text/international/bdo-bidi-width.html

Review URL: https://codereview.chromium.org/197883020

git-svn-id: svn://svn.chromium.org/blink/trunk@169461 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We need to carry out the nullptr assignment to m_workerGlobalScope
before notifying the proxy that the worker thread is going away. 
Otherwise, the main thread could destroy the WorkerThread object 
which owns the m_workerGlobalScope persistent before the assignment 
and that would lead to a use-after-free.

It turns out that there are objects that keep the execution context
alive in order to be able to determine if they are being destructed
on the right thread. Therefore, clearing out the thread member
in WorkerGlobalScope cannot be done before the WorkerGlobalScope
is actually dead. Therefore, the larger change that Sigbjorn did
will not work. (One example of this kind of dependency is
SQLCallbackWrapper.)

We need to just keep the thread member intact and let objects
die normally. The call to detach needs to happen before we
actually kill the worker thread because finalizers need to
be able to access thread local data.

Review URL: https://codereview.chromium.org/203233004

git-svn-id: svn://svn.chromium.org/blink/trunk@169460 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This flag has been removed from newer versions of the specification.

BUG=353337

Review URL: https://codereview.chromium.org/200763008

git-svn-id: svn://svn.chromium.org/blink/trunk@169459 bbb929c8-8fbe-4397-9dbb-9b2b20218538