- 10 Nov, 2018 24 commits
-
-
Charlene Yan authored
This is always false except for in tests and menu_example.cc which is not used. This helps simplify MenuButton for the Button cleanup task. Bug: 901183 Change-Id: If5a3cf7b6ba1ce5618548d112df1c4404b2ae181 Reviewed-on: https://chromium-review.googlesource.com/c/1324375Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#607061}
-
Oystein Eftevaag authored
Pass JSON strings to the callback (and hence Mojo) once they reach 100kb, rather than passing one giant string all at once. BUG=902064 Change-Id: If95811d3ac907d23d2f882e869d88e933ff5d7b0 Reviewed-on: https://chromium-review.googlesource.com/c/1330068 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#607060}
-
Min Qin authored
As we moved the download id generation logic to DownloadManagerImpl, but incognito download is still using regular profile's DownloadManagerDelegate to generate the id. So it is possible that incognito download may have the same id as a regular download. In theory this shouldn't be an issue as incognito and regular download belongs to different DownloadManagerImpl. However, Chrome's download home and extensions use id to uniquely identify a download. Thus causing the issues when accessing these downloads from the download home and extensions. BUG=902336 Change-Id: I3591153e4f453c75d4877f5ce1088c096d3edf1e Reviewed-on: https://chromium-review.googlesource.com/c/1330214Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#607059}
-
John Budorick authored
This CL: - renames "Fuchsia {ARM64,x64} Cast Audio" -> fuchsia-{arm64,x64}-cast - renames fuchsia_{arm64,x64}_cast_audio -> fuchsia-{arm64,x64}-cast - drops is_cast_audio_only=true from all of the above Requires crrev.com/c/1325090 Bug: 877264 Change-Id: I4cf02d4719caf3ec7fff43b51f77ce64b644d7f8 Reviewed-on: https://chromium-review.googlesource.com/c/1324457Reviewed-by:Stephen Martinis <martiniss@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#607058}
-
Ken Rockot authored
Changes Identity's instance group ID from a free-form string to a base::Token. Updates the 25-billion things which depend on this field. Some more details: - This removes kRootUserID in favor of a new C++ constant, kSystemInstanceGroup, a base::Token with a more approrpiate name given its purpose. - Also removes kInheritUserID. Because the instance group field is optional in an outgoing request Identity, nullopt is used to mean "inherit". - Not all conceptual references to "user ID" have been removed yet, since this CL is big enough as it is. For example, we still have a test-only service name "user_id", which no longer makes sense. Follow-up CLs will also change the instance ID field to a Token and clean up remaining conceptual references to "user ID". Bug: 895591 Change-Id: Idef13a269c6935123db68fa2621cecaca345974c Reviewed-on: https://chromium-review.googlesource.com/c/1325944 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
-
Daniel Rubery authored
Since the original request may have been cancelled, the original_request_url is not reliable, and should be overwritten with the search_url in referrer chain attribution. Bug: 903996 Change-Id: Ie04f9fe60665ebae83054eccdab0719d0840721c Reviewed-on: https://chromium-review.googlesource.com/c/1330754 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#607056}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 899324 Test: none Change-Id: I7c06a44ad5aa7bc3dc9ff2249fa819551b942088 Reviewed-on: https://chromium-review.googlesource.com/c/1330807 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#607055}
-
Yue Li authored
Bug: b/116166191 Test: Local build Change-Id: I0d4280ea21a194d7f37df95fa269781f758a24d2 Reviewed-on: https://chromium-review.googlesource.com/c/1330787Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#607054}
-
Christian Biesinger authored
I have to use N?G? instead of (NG)? because gtest does not support the latter on Windows. R=chrishtr@chromium.org Change-Id: Ia62d1ec85447a351b8abc341203c3dcdc17fc63b Reviewed-on: https://chromium-review.googlesource.com/c/1330695 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#607053}
-
Eric Karl authored
Previously, we'd rely on an ApplicationStatusListener to deliver background notifications. This was racy with sending the synchronous command to tear down the RootCompositorFrameSink / Display, and if it failed to trigger before teardown, we'd fail to disable the watchdog for the expensive teardown operation. This change ensures we always send the background signal before tearing down the Display / RootCompositorFrameSink. Bug: 899705 Change-Id: I2b5e5787f94ab1f392c5ec4c4063ef6664de2a3f Reviewed-on: https://chromium-review.googlesource.com/c/1327468Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#607052}
-
James Hawkins authored
R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: I45d7f04e97a914596cd1bffd5e2ea73543064810 Reviewed-on: https://chromium-review.googlesource.com/c/1329889 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
-
John Budorick authored
Matches other ios-* tasks on chromium.mac. Tbr: justincohen@chromium.org,lindsayw@chromium.org Bug: 903966 Change-Id: I201894ca5828bf1148943f32389527e83b1d7a98 Reviewed-on: https://chromium-review.googlesource.com/c/1330300Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#607050}
-
Donn Denman authored
This adds a copy of an existing Tap CTR histogram that restricts to sync-enabled users. This population is an approximation of the UKM-eligible population, which was used for training our Tap model. This will be useful in validating CTR of the Assist Ranker Tap Suppression experiments underway. BUG=899135 Change-Id: Idb423da02e88c21c9123d36366de5b5f7aa5038e Reviewed-on: https://chromium-review.googlesource.com/c/1329888Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#607049}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 65397cf9. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." 9ff65400 "Add redirected cases to CSP/import tests in wpt/worklets" 687313c5 "Add action_sequence in testdriver" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: igrigorik@chromium.org, yoav@yoav.ws: external/wpt/preload rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ib5dad7c15760eef9222b180fce377d8dbf52e16e Reviewed-on: https://chromium-review.googlesource.com/c/1330336 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607048}
-
Christopher Thompson authored
The latest release of libpng has an improved fuzzer (as part of its oss-fuzz integration). This CL rolls //third_party/libpng to the latest v1.6.35 and adds a target to the BUILD.gn to setup and use the included libpng fuzz target. This leaves the existing progressive read fuzz target in testing/libfuzzer/fuzzers/ (the upstream fuzzer does not currently support this), but replaces the normal read fuzzer. This also adds a patch file for the change in https://crrev.com/c/1014027 for future version rolls. Bug: 900480 Change-Id: Iec93c963fe5214e519f9e5d1a9414059b8f596c8 Reviewed-on: https://chromium-review.googlesource.com/c/1327237 Commit-Queue: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Cr-Commit-Position: refs/heads/master@{#607047}
-
Dave Tapuska authored
Generally PaintTiming histograms haven't been added to histograms.xml it appears. So this wasn't done in http://crrev.com/e5d647d0 But chirp is complaining about the missing histograms so corrrect that. BUG=348877 Change-Id: I2605949ae729b93852147716fed6d4e15064688f Reviewed-on: https://chromium-review.googlesource.com/c/1326802 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#607046}
-
Jian Li authored
Two problems are fixed: 1) Treat the app as still in foreground state when the app state is HAS_PAUSED_ACTIVITIES because this can happen when the activity is temporarily covered by another activity. 2) Detecting continuous online should be checked when switching from online to offline. Bug: 903649 Change-Id: Icbb2fe4b1021d9525940472e33ae820ca3117667 Reviewed-on: https://chromium-review.googlesource.com/c/1330705Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#607045}
-
Robert Flack authored
This reverts commit df72f9b5. Reason for revert: This caused a memory leak detected by the WebKit Linux Trusty Leak bot: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/ Original change's description: > Drag and Drop: Frames not containing drag source shouldn't be able to reset drag state > > Only allow frames who are ancestors of the drag_src_ to reset a drag_src_ > > Created layout test to show previous lack of dragend when moving iframe in dom as a result of dragging > Created layout test to verify lack of regression when frames containing drag source are moved/detached > > Bug: 737691 > Change-Id: Ic6cc8ac0528d35ac93a21612b453d6b3203a152d > Reviewed-on: https://chromium-review.googlesource.com/c/1265818 > Commit-Queue: Darwin Huang <huangdarwin@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606276} TBR=dcheng@chromium.org,pwnall@chromium.org,huangdarwin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 737691 Change-Id: I560230c44bbcc055632abcd81b3d6286f972f530 Reviewed-on: https://chromium-review.googlesource.com/c/1330329Reviewed-by:
-
Maggie Chen authored
AppendExtraCommandLineSwitches was called twice during GPU process launch and it caused some duplicate command line switches in GPU process. In GpuProcessHost::LaunchGpuProcess, the second AppendExtraCommandLineSwitches call was from BrowserChildProcessHostImpl::Launch(). The solution is to divide BrowserChildProcessHostImpl::Launch() into two parts - AppendExtraCommandLineSwitches and LaunchWithoutExtraComandLineSwitches. The GPU process will now call LaunchWithoutExtraComandLineSwitches to avoid running AppendExtraCommandLineSwitches twice. Bug:899361 Change-Id: I4ddfeaaf9624aac68e9ab68aabac6ed4e83f7a03 Reviewed-on: https://chromium-review.googlesource.com/c/1316660 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#607043}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/aab0b516aa87..7adddc2268b1 git log aab0b516aa87..7adddc2268b1 --date=short --no-merges --format='%ad %ae %s' 2018-11-09 thestig@chromium.org Simplify CPDF_DocRenderData::CreateTransferFunc(). Created with: gclient setdep -r src/third_party/pdfium@7adddc2268b1 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: If030eabb4924b5cfbc2270ed6fbad1cb96cfb3dc Reviewed-on: https://chromium-review.googlesource.com/c/1329988Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607042}
-
Xianzhu Wang authored
If a subsequence previously partially painted, when we use the cached without repainting, we should still treat the layer as partially painted, otherwise we'll fail to repaint on paint dirty rect change. Bug: 898435 Change-Id: I27ec2689377aaf408a819f2849675640c439fcd9 Reviewed-on: https://chromium-review.googlesource.com/c/1329701Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/934bab09..2b973a56 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1db470d9daec505e9f60ea02d900eefb5ad05e25 Reviewed-on: https://chromium-review.googlesource.com/c/1330286Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607040}
-
Tommy Steimel authored
This reverts commit e60d9aef. Reason for revert: Causes the close button to receive gesture events even when it's not the target of the tap. This causes the PiP window to unexpectedly close. Bug: 895773 Original change's description: > [Picture in Picture] Call parent function in OnGestureEvent. > > Change-Id: I854654be22abd217c3f8ed557bc3fb9118c557c6 > Reviewed-on: https://chromium-review.googlesource.com/1192326 > Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org> > Commit-Queue: apacible <apacible@chromium.org> > Cr-Commit-Position: refs/heads/master@{#586820} # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I2f36d78713f0b811a0a2681e09284c394e146a5c Reviewed-on: https://chromium-review.googlesource.com/c/1318397 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#607039}
-
Shakti Sahu authored
This CL fixes the following issues : 1 - AspectRatioFrameLayout doesn't re-adjust its bounds after orientation change. 2 - We don't set the correct matrix for tiny images after view is resized. 3 - Some cleanup for the bitmap resize code. Bug : 903634 Change-Id: I547ff13b6bb1bd8832966c30cf44900346c0d85f Reviewed-on: https://chromium-review.googlesource.com/c/1328227 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
-
- 09 Nov, 2018 16 commits
-
-
jonross authored
We had originally removed viz_content_browsertests and viz_content_unittests from Windows, Linux, Mac, and Android FYI bots. This was as we entered Finch trials and field configurations began to enable this on the CQ. However we have found out that this only affects test suites withing chrome/browser. So we lost coverage of content tests. This re-adds viz_content_browsertests, and viz_content_unittests to the FYI bots so that we can see if anything is broken. Change-Id: Ifcb2aab687276b82ec68c9e730aa27cf4ab4b0fc Reviewed-on: https://chromium-review.googlesource.com/c/1327565Reviewed-by:
-
siyua authored
being shown. Bug: 897998 Change-Id: I884709065290889f494a02e06d28602f2bcee68c Reviewed-on: https://chromium-review.googlesource.com/c/1325561Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#607036}
-
Thomas Guilbert authored
Currently, if a cast application is stopped from a different device that started the application, RemotePlayback is not properly torn down. This is because the cast application listener is never given a reference to the session that it should tear down. This CL fixes the issue, and adds a pre-emptive null check. Bug: 790766 Change-Id: I6fa67ca87a05efd135c57b396d6d09e69065a6f3 Reviewed-on: https://chromium-review.googlesource.com/c/1327605Reviewed-by:
Zhiqiang Zhang <zqzhang@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#607035}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/db21dac6ad7d..8ecbd57f8e89 Created with: gclient setdep -r src-internal@8ecbd57f8e89 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I03d1282524d74cb33bba2edbc34fe24a9ac8adad Reviewed-on: https://chromium-review.googlesource.com/c/1330025Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607034}
-
Zhongyi Shi authored
This is a follw-up change after merge internal change 219177525. Change-Id: I1ac9774d34c631b8ef3f71e86edd5d7c104c67da Reviewed-on: https://chromium-review.googlesource.com/c/1327801 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#607033}
-
Andres Calderon Jaramillo authored
This CL fixes the computation of the target_size in FromDrawImage() when the target_size is updated to the size of a mip level. Previously, the computation rounded down which was inconsistent with the behavior introduced in https://crrev.com/c/1107049. Test: the artifact in the referenced bug is no longer present. Bug: 891316 Change-Id: If8838c1501cbbcedd8261ddf6eac81f21cdca947 Reviewed-on: https://chromium-review.googlesource.com/c/1321774 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
-
Kyle Horimoto authored
Change-Id: I4b42fb71f931ef1fcb21150159b06dad4a78ca1d Reviewed-on: https://chromium-review.googlesource.com/c/1327743Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#607031}
-
David Black authored
Previously Assistant cards were rendered using WebContentsManager. This did not support either single- or multi-process mash. After this CL, I'll do a follow up to remove WebContentsManager and AnswerCardContentsRegistry as they are no longer used by either Assistant nor AppList. Known issue: This works fine for single-process mash but a crash occurs in multi-process mash when testing on device. No crash occurs with a glinux build so need to do more debugging. That said, this still moves us forward and allows us to deprecate some classes :) Bug: b:78078693 Change-Id: Iae0e9de8e5291f0ac99bae12207483838ccb910e Reviewed-on: https://chromium-review.googlesource.com/c/1321861 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#607030}
-
Etienne Pierre-doray authored
base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more explicit counterpart. It should have been replaced by : * base::ScopedAllowBaseSyncPrimitivesForTesting in test files. * base::ScopedAllowBaseSyncPrimitives in non-test files * base::ScopedAllowBaseSyncPrimitivesOutsideBlockingScope when it's used on threads that don't allow blocking The last one is strongly frowned upon but this CL aims to document existing behavior rather than address it. Owners are encouraged to follow-up by fixing unnecessary waits and more particularly unnecessary waits outside-blocking-scope. Note: The non-for-testing versions require friend'ing in thread_restrictions.h but care was taken to add these friends ahead of git cl split (since it wasn't possible to do a line-by-line associated CL split). Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1288533 Please CQ if LGTY! This CL was uploaded by git cl split. R=stevenjb@chromium.org Bug: 766678 Change-Id: I931476842857ed391d7148febbcac1c811a9ead1 Reviewed-on: https://chromium-review.googlesource.com/c/1324398 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#607029}
-
Varun Khaneja authored
Bug: 867518 Change-Id: I16891cc486f3d884229482b8c4d90309f9994b43 Reviewed-on: https://chromium-review.googlesource.com/c/1327810Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#607028}
-
Scott Violet authored
If the server shows a window, views was also activating the window. Instead views should just show the window. If the server wants the window active, it'll activate the window. BUG=756085 TEST=covered by test Change-Id: I208945a61d8c96b5dba0a070d7f32f6536342f28 Reviewed-on: https://chromium-review.googlesource.com/c/1330710Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#607027}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I6e6c980f74f247b4fd1615f7a956a5e8e2a4f8b6 Reviewed-on: https://chromium-review.googlesource.com/c/1330110Reviewed-by:
-
John Budorick authored
Tbr: chrisha@chromium.org Bug: 902335 Change-Id: Ie360d85f9f2a6ecc8f2305f9133a7313fb73dc09 Reviewed-on: https://chromium-review.googlesource.com/c/1330353Reviewed-by:
-
Andrii Shyshkalov authored
They became the default ones, no need to specify them. R=iannucci, vadimsh No-Try: True Change-Id: Iebc66d8291fdebab72fcdb334e26befdc6d90bf3 Reviewed-on: https://chromium-review.googlesource.com/c/1330288Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#607024}
-
Jun Mukai authored
OnEventFromSource for the |held_move_event_| may not return if one of the event handler creates a run loop -- this happens on tab-dragging. As long as |held_move_event_| is valid, any further touch moves are also held and not processed anymore. Bug: b/119260190 Test: manually Change-Id: Ibeacc167bbcf71d6d89a40ad2916ecf1f880998c Reviewed-on: https://chromium-review.googlesource.com/c/1330061Reviewed-by:
-
Carlos IL authored
Variations service now sets a flag if the last request was an HTTP retry, and uses it to decide whether to retry again, instead of relying on the scheme of the final URL. Also, retries are now disabled if the fallback url is HTTPS. Bug: 902727 Change-Id: Ibd6df4a22bc6302b231aff0ae32f8e1c8a1f277c Reviewed-on: https://chromium-review.googlesource.com/c/1325035 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#607022}
-
