- 01 Mar, 2018 40 commits
-
-
Bin Zhao authored
DeviceDescriptionFetcher and DialAppInfoFetcher have some common code. Create a DialURLFetcher class to get rid of some duplications. The common URLFetcher class can also be used to launch and stop Dial apps when we implement DIAL launch at browser side. Bug: 816628 Change-Id: I26bdfbbf7e2d59a68e3bf5aeaba8b6e3664bf430 Reviewed-on: https://chromium-review.googlesource.com/938158Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Bin Zhao <zhaobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#540242}
-
Jeremy Roman authored
base/memory/ptr_util.h includes will be cleaned up later. Generated by: git grep -l base::MakeUnique | xargs perl -pi -e 's/base::MakeUnique/std::make_unique/' git grep -l MakeUnique< base | xargs perl -pi -e 's/MakeUnique</std::make_unique</' Presubmit bypassed due to unrelated existing errors in touched lines. Bug: 755727 No-Presubmit: true Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Iedc5caf5bc04e119dadd0e3e8cc5c4dbf2fddc80 Reviewed-on: https://chromium-review.googlesource.com/943728Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#540241}
-
Alex Moshchuk authored
This CL adds user gesture plumbing to cross-process postMessage, so that when a frame sends a postMessage to a cross-process frame while processing a user gesture, the target frame's onmessage handler can utilize that user gesture as well. For now, the plumbing is only for one bit, has_user_gesture, which is restricted so that it can be forwarded at most once. This prevents unbounded forwarding of a user gesture via OOPIFs. This solution is temporary and should eventually be superceded by one of the following approaches: - Browser process starts tracking user gestures and enforcing constraints like at-most-one-popup-per-gesture. This plumbing should then pass a user gesture ID instead of a bool. - UserActivation V2 ships (see https://crbug.com/696617). This should allow us to remove this plumbing altogether. Bug: 161068 Change-Id: Ib7de03bb51470f6ff924d2e178b26e80b597321d Reviewed-on: https://chromium-review.googlesource.com/915101 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#540240}
-
Jay Civelli authored
Adding a callback to SimpleURLLoader to get notified when the request started, i.e. when the headers are available. Bug: 817458 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I1b53ba5b64a4c1cc406d03638f733a177ec863be Reviewed-on: https://chromium-review.googlesource.com/941881 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#540239}
-
Donn Denman authored
Splits the Ranker predition UMA logging to always log the prediction regardless of whether the UI was shown. BUG= Change-Id: I6593e3163113ea7201d71b587cbd7f2552ba085b Reviewed-on: https://chromium-review.googlesource.com/942058Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#540238}
-
Kai Ninomiya authored
The perf bot perf.chromium-rel-mac12 has alerted on a ~50% slowdown in http___webglsamples.org_dynamic-cubemap_dynamic-cubemap.html . In the regression range was my seemingly closely related CL: https://crrev.com/c/923103 But that commit should improve performance, not regress it. So this CL adds an exception to the workaround in 923103, so that that workaround does not apply on perf.chromium-rel-mac12. This should help determine whether my CL really caused a regression. I'm expecting this CL to cause a regression in http___kenrussell.github.io_webgl-animometer_Animometer_tests_3d_webgl.html (undoing the recent improvement caused by 923103). Bug: 815154 Change-Id: I335133a127bb7cfcb92ba29065641dfd55b63166 Reviewed-on: https://chromium-review.googlesource.com/938844 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#540237}
-
Ovidio Henriquez authored
This change adds a SimulateAdvertisementReceived function to the FakeCentral interface. The design for this class is detailed in the following document: https://docs.google.com/document/d/1XFl_4ZAgO8ddM6U53A9AfUuZeWgJnlYD5wtbXqEpzeg BUG=719826 Change-Id: I618dc68c967e6d9942f99f1807da6fb1985cd676 Reviewed-on: https://chromium-review.googlesource.com/916554Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Conley Owens <cco3@chromium.org> Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#540236}
-
Raymond Toy authored
The general pow function is pretty expensive when computing 10^x and 2^x. Replace it with the more specific exp and exp2 functions. This is only done for the routines for the BiquadFilterNode. Using https://jsfiddle.net/8vo0gbav/1/ (with dezipper = true to use setTargetAtTime) as a test, perf top on my Z840 machine said: + 29.01% 28.98% __ieee754_pow_sse2 + 22.65% 22.61% __exp1 With this CL, the same test reports + 17.15% 17.12% __expf_finite This isn't enough to make the test case use less than 100% CPU, but audio with glitches is now heard. Two tests needed to have the thresholds modified. Apparently there's a difference in round-off between exp and pow for this change to change the results slightly. Bug: 813504 Change-Id: I7c517c558bbb54c344f10dc3c057d21404679995 Reviewed-on: https://chromium-review.googlesource.com/942091Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#540235}
-
Xing Liu authored
This CL disables ParallelDownloadTest.ResumptionLastSliceUnfinished on Android. TBR=dtrainor@chromium.org, qinmin@chromium.org Bug: 817801 Change-Id: Icb2ce3a43d00ee1e74a005b2af91cea6045f3694 Reviewed-on: https://chromium-review.googlesource.com/943802 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#540234}
-
CrystalFaith authored
App documentation contains outdated information on ARC. This redirects those docs to updated Android documentation. Removed articles from the TOC. Bug: None Change-Id: I25f6f928ac704a5d357f0e8acab1f427521f84b3 Reviewed-on: https://chromium-review.googlesource.com/943823 Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Reviewed-by:
Meggin Kearney <mkearney@chromium.org> Cr-Commit-Position: refs/heads/master@{#540233}
-
Eugene But authored
Bug: 796418 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I77cefa817abceed2dc9485e1d753facec9430523 Reviewed-on: https://chromium-review.googlesource.com/943730Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#540232}
-
Benoit Lize authored
This CL adds a new class DetachedResourceRequest intended to be used from CustomTabs. When an intent is processed, a calling app can trigger a parallel request proceeding in the background. This is only the native implemenation, based on SimpleURLLoader. As such, since this feature is only triggered from Java code, there is no caller in chrome/ yet, only tests. Change-Id: I8a8d6bdca6ff65554769c3f0344e23dc2dcaf43b Bug: 816837 Reviewed-on: https://chromium-review.googlesource.com/934271 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#540231}
-
Philip Rogers authored
Hit tests can ignore clips and PaintLayer::HitTestLayer partially honored this setting but did not pass it along when computing clip rects for each layer fragment. Bug: 817186 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Icedf0470dfb06bb68f7f3c11a26a9a475262ac74 Reviewed-on: https://chromium-review.googlesource.com/942471Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#540230}
-
Xi Cheng authored
This reverts commit 5e06564a. Reason for revert: broke the build -- https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/27596 Original change's description: > Add the LaunchUninstallFlow() function > > This function uses automation to automatically write the name of a > program into the search box of the Apps & Features page. > > Bug: 717696 > Change-Id: Ifc6a1be295a3d06ac33f394dcf3fc4688bd4a907 > Reviewed-on: https://chromium-review.googlesource.com/907590 > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Cr-Commit-Position: refs/heads/master@{#540209} TBR=chrisha@chromium.org,dpapad@chromium.org,pmonette@chromium.org,grt@chromium.org Change-Id: Ifed25f3097f9b6091f40524cb12278f9f22c8915 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 717696 Reviewed-on: https://chromium-review.googlesource.com/943961Reviewed-by:
Xi Cheng <chengx@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#540229}
-
Emily Hanley authored
TBR=ashleymarie@chromium.org Change-Id: I8ab27cd1bf46467b4a7a25c87f3aef33eb10f9eb Reviewed-on: https://chromium-review.googlesource.com/943724Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#540228}
-
Scott Violet authored
This renames most of components. There are still a couple left, but this patch started getting big. Targets go from foo_features to foo_buildflags And similarly the header now has buildflags in the name. BUG=814485 TEST=covered by build TBR=tsepez@chromium.org Change-Id: I321403895df9ddc988491c70a78507ec51434783 Reviewed-on: https://chromium-review.googlesource.com/943600 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#540227}
-
David Bokan authored
Android uses an "overlay" composited video layer when a video is fullscreened. This layer is parented to the PaintLayerCompositor's root_content_layer and the actual content (LayoutView) is detached. With root-layer-scrolling enabled, PLC doesn't create a root_content_layer and the top-most GraphicsLayer in PLC is that of the LayoutView. This CL connects the video layer to the PLC's parent instead. This is currently the outer viewport scroll layer. We also need to make sure painting starts from the child of this layer, rather than the PLC's root layer since the video layer is no longer connected to the root. This doesn't matter for the video itself, however, the media player controls need to be painted from Blink. These changes exposed some brittleness in the compositor and the Android fullscreen video layout tests were hitting the DCHECK in ScrollbarLayerImplBase::CanScrollOrientation. This is because the viewport scrollbars use the outer/layout viewport as their ElementId but are owned by the inner/visual viewport. So when we disconnect the PLC's content layers, we remove the ScrollNode in the compositor but the visual viewport and its scrollbar layers live on. The rest of this patch changes the visual viewport scrollbars to use the visual viewport's element id. TEST=virtual/android/fullscreen/video-scrolled-iframe.html, virtual/android/fullscreen/video-controls-timeline.html, virtual/android/fullscreen/full-screen-iframe-allowed-video.html Bug: 711468,811024 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ic1c52e1853f14842ee3ae19119476b8945ecae17 Reviewed-on: https://chromium-review.googlesource.com/923397Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#540226}
-
Ryan Daum authored
Order of destruction in the system gestures test is incorrect, as discovered by msan. Bug: b/73738898 Test: Unit test Change-Id: Ib3f787e0a7e462d7ccbad2f70c1b35d595e58140 Reviewed-on: https://chromium-review.googlesource.com/943704 Commit-Queue: Ryan Daum <rdaum@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#540225}
-
Ehsan Karamad authored
The initial patch [1] landing the feature was passing the wrong rectangle to scroll to the LocalFrameView of the LocalRoot inside OOPIF process. The passed rectangle did not include the scroll offset of the LocalFrameView of the LocalFrameRoot. This CL fixes the problem and modifies the original test so that bounding client rectangle of each <iframe> in a nested <iframe> scenario are precisely tested. [1]- https://chromium-review.googlesource.com/c/chromium/src/+/679319 Bug: 810291 Change-Id: Id8859dd9dc70f0bb25519a0c812f7b7a078a9922 Reviewed-on: https://chromium-review.googlesource.com/914871 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#540224}
-
https://chromium.googlesource.com/catapult.git/+log/279fcf542e09..bbedc54bc5cf $ git log 279fcf542..bbedc54bc --date=short --no-merges --format='%ad %ae %s' 2018-03-01 perezju [Dashboard API] Include owner and updated in /bugs API response Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I8ef6701d5a6b13e6416e9a30faecfa42cb65e49a Reviewed-on: https://chromium-review.googlesource.com/943601 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#540223}
-
chrome://flagsRia Jiang authored
Bug: 804888 Change-Id: Icea95fd20113ff05ab916a3f2e69607eee2cfe5d Reviewed-on: https://chromium-review.googlesource.com/942053Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#540222}
-
Qiang Xu authored
Bug: 805046 Test: covered by tests Change-Id: Iad3ab2364eb5c034e1d78c5160918d9c10fe9c31 Reviewed-on: https://chromium-review.googlesource.com/942345 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#540221}
-
Mihai Sardarescu authored
This CLs filters out accounts that do not match pattern RestrictSigninToPattern. Bug: 807799 Change-Id: I2bf581315883166502920c3e86e9e6e9dabcf120 Reviewed-on: https://chromium-review.googlesource.com/928401Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#540220}
-
Mounir Lamouri authored
Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/aXYvQ01tMhw Bug: 690364 Change-Id: I3357e97e437069012554b60b0ae527a7b9998606 Reviewed-on: https://chromium-review.googlesource.com/943502Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#540219}
-
Maks Orlovich authored
... since it's easy for test fixture to provide based on public API. This reduced SetCookieWithCreationTimeAndOptions down to a single caller, so fold it in and simplify it a little bit. Bug: 731236 Change-Id: Ib5acd742ddb6aea7d26dff4952f800826bf5f1e2 Reviewed-on: https://chromium-review.googlesource.com/940142Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#540218}
-
Yash Malik authored
Change-Id: Id158c8cb4327a6aa795dd6bdeb14439fa6ef4704 Reviewed-on: https://chromium-review.googlesource.com/943680Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#540217}
-
bsheedy authored
Adds a new VR browsing Telemetry benchmark using WPR archives. It re-uses the URL list and WPR archive from the memory.top_10_mobile benchmark since they're reasonable sites that users of the VR browser might visit. Bug: 808597 Change-Id: I37a2a9ba14cdf2887125564d1cf1f653940fed6d Reviewed-on: https://chromium-review.googlesource.com/942086Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#540216}
-
Elad Alon authored
Bug: 775415 Change-Id: I0f88d37212866ba343e26b63d955cb7ad4a744b0 Reviewed-on: https://chromium-review.googlesource.com/943421Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#540215}
-
Robert Sesek authored
RUSAGE_SELF is already allowed for process-wide rusage, so per-thread should be permitted as well. Bug: 812250 Cq-Include-Trybots: master.tryserver.chromium.android:android_arm64_dbg_recipe;master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg Change-Id: I5e8a3203875238296cd96a861b70feff115bc97e Reviewed-on: https://chromium-review.googlesource.com/941592Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#540214}
-
Christopher Grant authored
There doesn't seem to be a reason to re-bind every frame, and it takes 300 us of CPU time to do so. BUG= R=vollick Change-Id: I487cf7e9268396bb71fe3317c6b27edf72a59bdf Reviewed-on: https://chromium-review.googlesource.com/943347Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#540213}
-
Stephen McGruer authored
Previously nullable values in the animations code were tracked by storing nulls as quiet_NaN() and using std::isnan as a null-detector. It is much more explicit to store such values using WTF::Optional, which forces code to consider whether or not the offset exists. Bug: 791086 Change-Id: Iad5e53456c40859bb7e3322c0cb6152b01f376e2 Reviewed-on: https://chromium-review.googlesource.com/939748 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#540212}
-
https://chromium.googlesource.com/angle/angle.git/+log/98e6a5f7b0ae..d6fef528fcfc $ git log 98e6a5f7b..d6fef528f --date=short --no-merges --format='%ad %ae %s' 2018-03-01 oetuaho Shorten mangled names of types Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I94b61a390ee85fe6c7bc340d0af5d7e2dd4472fd Reviewed-on: https://chromium-review.googlesource.com/943592Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#540211}
-
Carlos IL authored
With committed interstitials on, supervised user interstitials are now displayed using the new codepath. For this, supervised user throttle was modified so it cancels the navigation with the interstitial HTML. Browser tests were also modified so they test the committed interstitials cases too. Will be done on future CLs (and disabled tests requiring this will be re-enabled): -Adding bindings for interstitials to request permission or go back. -Handling the case where the URL list changes and we have to block the current page. -Migrate everything off of base::Callback. Bug: 780032 Change-Id: I53af29c43cc9d905b078c308021562830c05f47e Reviewed-on: https://chromium-review.googlesource.com/940459Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#540210}
-
Patrick Monette authored
This function uses automation to automatically write the name of a program into the search box of the Apps & Features page. Bug: 717696 Change-Id: Ifc6a1be295a3d06ac33f394dcf3fc4688bd4a907 Reviewed-on: https://chromium-review.googlesource.com/907590Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#540209}
-
Ahmed Fakhry authored
This CL makes the existing shortcuts affect whatever magnifier is currently enabled. This was also an opportunity to unify some scale related code. BUG=817490 TEST=Added test coverage Change-Id: I366ee56629d09ae22c725b034bfc410077fe52ab Reviewed-on: https://chromium-review.googlesource.com/942052 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#540208}
-
Oystein Eftevaag authored
With the direction both tracing and resource_coordinator has taken, there's no actual shared code between the two; this undoes the original move from //services/tracing. Mainly a mechanical move, except for starting up as an independent service. Change-Id: I093015c419166655b2015f7eddf4477983a16af9 Reviewed-on: https://chromium-review.googlesource.com/939659 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Ehsan Chiniforooshan <chiniforooshan@chromium.org> Cr-Commit-Position: refs/heads/master@{#540207}
-
Alexei Filippov authored
Change-Id: Ia0632c8b4fb4e3ba2daf9461f1ee11443db4efd8 Reviewed-on: https://chromium-review.googlesource.com/942028Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#540206}
-
Mustaq Ahmed authored
The nullptr was added in a past refactoring before UserActivationV2 was ready. Test failures with v2 enabled exposed the problem. Bug: 816527 Change-Id: Ia94fb85831c9ca312d45695e10cb0701c836153a Reviewed-on: https://chromium-review.googlesource.com/937659Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#540205}
-
Jay Civelli authored
Moving ZipFileInstaller from chrome/ to extensions/ and changing it to take a callback instead of directly installing the unpacked extension/theme. Providing a method in chrome/ to create a callback that does the installation (previous behavior). This CL is in preparation for using the Unzipper service to install extensions, as some of the logic performed by the utility handler code will be moved to this class and we'll be shared with the CrxInstaller class. Note that the zipfile_installer_unittest could not yet be moved to extensions/, it will be done later (see crbug.com/817131). Bug: 799220 Change-Id: I9ae6f13e5e9a0af4c111119952fd8915ff3dcfd3 Reviewed-on: https://chromium-review.googlesource.com/939842 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#540204}
-
Robert Liao authored
This change will be reverted after the M66 branch point. ExtensionPopup Views will need some harmonization work to bring it up to parity with some behavior provided by Mac. BUG=728174 Change-Id: Ia01160117c9dbda10e57d4f4b5a4fe706a39f36c Reviewed-on: https://chromium-review.googlesource.com/941883Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#540203}
-