- 31 May, 2019 40 commits
-
-
Juanmi Huertas authored
Registering the factory on OffscreenCanvas in modules, adding ImageBitmapRenderer to the union type for OffscreenCanvas. Adding new functionality to bitmaprenderer to let it be used in offscreencanvas. Changing IDL and some tests to validate new functionality. Adding a new virtual test to guarantee testing validation of trasnsfertooffscreencanvas for bitmaprenderer. Added bug: 969151 for the two missing tests. TBR=chrishtr Bug: 907141 Change-Id: I7c611952686aabdf2eb3df8ffe5ca73a69ae97f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638919Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#665260}
-
Zhenyao Mo authored
This reverts commit ca612692. Reason for revert: doesn't explain why YUY2 swap chain creation failed on Win10/AMD GPU, so this CL is unnecessary. Original change's description: > Add pixel format support flags on Windows. > > The flags are queried through ID3D11Device::CheckFormatSupport(). > > Hopefully they can be used to bypass YUY2 related tests on AMD > where creating a YUY2 swap chain fails. > > Also, they can be useful diagnosing swap chain related issues > from user machines, i.e., whether we assumed certain capabilities > without checking. > > BUG=967860 > TEST=bots > R=sunnyps@chromium.org,piman@chromium.org > > Change-Id: I5dff9069b2fc53851cbffc5263bd4a2e0e03582f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637195 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Commit-Queue: Zhenyao Mo <zmo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#665218} TBR=dcheng@chromium.org,zmo@chromium.org,sunnyps@chromium.org,piman@chromium.org Change-Id: Ic93530b90006c41da694a2bc7ae65d13d541b998 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 967860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639360Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#665259}
-
Peter Kotwicz authored
This CL: 1) Renames the blink::Manifest::ShareTarget::EncTypes enum values to make them easier to understand and to match EncodedFormData::EncodingType 2) Makes ShareTarget in shortcut_info.* use the enum type defined in blink::Manifest BUG=None Change-Id: I642a1bae9aff3bf463390683323ca0575673a505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629871 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#665258}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/78f6819b0e70..bd419fd9eb93 git log 78f6819b0e70..bd419fd9eb93 --date=short --no-merges --format='%ad %ae %s' 2019-05-31 tsepez@chromium.org Fix CFX_GEModule destruction order. Created with: gclient setdep -r src/third_party/pdfium@bd419fd9eb93 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: Ic2c2ab7ce28ca4a0b54aaa3bc68ef26b679c8ac9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638565Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665257}
-
Michael Ludwig authored
The desired behavior for backdrop filters is that the backdrop filtered content is combined with the original backdrop using src-over and the layer's opacity. The rpdq content should use the layer's blend mode when drawing into the filtered background. Bug: 967771, 948128 Change-Id: I967a81425bd30cbc101c24913ee13091a36e6a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636847Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Michael Ludwig <michaelludwig@google.com> Cr-Commit-Position: refs/heads/master@{#665256}
-
Gayane Petrosyan authored
Fix by adding default values icon related properties to the default theme background info. After doodle notifier clicked https://screenshot.googleplex.com/BwQAKd0qtPg.png After doodle notifier clicked in dark mode https://screenshot.googleplex.com/0qKA4iCTe6w.png Bug: 968490 Change-Id: I70e9a9f2b1e2ce8ef61ba00ad1614a0a2eac674e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636347 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#665255}
-
Maksym Onufriienko authored
Bug: 922813 Change-Id: I537f9c4607183af381d7a92eb2942cbd18ea5fba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638060Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Cr-Commit-Position: refs/heads/master@{#665254}
-
Antoine Labour authored
Original patch had a typo which exchanged 2 initializers. Instead initialize each field explicitly to avoid mistakes. Bug: 882547 Original change's description: > Use shared images in CopyVideoFrameYUVDataToGLTexture > > Use an explicit shared image allocation for the intermediate texture > that is used in both the source and destination GL contexts. > > Bug: 882547 > Change-Id: Ibd37bb16a1a43860976c9b35feadd576e099df4d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633530 > Auto-Submit: Antoine Labour <piman@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Commit-Queue: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#664539} Change-Id: I922d9ba1221dba772d5911cb28e2aeb8216c4a8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636608Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#665253}
-
Jeremy Roman authored
This adds support for the referrerpolicy attribute, including its default behavior (which may send the Referer header by default). Change-Id: I24fa87a8973c41d365027e7ef2bdfd2b1d369cb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631724Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#665252}
-
Natalie Chouinard authored
Migrate the About Chrome settings page to the Preference Support Library. This is the first page migrated, so it includes the initial set of necessary styles, layouts, and special handling code to support both Framework and Support Library Preferences simultaneously. These layouts and styles will be expanded incrementally as we migrate more complex settings pages. The net effect of this migration is expected to be a reduction in method count and binary size, but first CLs will cause increases. Bug: 966075 Binary-Size: New pref support library usage Change-Id: I714e7bed76c715357c1055a0f7d4a07211029c29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614475 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#665251}
-
John Abd-El-Malek authored
These aren't used anymore. Bug: 934009 Change-Id: Icb32638c0ce817c769b3dfd1c8a33e3a3021b8e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638918 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#665250}
-
Robbie McElrath authored
When you navigate to a url with an unsupported scheme, NavigationURLLoaderImpl will attempt to open the URL with an external program. However, if you have a protocol handler associated with that scheme, it will handle the request in addition to the external program (see ProtocolHandlerThrottle). On ChromeOS, the external program ends up being a new tab, which then repeats this process and in certain situations can result in an infinite loop of tabs being opened. This CL prevents the browser from opening an external program if a protocol handler exists for the URL's scheme. A browser test will be added in a followup CL. Bug: 963133 Change-Id: I6346b92adb3ea508a037b65a49dd1b44dd7d7b8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639077 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#665249}
-
Ben Pastene authored
And enable it for some UI tests. Bug: 947531 Change-Id: I1545ce6f718214a65690cc6044e2398d9a0bc218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635350Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#665248}
-
jonross authored
The section on pixel tests lists an output link format. However for the pixel_skia_gold_tests the link format is different. This updates the docs to include a note about the differences in links, with an example. Change-Id: I444c5391a3c05561b4177a76a7d3db70d4f03361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638548Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#665247}
-
Rune Lillesveen authored
Use Scoped* helpers to make sure the modified flags are reset for other tests. Change-Id: I7d03875cf2ab02029ca0807b1337ef3102625ed8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635680Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#665246}
-
dalyk authored
No changes in functionality. Bug: 878582 Change-Id: Ia1c64b54e5be2ac6676fd549d574316539554d1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638600Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#665245}
-
Mehran Mahmoudi authored
This adds some unit tests for the progress bar in touchless mode. Bug: 967453 Change-Id: Id85c3ba30ad2c9779f2716b2b5af2e708e3cbe83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637427Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#665244}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/c0d7ee45d45f..5e3c9d53d8ef git log c0d7ee45d45f..5e3c9d53d8ef --date=short --no-merges --format='%ad %ae %s' 2019-05-31 sugoi@google.com 32 bit compilation fixes for Visual Studio Created with: gclient setdep -r src/third_party/swiftshader@5e3c9d53d8ef The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Change-Id: Ib1e2c1aa24408ac406b4f4e6dab4c28926541ce2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638619Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665243}
-
Michael Ludwig authored
Needed when an RPDQ is partially offscreen Bug: 968160, 948128 Change-Id: Ic9f400dafa9997d367fc3a93cac44e640f01ace0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637778Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Michael Ludwig <michaelludwig@google.com> Cr-Commit-Position: refs/heads/master@{#665242}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d7e2fb330924..85b8ce2ab95b git log d7e2fb330924..85b8ce2ab95b --date=short --no-merges --format='%ad %ae %s' 2019-05-31 danilchap@webrtc.org In media engine replace forward declaration with proper includes Created with: gclient setdep -r src/third_party/webrtc@85b8ce2ab95b The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7ced80531edd2ae99177e2b7837c0891a615d611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636408Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665241}
-
Caroline Rising authored
Bug: 910739 Change-Id: I15e28232916c657ab442c5c6f909b1fd7ca09358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636867Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#665240}
-
Navid Zolghadr authored
Add callback supports to the RenderWidgetTargeter and use the async targetting in drag and drop code and register a callback to send drag events using the callback. Note that since drag and drop events aren't WebInputEvent it is not possible to use FindTargetAndDispatch function of RenderWidgetTargeter at this time. Bug: 804633 Change-Id: I2ecea2b70d7ea619169685a3a7b531355ddc0d59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596840 Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#665239}
-
Chase Phillips authored
Previously, idb-load-docs would run a final transaction ("txn18") which created a readonly transaction on the Documents store. Since it didn't wait for this transaction to complete, the trace and test results would often show "IDBObjectStore::get (Did Not Finish)" results. The telemetry harness had code to ignore these "Did Not Finish" results. If a change came along that did allow these to complete, however, the results for the completed actions would be included and count. This might appear as a regression when really the overall scheduling system was improving. Finally, as the "Did Not Finish" tasks piled up, some or all of them never finished, which caused the overall test to take longer to complete as it waited for these tasks. Eventually the test framework would timeout waiting and this additional timeout amount was included in our overall run time. The run time didn't impact the results, it did however make the traces hard to read. Bug: 968812 Change-Id: I37f135670c6596a3d598b240d76dff5211b89429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636223Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#665238}
-
Yue Li authored
Since we are sending app capabilities to the server, the VerifyProvider clientOp is no longer needed. This is the second step of removing the logic: 1. Remove VerifyProvider in the list of supported actions (internal) 2. Remove Handling of the VerifyProvider action (external) 3. Remove the logic of notifying the VerifyProvider action (internal) Bug: b/134085742 Change-Id: I5c6eab87d24655198696a1b711efeb4ecf15a9dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637650Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#665237}
-
Eugene But authored
This CL makes changes to the file so it compiles with EG2, the test is not added to EG2 target yet. Notable changes: - Replaced #import <EarlGrey/EarlGrey.h> with #import "ios/testing/earl_grey/earl_grey_test.h" - Removed unused headers Bug: 922813 Change-Id: I07ce60469de869d1c4281658c29a6ae0cbc5aa77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637937Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#665236}
-
Ian Kilpatrick authored
There should be no behaviour change as a result of this patch. Bug: 813068 Change-Id: I627eeea190435b5136f5382c2d28bab66f9eb617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639117Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#665235}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ef80e835027e..c92b6ad29083 Created with: gclient setdep -r src-internal@c92b6ad29083 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:955936,chromium:b/133794084,chromium:b/134085742 TBR=melandory@google.com,hiroshige@google.com,mlamouri@google.com,loyso@google.com Change-Id: I51c4ed1b7b1ef7e755fc75b388e8f9a08d786360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638857Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665234}
-
Christian Biesinger authored
It's not necessary and causes problems in LayoutNG when we reuse the cached fragment inside of ForceLayout (nothing will set the height to the correct value) In the specific testcase, we incorrectly think that the block has a percentage-sized child due to the abspos item. Bug: 967061 Change-Id: If6fabc93173f025966f359510e5b600914376e45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638192 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#665233}
-
Raymond Toy authored
Use a static local to hold the vector of all the FFTSetup objects that can be shared across all FFTFrame objects. Modeled after how PFFFT does this. Internal change with no user-visible effects. Bug: 962644 Change-Id: I9325f94f3ee18dd19014c00a4872c74d667bf497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629429Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#665232}
-
Danyao Wang authored
Also add rouslan@ and danyao@ to ios/chrome/browser/payments/OWNERS. Change-Id: I695105d983eef56101fd7325e4ea3a5d2f4c448f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637449Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#665231}
-
Robert Liao authored
Currently, WebUI refers to Views Resources. It should use the web default checkboxes already used by components like devtools BUG=967845 Change-Id: I5a56633b8ddc8b513d7407cfc5278c797e0fdff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632427 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#665230}
-
Michael Ludwig authored
Bug: 967778, 948128 Change-Id: Ibf1682788ee9f444e76674f8b0d93bc33954b67e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637050Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Michael Ludwig <michaelludwig@google.com> Cr-Commit-Position: refs/heads/master@{#665229}
-
Lily Chen authored
Bug: 969144 Change-Id: I58d049cfb5cbcda95fc1fb06a8fe409bbc26ee17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638819Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#665228}
-
Darwin Huang authored
Enables the Async Clipboard API's read and write functions, with ClipboardItem, on stable, by updating runtime_enabled_features flags from experimental to stable. Spec: https://w3c.github.io/clipboard-apis/#async-clipboard-api Intent to Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/TssvWe8TzBc Bug: 150835 Change-Id: I602defa5f300832c2322e3dccb444b4c807311ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567224Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#665227}
-
Andrey Kosyakov authored
Use appropriate (pending) RenderFrameHost when choosing associated RenderFrameDevToolsAgentHost in WillCreateURLLoaderFactory(). Change-Id: If72a7e056cea3f8a35f98564d9d3aed3e46f6e65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636684 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#665226}
-
Caleb Raitto authored
Metrics are already supplied in https://crrev.com/c/1496495 -- this CL fills out the additional, non-metrics info in the RequestFinishedInfo struct. Bug: 879208 Change-Id: Ie3c51275ca1003a16a2ad2817351e436d84a3264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575736 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#665225}
-
Jian Li authored
Bug: 965999 Tbr: rouslan@chromium.org,caitkp@chromium.org Change-Id: Ie5a4015599e9657f992afdf4dce18b97734efb53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634563 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#665224}
-
Ben Pastene authored
eg: https://chromium-swarm.appspot.com/task?id=4527b399d8f02d10 Something went wrong there, and cros_run_test return non-zero, but no failed Tast tests were found, so the test runner returned zero. This'll prevent that from happening. Bug: 947531 Change-Id: Ie43912771820f3920c30b82f82d6d54555868164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638777Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#665223}
-
Kevin Babbitt authored
This is similar to the issue fixed in crrev.com/c/1532893 and follow-up crrev.com/c/1535165. When the PDF plugin sends its accessibility tree to the browser process, we would incorrectly detect that the PDF tree is the root tree and switch out the node tracked by the UIA fragment root as its lone child. The fix is to check for a parent tree ID when determining whether a given tree is the root tree. Bug: 968245 Change-Id: I91a193064a51f9694eb4338af7a12f2fbf22dd30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636480Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#665222}
-
Lukasz Anforowicz authored
This CL fixes a problem where a GuestView that stops loading (e.g. a MimeHandlerView for a PDF) would not trigger a re-checking whether a parent frame can also report that it stopped loading. The CL fixes this by adding a |parent->CheckCompleted()| call to WebRemoteFrameImpl::DidStopLoading. In a regular-OOPIF case, the check in the parent would be triggered by: 1. OOPIF process: FrameLoader::DidFinishNavigation -> parent->CheckCompleted() -> RemoteFrame::CheckCompleted() -> ... -> RenderFrameProxy::CheckCompleted() -> send FrameHostMsg_CheckCompleted 2. Parent process: receive FrameMsg_CheckCompleted -> LocalFrame::CheckCompleted() The flow above is not happening for GuestView, because the main frame inside the GuestView doesn't know it has a parent. FWIW, the DidStopLoading issue is (a bit remotely) similar to the old https://crbug.com/779433. This CL re-enables a portion of the SavePageOriginalVsSavedComparisonTest.ObjectElementsViaHttp test, because after this CL, the test no longer hangs when waiting for the test page to stop loading. The remainder of the test will be re-enabled after fixing find-in-page issues that are tracked in https://crbug.com/965254. Bug: 964364 Change-Id: Iee165a88cdfb94b3169919393c563b483c145cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621486 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#665221}
-