GitLab

I'll land this on the tip-of-tree, and then revert it.  We'll then apply
it to the dev branch so that there is no chance of accidentally getting
security dialogs on Windows.

This should reduce the bug to P2, and allow a more complete resolution
of the bug.

r=rch
BUG=329255

Review URL: https://codereview.chromium.org/127463003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243858 0039d316-1c4b-4281-b951-d872f2087c98

On Windows, Widget::InitParams::force_show_in_taskbar is now respected,
so it is possible to override the default without having to directly set
HWND properties.

This should not change any behaviour (just a refactor).

Previously, we had a special case where the message center would turn
off showing in taskbar, and app launcher would turn it off for <= Vista.
Now we have just one special case: app launcher turns it on for >= Win7.

BUG=332277

Review URL: https://codereview.chromium.org/127133003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243857 0039d316-1c4b-4281-b951-d872f2087c98

Remove ResourceUpdate::CreateFromCanvas().
|canvas| member variable of ResourceUpdate is not used by ResourceUpdateController.
Also all customer of ResourceUpdate can pass SkBitmap.

R=enne@chromium.org, danakj@chromium.org
BUG=NONE
TEST=cc_unittests --gtest_filter=ResourceUpdateControllerTest.*

Review URL: https://codereview.chromium.org/127053004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243856 0039d316-1c4b-4281-b951-d872f2087c98

Add a check if the user tries to create a profile with the
name of an already existing supervised user. In that case,
the user is not allowed to create a new such supervised user
profile, instead he can directly import the existing supervised
user.
A screenshot can be found in the bug description.

BUG=282464
TEST=browser_tests

Review URL: https://codereview.chromium.org/125993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243855 0039d316-1c4b-4281-b951-d872f2087c98

This change is partially a cleanup and implementation of UdpTransport
for Cast. As the name suggests it is a UDP transport mechanism for
Cast using net::UdpSocket.

A behavior change is that a Cast receiver can have sender IP address
optional. Only after a packet is received that it can send packets. It
will reply only to that address and ignore packets coming from a
different address.

If a sender address is given to Cast receiver then there is no change.

BUG=331989

Review URL: https://codereview.chromium.org/125713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243854 0039d316-1c4b-4281-b951-d872f2087c98

BUG=322664
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/125643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243852 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332675
R=bauerb@chromium.org,inferno@chromium.org

Review URL: https://codereview.chromium.org/131073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243851 0039d316-1c4b-4281-b951-d872f2087c98

Moves the creation of PrintingControllerImpl into the UI thread.
Before, it wasn't being created in the UI thread, and for some reason
PrintingControllerImpl#create wasn't failing its UI thread assertion.
It did start to fail for N4 with KitKat, so this fixes the issue and
re-enables the test.

BUG=330291

Review URL: https://codereview.chromium.org/123883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243850 0039d316-1c4b-4281-b951-d872f2087c98

This makes the --url option generally available, and adds tests for
starting Chrome with a URL, with and without a simultaneously
restoring a session.

Note:- As part of this I have added to telemetry the ability
to specify different browser options for each page, and to
specify the startup URL in the page set (this could easily
be extended to other browser options). This was needed to
avoid having to create 6 separate benchmarks to test
different combinations of URLs and sessions to be restored.

BUG=298052

Review URL: https://codereview.chromium.org/113563004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243849 0039d316-1c4b-4281-b951-d872f2087c98

Process wrapping on Android currently conflicts with SELinux.

TEST=ASan content_shell test on KLP Android
BUG=325685
R=bulach@chromium.org

Review URL: https://codereview.chromium.org/120733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243848 0039d316-1c4b-4281-b951-d872f2087c98

This patch removes working on fullPath from the isMovable() method. Instead the volume manager is used.

TEST=Tested manually, also partly covered by browser tests.
BUG=329435

Review URL: https://codereview.chromium.org/130353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243847 0039d316-1c4b-4281-b951-d872f2087c98

R=enne@chromium.org
BUG=NONE
TEST=NONE (No functional change)

Review URL: https://codereview.chromium.org/130213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243846 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/130183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243845 0039d316-1c4b-4281-b951-d872f2087c98

This goes from 1% to 10% . Over Jan 7-8 we only got 3 jobs total with
no problems.

BUG=317931
R=joi@chromium.org

Review URL: https://codereview.chromium.org/131503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243844 0039d316-1c4b-4281-b951-d872f2087c98

BUG=297672
TBR=joi@chromium.org

Review URL: https://codereview.chromium.org/130173003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243843 0039d316-1c4b-4281-b951-d872f2087c98

This breaks examples of NaCl SDK.
http://build.chromium.org/p/client.nacl.sdk/builders/mac-sdk-multi/builds/6796

> PPAPI: Add new PPB_FileRef.MakeDirectory to support exclusive operation
> 
> Current PPB_FileRef.MakeDirectory returns PP_OK if a directory exists on
> the given path. This makes it difficult to create POSIX compatible API on
> top of PPAPI.
> 
> This change introduces new PPB_FileRef.MakeDirectory as dev channel API.
> That makes a new directory according to the given PP_MakeDirectoryFlags
> values. The flags provide exclusive operation option. If exclusive flag
> is specified and a directory exists on the given path, the function fails
> and returns PP_ERROR_FILEEXISTS.
> 
> 
> BUG=314879
> TEST=browser_tests
> 
> Review URL: https://codereview.chromium.org/113363004

TBR=nhiroki@chromium.org

Review URL: https://codereview.chromium.org/131473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243842 0039d316-1c4b-4281-b951-d872f2087c98

there already is information in the autofill DB.

BUG=326679

Review URL: https://codereview.chromium.org/120343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243841 0039d316-1c4b-4281-b951-d872f2087c98

In OSExchangeData, there's a difference between URLs and files. In the
mime type "text/uri-list", there isn't, and Linux usually uses the later
to exchange both data types.

This fixes dragging files onto several sites, like the HTML Five Wow
Terminal, but doesn't fix Dropbox, which seems to be failing somewhere
else.

BUG=317548

Review URL: https://codereview.chromium.org/129113004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243840 0039d316-1c4b-4281-b951-d872f2087c98

BUG=330823
TEST=Regression testing manually
NOTRY=TRUE

Review URL: https://codereview.chromium.org/110853006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243839 0039d316-1c4b-4281-b951-d872f2087c98

Will rebaseline.

> Revert of https://codereview.chromium.org/128443002/
> Reason for revert: a bunch of video* layout tests failed http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/24977
> 
> TBR=reed@google.com,thestig@chromium.org,jochen@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=332271
> 
> Review URL: https://codereview.chromium.org/130963002

TBR=alph@chromium.org

Review URL: https://codereview.chromium.org/131443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243838 0039d316-1c4b-4281-b951-d872f2087c98

This means that running with --reset-app-list-install-state
--enable-app-list always re-installs the app list, even if it has
already been installed.

BUG=332324

Review URL: https://codereview.chromium.org/127753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243837 0039d316-1c4b-4281-b951-d872f2087c98

BUG=316685

Review URL: https://codereview.chromium.org/110883015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243836 0039d316-1c4b-4281-b951-d872f2087c98

Call WebSocketMsg_NotifyFailure instead of
WebSocketMsg_AddChannelResponse(true, ...) when the opening handshake fails.

BUG=310405
R=ricea@chromium.org

Review URL: https://codereview.chromium.org/105833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243835 0039d316-1c4b-4281-b951-d872f2087c98

It is no longer used.

BUG=

Review URL: https://codereview.chromium.org/101013004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243834 0039d316-1c4b-4281-b951-d872f2087c98

BUG=329978
TEST=none
R=palmer@chromium.org

Review URL: https://codereview.chromium.org/98753005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243833 0039d316-1c4b-4281-b951-d872f2087c98

BUG=299154
TEST=unit_tests
R=estade@chromium.org

Review URL: https://codereview.chromium.org/127403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243832 0039d316-1c4b-4281-b951-d872f2087c98

so that rebuilding detail inputs on Autofill popup acceptance doesn't crash.
This also changes the public AutofillDialogView API to accept ServerFieldTypes
intead of DetailInputs in FillSection() and HitTestInput().

NOTE: |input.type| was the only thing used by all callers anyways, so rather than
dance around resetting a potentially dead pointer, I'd rather change to server
types.

BUG=331544
R=estade@chromium.org,groby@chromium.org

Review URL: https://codereview.chromium.org/127153004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243831 0039d316-1c4b-4281-b951-d872f2087c98

adb forward --remove is not available in older adb binaries;
to avoid leaks, maintain a pool of previously forwarded ports.

BUG=None

Review URL: https://codereview.chromium.org/127143003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243830 0039d316-1c4b-4281-b951-d872f2087c98

While Custom Element callbacks were being renamed in Blink, WebView
had to work with either old or new names. The new names are available
post Blink r164213, so it's OK to use the new names exclusively now.

BUG=180965
TEST=WebViewTest.*

Review URL: https://codereview.chromium.org/127133004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243829 0039d316-1c4b-4281-b951-d872f2087c98

This avoids duplicating the default logic for all of its methods.
Previously, every time a method was called, we had to test for NULL and
assume the default value for that method (even though the default method
implementation already exists; it was never used). Now the caller
assumes platform_observer_ is non-NULL (via a DCHECK) and it is the base
class's responsibility to provide default methods.

Review URL: https://codereview.chromium.org/124893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243819 0039d316-1c4b-4281-b951-d872f2087c98

Packaged apps do not have access to some features of the Web platform
that are deprecated, or that do not make sense in the context of an
app. Currently, accessing most of those features throws an error.

This change makes thse features behave more like missing featurs on the
Web platform. Whenever possible, accessing restricted features returns
undefined and logs an error to the browser console. Features accessible
via non-configurable ES5 properties (e.g. window.alert, document.write)
either become no-ops or throw errors, on a case-by-case basis.

Deprecated events have their "on*" properties return undefined (as
opposed to null, for events with no handlers) to facilitate feature
detection. Using addEventListener for these events used to throw an
error, and now logs an error to the console and turns into a no-op, to
mimic the behavior for undefined events as well as possible.

This change aims to make JavaScript libraries written for browsers work
in packaged apps as seamlessly as possible, while still providing useful
warnings for developers. This creates a couple of warts: (1) properties
are not removed, so the "in" operator will still see them, and (2)
dispatchEvent will never deliver deprecated events, but it normally
delives un-implemented events.

BUG=330487

Review URL: https://codereview.chromium.org/120733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243817 0039d316-1c4b-4281-b951-d872f2087c98

Previously, sort was not started until all the metadata is fetched. When fetching took a time, the user saw unsorted list for a while. With this patch, sort is happened just after every updates. User can see sorted list every time.

BUG=327479
TEST=manually tested

Review URL: https://codereview.chromium.org/113293007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243816 0039d316-1c4b-4281-b951-d872f2087c98

BUG=331223

Review URL: https://codereview.chromium.org/122803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243814 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243813 0039d316-1c4b-4281-b951-d872f2087c98

This patch removes the last instance of fullPath from the metadata cache, by using volume manager and its getLocationInformation method.

TEST=Tested manually.
BUG=320967

Review URL: https://codereview.chromium.org/130663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243812 0039d316-1c4b-4281-b951-d872f2087c98

TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/131103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243811 0039d316-1c4b-4281-b951-d872f2087c98

$ git log f1632c7d11..def5b803e9 --date=short --format="%ad %ae %s" | sed 's/@chromium\.org//'
2014-01-08 maruel Allow extra argument in run_isolated.py.
2014-01-08 maruel Add date in the temporary name generated by isolate.py run.

BUG=321878

Review URL: https://codereview.chromium.org/130563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243810 0039d316-1c4b-4281-b951-d872f2087c98

In order to be compatible with the v2 version of the update protocol and
existing update configuration files, the "os" attribute (and fwiw, "arch")
must be serialized as part of the <request> element.

BUG=332551

Review URL: https://codereview.chromium.org/130543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243809 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243808 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243804 0039d316-1c4b-4281-b951-d872f2087c98