- 02 Aug, 2019 40 commits
-
-
Edvard Thörnros authored
The animation test "correct-events-for-short-animations-with-syncbases.html" used to be flaky. This is an attempt to fix it and also convert it to a web platform tests. Verified to run in FF and Chromium. Colors were also changed reflect their usage. Bug: 981522 Change-Id: Ieead9ca1c5ccf050ac2e886ecf630d9a9f61b6e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732097 Auto-Submit: Edvard Thörnros <edvardt@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#683542}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/97bc222c..9ccf13eb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia0a0b9016576dd9be9bb9a55066921353e81598c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732771Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683541}
-
Mohamed Abdelhalim authored
Now that NavigationHandleImpl is a wrapper around NavigationRequest, transforming NavigationHandleImplTest to NavigationRequestTest, and removing it from NavigationHandleImpl friends. Change-Id: Ibc1054611e5c61879121bd7229db493a921877b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729261 Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org> Reviewed-by:
Lowell Manners <lowell@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#683540}
-
Eric Willigers authored
scroll-behavior is auto or smooth. https://drafts.csswg.org/cssom-view/#propdef-scroll-behavior Change-Id: I3620234e38bb4905176bce61b2ebc8f66537ca7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732789Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#683539}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0e04cdf70fe2..ccb8f1c82e61 git log 0e04cdf70fe2..ccb8f1c82e61 --date=short --no-merges --format='%ad %ae %s' 2019-08-02 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-08-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 1dbbc7b3e232..369f9e5df60b (7 commits) 2019-08-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 9aeb39b9..01452feb (403 commits) Created with: gclient setdep -r src/third_party/skia@ccb8f1c82e61 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: chromium:None,chromium:None Change-Id: Iddabd728e1bea5b2103769cb979d4a823271accf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732512Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683538}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/432573ac119d..e52728367fa3 git log 432573ac119d..e52728367fa3 --date=short --no-merges --format='%ad %ae %s' 2019-08-02 fmayer@google.com Merge "Set python_version for merged_sql_metrics." Created with: gclient setdep -r src/third_party/perfetto@e52728367fa3 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I67dc38241c690538250114fb683af0e3405a3f81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733030Reviewed-by:
-
Anastasiia Nikolaienko authored
Bug: 989849 Change-Id: Id3d68e7fadae8a87722169900fe91b865448af02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732091 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#683536}
-
Justin Cohen authored
Workround for out-of-sync tableView and model data when ReadingListTableViewController is incorrectly kept alive. Bug: 988909 Change-Id: I53260558a419bb910b296cffe85674fa2918f96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731432Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#683535}
-
Ioana Pandele authored
Removing the flag, since utomatic password generation is fully launched. This CL also moves the expiry date for the manual password generation flag. Bug: 835234 Change-Id: Id1565b2b115b5c98274c1befec2f8934f3bb2a8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731897Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#683534}
-
Benoît Lizé authored
https://chromium-review.googlesource.com/c/chromium/src/+/1730834 refactored some GN files, and as a result generation fails on ARM64, see attached bug. This is due to an unused variable in some cases. Mark it as such to avoid generation errors. TBR: tiborg@chromium.org Bug: 990278 Change-Id: Ief4463de27cb4afe2699cb18ef0ac8aefca721bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732080Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#683533}
-
Alexandre Courbot authored
We used to strongly associate requests to input buffers, but doing so is sub-optimal: a request may not be completed even if its associated input buffer has been dequeued, meaning we cannot reuse the request just yet. This CL addresses this by dissociated requests from input buffers and putting them into a FIFO queue: when constructing a V4L2RequestDecodeSurface, we always take to least recently used request, maximizing its odds of being completed at the time. Bug: 917279 Test: VDA unittest passing on Kukui with required IP changes. Change-Id: I3e84c1d9120cdded3876fa8f4a91fad964563ac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731011 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#683532}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ib8ea5755225fc12467318e8d89a4963775038217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733109Reviewed-by:
-
Bo Liu authored
Make TaskQueueWebView an abstract interface. The old implementation becomes TaskQueueSingleThread, with some cleanups. Add new TaskQueueViz which implements code required for viz thread scheduling tasks to render thread without ability to block on it at any time. Add a kVizForWebView to switch between the two implementations, and use to distinguish the code paths in the future. Nothing uses TaskQueueViz in this CL yet, but the viz prototype has been rebased onto this and works. Bug: 805739 Change-Id: I0fe6c935fa7b1536700bd84950397ac756c4209e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729473 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#683530}
-
Mohamed Abdelhalim authored
This includes moving the checks in GetResponseHeaders from NavigationHandleImpl to NavigationRequest. Bug: 916537 Change-Id: I3e2c1bae2887d0b024ac3df6817b4bde40cfcb86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729254Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
Yi Su authored
TabGridBottomToolbar is changed from UIToolbar to UIView in this CL: http://crrev/c/1715188 Override its "intrinsicContentSize" to return the correct size. Bug: 989390 Change-Id: I4cc81f4bb4f55eba49447aa7e5e57135b7487939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730897 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#683528}
-
Carlos Caballero authored
OS_WIN is defined in build/build_config.h so #if defined(OS_WIN) must appear after that include. Change-Id: I3699e4bafb337f485eee62c6b782df46c21e7791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730894 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#683527}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/07475fa782de..31899ec2ac04 git log 07475fa782de..31899ec2ac04 --date=short --no-merges --format='%ad %ae %s' 2019-08-02 tbarzic@google.com Increase parallel emerge job output interval Created with: gclient setdep -r src/third_party/chromite@31899ec2ac04 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I1312b9695e1581219457227beebb76c7a4600177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733009Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium fd0bec2f. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" 6790530d "[WPT/common/security-features] Make subresourceContext unmodified" 219bce7d "Worker: Add upgrade-insecure-requests tests for top-level classic shared worker script loading" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I90ea852ac71df99f922fcad1a309f17453ab3f43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731512Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683525}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/369f9e5df60b..5e6468ba6b6f git log 369f9e5df60b..5e6468ba6b6f --date=short --no-merges --format='%ad %ae %s' 2019-08-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src eea340047eca..a0eb5efd2bad (1 commits) Created with: gclient setdep -r src/third_party/angle@5e6468ba6b6f The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: chromium:None Change-Id: I65962fb26216f3c9e1cbd042a8c4bf48ece1caa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732685Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f50c2ff2f70c..432573ac119d git log f50c2ff2f70c..432573ac119d --date=short --no-merges --format='%ad %ae %s' 2019-08-02 fmayer@google.com Merge "Parse line numbers for llvm-symbolizer." Created with: gclient setdep -r src/third_party/perfetto@432573ac119d The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I589e96bc4ac9e1b93eef2715b4e136c2570eba30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733010Reviewed-by:
-
François Beaufort authored
Following https://dawn-review.googlesource.com/c/dawn/+/9641, a GPURenderPipeline fragmentStage is not required anymore. Note that it will still raise a validation error as vertex-only render pipelines are not supported yet in Dawn. Bug: 877147 Change-Id: I2ccf88974fa011a6ba3a45d229e36e40e23c5dc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730057Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#683522}
-
Mikel Astiz authored
It seems like, in rare cases, the local changes sync up to the server before the test has the chance to assert that local changes are pending. Since the condition is not crucial for the test, let's just skip it. Bug: 956043 Change-Id: Ia515d174aeae3f8ccf5648e46ed79e685d9e29e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731934 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
When WebUsage is disabled, the touch recognizer is disconnected from the WebController. The WebController is no longer notified of the touch events. The touch recognizer was never reconnected, even when WebUsage was enabled back. This CL completely removes the touch recognizer from the Container view when the WebUsage is disabled, but add a new one when it is re-enabled. Bug: 987613 Change-Id: I696955bf0d28ee08658f5e788afcb1ffc07cdc12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724672 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#683520}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b0db4f56..97bc222c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic12beacf693c76ec193e40f3be4333c6c8cce301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731340Reviewed-by:
-
Arthur Hemery authored
PerNavigationMojoInterface is turned on by default. Beta/Stable rollout gets controlled by a finch config. Bug: 784904, 988368 Change-Id: I3e0fd0af1b47582764fb076a5be244a700b9bfc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710320Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#683518}
-
Juan Antonio Navarro Perez authored
The 'options' argument has been replaced with a new 'run_options', where callers are expected to pass a fully formed options object with all settings required to run benchmark stories. This also requires clients to provide an output_dir suitably wired to a temp_dir for tests. Bug: 985712 Change-Id: If26078caa61f7b0a006906420899109d1f4e9a8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720839 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ravi Mistry <rmistry@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#683517}
-
Mikel Astiz authored
Latency is a priority for our team in the next year so we're extending the expiration for the relevant metrics. Bug: 988629 Change-Id: I2b26a29d3722d6dfa0907eb626eddf07c8d1ead8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731830 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#683516}
-
Philip Jägenstedt authored
SpeechGrammar's addFromUri method was already measured because the capitalization doesn't match the spec, but also measure the other parts of the grammar API surface to learn how widely used it is. Prompted by spec issue: https://github.com/w3c/speech-api/issues/57 Change-Id: Ib9289f911ad4966d5e0c836924444cd1d3b4be60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732790 Auto-Submit: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#683515}
-
Anton Bikineev authored
Theoretically, if the scheduler for some reason doesn't destroy the callback right after its execution, CancelableTaskScheduler::CancelAndWait may stall. I'm not sure if this is the reason why performance tests fail with timeouts on win-perf, but it may be related to Windows scheduler specifics. Bug: 987574 Change-Id: Id3bf951c78bf37aae66ce0657e113ddefe9918b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731930 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=grunell@chromium.org, jbroman@chromium.org Bug: 968047 Change-Id: Id8a11433f2c3e2d37c5452bab643ed098441b435 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728886 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Reviewed-by:Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#683513}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/eea340047eca..a0eb5efd2bad git log eea340047eca..a0eb5efd2bad --date=short --no-merges --format='%ad %ae %s' 2019-08-02 johnkslang@users.noreply.github.com Merge pull request #1860 from zoddicus/fixShaderCRoll Created with: gclient setdep -r src/third_party/glslang/src@a0eb5efd2bad The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,geofflang@google.com Bug: None Change-Id: Id612423397a0b4bb1edb2ab7dacee09136fa0118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732792Reviewed-by:
-
Matt Giuca authored
This reverts commit addae291. Reason for revert: Still flaking (see https://crbug.com/990229). Original change's description: > Re-enable ChromeVox panel tests > > TBR=sky@chromium.org > > Bug: 795840 > Change-Id: Idc11aa884c29cd73960355e660ce2219aa674621 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534283 > Reviewed-by: David Tseng <dtseng@chromium.org> > Commit-Queue: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#644494} TBR=dmazzoni@chromium.org,sky@chromium.org,dtseng@chromium.org,anastasi@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 795840, 990229 Change-Id: I2de806da00fb806e042d2a89b71026738105348a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732889 Commit-Queue: Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#683511}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/87ba747e956d..07475fa782de git log 87ba747e956d..07475fa782de --date=short --no-merges --format='%ad %ae %s' 2019-08-02 vapier@chromium.org lint: catch excess quotes at the start of docstrings 2019-08-02 vapier@chromium.org third_party: import pylint_quotes module for linting 2019-08-02 mmortensen@google.com Refactor artifacts.BundleEbuildLogs to use service/lib structure. Created with: gclient setdep -r src/third_party/chromite@07475fa782de The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ieedfec86be40b306f33291980fd2d4853dfc2a6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732517Reviewed-by:
-
Yang Guo authored
Also make punctuation consistent across descriptions of the Renderer Panel. Bug: 989861 Change-Id: I4f1026d1899fb5965f791d1ae6891073a6e4e637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730412 Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Yang Guo <yangguo@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Jeff Fisher <jeffish@microsoft.com> Cr-Commit-Position: refs/heads/master@{#683509}
-
Miyoung Shin authored
This CL renames *_struct_traits.* to *_mojom_traits.* in //services and fixes the wrong header guard name. *_struct_traits.* => *_mojom_traits.* Bug: 806965 Change-Id: I4e45625070fa592af6c05a734a15f46e08378ba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730411Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#683508}
-
Yi Su authored
Now that pending NavigationItem are stored in NavigationContext, it will never be null. Remove the legacy code that checks if pending NavigationItem exists in CRWWKNavigationHandler. Bug: 925304 Change-Id: I5eb541f068b4a6db1f5322fed2e7318d686a845a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730424 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
-
Ken Rockot authored
r683358 introduced a bug where in a SpellCheckHost.CallSpellingService message response callback may be dropped without being called whenever the source render process has been terminated. That can result in a DCHECK being hit in testing environments but is otherwise harmless. This CL fixes the issue by ensuring that the response callback gets called in the case where the process has been terminated. Bug: 977637 Change-Id: I6d815be3cad8199c7f8bef27ac10f322b217f881 Tbr: thestig@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732678Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#683506}
-
Lutz Justen authored
The presubmit told me so. TBR=rsorokin@chromium.org BUG=b/138287069 TEST=None Change-Id: I6e32ff7e4cc74e044e949e09a75d8fffbd271c5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731835Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#683505}
-
Takuto Ikuta authored
Change-Id: Ie171df6c108992ecaf417f95de24bb43e1d79967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732076 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#683504}
-
Alan Cutter authored
PendingAppManagerImplBrowserTest.BypassServiceWorkerCheck tests whether the pending app installation installs the app as a PWA rather than a shortcut app. This can be determined by the presence of a scope. The function FindAppWithUrlInScope() uses a default scope if there isn't one present so its return value can't be used as an indication of the app having/not having a scope. This CL improves the check by explicitly checking GetAppScope(). Change-Id: Ieeb0c9dfb911cf3af5657e53ed86f65b60a8f07d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732516 Commit-Queue: Alan Cutter <alancutter@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#683503}
-
