- 06 Sep, 2018 40 commits
-
-
Manas Verma authored
Previously, if we save a card twice in a row, the second time the animation needs to be shown, it would just show static text. The animation continues to glitch for each subsequent use. Now the animation works properly each time it is invoked. This also applies to the pop-up blocker's "Pop-up blocked" text animation. Bug: 855186,881324,881320 Change-Id: Ie6f8a53a24d5ec4dd06b9ead27b784fc46a26310 Reviewed-on: https://chromium-review.googlesource.com/1208140Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#589356}
-
Michael Giuffrida authored
Register and download the demo mode resources CrOS component during online demo mode setup. This happens before online enrollment starts. Also updates offline-enrolled Demo Mode to always use the offline resources image instead of attempting to download the CrOS component. Bug: 869455 Change-Id: I6a947eab916f68bba4730a9ab611136be7fe1bc1 Reviewed-on: https://chromium-review.googlesource.com/1198018 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#589355}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a3895348. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24196 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: Ib75a8ff8ee0a7f3bf3011ab31088fddcb4d37144 Reviewed-on: https://chromium-review.googlesource.com/1211843 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#589354}
-
Wez authored
Clear the |*base|-address out-parameter to null in case of blocking, to ensure that calling-code won't get confused by seeing a failure NTSTATUS with a non-null base-address. e.g. Win32's MapViewOfFile() returns the base-pointer as its result, using null to indicate failure, and leaves the Win32 GetLastError() set based on the NTSTATUS. Bug: 864351, 870663 Change-Id: I0aa2aacd1075224100d10d6291a416849f6d227b Reviewed-on: https://chromium-review.googlesource.com/1211322Reviewed-by:
Robert Shield <robertshield@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#589353}
-
Bo authored
This reverts commit 0c9c754f. Reason for revert: Underlying issue (crbug.com/880203) is fixed. Original change's description: > Mark InterstitialPageTest#testCloseInterstitial as flaky > > Bug: 879757 > > Change-Id: Ib8fbd95f086d95fc0f1ac00526059a7383e2ca24 > > TBR=boliu@chromium.org > > Change-Id: Ib8fbd95f086d95fc0f1ac00526059a7383e2ca24 > Reviewed-on: https://chromium-review.googlesource.com/1200165 > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588214} TBR=boliu@chromium.org,oksamyt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 879757 Change-Id: I6c31bda83ad0a72c76fcb4054b14343478f7683f Reviewed-on: https://chromium-review.googlesource.com/1211960Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#589352}
-
Steven Bennetts authored
Bug: 870903, 866839 Change-Id: I9747dfdb7c682c86c3aae201db7e74faa126aaf8 Reviewed-on: https://chromium-review.googlesource.com/1184314Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#589351}
-
Xiangjun Zhang authored
This CL fixed the CastRemotingConnector to support OffscreenTab mirroring/remoting using Mirroring Service. However, when Mirroring service is not used, remoting an OffscreenTab is still not supported. Bug: 734672 Change-Id: I09aab2d76be9d1b466d5c54a3d5eb66c7a6ff83f Reviewed-on: https://chromium-review.googlesource.com/1200321 Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#589350}
-
Eric Roman authored
Add comments explaining different results for NetworkContextTest.ProxyErrorClientNotifiedOfPacError on iOS. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Iee8707645813ad7af92f7a4e84403ccacc22abd0 Reviewed-on: https://chromium-review.googlesource.com/1208932 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#589349}
-
Ryan Cui authored
Adds screen brightness mojo methods to assistant device API. Generalizes volume action methods to handle slider actions. BUG:b/78189672 BUG:b/111130167 Change-Id: I5a8759478ec6ecef5b950839d644bca11cd88bbc Reviewed-on: https://chromium-review.googlesource.com/1194984 Commit-Queue: Ryan Cui <rcui@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#589348}
-
Tim Zheng authored
BUG=chromium:879737 TEST=This is a test case. Change-Id: I57c11e9ad663081ec6ee56b5dd4afa58db470384 Reviewed-on: https://chromium-review.googlesource.com/1211113Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Tim Zheng <timzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#589347}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/59d21660a3d9..aaff8f8b902a git log 59d21660a3d9..aaff8f8b902a --date=short --no-merges --format='%ad %ae %s' 2018-09-06 hnakashima@chromium.org Discard deps that are not sync'ed anymore in safetynet_compare.py. Created with: gclient setdep -r src/third_party/pdfium@aaff8f8b902a The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Id9422dca4b077437ff7f7672fa01d7f3ab401435 Reviewed-on: https://chromium-review.googlesource.com/1211865Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589346}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/41db1841..e1220339 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I26eb6a975247973694e3d72c7a6bffd99c9420a3 Reviewed-on: https://chromium-review.googlesource.com/1211903Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589345}
-
Jian Li authored
The following parameters are added: 1) Select either top or bottom snackbar 2) Set stable offline wait time 3) Allow to bypass getting connectivity info from system and run our own http probes Bug: 881064 Change-Id: I72bbb82f2deb9f6222d25191380c048a53a4c815 Reviewed-on: https://chromium-review.googlesource.com/1208445Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#589344}
-
Chris Mumford authored
Send the encryption key to network service so that the process does not request the item from the keychain directly, which would cause macOS to show a confirmation prompt. Bug: 880522 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ia1067bf809472653d843b9007a45574bfe10ed2c Reviewed-on: https://chromium-review.googlesource.com/1208457 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#589343}
-
Aldo Culquicondor authored
The delegates communicate through 2 channels in the android implementation: 1. WebXrPresentationState, owned by the scheduler. 2. The public interface of VrShellGl. Ideally, this interface should remain very small to ensure the task separation. VrShellGl now only implements the CompositorDelegate, and it's soon to be renamed. RenderLoop now owns the delegates. Bug: 875291 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia30e62ed249b5fc0682b8f2b943eef615408daa3 Reviewed-on: https://chromium-review.googlesource.com/1191864 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#589342}
-
Evan Stade authored
This is necessary so the initial bounds can be calculated correctly. The app window requests a size for the content bounds and ClientSideNonClientFrameView tacks on kTopViewInset. Bug: 880584 Change-Id: I0584e6aef313cde4e17bcf7c58a59830815ff831 Reviewed-on: https://chromium-review.googlesource.com/1208937Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#589341}
-
Denis Kuznetsov authored
Bug: 854101 Change-Id: Id53834ff2b3e596e22b22b6e8878247fd904abe2 Reviewed-on: https://chromium-review.googlesource.com/1209707Reviewed-by:
-
Scott Violet authored
Removes client_created_windows_ and folds into known_windows_map_. This also ensures embedded clients can't intercept events. BUG=none TEST=covered by tests Change-Id: I529d553c0079287b18c7feaab67b81fda65d412f Reviewed-on: https://chromium-review.googlesource.com/1211952Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#589339}
-
Emil A Eklund authored
Tbr: kojii@chromium.org Bug: 881110 Change-Id: Ib1007641d09eec0ad372f2641bec77bc1c8643c8 Reviewed-on: https://chromium-review.googlesource.com/1211709Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#589338}
-
Brandon Wylie authored
Bug: 875088 Change-Id: Ied195d731d991553fc3df4243c131a633111e38d Reviewed-on: https://chromium-review.googlesource.com/1204722Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#589337}
-
Ben Pastene authored
This script that runs in the VM only runs after all the test binaries & deps have been pushed. Consequently if a test generates crash dumps, it won't get cleaned up until the next test pushes all its deps (which might not fit in the VM since there's left-over crash dumps.) This fixes that by ensuring that the test that generates the dumps also cleans them up. Bug: 880878 Change-Id: Icfe1559d244053998cace31bfc19f5c1606770b9 Reviewed-on: https://chromium-review.googlesource.com/1211706Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#589336}
-
James Forshaw authored
This CL changes the creation of anonymous shared memory on Windows to remove name generation on versions < 8.1. This was originally added as Windows would ignore the security of an unnamed object on XP -> 7, however from at least Windows 8.1 this is no longer the case as we can create unnamed shared memory (which will reduce memory usage slightly as well as clutter in the user's named objects directory) while still enforcing the security requirements. While this is likely to work on Windows 8 it'll only be enforced for 8.1 and above due to a lack of testing for 8. This CL applies the same changes in shared_memory_win to the platform shared memory APIs which just copied the original implementation. Bug: 880064 Change-Id: I3c61c01823a78d09ac6d220b647b26a07821ab39 Reviewed-on: https://chromium-review.googlesource.com/1209603Reviewed-by:
-
Jordy Greenblatt authored
As part of the MultiDevice Unified Setup project, the Chromebook is supposed to notify the user for each of the following situations: (1) A user who has not been through the Unified Setup Flow has a phone capable of hosting some MultiDevice features (a.k.a. 'new host'), (2) A user who has already been through the Unified Setup Flow has a new host phone on their accounts (a.k.a. 'host switched'), or (3) The currently logged in account went through the Unified Setup Flow on a different Chromebook (a.k.a. 'Chromebook added'). In the original design, implemented in https://chromium-review.googlesource.com/c/chromium/src/+/1081287 and https://chromium-review.googlesource.com/c/chromium/src/+/1089828 the Chromebook would have a bit in its preferences to indicate that it had been enabled as a MultiDevice client. However we no longer perform the verification necessary for to turn this on as part of the Unified Setup flow so the bit is longer a valid basis for determining whether/ when to fire the notifications listed above. This CL refactors the class responsible for this determination (formerly ObserverNotifier, now AccountStatusChangeDelegateNotifierImpl) so that it uses the status of an already set MultiDevice host (or the lack thereof) to decide whether/ when to fire the notifications. In particular, the HostStatusProvider class makes the raw data required readily available. ----- A minor functionality change was implemented in the 'Chromebook added' event. Prior to this CL, the check for that event, i.e. AccountStatusChangeDelegateNotifierImpl:: CheckForExistingUserChromebookAddedEvent, would not fire a notification if the SetupFlowCompletionRecorder says that the Chromebook was previously used for Unified Setup. We decided this is not ideal behavior because of the following case: A user goes through Unified Setup on Chromebook A, forgets the host on Chromebook A, and then go through Unified Setup on Chromebook B. This automatically enabled the MultiDevice features on Chromebook A. In the intended behavior before this CL (I say 'intended' because the implementation was incomplete) this would not trigger a notification and a user could be in a state in which they do not realize that Chromebook A is connecting to their host phone. Removing the check for whether Chromebook A has gone through Unified Setup prevents this from happening. It has a side effect that the user will see the 'Chromebook added' notification on Chromebook A immediately following following a successful setup on Chromebook A but this is a much smaller concern than the potential privacy issue described above. I filed a bug https://bugs.chromium.org/p/chromium/issues/detail?id=881549 to either use or get rid of the SetupFlowCompletionRecorder pointer in AccountStatusChangeDelegateNotifierImpl. ----- Note that most of the unit tests from the aforementioned CLs 1081287 and 1089828 remained relevant modulo some adaptations. A small number were dropped altogether as they were inextricably tied to the implementation. Bug: 856848 Change-Id: I49d884847f7e21516ea8af1a7264843386103c70 Reviewed-on: https://chromium-review.googlesource.com/1205495Reviewed-by:Jeremy Klein <jlklein@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#589334}
-
Doug Arnett authored
This is motivated by HTTPS Server Previews wanting to pass a large blacklist to the client to avoid unnecessary roundtrips to the litepages server. We also may want to pass a LoFi blacklist in the future and perhaps a Hint API whitelist so the proto definition should allow such additions. Bug: 864640 Change-Id: I6c74483e22dac7e5b9c4705057728ddfb1d60ea2 Reviewed-on: https://chromium-review.googlesource.com/1208951 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#589333}
-
Kim Paulhamus authored
isUVPAA is only available on Android N+ TBR=wychen@google.com Bug: 880885 Change-Id: Ic768ae32cc09013f1e7197fbbb605948e9040f5e Reviewed-on: https://chromium-review.googlesource.com/1211732Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#589332}
-
Frank Barchard authored
https://chromium.googlesource.com/libyuv/libyuv.git/+log/d694f0a82b4d..9a07219dc8fb $ git log d694f0a82..9a07219dc --date=short --no-merges --format='%ad %ae %s' 2018-09-04 fbarchard Documentation update for GYP and envionment variables 2018-09-04 fbarchard Remove GYP support from libyuv 2018-08-16 efoo Remove Android MIPs BB builder 2018-08-13 efoo Flip mirrored Windows LUCI builders to prod Created with: roll-dep src/third_party/libyuv Bug: libyuv:816 Change-Id: Ib4f63018b2aca0329f8eb9da309ae94d366c7f12 Reviewed-on: https://chromium-review.googlesource.com/1210723Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Frank Barchard <fbarchard@chromium.org> Cr-Commit-Position: refs/heads/master@{#589331}
-
Ehsan Karamad authored
When a wheel event is not consumed it will lead into either scroll or page zoom. This CL adds an enum type EventAction and a corresponding getter on WebMouseWheelEvent to clarify the action associated with a wheel event (should it not get canceled by a handler). This field simplifies the logic around finding scroll direction with use cases in feature policy vertical-scroll. Bug: 853292 Change-Id: I3d554d6b97189ed63911d97607cf7cb03bfab64a Reviewed-on: https://chromium-review.googlesource.com/1127347Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#589330}
-
Alex Newcomer authored
The bug is that when transitioning to tablet mode with a window (which will expand to fullscreen) open and a shown AppList results in a stale shelf background. This is a corner case, where the AppList does not change in visibility, it remains visible and the shelf does not know to re-evaluate its background. Maybe the shelf should observe active windows instead of relying on AppList visibility state changes? For now, we fix this corner case by forcing the shelf to re-evaluate it's background when the launcher stays open during the tablet mode transition. Test=automated and manual Bug: 879591 Change-Id: I71c8d97672824853b0edac77e1a91734ba148af0 Reviewed-on: https://chromium-review.googlesource.com/1200408Reviewed-by:
-
erikchen authored
The inspect element keyboard shortcut when it was added 8 years ago was intended to be command + shift + c. Due to a bug in the implementation, it triggered off of both <cmd + shift +c> and <cmd + option + c>. See https://codereview.chromium.org/3011002. Recent refactors fixed the logic so that it correctly triggered off of only <cmd + shift + c>. Since some users have gotten used to <cmd + option + c>, this CL manually adds that also as a hidden shortcut for devtools. Bug: 880867 Change-Id: Idb70ee26afa485874674171642b8d380b50528ad Reviewed-on: https://chromium-review.googlesource.com/1211504Reviewed-by:
-
Daniel Zhang authored
Allow AppList autocomplete to complete suggestions if SearchBoxView recieves a mouse press event. Approved by UX. Bug: 881465 Change-Id: I028b809150513567a45782fd176a8ca93ce532ca Reviewed-on: https://chromium-review.googlesource.com/1211622Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
-
John Z Wu authored
Just the @interfaces for now. Bug: 867548 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I3be40a5d150726d39b5cb6934e2f642093dee32f Reviewed-on: https://chromium-review.googlesource.com/1197726 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#589326}
-
Sky Malice authored
Specifics: +646,547 bytes normalized apk size +3 zip entries file count +41,648 bytes main lib size +409,700 bytes main dex size InstallSize: +238,503 bytes APK size +1,893,691.0 bytes Estimated installed size InstallBreakdown (+1,891,712.0 bytes): +1,656 bytes unwind_cfi (dev and canary only) size +1,441 bytes Non-compiled Android resources size +41,648 bytes Native code size +135 bytes Package metadata size +1,832,156.0 bytes Java code size +14,676 bytes Compiled Android resources size Dex: +2,020 entries fields +2,750 entries methods +655 entries types +1,370 entries strings Change-Id: I937ce431e22fe32774473ec94147b458bfac4e47 Reviewed-on: https://chromium-review.googlesource.com/1211703 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by: -
Weilun Shi authored
Adding automated test for set and reset custom background attribution. The attribution should be removed when we cleared the custom background and when a theme was applied. Bug: 857256 Change-Id: Iccabe90925bc7e7d3da8ca0fa03705264493cf7b Reviewed-on: https://chromium-review.googlesource.com/1208469 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#589324}
-
Justin Donnelly authored
This reverts commit 074455de. Reason for revert: Suspected of causing check failures across a variety of tests on the Android CFI bot. See https://crbug.com/881538 for more details. Original change's description: > Strengthen requirements on CORS-safelisted request-headers > > With this CL, some request headers that used to be treated as > CORS-safelisted are not CORS-safelisted any more. Specifically, > > - "accept", "accept-language" and "content-language" have a stronger > check on its value > - All headers whose value exceeds 128 bytes are treated as not > CORS-safelisted > - If the sum of value length of CORS-safelisted headers exceeds 1024, > then all of them are treated as not CORS-safelisted. > > This CL also implements > https://fetch.spec.whatwg.org/#no-cors-safelisted-request-header. > > This is for https://github.com/whatwg/fetch/pull/736. > > Bug: 824130 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: Ib12a7dbff6367717a43130ae59304dca55b7bf4e > Reviewed-on: https://chromium-review.googlesource.com/1196563 > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589153} TBR=toyoshim@chromium.org,yhirano@chromium.org Change-Id: I9952df291ff0aeaab0b50c6cff3de418b2272e71 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 824130, 881538 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1211958Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#589323}
-
Xiangjun Zhang authored
This CL adds the implementation in the Mirroring Service to connect to the GPU service to support the HW encoding if available. Bug: 734672 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I3380ed0dcf2f06ae0ee42dbf30bf0905475e3d78 Reviewed-on: https://chromium-review.googlesource.com/1189122Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
-
Mirko Bonadei authored
In Chromium, WebRTC's metrics implementation is never used. This is the only use case of them and it is probably possible to use the Chromium implementation provided by //third_party/webrtc_overrides. This CL moves metrics specific symbols out of the build target //third_party/webrtc_overrides:init_webrtc in order to avoid to compile too much in cases where metrics is the only thing needed. Bug: webrtc:9631 Change-Id: Id6e07a33eb2df95debee35297d99551224d2ba6e Reviewed-on: https://chromium-review.googlesource.com/1192923 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#589321}
-
John Z Wu authored
Currently retry only re-checks the ready status of the scripts. To properly retry, the scripts need to be reinjected so a new ready status can be provided. Bug: 879821 Change-Id: I3f188a3358435304006c907b7dd3799d907c6a80 Reviewed-on: https://chromium-review.googlesource.com/1200573 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
-
Ryan Hansberry authored
Use a new Smart Lock user pref to track if Smart Lock is fully enabled. This removes the need to consider additional complexity when migrating to Unified Setup. Additionally, make EasyUnlockServiceRegular and ProximityAuthProfilePrefManager now consult MultiDeviceSetupClient if Smart Lock is enabled (and listen on feature state changes from it). To be clear, these two classes no longer directly set the Smart Lock user pref, and instead only determine if Smart Lock is enabled by asking MultiDeviceSetupClient. R=jhawkins@chromium.org, jlklein@chromium.org Bug: 881435 Change-Id: I0a8535c19789e826d277258f76ce384e27cc8652 Reviewed-on: https://chromium-review.googlesource.com/1211246Reviewed-by:
James Hawkins <jhawkins@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#589319}
-
Justin Donnelly authored
This reverts commit bd27fde7. Reason for revert: Suspected of causing check failures across a variety of tests on the Android CFI bot. See https://crbug.com/881538 for more details. Original change's description: > FetchManager should not set "referer" HTTP header > > Instead it should use ResourceRequest::SetReferrerString and > ResourceRequest::SetReferrerPolicy. > > Bug: 863769 > Change-Id: I4de47bae9aa259ace5ffb5bbdd17d6cf423931d7 > Reviewed-on: https://chromium-review.googlesource.com/1203474 > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Dominic Farolino <domfarolino@gmail.com> > Cr-Commit-Position: refs/heads/master@{#589159} TBR=yhirano@chromium.org,domfarolino@gmail.com Change-Id: Ie5e58f0e1b794acf2e9ca2f7d1ae24f043d9fe8e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 863769, 881538 Reviewed-on: https://chromium-review.googlesource.com/1211957Reviewed-by:
-
Roman Kuksin authored
The test fails due to a race of UkmRecorder::AddEntry with DOMMessageQueue::Observe: https://cs.chromium.org/chromium/src/services/metrics/public/cpp/delegating_ukm_recorder.cc?q=src/services/metrics/public/cpp/delegating_ukm_recorder.cc&sq=package:chromium&g=0&l=137 Bug: 880217 Change-Id: Icf099c3eb1094d8a571dc6f87b152e3c838807dc Reviewed-on: https://chromium-review.googlesource.com/1204011Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#589317}
-
