- 30 Jun, 2020 40 commits
-
-
Xida Chen authored
This Cl converts base::Bind to base::BindRepeating in banners/ This is a code health CL, no behavior change. Bug: 1007635 Change-Id: I52576f02d18bd51171c6b0d43a38f73ba0ada95e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273485 Auto-Submit: Xida Chen <xidachen@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#783788}
-
dpapad authored
There is no benefit by using cr-input, as the UI of this element is heavily customized anyway, and none other features of cr-input are needed. Bug: 1100432 Change-Id: I9831a981dc790b83570a9d6645ffab1af2e290cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271105Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#783787}
-
Sammie Quon authored
These are continued to be use for performance measurement. Test: none Fixed: 1089982 Change-Id: I95aa09b5587b1171bd374520ba904dde3b3358cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274587Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#783786}
-
Panos Astithas authored
Bug: 646113 Change-Id: Ib16b182766ec63175c49ba6dc27d5a4ae1d67677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256157 Commit-Queue: Panos Astithas <pastithas@google.com> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#783785}
-
Toby Huang authored
This CL removes an enum and icon related to the deprecated legacy supervised users that's no longer needed or referenced in the code base. Bug: 1090844 Change-Id: I3002cbe6a028c9d895780583eb330af07aa25fee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271170Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#783784}
-
Julie Jeongeun Kim authored
This CL moves PrintHostMsg_DidPreviewDocument_Params to //printing/mojom/print.mojom to pass it to Mojo interfaces. It's a precursor CL of PrintHostMsg_MetafileReadyForPrinting mojofication. Bug: 1008939 Change-Id: I83b988849cbc93b780d9422d2ac3e5065e51fbbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257035 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#783783}
-
Stephan Hartmann authored
GCC is confused by multiple definitions in different namespaces and fails like this: ../../third_party/blink/renderer/platform/widget/widget_base_client.h:153:24: error: declaration of 'virtual blink::FrameWidget* blink::WidgetBaseClient::FrameWidget()' changes meaning of 'FrameWidget' [-fpermissive] 153 | virtual FrameWidget* FrameWidget() { return nullptr; } | ^~~~~~~~~~~ Bug: 819294 Change-Id: If2f6ab4e75f5d4c87657620de84a50b85b2af960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273229Reviewed-by:Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#783782}
-
Amin Hassani authored
Also move the ownership from senj@ to ahassani@ and chromeos-core-services@ BUG=1089610 TEST=None Change-Id: I7db9e20dd0dc1a595d11884cc49bbde078993707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250711 Auto-Submit: Amin Hassani <ahassani@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
David Black authored
We will maintain a distinct "ticker" for each timer to workaround synchronization issues that exist with ticking multiple timers in unison due to differences in their respective fractional seconds remaining. Bug: b:149570650 Change-Id: Ie5e4d1aa53b9ae2189514ad626b21168ae668a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271521Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@google.com> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#783780}
-
Sergey Ulanov authored
OutputPresenterFuchsia implements gpu::OutputPresenter interface for Fuchsia using Scenic's ImagePipe interface. In the future ImagePipe will be replaced with a new interface, which will allow to render overlays. Bug: 1090447 Change-Id: Ib3c12c4df733b7ef781c8381a1ed42fbba3155c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254704Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#783779}
-
rbpotter authored
Remove the zoom toolbar from the UI when the PDFViewerUpdate flag is on, since zoom controls will be located in the main toolbar in this case. Bug: 1099550 Change-Id: I754c2e69130da4b8463a2d928ba7af8656ee1ec2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269486 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#783778}
-
Sophey Dong authored
onAttach(Activity) is used instead of onAttach(Context) prior to API23, so it was not being run. This switches the call to initialize the tabs to onCreateDialog(). Bug: 1099644 Change-Id: Icc74d69e89eb5d5b49251df52402c4065953045e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274858Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#783777}
-
rbpotter authored
Bug: 1000989 Change-Id: If2b8bf89c4577a5123a1570b27bd2b4243ab3530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271070Reviewed-by:
-
Scott Little authored
This histogram is still in use, so this CL extends the expiration of the PageSerialization.ProblemDetection.LoadedImagePercentage histogram. Fixed: 1089213 Change-Id: I92d5011fa21eb521393e0324f3c0c9b1328f5388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269539 Auto-Submit: Scott Little <sclittle@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/33603fd54117..3a54b68cb436 2020-06-29 hcm@google.com release notes for 85 to web page 2020-06-29 hcm@google.com Update Skia milestone to 86 2020-06-29 bungeman@google.com Allow fontmgr factory to depend on fontmgrs. 2020-06-29 brianosman@google.com SkSL ByteCode: Remove specialized instructions for N up to 4 2020-06-29 michaelludwig@google.com Remove workarounds to support legacy coord transforms 2020-06-29 johnstiles@google.com Update SkColorFilterShader to use an inputFP instead of RunInSeries. 2020-06-29 robertphillips@google.com Revert "Add storage on the surface for its last render task" 2020-06-29 jmbetancourt@google.com Clean up skottielib: modify access to package classes and delete unneeded code 2020-06-29 bsalomon@google.com Reland "Don't flatten images in SkImageShader" 2020-06-29 fmalita@chromium.org Add a full build option for SkottieKit 2020-06-29 johnstiles@google.com Update SkGaussianColorFilter to support an input FP. 2020-06-29 robertphillips@google.com Be more consistent about calling release procs in SkImage factories (take 2) 2020-06-29 johnstiles@google.com Update SkSRGBGammaColorFilter to accept an input fragment processor. 2020-06-29 johnstiles@google.com Clean up GrColorSpaceXformEffect to allow a null child FP. 2020-06-29 michaelludwig@google.com Remove GrFragmentProcessor::addCoordTransform() 2020-06-29 adlai@google.com Finish the DDL sk_sp migration 2020-06-29 djsollen@google.com Revert "Don't flatten images in SkImageShader" 2020-06-29 adlai@google.com Add storage on the surface for its last render task 2020-06-29 robertphillips@google.com Use recording context more widely in SkGpuDevice If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1097484 Tbr: ethannicholas@google.com Change-Id: I27acae8332e81c329ccdbf446ead2bb5840166c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274664Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783774}
-
Scott Little authored
The OfflinePages.SavePageTime.* histograms are still in use, so this CL extends the expiration of them. Fixed: 1089765, 1089766 Change-Id: I595c5109ff15bc7b6e33304e21489c645f8d2008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269697 Auto-Submit: Scott Little <sclittle@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Scott Little authored
The OfflinePages.PageAccessInterval.* histograms are still in use, so this CL extends their expiration. Fixed: 1089759, 1089760 Change-Id: I997f39f8fc5d8705ffc4946774673d54841ea7f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268234 Auto-Submit: Scott Little <sclittle@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Kenichi Ishibashi authored
To mojofy writing service worker resources (scripts). Bug: 1055677 Change-Id: Ibc975cfbbddcb692977e15d0aa7a792547ef7630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269985 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#783771}
-
Jia authored
Bug: 1090132 Change-Id: Ieed0da666c9d1baae3a16cf8bd667c83a196c4fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272180Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#783770}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eef73d8cd3f8..42bac92a0600 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC dalecurtis@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: dalecurtis@google.com Change-Id: Ida3b642a5e4cd03015152c856ebff2f612640dd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274670Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783769}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I01d21f4fd8cdc5f40fed64cde9ce2fe32ad02e51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274859Reviewed-by:
-
Scott Little authored
These histograms are still in use, so this CL extends the expiry of the OfflinePages.ClearStoragePreRunUsage2.* histograms. Fixed: 1089140 Change-Id: Iebe0bd696e5dc6b055341f3f01750efc91e88108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268641 Auto-Submit: Scott Little <sclittle@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Scott Little authored
This CL extends the expiration of several OfflinePages.ConsistencyCheck.* histograms: OfflinePages.ConsistencyCheck.Legacy.DeletedHeadlessFileCount OfflinePages.ConsistencyCheck.Persistent.ReappearedFileCount OfflinePages.ConsistencyCheck.Persistent.MissingFileCount OfflinePages.ConsistencyCheck.Persistent.Result OfflinePages.ConsistencyCheck.Persistent.ExpiredEntryCount OfflinePages.ConsistencyCheck.Temporary.PagesMissingDbEntryCount OfflinePages.ConsistencyCheck.Temporary.Result OfflinePages.ConsistencyCheck.Temporary.PagesMissingArchiveFileCount Fixed: 975893, 975568, 984225, 1089142, 984186 Change-Id: If0af9102bb789d5204173f60e1a60eddece2a87c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269117 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Scott Little authored
The histograms OfflinePages.PageSizeOnAccess.Offline.* and OfflinePages.PageSizeOnAccess.Online.* are still in use, so this CL extends the expiration of these histograms. Fixed: 1089147, 1089148 Change-Id: Ibccbdda86ed25a8dc9f868a4d681ba01a332aa94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269140 Auto-Submit: Scott Little <sclittle@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Ben Pastene authored
The suite has been running at around 2 hours per-build on the dbg linux tester since it was added: http://shortn/_I45U4pBNNO Leading to occasional shard timeouts: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/89935 This increases shard count from 2 to 4, which should avoid the timeouts. Change-Id: I214f30386e8e4563c52c0554716a65c0db4cf8d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273619Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#783764}
-
rbpotter authored
This file contains UI strings and flags, which frequently need to be updated for front end PDF Viewer changes. Add a few Web UI OWNERS for this file, so a separate reviewer does not need to be added for it. Change-Id: I9cf46bb7d001c146d9fb47efbf1f27f7bd94a602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274183 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Renjie Tang authored
https://quiche.googlesource.com/quiche.git/+log/54a38e35843d..1bb8308215d8 $ git log 54a38e358..1bb830821 --date=short --no-merges --format='%ad %ae %s' 2020-06-29 renjietang Simplify transport parameters related test setup. 2020-06-29 nharper Deprecate gfe2_reloadable_flag_quic_tls_enforce_valid_sni 2020-06-29 fayang In quic, add a connection option to disable blackhole detection on both sides. not used yet. not protected. 2020-06-29 haoyuewang Deprecate gfe2_restart_flag_quic_replace_time_wait_list_encryption_level. 2020-06-29 fayang Deprecate gfe2_reloadable_flag_quic_use_idle_network_detector. 2020-06-29 fayang Deprecate gfe2_reloadable_flag_quic_notify_stream_id_manager_when_disconnected. 2020-06-29 fayang Deprecate gfe2_reloadable_flag_quic_donot_change_queued_ack. 2020-06-29 fayang Deprecate gfe2_reloadable_flag_quic_fix_last_inflight_packets_sent_time. 2020-06-29 fayang Deprecate gfe2_reloadable_flag_quic_fix_checking_should_generate_packet. 2020-06-27 quiche-dev Replaces an std::map with a quichashmap. 2020-06-27 quiche-dev Ensure verification methods that return AssertionResult use the return value 2020-06-26 quiche-dev Migrates quic's settingsframe from std::map to quichashmap. 2020-06-26 fayang In quic, consider frame expansion when extra padding is needed to meet the minimum plaintext size needed for header protection. protected by gfe2_reloadable_flag_quic_fix_extra_padding_bytes. 2020-06-26 fayang In quic, do not include max_ack_delay when calculating pto timeout for initial and handshake packet number spaces. protected by enabled gfe2_reloadable_flag_quic_fix_pto_timeout. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Ie4e0185ef35984b2d5ed15ff15a91c82cedca798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274186 Auto-Submit: Renjie Tang <renjietang@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#783762}
-
Nick Diego Yamane authored
Additionally reformat a few (oddly indented) comment blocks. R=thomasanderson@chromium.org Bug: None Change-Id: I14deaa1eb750c79f0b7f2915d8f68dfa8bc484c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274239 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#783761}
-
Wan-Teh Chang authored
Also remove unneeded ImageFrame setter calls in AVIFImageDecoder::InitializeNewFrame. By analyzing all the overrides of the InitializeNewFrame method, I found that the following ImageFrame setters can only be called during InitializeNewFrame: * SetDuration * SetDisposalMethod * SetAlphaBlendSource * SetRequiredPreviousFrameIndex Since AVIF frames don't require any previous frames, we don't need to call the last three setters in AVIFImageDecoder::InitializeNewFrame. Change-Id: I554c1a28a4dc008cd5e19946297b82fa0061f97c Bug: 1071221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164108 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#783760}
-
nancylingwang@google.com authored
Rename apps::mojom::IconCompression to apps::mojom::IconType, because not only compression and uncompression, kStandard is added to bring adaptive icons from Android to ChromeOS. And kAdaptive will be added to implement animations later. Modify the load icon interfaces for shelf, launcher and dialogs, to load the new standard icons. Design doc: go/appservice-adaptive-icon BUG=1083331 TBR=sky@chromium.org Change-Id: I31d9f7ff5a91f99db87db742fef412cd3bdbe2ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271958 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
-
Justin Cohen authored
Cronet still builds 32-bit. Bug: 1100434 Change-Id: I62511f8a5dae409cf8f85423a479c22283a3f9b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274781 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#783758}
-
Xiaohan Wang authored
This CL adds MediaFoundationRendererFactory so that we can plug MediaFoundationRenderer into the media pipeline. Currently this can be used for local testing. Later this will be updated to support mojo IPC. This CL also merges "media_foundation_renderer" target into media/renderers:renderers so the classes can be used in media pipeline. Bug: 999747 Change-Id: Id10fd3bc0be971a69af8bf9cde98d6365137d63c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268217Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#783757}
-
Daniel Libby authored
Generating the manifests can take 10's of seconds. This CL avoids that cost unless it is necessary by computing the bases for a virtual suite based on the passed in paths. Using those bases, we can determine whether or not a WPT test is specified before computing the manifests. Bug: 1091307 Change-Id: I3bb37266ca929edb7ce4e52c8118b1cc25608c11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255778 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#783756}
-
George Steel authored
Fixes casting overflow caught by Clusterfuzz. Bug: 1099559, 745910 Change-Id: Ia3a18d4e21c7fd9be26c3667a4c160cd7023a213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271069 Commit-Queue: George Steel <gtsteel@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#783755}
-
Nate Chapin authored
This is a smattering of callsites that I've stumbled across in the last week or two. Bug: 1029822 Change-Id: I75b0fa5008d6cc2f37f0334154f556e86330d897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273489 Auto-Submit: Nate Chapin <japhet@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Peter Kotwicz authored
BUG=1088685 Change-Id: If4986324036c0168b499521f63803ba2bc5b72e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269502Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#783753}
-
Xiaohan Wang authored
Microsoft::WRL::ComPtr<T>::GetAddressOf() is banned due to the ease of causing memory leaks. Also replace CopyTo(foo.GetAddressOf()) with As(&foo) since CopyTo(&foo) does not work if we are copying to different interfaces. Also replace QueryInterface(foo.GetAddressOf()) with QueryInterface(IID_PPV_ARGS(&foo)). Bug: 914910 Change-Id: Iefa3d954d9ec03867afae97af10125ab86549057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271523Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
-
Brian Sheedy authored
Makes the --expected-device-id argument passed to info_collection_tests automatically handle the case where there are multiple dimension sets or multiple GPUs listed via the swarming OR operator. This is done by adding a new GPUExpectedDeviceId magic substitution. Bug: 1099762 Change-Id: I6f80ca545848bb63f418a158af65e0ee0daea4e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270846 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#783751}
-
Peter Kasting authored
These files don't use the functions in it. Bug: 1088346 Change-Id: Ia64fb9dac17067e933ab6bcb0616e020e8bf5fd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271398 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Karandeep Bhatia authored
Rename ExecutionContext::GetContentSecurityPolicyForWorld() to GetContentSecurityPolicyForCurrentWorld() to disambiguate it with GetContentSecurityPolicyForWorld(const DOMWrapperWorld&). BUG=896041 Change-Id: I13c21571169756f1863f160ad5b7e9fd64a415d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270841Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#783749}
-
