- 10 Mar, 2018 40 commits
-
-
https://skia.googlesource.com/skia.git/+log/46fe9c7f6cc7..e3dc6a93466f $ git log 46fe9c7f6..e3dc6a934 --date=short --no-merges --format='%ad %ae %s' 2018-03-10 update-docs Update markdown files Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: Ifb18487118d65c1e6d8763e4f96327157855accc Reviewed-on: https://chromium-review.googlesource.com/958323 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542371}
-
tzik authored
This CL changes the ownership of base::Clock and base::TickClock from injectee-owned to injecter-owned. Before this CL, these instances are owned by the owner of the injectee or one of the injectees themselves. That makes the ownership handling complex. After this CL, the injectee of clocks never own the clock. Instead, injecters owns a clock for testing, and a shared clock is used on the production code. Bug: 789079 Change-Id: I0853452f16f4444b5ef336cd06e7fd7b1dc19dac Reviewed-on: https://chromium-review.googlesource.com/956944Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#542370}
-
https://webrtc.googlesource.com/src.git/+log/35576ac007c8..03e6ec9db0ec $ git log 35576ac00..03e6ec9db --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie39dc926f7d9d2abd9f7772cc44fff0645e04c28 Reviewed-on: https://chromium-review.googlesource.com/958264 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542369}
-
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I9b19ab217948ec96262b6e4fdf3c718fb5dbf66d Reviewed-on: https://chromium-review.googlesource.com/958322Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542368}
-
Pritam authored
At present, tests for newly added mojom API #FlushCookieStore are missing. With this patch new unittest is added. This is a follow-up CL to #903307. BUG=792672 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I1f4e0b2a989207c09a4bd0c81015d4d4dbce5cde Reviewed-on: https://chromium-review.googlesource.com/948802 Commit-Queue: Pritam Nikam <pritam.nikam@samsung.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#542367}
-
https://skia.googlesource.com/skia.git/+log/0c51eeada6a9..46fe9c7f6cc7 $ git log 0c51eeada..46fe9c7f6 --date=short --no-merges --format='%ad %ae %s' 2018-03-09 brianosman Remove SkDumpCanvas 2018-03-10 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 331404098..e2995cce7 (10 commits) Created with: roll-dep src/third_party/skia BUG=815092 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: Ic9d89f778d43231a25a104641218ea847f19e89d Reviewed-on: https://chromium-review.googlesource.com/958263Reviewed-by:
-
Emily Stark authored
This will allow us to see how many page loads are affected by the Symantec distrust (https://security.googleblog.com/2018/03/distrust-of-symantec-pki-immediate.html). Note that this doesn't cover iframe main resources that fail to load because they are distrusted. Bug: 820582 Change-Id: I4a382dc155f0500222d91c7cdd1eb1a15eea32a6 Reviewed-on: https://chromium-review.googlesource.com/957548 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#542365}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0f36d390. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13544 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=foolip No-Export: true Change-Id: Icfc584cdf365f25be4695748c1bf21cd2b3908a3 Reviewed-on: https://chromium-review.googlesource.com/958183 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#542364}
-
Andrii Shyshkalov authored
R=hinoka@chromium.org Bug: 790154, 790169 Change-Id: I168f5b9a321ec31ae651a76ca6e629b2e592a988 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/947705 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#542363}
-
Hector Carmona authored
As part of the update, syntax for paper-icon-button-light changed, so this CL will also update our usage of it. R=dpapad@chromium.org Bug: 808542 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9ac87a515e2d07084f85ab07b66b7f2e32f3d544 Reviewed-on: https://chromium-review.googlesource.com/907856 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#542362}
-
Wei Li authored
Most mojo services are simple utility processes that don't require blink web sandbox support. However, services such as pdf compositor would need such support to access and load fonts. This CL does the following two major tasks: -- Add SandboxSupportedUtilityBlinkPlatformImpl and implements it to allow utility process to have the sandbox support when needed; -- Move LoadFont() interprocess call on MacOS from renderer to content/common, so it can be used by both renderer and utility processes. BUG=809763,813034 Change-Id: I4f8b50cc5cc31ac68dfbc2ba5b1195fb4e0748cc Reviewed-on: https://chromium-review.googlesource.com/919968 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#542361}
-
Lukasz Anforowicz authored
Bug: 820589 Change-Id: I16c02746c61f42fafead5f96ae436b331fba4f85 Reviewed-on: https://chromium-review.googlesource.com/957587 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#542360}
-
Conley Owens authored
This data type is useful for sending stats from the renderer to the browser, in SubresourceResponseStarted methods. Currently there are six fields that are passed around, but soon there may be more in order to get PageLoadMetrics working with the Network Service. This reverts commit badc08ce. This fixes the problem with the previous change by ensuring we have an IP address before attempting to update the ClientSideDetectionHost IP map. BUG=816684,819916,820032 Change-Id: I24ebb230c5bd76a5d2a43b39e86aba7541386bec Reviewed-on: https://chromium-review.googlesource.com/957802 Commit-Queue: Conley Owens <cco3@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
James Darpinian authored
Bug: 819044 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3d7cf99b0785198c8906f4bf43d3fa072c565b4b Reviewed-on: https://chromium-review.googlesource.com/950462 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#542358}
-
Sidney San Martín authored
This fixes a crash if the download item controller goes away while the button is tracking the mouse and then sends its action on mouse up. Bug: 815161 Change-Id: I4ab377ca5fe190e3d95aa81b989c13c96b46f5b4 Reviewed-on: https://chromium-review.googlesource.com/957843 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
When an object's fragments change, e.g. - the object moved from one fragment to another fragment of the flow thread; - the object resized and created more or less fragments etc., we need to update paint properties of the subtree. The new logic also covers the previous SetNeedsPaintPropertyUpdate logic for multicols. Bug: 817803 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ib641c1e5ef5af7d93b8fb8de70cdc9aae2382fc9 Reviewed-on: https://chromium-review.googlesource.com/953566Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#542356}
-
Michael Giuffrida authored
This code has been unused since we removed the Profile menu from the CrOS Chrome browser window. Per suggestion by jamescook, added comments mentioning the old code in case we decide to add back Chrome OS-specific UI in the future. Bug: None Change-Id: Idd63c64926f571f665a76f68b056d62c54797b05 Reviewed-on: https://chromium-review.googlesource.com/956627 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#542355}
-
https://pdfium.googlesource.com/pdfium.git/+log/0d0d3ad30ca8..073b99d51c7a $ git log 0d0d3ad30..073b99d51 --date=short --no-merges --format='%ad %ae %s' 2018-03-09 dsinclair Cleanup CPDF_DefaultAppearance Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I4cffbad23b210d0908ca7340bd83fea5fe1fad16 Reviewed-on: https://chromium-review.googlesource.com/958122Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542354}
-
Andrey Kosyakov authored
We used to fire DataPipeDrainer::Client::OnDataComplete() twice because underlying SimpleWatcher fired its client callback twice when MOJO_RESULT_FAILED_PRECONDITION occurs after the remote end of data pipe is closed. Change-Id: I241aa6648dec79c2cf60e9c32de70a52d59d3412 Reviewed-on: https://chromium-review.googlesource.com/958094Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#542353}
-
Aaron Leventhal authored
An alert is more suited to situations where the message is not directly related to the user's input. Bug: None Change-Id: I4de40267e7aab8ffd4bca5e7efa104591ea04c2b Reviewed-on: https://chromium-review.googlesource.com/956846 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#542352}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 91d310c1. With Chromium commits locally applied on WPT: 946e66a2 "Add http-state cookie tests from abart/http-state github repository" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13543 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=foolip No-Export: true Change-Id: I65e890f50602844b7a44538a877218713b413667 Reviewed-on: https://chromium-review.googlesource.com/957663 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=xdai@google.com Change-Id: Icee681f5418f0c9e3ca1735293fcd0d72a6ec356 Reviewed-on: https://chromium-review.googlesource.com/958184Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#542350}
-
Ovidio Henriquez authored
This change adds discovery session support to FakeCentral in order to allow Bluetooth scanning to be simulated. BUG=719826,719827 Change-Id: Ia5150cc14924e9e03e5361797068db6718b26595 Reviewed-on: https://chromium-review.googlesource.com/954231Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#542349}
-
https://webrtc.googlesource.com/src.git/+log/ba907f00581e..35576ac007c8 $ git log ba907f005..35576ac00 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib357939707fe9dc5530c57f1df3bf3126b1902c9 Reviewed-on: https://chromium-review.googlesource.com/958100 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Mitsuru Oshima authored
The original CL crrev.com/c/903223 changed the GetCurosr logic only for notification surface. Regular exo surface should do the same. This also removes obsolete path. Bug: 814600 Test: manual. See bug for repro step. Change-Id: Icbdf000db30efa96aa056c1b7fe15d38822b7610 Reviewed-on: https://chromium-review.googlesource.com/956103Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#542347}
-
Dale Curtis authored
http://crrev.com/535822, while not enabled, accidentally broke cases where a seek should resume the pipeline by completing the seek before the Resume() call. This was partially documented and partially tested behavior, but unfortunately neither was sufficient to avoid this issue being introduced. I've updated the tests and documentation for this functionality and reworked how suspended start works; though it is still unlaunched on current ToT. This CL also adds some debugging logs to WebMediaPlayerImpl which I find myself manually readding everytime I need to debug one of these issues. BUG=813573, 818554 TEST=manual, fixed existing unittest Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ifa9c78726abf3e243cfeac8b983d41605c1c7bf2 Reviewed-on: https://chromium-review.googlesource.com/956326 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#542346}
-
Jinho Bang authored
A jumbo build error occurs since https://crrev.com/c/933867. It is caused by the same name conflict in the anonymous namespace. Please see the following CL and comments there. - https://crrev.com/c/940641 So, this patch simply resolves the name conflict by removing `using` statement in service_worker_version.cc. TBR=leon.han@intel.com,shimazu@chromium.org Bug: none Change-Id: Iebb3ecc7f0295ff48fdf724429edd538da465249 Reviewed-on: https://chromium-review.googlesource.com/957568 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#542345}
-
Ovidio Henriquez authored
Adds a Mojo typemap to properly handle the UUID strings in the service_data field of ScanRecord. The typemap allows the service_data field to map to a device::BluetoothDevice::ServiceDataMap object in C++. BUG=817603 Change-Id: Ie4d5785e8b04098fda76ca8bc99c58141c9b5b82 Reviewed-on: https://chromium-review.googlesource.com/942307 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by:
-
Xiaohan Wang authored
This gn arg should only be enabled when component updated CDM is supported, which is only the case on Windows and Mac for now. Bug: 663554 Change-Id: I8d6e6dfdfba8b53bef80d84f376f1ebd36fb4605 Reviewed-on: https://chromium-review.googlesource.com/957707Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#542343}
-
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I61e462bd1cb5d92f74fd619e4d9142418ebfcf55 Reviewed-on: https://chromium-review.googlesource.com/958228 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
https://skia.googlesource.com/skia.git/+log/8c4cbf4cfb6d..0c51eeada6a9 $ git log 8c4cbf4cf..0c51eeada --date=short --no-merges --format='%ad %ae %s' 2018-03-09 bsalomon Add GrMockRenderTarget and mock backend render targets Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I9ff039a3a2f7441ebe9d70ad8f5e365356bace5f Reviewed-on: https://chromium-review.googlesource.com/957965 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I8e7f69af46113860c077f2d1811d442d7c914bdd Reviewed-on: https://chromium-review.googlesource.com/958182Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#542340}
-
Findit authored
This reverts commit b513507c. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 542315 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2I1MTM1MDdjZTQ5ZDhjMWU2ZWYwNThmNDUwODJmOGQyMzMxYzk4MzMM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/4635 Sample Failed Step: compile Original change's description: > tablet: Remove minimum time between taps for quick switch. > > Previously relied on using tap_count in GestureEvent which has a minimum > time between taps of 40ms for consecutive taps to have tap_count of 2. > Remove that and track double taps in overview button tray.cc. Allows > double tap from mice now. > > Test: ash_unittests OverviewButtonTrayTest.* > Bug: 817883 > Change-Id: Icce2e668223f938a7f8194c5f0a03279abff9907 > Reviewed-on: https://chromium-review.googlesource.com/956769 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542315} Change-Id: If15964ea1fab006fc7420d708dc08f0f6b5ca03f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 817883 Reviewed-on: https://chromium-review.googlesource.com/958132 Cr-Commit-Position: refs/heads/master@{#542339}
-
Ken Rockot authored
If a message is read from a port and then re-transmitted over another port, it currently retains its previous sequence number. This is problematic and can trivially lead to the message being lost (or rather, queued invisibly forever). This CL resets a message object's sequence number immediately before passing it out to the user reading the port. Bug: None Change-Id: I31604b341c55eee0c7ad6e1fd21e385fb945cf60 Reviewed-on: https://chromium-review.googlesource.com/955555Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#542338}
-
Chris Palmer authored
Bug: 817982 Change-Id: I823b9203db0f549c19f9de7f5ac742ba358b8858 Reviewed-on: https://chromium-review.googlesource.com/952187 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
-
Benjamin Pastene authored
Bug: 817779 Change-Id: Ie45ebfb14d2bdeeb80724ec94d1fce74cc64b8a8 Reviewed-on: https://chromium-review.googlesource.com/957648Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#542336}
-
Kim Paulhamus authored
This updates the filtering preferences (AuthenticatorSelectionCriteria, AttestationConveyancePreference, UserVerificationRequirement) in blink and plumbs the options through authenticator.mojom, along with typeconverters. These preferences are used to determine the types of authenticators the relying party wants/needs to use. Bug: 803832 Change-Id: I070ec4bc04de81ad955e878df45a716e3f9083b9 Reviewed-on: https://chromium-review.googlesource.com/947038 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
-
Nate Fischer authored
This fixes a bug related to the implementation of AwContentsIoThreadClient::FromID(frame_tree_node_id). This function is implemented using a map to keep track of the AwContentsIoThreadClient for a particular FrameTreeNode. Before this change, we would remove a map entry for a frame_tree_node_id whenever we destroy an associated RenderFrameHost. This is incorrect in multiprocess mode however, because a FrameTreeNode may have multiple associated RenderFrameHosts in its lifetime (such as swapping RenderFrameHosts for cross-site navigations). When we swap, we would first overwrite the map entry for the new RenderFrameHost, then erase the map entry when we destroy the old RenderFrameHost. The issue manifests most visibly for Safe Browsing, because FromID() returns nullptr, and Safe Browsing logic defaults to disabling the feature. However, this issue is not specific to Safe Browsing, and this would bug would cause a bad state whenever we trigger multiple cross-site browser-initiated navigations. With this change, we keep track of live RenderFrameHosts for a given FrameTreeNode, and only remove an entry from the map if we've destroyed the last associated RenderFrameHost. Bug: 818025 Test: manual - see bug for repro steps Change-Id: I2ae81fdb5338084cdf253582206144b4f45704b1 Reviewed-on: https://chromium-review.googlesource.com/956411Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#542334}
-
Chris Harrelson authored
If a paint invalidation container returns true from IsPaintInvalidationContainer(), that means it is composited, which in turn must mean the containing LayoutView is composited. This allows us to simplify the code and avoid a call to View(), which may be expensive because it has to first dereference the document. Bug: 814251 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I79cc37ee79271c2030a9f5c832ba5640ca8445c9 Reviewed-on: https://chromium-review.googlesource.com/957962Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#542333}
-
Brandon Jones authored
Should prevent crashes due to the matrix info not being sent properly. Bug: 820377 Change-Id: I36ee0af1f60333e55b3a076e72123fe4f5f3099f Reviewed-on: https://chromium-review.googlesource.com/957808Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#542332}
-
