- 01 Apr, 2020 40 commits
-
-
Etienne Pierre-doray authored
Bug: 1059767 Change-Id: I69880f5bb32cb6400138f1af0b2cf9da56a08c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129013Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#755467}
-
Sadrul Habib Chowdhury authored
In the previous change, the latency metrics from the UI were still being reported in the common CompositorLatency bucket. This was unintentional. Fix this to stop reporting the latency metrics for the UI compositor altogether. BUG=1005226 Change-Id: I42f21c0200723d9b72b17c9dd3027c379e890174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132626 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#755466}
-
Fan Yang authored
Change-Id: Ie8f1d0f26bb7e40176401a3520625aba500ff90c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132527Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#755465}
-
Mikhail Khokhlov authored
Isolate file generation fails with current setup (see crbug.com/1066246), because the uploader script is not a gtest test. Switch target type to 'generated_script' instead. Bug: 1050517, 1066246 Change-Id: I59b136a155e60751f69e343878906d4350dfe1ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128114Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#755464}
-
Xida Chen authored
Currently we report throughput to UKM at: 1. 5 seconds after a sequence starts. 2. Every 500 seconds after that as long as the sequence lasts. The problem is that in many cases users stays on a page less than 500 seconds, and then we would only get the report for the first 5 seconds, which can be heavily biased by the page loading time. This CL is a temp solution to ignore the first 5 seconds, so instead we will report throughput at: 1. The second 5 seconds after a sequence starts. 2. Every 500 seconds after that as long as the sequence lasts. Bug: 1040634 Change-Id: I808b3ff56acce12c3a81e8fca5b7d472f4fcf4a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129014 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#755463}
-
George Steel authored
Make the implementations of CSSValueFromComputedStyle for background-position-x/y return correct values when three/four-value syntax is used with background-position. Since these properties only support single-value syntax, positions from the right or bottom will use calc() values if they result in mixed lengths and percentages when converted to be from the left/top. This is not the canonical form in the css-backgrounds-4 spec proposal, but does not require changes to the parser. Add a reftest (passes without patch) for three/four-value background-position syntax (there is currently only a manual test). Add another version of the reftest (fails without patch) which takes the above and attempts to write back the computed values of background-position-x/y. This is done in preparation to make transitions use normal keyframes which require round-trip serialization of all transition properties. Change-Id: I50e714746cc15fd0591bcd0a41cf9ecd56f55c44 Bug: 610627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121415Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#755462}
-
Renjie Tang authored
Change-Id: I99d8d77190b66eda62a5116a224ae23d94845d82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128470Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#755461}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4f30cf017965..994bed549663 git log 4f30cf017965..994bed549663 --date=short --first-parent --format='%ad %ae %s' 2020-04-01 ehmaldonado@google.com Fix Python3 integer division issue in roll-dep. Created with: gclient setdep -r src/third_party/depot_tools@994bed549663 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Idb0505efd9fcd2d9a2ab61d736a99dfbe05db8a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132573Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755460}
-
Dan Harrington authored
- Updated code so content fetch time is saved - If content is stale, load from the network. Bug: 1044139 Change-Id: I676ac6dab77133815286b14d93b94b5b778b3386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131012Reviewed-by:
Ian Wells <iwells@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#755459}
-
Danyao Wang authored
This patch contains two preparatory changes for exposing the C++ PaymentAppService via JNI: 1. Replace the output parameter of PaymentAppService::Create() with a separate method that callers can use to get the number of payment factories. This will make it easier for the upcoming JNI code to first query the number of factories, cache it in a delegate, and call Create() with the delegate. 2. Added two new utility helpers to deserialize Mojo objects from Java ByteBuffers. Bug: 1063118 Change-Id: Ibb7ff2fcb09e18cc30abe06f410392852bbe7307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129066 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#755458}
-
Devlin Cronin authored
The ErrorConsole has been launched for several milestones. Remove the corresponding feature switch. Bug: None Change-Id: I403d6dedb51227433a75b99cc6de244eaf06d851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131360Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#755457}
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //device/bluetooth/bluez. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=sonnysasaka@chromium.org Bug: 714018 Change-Id: I294a17baa39c390c53928676b4c3cefd09f67e37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132135 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Sonny Sasaka <sonnysasaka@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#755456}
-
Kyle Horimoto authored
This removes jhawkins@, who is no longer working on EasyUnlock. Change-Id: I05adf467fd5ba570b24e0accc24a6d25915351ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132588 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#755455}
-
Hesen Zhang authored
- Will continue to implement CreateFromFinch once the flag change is done, include the unittest. Bug: 1066550 Change-Id: Ie63e4b037eeb8ffc5d100d3fff7cc168f46eb406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130182Reviewed-by:
Hesen Zhang <hesen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Auto-Submit: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#755454}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e283d1ca64c6..486232025b0b git log e283d1ca64c6..486232025b0b --date=short --first-parent --format='%ad %ae %s' 2020-04-01 marinaciocea@webrtc.org Transform received audio frames in ChannelReceive. 2020-04-01 mbonadei@webrtc.org Replace std::string::find() == 0 with absl::StartsWith. Created with: gclient setdep -r src/third_party/webrtc@486232025b0b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I69b0ac541b1076f9ed558459218ecab3e63939ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132576Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755453}
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //remoting. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=lambroslambrou@chromium.org Bug: 714018 Change-Id: I34f580a97431487d7b438a9cc4bf4640611b311a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132152 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#755452}
-
Livvie Lin authored
Interstitial code that relies on dynamic_type_util is getting moved to //ios/components so that it can be used by iGA, so the common util methods should also be moved to a shared directory. Bug: 1064382 Change-Id: I6719ddefd0ac76a9a5b2b3727221bd1f0207aa95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128086 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#755451}
-
Kevin Marshall authored
This is a reland of 4898ea48 Adds a missing export directive which was breaking component builds. Original change's description: > [Fuchsia] Add support for selectively enabling input types. > > * Implements the FIDL ConfigureInputTypes() API, for embedder control > over whether input events should be routed to web content or ignored. > * Transitions CastRunner to use ConfigureInputTypes(). > * Removes the deprecated SetInputEnabled() method. > > Bug: 1031776 > Change-Id: I54e0b5c3b5a92935e6860e037edc6bc5a92eaa42 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956154 > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Reviewed-by: David Dorwin <ddorwin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#755219} TBR=ddorwin@chromium.org Bug: 1031776 Change-Id: Ia0047b56ce7ac8b28b25d0853f4d772d94cec68b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132854Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#755450}
-
Marc Treib authored
The model type was added in crrev.com/c/1455965, which failed to add this suffix entry. While we're here, also mark the EXPERIMENTS suffix as obsolete. The corresponding data type has been deprecated and unused since March 2019 (crrev.com/c/1515537). Bug: 919489 Change-Id: I1941e1fc34d21ea33e2fd0ac7a87807222894d9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131328Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#755449}
-
Becca Hughes authored
Add a field that stores whether the item has been checked by Safe Search or not and the result. Adds that to the Media Feeds WebUI. BUG=1066643 Change-Id: I65587885d177b45f95237a22bd08a3e1488f407b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130784Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#755448}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b6fd42ad9ae2..77cb6e24f164 git log b6fd42ad9ae2..77cb6e24f164 --date=short --first-parent --format='%ad %ae %s' 2020-04-01 fmayer@google.com Merge "Try to connect to central heapprofd on user." Created with: gclient setdep -r src/third_party/perfetto@77cb6e24f164 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I3bc81ea787fd83c5477c46f31e75b56fd4f23b98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132510Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755447}
-
Anastasiia Nikolaienko authored
Add inline margin to the label, fix repeated ids. Screenshot: http://screen/UO3c4g6HR17 Bug: 1043108 Change-Id: I169b11823efb6981d80574eda181bd4a7b7b4150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130350Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#755446}
-
Mohit Hotwani authored
Also remove the timestamp since logd adds the timestamp. This makes the logs similar to cast. Bug: internal b/152558058 Change-Id: Ifda50ed1115e2192aaa7887440aba7a02341ef09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123507Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Mohit Hotwani <hmohit@chromium.org> Cr-Commit-Position: refs/heads/master@{#755445}
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //ash. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=xiyuan@chromium.org Bug: 714018 Change-Id: I1bad1acf6e94610fe36679f925772aa0968b9cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132131 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#755444}
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //chromeos/services. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=khorimoto@chromium.org Bug: 714018 Change-Id: I13f5ea4b51764c8108cf630aa6913384f0657d9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132392 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#755443}
-
Jan Wilken Dörrie authored
This change extends the histograms related to HTTP Password Migration and performs some small clean-ups of the logging code. Fixed: 1053097 Change-Id: If1950c16bc168ee6595c2cdf3755b9336a9fc06b Bug: 1053097 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132264 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#755442}
-
Stephen Chenney authored
Add tests for the following: - Images in <embed> - Images in <object> - Background repeat, position and size properties Chromium fails the background repeat tests. Also removed border properties from the existing tests as they influence the compositing behavior of Chromium and are not necessary for the test. All the tests are marked as failing for Chromium due to a lack of fuzzy matching support. Bug: 1034283 Change-Id: Ib8dfc0c47ba7d9d1e33c38b541caf169e07c786d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130648 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#755441}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e8d2080a34ed..587b091d03bc git log e8d2080a34ed..587b091d03bc --date=short --first-parent --format='%ad %ae %s' 2020-04-01 brianosman@google.com Stop including SkVertices.h from SkCanvas.h Created with: gclient setdep -r src/third_party/skia@587b091d03bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: michaelludwig@google.com Change-Id: I21579ad6f5af9b93109d7292f501a7659ab8f531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132509Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755440}
-
Sergey Poromov authored
Original CL: https://crrev.com/c/2127707 Bug: 1062788 Change-Id: Ife67de34bd4b214a6832bd9889ac050fc056f2be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132129Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#755439}
-
Tomasz Wiszkowski authored
This change enables the OmniboxUIExperimentMaxAutocompleteMatches flag to control ZeroPrefixSuggestions as well as other search suggestion types. Bug: 1066904 Change-Id: I8eb0f41c0c86ecff32ad35f3a808225138e0ccb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132632 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#755438}
-
Roman Sorokin authored
Bug: 1057957 Change-Id: I782b98b4703d585eec99eb06fb1ea8a9f3dfb9b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102540Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#755437}
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //sandbox. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=jorgelo@chromium.org Bug: 714018 Change-Id: I40e474d39448345830eaa34a8504d1815f940191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132136 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#755436}
-
Victor Costan authored
Localized changes should not require reviews from the service's top-level OWNERS. This CL covers DOM Storage and IndexedDB, and sets up an example for future features to follow. Bug: 994911 Change-Id: I346bbfff65f5509eedd42f861604cbd43f25a92d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129508 Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#755435}
-
Felipe Andrade authored
This histogram will collect the encryption types used when a Kerberos TGT is successfully created or refreshed. This value can be 'all', 'legacy' or 'strong'. This metric will be reported on ChromeOS, and is implemented on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2117121 Bug: 1062630 Change-Id: Ie11daebbd3dade8d6753aa60c2815b28cd6e3ce0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112711Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Cr-Commit-Position: refs/heads/master@{#755434}
-
Vasiliy Telezhnikov authored
This CL converts resource_dirs to sources for android_resources in BUILD.gn files. Details: https://crbug.com/1026378 https://groups.google.com/a/chromium.org/forum/#!msg/chromium-dev/KAFsfaoq7y4/OC4v5sb9BQAJ Bug: 1062263 Change-Id: I3c0323854f0543d7e487d63b5c893a4567334891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121090Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#755433}
-
Sorin Jianu authored
The binding code is missing template definitions for __stdcall object method invocations. Such template definitions exists for functions but not for object methods. This patch allows this code to compile: class MethodHolder { public: int __stdcall Func(int n) { return n; } int __stdcall ConstFunc(int n) const { return -n; } }; MethodHolder obj; auto stdcall_method_cb = BindRepeating(&MethodHolder::Func, base::Unretained(&obj), 1); Bug: 1066580 Change-Id: I6ce3cbeb9b42ebcf75c64e33f464c4e4c5409a26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129895 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#755432}
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //pdf. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=thestig@chromium.org Bug: 714018 Change-Id: I6450f7b53ea140ac36b9db4a0c5bac5f3047f5dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132261 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#755431}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I14e2abca33bacdfe8b3dfac3116d18159104d36a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132578Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755430}
-
Monica Basta authored
This CL prevents mirroring profile menu feature buttons icons: Passwords, Payment methods and localization in RTL mode. Payment methods and localization are symmetric and there is no need for mirroring. This change goes with consistency of the password icon in the settings page. Bug: 1052244 Change-Id: I59593312241b592169125d54640e0b4f08db78e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127930Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#755429}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/5cf1e9a31c90..c66dad9552ef git log 5cf1e9a31c90..c66dad9552ef --date=short --first-parent --format='%ad %ae %s' 2020-04-01 bclayton@google.com Regres: Add invertCommon optimization. 2020-04-01 bclayton@google.com Regres: Move optimization logic to separate file 2020-04-01 bclayton@google.com Regres: Keep coverage span groups stable. 2020-04-01 bclayton@google.com Regres: Split coverage.go into multiple files 2020-04-01 bclayton@google.com Regres: Further optimizations for coverage 2020-04-01 bclayton@google.com Regres: Add cov.ReadJSON() Created with: gclient setdep -r src/third_party/swiftshader@c66dad9552ef If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I4bf210429838cc2de263f531f17da2c56b38fcca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132508Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755428}
-