GitLab

This change handles the cases of brand new IDL files added to a build,
or cases where files under third_party\win_build_output\midl are
(unexpectedly) missing. This change also has some minor refactoring of
the |writes_tlb| midl.gni option.

Bug: 1149764
Change-Id: If2e608f2e986bd3fbc13a3a7b699801660c2ffa1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543367
Commit-Queue: S. Ganesh <ganesh@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828319}

Bug: 1146151
Change-Id: I854913ca3604768684c100b17abdf25b7766e2b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542804
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828318}

This reverts commit 5f42b6c7.

Reason for revert: Causing test failures in https://ci.chromium.org/p/chromium/builders/ci/Linux%20ASan%20Tests%20%28sandboxed%29/72608

../../content/browser/renderer_host/navigation_controller_impl_browsertest.cc:10961: Failure
Expected equality of these values:
  root->child_at(0)->current_frame_host()->GetLastCommittedURL()
    Which is: http://another-site.com:35903/title2.html
  GURL("http://another-site.com:0/title2.html#someRef")
    Which is: http://another-site.com:0/title2.html#someRef

Original change's description:
> blink: Bring SecurityOrigin port=0 handling in line with //url
>
> SecurityOrigin currently returns identical objects when constructed from
> KURLs with ports explicitly set to 0 and KURLs with ports equal to their
> schemes' defaults. This is inconsistent with the //url implementation
> (and the HTML spec!).
>
> This CL makes two changes to ensure that
>   AreSameOrigin(KURL("https://a.com:0"), KURL("https://a.com"))
> starts returning false.
>
> (1)  It updates SecurityOrigin(KURL) to set the origin's "effective
> port" field to the given URL's protocol's default port when the URL's
> parsed port is empty.
> (2)  It updates SecurityOrigin::IsSameOriginWith to use
> SecurityOrigin::effective_port_ for comparison rather than
> SecurityOrigin::port_.
>
> (SecurityOrigin::effective_port_ and SecurityOrigin::port_ differ in
> that `effective_port_` takes into account empty/default ports, and
> `port_` doesn't; prior to this change, `effective_port_` was being
> initialized incorrectly to the default port for SecurityOrigins
> constructed from URLs with port explicitly set to 0.)
>
> This CL adds serialization behavior for port-0 origins that is incorrect
> but matches url::Origin's. Port-0 origins' serializations should include
> the port, but they currently don't (crbug.com/1136966). A subsequent
> change will implement this fix for both SecurityOrigin and url::Origin.
> (Doing one at a time is tricky because some tests check equality of
> origins' serializations.)
>
> Test: Adds unit tests covering same-originness and effective_port_.
> Change-Id: I5f9b4478d28d2892abb31ea9e12ab7d3bcaa8077
> Fixed: 1136678, 1138540, 1100794
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472460
> Auto-Submit: David Van Cleve <davidvc@chromium.org>
> Reviewed-by: Charlie Reis <creis@chromium.org>
> Reviewed-by: Andy Paicu <andypaicu@chromium.org>
> Reviewed-by: Mike West <mkwst@chromium.org>
> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
> Commit-Queue: David Van Cleve <davidvc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#828240}

TBR=creis@chromium.org,lukasza@chromium.org,mkwst@chromium.org,andypaicu@chromium.org,davidvc@chromium.org

Change-Id: I008878ca4412715e6bbaab611307cdd6178b50b2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545227Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828317}

Generate DIR_METADATA files and remove metadata from OWNERS
files for directories under //chrome.

Bug: 1113033
Change-Id: Ifef310c71f90479e7c0ab615e4c9066ad7ebeb9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545242
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828316}

Replace uses of "blacklistDomains" with "excludedDomains". This matches
the terminology already used on the C++ side of the bridge.

Bug: 1149433
Change-Id: If9addd57f589613d1094c3d1dc4c8848f32fe85b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541064
Auto-Submit: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828315}

With this change we introduce a ErrorInfo struct that has the Error enum
and optional integer argument that can be used to format the error
message.

BUG=b:166322619
TEST=unit_tests  --gtest_filter='*ProvisioningErrorDisplay*'

Change-Id: I6aecddf325e9b350c057f93b1f22784cff3ba0cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532908Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828314}

* Reduces the intensity of the ambient/environment map
* Adds a directional light from the information provided by the probe
* Only creates a light probe of the requested texture type due to a bug
  in the implementation that always uses the texture type of the first
  light probe.

Change-Id: I6e798f64b92ae903c8931eee07af981981cea42b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542651
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828313}

Adds a new toggle in Privacy settings to enable incognito authentication
which prompts the user for face/touch/code-ID before allowing to enable.
Adds some code to SceneAgent to authenticate through the same mechanism
as settings.

Bug: 1138892
Change-Id: Ic34f51a09b0049e37a2a4e2619b862369ae71688
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527201Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828312}

https://imgur.com/a/75Ct7RK

Bug: 1070910
Change-Id: Ia511037f01012fa75a17ab88a92bda606974849a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543043Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828311}

This CL has no behavior changes.

TBR=futhark@chromium.org

No-Try: true
Change-Id: I212e00963ddb9636c6ab754bd28b4dcce2ad03a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545322
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828310}

KeyedServiceBaseFactory::service_name_ is used in decltype() to check that the types match.

Bug: 1073933
Change-Id: I8b3380c0c4e33e937d7da817b892dd86b530e4a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542937Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Bartek Nowierski <bartekn@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828309}

In accordance with current deprecation schedule.

Bug: 1149472
Bug: 1149473
Bug: 1149474
Bug: 1149475
Bug: 1149476
Bug: 1149477
Bug: 1149478
Bug: 1149479
Bug: 1149480
Bug: 1149481
Bug: 1149482
Bug: 1149483
Bug: 1149484
Bug: 1149485
Change-Id: I2a33c92b31613dfe18822715c1363108737e814b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542731Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Anthony LaForge <laforge@chromium.org>
Commit-Queue: Derek Schuff <dschuff@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828308}

Updates the expires_after attribute for 9 histograms that have
been used to generate alerts in the past 90 days and do not already have
a date later than or within 60 days of 2021-02-15.

TBR=chromium-metrics-reviews@google.com

Change-Id: Id403ba81739b1fe3472679211a1c5ef2a5cec2d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543453Reviewed-by: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Cr-Commit-Position: refs/heads/master@{#828307}

ScopedObserver is being deprecated in favor of two new classes:
- base::ScopedObservation for observers that only ever observe
  a single source.
- base::ScopedMultiSourceObservation for observers that do or may
  observe more than a single source.

This CL was uploaded by git cl split.

R=tom.cassiotis@gmail.com

Bug: 1145565
Change-Id: I8c5915322326c6ed819025f922af9432aabc08be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532660
Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Cait Phillips <caitkp@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828306}

Bug: 1149987
Change-Id: Ia5c7842e90c3f757912aec993b504c4388617757
Tbr: yhirano@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544844Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828305}

See https://skia-review.googlesource.com/c/skia/+/335593

Bug: skia:7650
Change-Id: Ie8237e3fb62ba95a0b1ccfd582dc04ce45885aac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544804Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Cr-Commit-Position: refs/heads/master@{#828304}

This CL records state of the EduCoexistence flow when it is closed.
This will allow us to understand the user drop off rate.

Bug: 1140250
Change-Id: I4f3e7ff6324746b964644b7c6f24e8eeeadf7c70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523522
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Kush Sinha <sinhak@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828303}

This reverts commit a3bfafb1.

Reason for revert: Breaks compilation, for example on https://ci.chromium.org/p/chromium/builders/ci/Deterministic%20Linux%20%28dbg%29/19608

[14678/62398] ACTION //tools/privacy_budget/blink_apis:blink_apis(//build/toolchain/linux:clang_x64)
FAILED: blink_apis.textpb 
python ../../tools/privacy_budget/blink_apis/generate_blink_api_db.py --web_idl_database gen/third_party/blink/renderer/bindings/web_idl_database.pickle --output blink_apis.textpb --path ../../third_party/blink/renderer/bindings/scripts:../../third_party/blink/renderer/build/scripts:pyproto/tools/privacy_budget/blink_apis/proto:pyproto:pyproto/google/third_party/six
Traceback (most recent call last):
  File "../../tools/privacy_budget/blink_apis/generate_blink_api_db.py", line 74, in <module>
    main()
  File "../../tools/privacy_budget/blink_apis/generate_blink_api_db.py", line 66, in main
    from blink_api_proto import BlinkApiProto
  File "/b/s/w/ir/cache/builder/src/tools/privacy_budget/blink_apis/blink_api_proto.py", line 10, in <module>
    import blink_apis_pb2 as pb
  File "pyproto/tools/privacy_budget/blink_apis/proto/blink_apis_pb2.py", line 22, in <module>
    create_key=_descriptor._internal_create_key,
AttributeError: 'module' object has no attribute '_internal_create_key'

Original change's description:
> [third_party] Uprev protobuf to v3.13.0.1+
>
> Followed process in //third_party/protobuf/README.chromium
> Highlights:
> * Some protobuf APIs started being deprecated. Moved sources in
> //chromecast and //components to start using the non-deprecated
> versions.
> * Removed most of the patches and updated the ones that are still
> needed. No new patches.
> * //components/subresource_filter/core/common/unindexed_ruleset.h:
> HadError is not const anymore.
>
> Size increase is caused by protobuf mainlining 2
> functions to Serialize and Parse inside each *pb.cc file. This new
> methods are now the way protobuf serializes and deserializes messages
> so no way to avoid those without substantially changing protobuf
> internals.
>
> Binary-Size: Unavoidable. Increase intrinsic to new protobuf.
> Bug: 1144985
> Change-Id: I23ce43f07da82fdda60575934a4b039200164f48
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518036
> Commit-Queue: Andres Medina <medinaandres@chromium.org>
> Auto-Submit: Andres Medina <medinaandres@chromium.org>
> Reviewed-by: Colin Blundell <blundell@chromium.org>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#828263}

TBR=pkasting@chromium.org,caitkp@chromium.org,blundell@chromium.org,halliwell@chromium.org,medinaandres@chromium.org

Change-Id: I856a83d283bcf9453cfdd604a4ee7dba539d2b68
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1144985
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544866Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828302}

Now that bookmarks::BookmarkNode stores a base::GUID instead of a
std::string, return a base::GUID. Modify the code around callers to make
them compatible with the new API.

Bug: 1026195
Change-Id: I68968cda23ae48c2c45413ad752e50330c9869df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523745
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828301}

These methods are only called from the browser and we can assert
they are executed for subframes.

BUG=1097816

Change-Id: I152102fc55360769ebec3594aed03d3d452ccbfa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537574Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828300}

BatteryManager can adequately be its own Supplement<Navigator>,
reducing boilerplate.

Bug: 1147612
Change-Id: I15cfaa7b2778f34a1bc754a8ca54a5361b075ddd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523362
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Auto-Submit: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828299}

When PDFViewerUpdate is on, |topToolbarHeight| is always zero. The code
that uses |topToolbarHeight| in calculations is effectively a no-op and
can be deleted.

This CL reverts a subset of the changes in r789720, as they are no
longer needed.

Bug: None
Change-Id: Icd6a6b7b91ae2137e9a81dd68c3c53ad031a3840
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541607Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828298}

The meet.google.com rendering issue is because
shared_quad_state->mask_filter_info is not transformed correctly. Fix the
problem by transform it into the new allocated overlay backing's
coordinates.

Bug: 1148477
Change-Id: I016c0c01c4e60262d197c7b24f37f1df522859c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542949
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828297}

https://skia.googlesource.com/skia.git/+log/5160aada22ed..5035b8f92a0e

2020-11-17 brianosman@google.com Minor cleanup in the intrinsics GMs
2020-11-17 johnstiles@google.com Disallow opaque types in structs and interface blocks.
2020-11-17 johnstiles@google.com Code cleanup: remove macros from AST node creation.
2020-11-17 kjlubick@google.com Update Go Deps
2020-11-17 adlai@google.com Move GrOpsTask::addOp and addDrawOp out of header
2020-11-17 adlai@google.com Remove bulk GrDrawingManager::appendTasks
2020-11-17 robertphillips@google.com Connect DDL offsets in the testing harness to the new ddlTask
2020-11-17 robertphillips@google.com Move SkTTopoSort to src/gpu and rename it to GrTTopoSort
2020-11-17 scroggo@google.com Reland "SkAnimatedImage: Use fSampleSize"
2020-11-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from e4c1a25cc679 to 04515da400d5 (3 revisions)
2020-11-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 60570b859f7c to 4f96bf19941b (15 revisions)
2020-11-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 575729e8dd25 to f2bc3b3edd6f (5 revisions)
2020-11-16 nifong@google.com Move SKP version extraction into JS
2020-11-16 jlavrova@google.com Added SK_PARAGRAPH_LIBTXT_SPACES_RESOLUTION to flutter_defines.gni
2020-11-16 herb@google.com clip more cases using the CPU allowing more op merges
2020-11-16 robertphillips@google.com Change UnrefDDLTask to just be the DDLTask (take 2)
2020-11-16 johnstiles@google.com Detect unsupported types for MemoryLayout and report errors.
2020-11-16 mtklein@google.com roll back minimum picture version to 73
2020-11-16 robertphillips@google.com Revert "Remove SkBaseDevice::flush"
2020-11-16 mtklein@google.com make I32a less ambiguous

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: lovisolo@google.com
Change-Id: Idce79d55c6dbabee8aa1f7732832e534de5857c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542655Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#828296}

Bug: 1146481
Change-Id: I6fb9f2902f38e4c237902681c71d22db0940fe6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542725Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828295}

The Service.Error property gets set when running on a VM, which is fine,
but it is causing logs.NetworkEventLog to incorrectly fail.
We should not be using ERROR for property changes anwyay.

BUG=b/167581118

Change-Id: I3a6014876789d2811db6fb1b788dbcec1c76987e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544842
Auto-Submit: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Azeem Arshad <azeemarshad@chromium.org>
Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828294}

Rewrite SkiaRenderer::PrepareRenderPassOverlay() to fix the rendering
problem. Seems the problem is related to clipping and transforms.

Bug: 1147933
Change-Id: I813aee2634aad8691f80527c8d24cd7324d2827f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537067Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828293}

Some files (like system logs) apply to a test run as a whole, and not
necessarily to a single test case. These artifacts can be uploaded to
RDB as "invocation-level" artifacts. So this crawls the system_logs
and crash dirs after a Tast test and uploads them as "invocation-level"
artifacts.

Bug: 1129654
Change-Id: I27f4cd27b4293a69364d37aa4be89a4185aa4900
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541747Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828292}

In http://crrev.com/261e76876c we used the FocusedCoreFrame and this is
not necessarily correct for OOPIFs as it might find the selection for
another LocalFrame that is not rooted by widget in question but another
widget.

Go back to the WebFrameWidgetImpl code but fix a few tests which were
not setting focus for text selection calculation.

BUG=1149653

Change-Id: I6ecbaf3d70cc356bbb1bd1073ac768ba34ffef3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543128Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828291}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2e8c7015c00a..384b05891b9b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC gogerald@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: gogerald@google.com
Change-Id: I228d09581eafe7b5400e6f8e68dbc6faf75df9cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544257Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#828290}

Adds the ability to bind the SystemRoutineController interface.

Bug: 1128204
Change-Id: Id729b624018fef5dbec273a562ca76a120fcc026
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541648
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Auto-Submit: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828289}

No change to logic, only docs. This expands on the existing CTS docs:

* Links to the AOSP source code
* Failures must be ReleaseBlock-Dev
* How to change test logic
* How to run tests locally

Fixed: 1138051
Test: Upload to gerrit > open file > click "gitiles"
Change-Id: I635718e5d1e4327a1964e617279282a157f14d72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542679
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828288}

This change removes DISALLOW_COPY_AND_ASSIGN from the
IllegalCharacters class, and makes member functions that don't modify
the class instance `const`.

Change-Id: I3b49140c4fb52aa6ae4982ed0bc6563dad6bd3a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459637Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Commit-Queue: Jesse McKenna <jessemckenna@google.com>
Cr-Commit-Position: refs/heads/master@{#828287}

In Multipaste, show a static string instead of the raw html.

Raw HTML used to be shown when:
 - HTML is not rendered (No IMG or Table tags)
 - No plain-text content

UX does not like this, so instead show "HTML Content".

Bug: 1139062
Change-Id: Ic4b164b1449c0ad13ef6a539a4d747b8208a9e04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543084
Auto-Submit: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Andrew Xu <andrewxu@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828286}

The function is deprecated as it doesn't support custom counter styles.
This patch changes some callers to call GetListStyleType() instead.

Bug: 687225
Change-Id: I130d09ecdcc9d896cefba1590b9793732bb552c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543369
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828285}

Instruments HTMLFrameOwnerElement to notify RendererResourceCoordinator
whenever the content frame changes. If the new content frame is a
RemoteFrame, RendererResourceCoordinator will notify PerformanceManager
of the frame's RemoteFrameToken and some attribution information for the
iframe. PerformanceManager stores this information in V8ContextTracker.

Also updates frame_test_helpers::CreateProvisional to accept local
frames since the underlying WebLocalFrame::CreateProvisional now allows
this.

Bug: 1085129
Change-Id: I43d7d7f1309db9c4b1760ca32983c0e8a2f51a6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363710Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828284}

Type annotations must begin with "/**" even if it's a single line.
JSC also doesn't seem to infer array destructuring.

Bug: 1125150
Test: browser_tests --gtest_filter=Diagnostics*
Change-Id: I320080ec0ef4baa0807e07af10f4b9d70d226128
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542730
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Auto-Submit: Joon Ahn <joonbug@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828283}

Close the tray bubble when entering capture mode via the tray bubble.
Do not close app list or any tray bubbles in capture mode on click or
touch.

Test: manual
Fixed: 1137889, 1141496
Change-Id: Idd231f28be3d58dba823d5f371d630c28c6afc9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487876
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828282}

Bug: 1016952
Change-Id: I6707bf7a5e5caef6e002751f7759815f94f14e92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543687Reviewed-by: Caitlin Fischer <caitlinfischer@google.com>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828281}

The custom element used for the Assistant screen now has
a proper "-element" suffix to discern the dom-module from
the rest of its uses throughout the code. This is a necessary
change for using the HTMLImports polyfill in order to avoid
clashes in the names.

Bug: 1111387
Change-Id: Ib4ec56b74e2c9f035dc1a3166be8fd9b80a24b5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544543
Commit-Queue: Renato Silva <rrsilva@google.com>
Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828280}