- 24 Jul, 2018 40 commits
-
-
Mathieu Perreault authored
Bug: 866736 Change-Id: I2ead391e93eb64a4622ad94d75d34755e831c50f Reviewed-on: https://chromium-review.googlesource.com/1147756Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#577598}
-
Dan Elphick authored
V8TypeAsString was passing nullptr to the ConvertFromV8 function, so now we always pass the isolate. Also adds a DCHECK to ensure that V8ToString to ConvertFromV8 to ensure it's always passed a non-null Isolate. Bug: 866767 Change-Id: I715396f309a0c49e4c6bc6ade14b5f0aad8befec Reviewed-on: https://chromium-review.googlesource.com/1148209Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#577597}
-
Derek Cheng authored
It's been flaking heavily since https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Fuchsia%20x64/14471. TBR=sahel@chromium.org Bug: 866946 Change-Id: Iadbf5f330b9775d10dc5969d36f3fef8ad19a205 Reviewed-on: https://chromium-review.googlesource.com/1148597Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#577596}
-
Matt Menke authored
This is so that I can try increasing the media cache size in experiments without increasing Chrome's profile size (Except possibly for profiles that have never been used to play video). This is a relant of https://chromium-review.googlesource.com/c/chromium/src/+/1130162, with re-worked tests. Bug: 789657 Change-Id: I057e2e657572e21732610aefc468550e58fabf77 Reviewed-on: https://chromium-review.googlesource.com/1145137Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#577595}
-
Mounir Lamouri authored
When the internal object is destroyed, notify the controller so it can reset its internal state. It allows the user to close the window via any system/window manager UI. Bug: 863842 Change-Id: Ica84f4ffee2578658a60e0ae708a4e327d293077 Reviewed-on: https://chromium-review.googlesource.com/1147252Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
apacible <apacible@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#577594}
-
Philip Rogers authored
This patch stops culling out painting of svg images and svg shapes in the presence of transform styles. This was done for containers in crrev.com/575855 but needs to apply to all svg painting. SVGModelObjectPainter has been introduced so the cull rect optimization can be shared by shapes, images, and containers. A lengthy comment has been added in SVGModelObjectPainter::CullRectSkipsPainting describing why. While we're in the area and thinking about sharing code, the common outline painting code for has also been unified (SVGModelObjectPainter::PaintOutline). Bug: 865965, 862318 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I5bb3d43ae089d4bd6c617957abf9c401dfb89e0c Reviewed-on: https://chromium-review.googlesource.com/1146147 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#577593}
-
Jan Krcal authored
This CL introduces new UMA histograms that record types of commits and updates processed by the sync engine. For each datatype there is a separate histogram so that the data can indicate bugs or regression in individual data types. Bug: 859859 Change-Id: Iaeaa7a657ebe7d9d6fbbd329152162c5acaadc01 Reviewed-on: https://chromium-review.googlesource.com/1131507 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#577592}
-
Mike Frysinger authored
Newer pylint warns when files have trailing blank lines. Trim them. Bug: 866772 Change-Id: Ib0f353d83dd0b86ac0b304c5704a9725867846b2 Reviewed-on: https://chromium-review.googlesource.com/1147719Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#577591}
-
Sidney San Martín authored
This is a reland of 94b94d9e Original change's description: > Simplify how the FSLP background rect is chosen. > > Before, the background size was reconstituted from the layer tree by > taking the union of of black and video layers. Now, the actual size is > plumbed through. > > Change-Id: I0cb643b350ef7e4fca06e3bfd419e24861a2e3c6 > Reviewed-on: https://chromium-review.googlesource.com/1142962 > Reviewed-by: ccameron <ccameron@chromium.org> > Commit-Queue: Sidney San Martín <sdy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576521} Change-Id: Idf5199a2aeb8be08b34e0594142c33b3ebed5b78 Reviewed-on: https://chromium-review.googlesource.com/1143960Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#577590}
-
Nicolas Ouellet-payeur authored
We were using a magic number for what is technically a platform-specific constant, which hurts readability & portability. Bug: 816389 Change-Id: I9be8d32d08f2e1f224e04a594269b1e1d73fbade Reviewed-on: https://chromium-review.googlesource.com/1146996Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#577589}
-
Victor Costan authored
Change-Id: Ib1ad967c2a331323b59f6bc40114f4a1a296eab4 Reviewed-on: https://chromium-review.googlesource.com/1148221 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#577588}
-
Tommy C. Li authored
This is a reland of 26399bca It simplifies the layer creation-and-destruction lifecycle, because that aspect seemed the most suspicious for causing crashes. Original change's description: > Match security chip visibility with focus ring > > Instantly hides or shows the IconLabelBubbleView separator when focus > rings are available to prevent showing the separator when a focus ring > overlaps it. > > Bug: chromium:865029 > Change-Id: I21a4c296c1da06b81dc91d66101d46e8ad52ad99 > Reviewed-on: https://chromium-review.googlesource.com/1142442 > Commit-Queue: Peter Boström <pbos@chromium.org> > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576358} Bug: chromium:865029 Change-Id: I7b5b597a6e6ec114faf4888b62da1f8751e64646 Reviewed-on: https://chromium-review.googlesource.com/1147361Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#577587}
-
Andreas Haas authored
This is the blink side CL to refactor WebAssembly.instantiateStreaming to make it spec compliant again. The design doc where the whole change is discussed is available in the tracking bug. The tracking bug also references prototype implementations of the whole change, which includes the changes in this CL. Note that most of the changes in this CL are copied from the existing implementation which uses the old API. I added a regression test but disable it until the V8 change landed. Bug: chromium:860637 Change-Id: Iba75dc4e187aad5891084e5e7dcc3f759e86f706 Reviewed-on: https://chromium-review.googlesource.com/1081947 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#577586}
-
Jan Krcal authored
The problem came with CL https://chromium-review.googlesource.com/c/chromium/src/+/1129140. Bug: 866876 Change-Id: I00c6a6464b6cd8a879c0c7bb72c03bc221137043 Reviewed-on: https://chromium-review.googlesource.com/1148388Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#577585}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8afa86c63713..734b2a859784 git log 8afa86c63713..734b2a859784 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 ethannicholas@google.com Revert "removed SkSLLayoutLexer" 2018-07-24 herb@google.com Clean up bitmap path 2018-07-24 egdaniel@google.com Add new vulkan headers to third_party/vulkan. 2018-07-24 jvanverth@google.com Some more SkPolyUtils optimizations and clean up. 2018-07-24 ethannicholas@google.com removed SkSLLayoutLexer 2018-07-24 robertphillips@google.com Address fuzzer issue 2018-07-24 caryclark@skia.org fix bookmaker bot Created with: gclient setdep -r src/third_party/skia@734b2a859784 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866775 TBR=benjaminwagner@chromium.org Change-Id: I72064c967a9348238014399d855b79c164b6d713 Reviewed-on: https://chromium-review.googlesource.com/1147910Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577584}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3bf99f3a4746..43ee74f7bd72 git log 3bf99f3a4746..43ee74f7bd72 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 hjd@google.com Merge "Implement Track Registry" 2018-07-24 dproy@google.com Implement Track Registry Created with: gclient setdep -r src/third_party/perfetto@43ee74f7bd72 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:111540363 TBR=perfetto-bugs@google.com Change-Id: I01da6d5dea361c380caee36c73d1db87769c4968 Reviewed-on: https://chromium-review.googlesource.com/1147951 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577583}
-
Mike Frysinger authored
Newer pylint warns when files have trailing blank lines. Trim them. Bug: 866772 Change-Id: I20739c2086c1fac0a802c07e9f4baa5f8bbf4291 Reviewed-on: https://chromium-review.googlesource.com/1148000Reviewed-by:
Brad Nelson <bradnelson@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#577582}
-
Gabriel Charette authored
Revert "[TaskScheduler] Temporarily disable heartbeat latency metrics on Android to bisect power regression" This reverts commit 548db201. Reason for revert: regression had recovered on its own and this CL doesn't seem to help further : https://chromeperf.appspot.com/group_report?sid=3b04a394179538536eb72ebc4c7a33913ff5dcc85145d95666f5aea61823d770 Original change's description: > [TaskScheduler] Temporarily disable heartbeat latency metrics on Android to bisect power regression > > R=fdoray@chromium.org > > Bug: 848255 > Change-Id: Ic47d338fb15e0bf3579ecd9d1acca67099c6d570 > Reviewed-on: https://chromium-review.googlesource.com/1137849 > Reviewed-by: Robert Liao <robliao@chromium.org> > Commit-Queue: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576158} TBR=gab@chromium.org,robliao@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 848255 Change-Id: Ie402a1ec2381f296863522bcf9ba7c387648df6d Reviewed-on: https://chromium-review.googlesource.com/1148481Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#577581}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4ac42e42..696e3951 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic6a08f97213fc5ccdb0205004dde2117e887b897 Reviewed-on: https://chromium-review.googlesource.com/1148549Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577580}
-
rbpotter authored
Make sure the promo close button is in the tab order, and shows the correct image when focused with the keyboard. Bug: 866420 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id8054203f5917fc72f187c33a826d29817fd3b18 Reviewed-on: https://chromium-review.googlesource.com/1147254 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#577579}
-
Mathieu Perreault authored
Web Store will have an icon now! Bug: 853349 Test: out/Default/ntp_render_browsertests Change-Id: I46182b509b08d2772cb2a439f60f0a3313e5cb81 Reviewed-on: https://chromium-review.googlesource.com/1147105Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#577578}
-
Dave Tapuska authored
gc_info_index was widen to be a size_t in some areas. Whereas the effective gc_index is restricted to be in the range 1 << 14. It is more appropriate to use a uint32_t to store this value as opposed to using a size_t. BUG=596846 Change-Id: I3eac5fadabe82bbadeb315b3c3d8f1d4cf5a62a3 Reviewed-on: https://chromium-review.googlesource.com/1145232Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#577577}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/62e2a5e8c2cd..dad47a9531e4 git log 62e2a5e8c2cd..dad47a9531e4 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 cmtice@google.com Enable CFI on peach_pit and kevin release builders. Created with: gclient setdep -r src/third_party/chromite@dad47a9531e4 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: If51a517a4f3993b214629fcd9aacd654b976c07e Reviewed-on: https://chromium-review.googlesource.com/1147955Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577576}
-
David 'Digit' Turner authored
This CL introduces a new Python script providing various functions to deal with symbolization of crash back traces, stack traces, and memory map sections, as they appear in logcat and tombstone files on Android. They also rely on the classes introduced by the previous CL at [1] - HostLibraryFind() is used to locate unstripped version of native libraries on the host, based on their device path as it appears in tombstones / logcat. - SymbolResolver, and its derived classes, are used to turn a library (path, offset) into a symbol info string. - MemoryMap is used to model the memory map as it appears in a tombstone file, which can be used to symbolize random addresses that appear in the stack. - BackTraceTranslator is used to parse and symbolize back traces as they appear in logcat and tombstones. - StackTranslator is used to parse and symbolize stacks as they appear in tombstones. BUG=755225 R=agrieve@chromium.org, jbudorick@chromium.org, pasko@chromium.org, lizeb@chromium.org [1] https://chromium-review.googlesource.com/c/chromium/src/+/1047211 Change-Id: Ie6d5e8ad395c8953fc6c88948a761ecd2fda8092 Reviewed-on: https://chromium-review.googlesource.com/1138323 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#577575}
-
Oksana Zhuravlova authored
Bug: 855308 Change-Id: I712a91bb7e344827e26cea38d92829871aee9b02 Reviewed-on: https://chromium-review.googlesource.com/1147660Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#577574}
-
Andrew Grieve authored
Bug: 855726 Change-Id: I451b9cc0d68982a9cf3deba0af3d7146e8beb14b Reviewed-on: https://chromium-review.googlesource.com/1114348Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#577573}
-
Anna Offenwanger authored
Merging presentation provider and magic window provider to get rid of duplicate code that fetches data. Changing request session so that it must always return at least one interface for getting data, allowing some uniformity of getting sessions across devices. Bug: 842025 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I587b314daf177619440a82f12471ea567b346caf Reviewed-on: https://chromium-review.googlesource.com/1135831Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Cr-Commit-Position: refs/heads/master@{#577572}
-
Clemens Hammacher authored
In V8, we still have an ordering problem with processing flags. In this case, the "--wasm-tier-up" flag implies "--liftoff", and since "--wasm-tier-up" is enabled by default, also "--liftoff" is enabled by default. If we now set "--no-wasm-tier-up" (via {SetFlagsFromString}), this does not disable "--liftoff". Hence, disable it explicitly. R=jochen@chromium.org, titzer@chromium.org Bug: chromium:866924, chromium:787421 Change-Id: I298792bda07ef02a8f039c72be165ec815baa46f Reviewed-on: https://chromium-review.googlesource.com/1148386Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#577571}
-
Mikel Astiz authored
No actual implementation included, just the basic skeleton files and classes, the required plumbing and the associated feature toggle. Follow-up patches will introduce the actual implementation, to ultimately replace AutofillWalletSyncableService. Bug: 853688 Change-Id: Ia0963fbad2d3e046686e93aea6468283bad186fd Reviewed-on: https://chromium-review.googlesource.com/1147223Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#577570}
-
chrome://ukmMoe Ahmadi authored
- Modifies iOS implementation of chrome://ukm to use WebUI. - Refactors HTML/JS resources to be used in iOS. - Removes method in ukm::UkmDebugDataExtractor that returns HTML debug data. - Adds helper methods to resolve/reject Promises to WebUIIOS. Bug: 843181 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I008ce1beb8d35dd9d4a7fc482990f06e3095f16a Reviewed-on: https://chromium-review.googlesource.com/1147241 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#577569}
-
Kurt Horimoto authored
Since the OmniboxFocuser dispatcher is owned by the BVC and the tab switcher coordinator doesn't know about BVC details, this logic needs to be pushed up to MainController. Bug: 805106 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4c1e78de8eebb104f597651d9e81f79e292eb079 Reviewed-on: https://chromium-review.googlesource.com/1142540Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#577568}
-
Danyao Wang authored
I missed this suggestion in http://crrev.com/c/1145725 Bug: 865985 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie656457f7acf0acb5da81cfc267a7962acb62cc3 Reviewed-on: https://chromium-review.googlesource.com/1146902Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#577567}
-
Justin Novosad authored
This is a reland of 5c4bc1ff Original change's description: > Add a single buffered mode to CanvasResourceProvider > > This CL completes the initial implementation of Low Latency mode for 2d > canvases > > Bug: 788439 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I58fcd3fe4ab19fa10f2876f3da4f078fd4fbc2a9 > Reviewed-on: https://chromium-review.googlesource.com/1145235 > Commit-Queue: Justin Novosad <junov@chromium.org> > Reviewed-by: Fernando Serboncini <fserb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576962} TBR=fserb@chromium.org Bug: 788439 Change-Id: Ie18018ef0ebcff92beb31fcdebbc0ac2e077053e Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1147952 Commit-Queue: Justin Novosad <junov@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#577566}
-
Helen Li authored
This reverts commit 494108ab. Reason for revert: Reland it in M70. Original change's description: > Revert "Convert Extensions TCP & TLS Socket APIs to mojo sockets" > > This reverts commit 41066e83. > > Reason for revert: This CL broke an internal app. See crbug.com/865958 > > Original change's description: > > Convert Extensions TCP & TLS Socket APIs to mojo sockets > > > > This CL converts extensions TCP and TLS socket apis to network service's mojo > > socket. > > > > - Remove combined_socket_unittest.cc because the test cases no longer apply. I > > tried to write equivalent ones in tcp_socket_unittest.cc and > > tls_socket_unittest.cc > > - Add a ContentUtilityClient implementation for extensions_browsertests, so we > > can inject a NetworkServiceTestHelper to the utility process in which network > > service runs. > > > > Bug: 721401 > > Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_mojo > > Change-Id: I333a3021a5c66eb94618be6830ba0ff68c442eba > > Reviewed-on: https://chromium-review.googlesource.com/1070434 > > Commit-Queue: Helen Li <xunjieli@chromium.org> > > Reviewed-by: Maks Orlovich <morlovich@chromium.org> > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Reviewed-by: Reilly Grant <reillyg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#563390} > > TBR=jam@chromium.org,reillyg@chromium.org,xunjieli@chromium.org,morlovich@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 721401, 865958 > Change-Id: I9e9408f31887ab45d0bd967e2f17f91c465836c6 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng;luci.chromium.try:linux_mojo > Reviewed-on: https://chromium-review.googlesource.com/1145340 > Commit-Queue: Helen Li <xunjieli@chromium.org> > Reviewed-by: Helen Li <xunjieli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576982} TBR=jam@chromium.org,reillyg@chromium.org,xunjieli@chromium.org,morlovich@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 721401, 865958 Change-Id: I9748ea1d6c04f26429508da9358ca16ff01ff90d Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng;luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1148480Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#577565}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2bc1ba83. With Chromium commits locally applied on WPT: 1736c657 "Rename a WPT which has a duplicate basename" 4bd63c29 "webrtc wpt: close RTCPeerConnection in generateAnswer helper" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21663 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=foolip No-Export: true Change-Id: Ib1cfdee63c7a97d40221e092ecdeef485b5c7235 Reviewed-on: https://chromium-review.googlesource.com/1148235 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#577564}
-
Moe Ahmadi authored
This reverts commit 5e8f9218. Reason for revert: These tests failed due to a change to the Autofill predictions server in which it started sending UNKNOWN_TYPE for unknown fields (which signals Autofill not to fill and save form data) rather than NO_SERVER_DATA ( which signals Autofill to fall back to the local heuristics). Since these tests rely on saving a profile in order to populate the settings page and that the test form wasn't known to the predictions server, they started to fail. crbug.com/866922 is filed to eliminate that dependency. Original change's description: > [ios] Disable failing autofill tests. > > TBR: sczs@chromium.org > Bug: 866730 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: Ibc3828d336d5f6247f2a656d747e35847f86fd70 > Reviewed-on: https://chromium-review.googlesource.com/1147701 > Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> > Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577384} TBR=rohitrao@chromium.org,justincohen@chromium.org,kkhorimoto@chromium.org,sczs@chromium.org Change-Id: Iba5ecab647a979cebf6d4b32894c665b356037b5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 866730 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1148502Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#577563}
-
Luis Hector Chavez authored
This change also lets the unhandled exception handler take a first attempt at handling errors that occur when handling connection errors. yo dawg! Bug: 810087 Test: Intentionally threw an exception from a connection error handler Change-Id: I432055b33443208a352d272c7f7fcb1dbeb2a43f Reviewed-on: https://chromium-review.googlesource.com/1147516Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#577562}
-
Bill Budge authored
- Modifies partition allocator, adding a TryRealloc method that returns nullptr on failure, rather than OOM crashing. - Modifies the single call site in Blink for buffer resizing during serialization. Bug: chromium:857387 Change-Id: I9bf8d3ced837a9dd4f96a953bb52ccad3078dfa1 Reviewed-on: https://chromium-review.googlesource.com/1138859Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#577561}
-
Peter Kasting authored
Bug: none Change-Id: Ib5d1fbac1ccc7aec39cbaad56edc36c7f9fcea11 Reviewed-on: https://chromium-review.googlesource.com/1147091Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#577560}
-
Findit authored
This reverts commit 9311d412. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 577500 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzkzMTFkNDEyNTNmYzc0ZDQ5NTI3ZmIyZWU2OWUwMzYzMzM0Yjk2OWQM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win%207%20Tests%20x64%20%281%29/41118 Sample Failed Step: viz_content_unittests Original change's description: > Reland "[Background Fetch] Move all updatable UI options to their own proto." > > This is a reland of d3981964 > > TBR=avi@chromium.org > > Original change's description: > > [Background Fetch] Move all updatable UI options to their own proto. > > > > Bundle up the icon and the title since they will be accessed/modified > > together in the updateUI call. > > > > It also makes sense to move the icon from the metadata proto since that > > will speed up getting the registration info. > > > > TBR=avi@chromium.org > > > > Bug: 865063 > > Change-Id: I661062f19fddfa6b9c3bf11b5e146d5289a02593 > > Reviewed-on: https://chromium-review.googlesource.com/1146650 > > Commit-Queue: Rayan Kanso <rayankans@chromium.org> > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Reviewed-by: Peter Beverloo <peter@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#577272} > > Bug: 865063 > Change-Id: I77567e8e2e0ea59ede514c77b40326e7ece48a25 > Reviewed-on: https://chromium-review.googlesource.com/1148261 > Commit-Queue: Rayan Kanso <rayankans@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577500} Change-Id: I60aa46070806c053cc60d77b32456d192de378c8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 865063 Reviewed-on: https://chromium-review.googlesource.com/1148500 Cr-Commit-Position: refs/heads/master@{#577559}
-