GitLab

We're not moving the bitmap after injected cursor moves. This regressed
in r312018 ("ozone: dri: Synchronize the cursor state").

BUG=459447
TEST=Connect via remoting to freon chromebook & move cursor. Cursor
     displayed on remote system should track movement closely.

Review URL: https://codereview.chromium.org/933363003

Cr-Commit-Position: refs/heads/master@{#316914}

DuplicateFinder now aggregates stats over its lifetime.

MediaImportHandler was changed to create a DuplicateFinder instance per import, so stats relating to duplicate-finding are reported per import session (instead of per-file).

Other changes are just straight-up addition of analytics logging code.

BUG=457736

Review URL: https://codereview.chromium.org/918713003

Cr-Commit-Position: refs/heads/master@{#316913}

WebContentsImpl::RouteMessageEvent is called in the UI thread, and it called
MessagePortService::UpdateMessagePort which assumed to be called in the IO
thread. Oops.

BUG=459115

Review URL: https://codereview.chromium.org/940493002

Cr-Commit-Position: refs/heads/master@{#316912}

This still breaks Clang-Win, as it seems Clang-Win mimics MSVS.

BUG=

Review URL: https://codereview.chromium.org/913223006

Cr-Commit-Position: refs/heads/master@{#316911}

Note that target_subarch=both is already set on the tryserver and Mac main waterfalls.

BUG=458398

Review URL: https://codereview.chromium.org/926443002

Cr-Commit-Position: refs/heads/master@{#316910}

Offscreen surfaces are implemented in different ways on different devices.
Using a framebuffer object allows gpu_perftests to run where a drawable offscreen surface is not available (i.e: mac) and in general to have a more consistent behavior across different drivers.

BUG=423481

Review URL: https://codereview.chromium.org/939553002

Cr-Commit-Position: refs/heads/master@{#316909}

Due to a recent threading changes, the Ozone SystemInputInjector must be
created on the UI thread.

This CL moves the creation of the input injector and input controller on
to the browser UI thread.

BUG=458314

Committed: https://crrev.com/9c59eedd7720845a5bc93b6dbc72639305c52ea7
Cr-Commit-Position: refs/heads/master@{#316883}

Review URL: https://codereview.chromium.org/931393003

Cr-Commit-Position: refs/heads/master@{#316908}

This is a followup to
https://chromium.googlesource.com/chromium/src/+/4ee38944c67548f1314f9fc1ef1363797b28bf02

BUG=None
TEST=trybots - GYP and GN builds still works.
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/940643002

Cr-Commit-Position: refs/heads/master@{#316907}

WebRTC 8413:8421
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/27b46ae..bec05b6

Libjingle 8411:8417
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/ea35ab3..e8e2384

TBR=niklase@chromium.org

Review URL: https://codereview.chromium.org/934363002

Cr-Commit-Position: refs/heads/master@{#316906}

Verify that the page transition matches the navigation type with RendererDidNavigate[New|Auto]Subframe.

BUG=none
TEST=should all stay green

Review URL: https://codereview.chromium.org/814563004

Cr-Commit-Position: refs/heads/master@{#316905}

[Telemetry] Rename test methods in page_test_results_unittest to follow existing convention of telemetry

Review URL: https://codereview.chromium.org/937783002

Cr-Commit-Position: refs/heads/master@{#316904}

When the plugin params don't include a MIME type, and there is no
plugin found, the first menu item will be blank.

This patch just removes the first menu item if there is no mime type.

BUG=354197

Review URL: https://codereview.chromium.org/937823002

Cr-Commit-Position: refs/heads/master@{#316903}

R=mbarbella@chromium.org
TBR=tsepez@chromium.org
BUG=450268

Review URL: https://codereview.chromium.org/932103003

Cr-Commit-Position: refs/heads/master@{#316902}

It should be be updated for each platform, in the same way the menu
item to bring it up is.

BUG=447384

Review URL: https://codereview.chromium.org/932023002

Cr-Commit-Position: refs/heads/master@{#316901}

BUG=437277

Review URL: https://codereview.chromium.org/937713004

Cr-Commit-Position: refs/heads/master@{#316900}

The change in the chrome_autofill_client.cc is needed to enable the autofill popup on
Mac.

BUG=447938
TEST=Start Chrome. Navigate to chrome://chrome-signin. Enter a correct username
with an incorrect password. After the password error appears, you should be able
to autofill that username.

Committed: https://crrev.com/4a1e13b16b5ef2cb6f7c800ad3c08f1f44bef285
Cr-Commit-Position: refs/heads/master@{#314889}

Review URL: https://codereview.chromium.org/866523002

Cr-Commit-Position: refs/heads/master@{#316899}

Revert of Fix breaking change in It2me Host on Ozone (patchset #2 id:20001 of https://codereview.chromium.org/931393003/)

Reason for revert:
does not compile

Original issue's description:
> Fix breaking change in It2me Host on Ozone
>
> Due to a recent threading changes, the Ozone SystemInputInjector must be
> created on the UI thread.
>
> This CL moves the creation of the input injector and input controller on
> to the browser UI thread.
>
> BUG=458314
>
> Committed: https://crrev.com/9c59eedd7720845a5bc93b6dbc72639305c52ea7
> Cr-Commit-Position: refs/heads/master@{#316883}

TBR=sergeyu@chromium.org,kelvinp@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=458314

Review URL: https://codereview.chromium.org/932233002

Cr-Commit-Position: refs/heads/master@{#316898}

This addresses several issues:

- Use of weak_factory_io_to_io_ was unsafe because PushMessagingMessageFilter
  could be destroyed on either IO or UI thread. Fixed by overriding OnDestruct
  to ensure it is always destroyed on IO thread.

- Use of weak_factory_ui_to_ui_ was similarly unsafe. Fixed by splitting out
  the UI thread parts of PushMessagingMessageFilter into a new class,
  PushMessagingMessageFilterCore, which does all the UI thread work, and is
  destoyed on the UI thread. To preserve code clarity, the methods of both
  PushMessagingMessageFilter and PushMessagingMessageFilterCore remain
  interleaved in the .cc file, so that each of the flows triggered by incoming
  messages can be easily traced by reading the methods in order.

- PushMessagingMessageFilter::service() was unsafe because it may be called
  after the Profile is destroyed, in which case the cached PushMessagingService
  would also have been destroyed. Fixed by removing caching.

BUG=459231

Review URL: https://codereview.chromium.org/933523005

Cr-Commit-Position: refs/heads/master@{#316897}

Hide JNI exported functions in Android binaries by default, unless the
target in question has explicitly set "use_native_jni_exports" to
indicate that it relies on the JVM's automatic symbol lookup mechanism.

The functions are simply demoted to hidden visibility; the code will
remain unless the linker determines that it is unreferenced and strips
it via --gc-sections.

This ensures that binaries by default actually test the explicit JNI
registration codepaths, which are required for compatibility with the
crazy linker, while still allowing binaries that do not require crazy
linker compatibility to choose to use the automatic mechanism in future.

BUG=442327

Review URL: https://codereview.chromium.org/843103003

Cr-Commit-Position: refs/heads/master@{#316896}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/e4ef1ca..c119981

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=scroggo@google.com

Review URL: https://codereview.chromium.org/920343005

Cr-Commit-Position: refs/heads/master@{#316895}

This change followed by the virtual methods and override/final section of
http://www.chromium.org/developers/coding-style/chromium-style-checker-errors.
Only one of {virtual,override,final} should be used for each declaration, since
override implies virtual.

BUG=417463

Review URL: https://codereview.chromium.org/906413003

Cr-Commit-Position: refs/heads/master@{#316894}

BUG=420680

Review URL: https://codereview.chromium.org/933393002

Cr-Commit-Position: refs/heads/master@{#316893}

This removes #ifs that are no longer needed since Blink-side changes
(http://crrev.com/875423003) have landed.

BUG=453924

Review URL: https://codereview.chromium.org/940463005

Cr-Commit-Position: refs/heads/master@{#316892}

BUG=none

Review URL: https://codereview.chromium.org/937793002

Cr-Commit-Position: refs/heads/master@{#316891}

Change the dependency of 'browser_ui' on 'libusb' to only be present
when OS is neither "ios" nor "android", instead of always having it
and removing it when OS is "android".

BUG=458398

Review URL: https://codereview.chromium.org/934323003

Cr-Commit-Position: refs/heads/master@{#316890}

BUG=417463

Review URL: https://codereview.chromium.org/935083003

Cr-Commit-Position: refs/heads/master@{#316889}

BUG=417463

Review URL: https://codereview.chromium.org/938773002

Cr-Commit-Position: refs/heads/master@{#316888}

Review URL: https://codereview.chromium.org/926053003

Cr-Commit-Position: refs/heads/master@{#316887}

R=lcwu@chromium.org,byungchul@chromium.org
BUG=internal b/19004169

Review URL: https://codereview.chromium.org/917063003

Cr-Commit-Position: refs/heads/master@{#316886}

R=lcwu@chromium.org
BUG=458727

Review URL: https://codereview.chromium.org/936833002

Cr-Commit-Position: refs/heads/master@{#316885}

To set an extension id for the extensionview, there must be a  connect(extensionid, src); call. After an extension has been set, it cannot be reset without the guestview being destroyed/recreated. Once an extension has been set, the src can be modified to navigate to different pages for that extension.

The extensionview will navigate to pages with format of chrome-extension://extensionid/page.html, where:
extension="extensionid" and src="page.html"

BUG=459680

Review URL: https://codereview.chromium.org/913393003

Cr-Commit-Position: refs/heads/master@{#316884}

Due to a recent threading changes, the Ozone SystemInputInjector must be
created on the UI thread.

This CL moves the creation of the input injector and input controller on
to the browser UI thread.

BUG=458314

Review URL: https://codereview.chromium.org/931393003

Cr-Commit-Position: refs/heads/master@{#316883}

An unrelated change of mine revealed that SyncBackendMigratorTest
failed to correctly initialize the browser threads necessary for
creating ProfileSyncService.

This error manifested in a confusing way, so I've added a DCHECK to
make it clearer in the future.

Review URL: https://codereview.chromium.org/936673002

Cr-Commit-Position: refs/heads/master@{#316882}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/52a23441..209cf09a

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/938793002

Cr-Commit-Position: refs/heads/master@{#316881}

This CL causes gclient runhooks to unpack the NaCl toolchain to
//native_client/toolchain.  It also causes GYP to use the toolchain from that
location rather than unpacking it into the output directory during the build.

This CL adds a landmine to reclaim ~1 GB of disk space.  Landmines are normally
used for correctness issues, in this case it is being used because an additional
1 GB of disk usage could cause random bots to fail.

BUG=456902

Review URL: https://codereview.chromium.org/921243002

Cr-Commit-Position: refs/heads/master@{#316880}

The "microdump_stackwalk", "minidump_stackwalk", and "minidump_dump" tools
are not expected to be run on the device, so only build them for "host"
toolset not "target" when targetting iOS.

When building for other targets build the tools both for "host" and "target"
to fix compilation of ChromeOS build in `cros chrome-sdk` shells.

BUG=459035
TBR=mark

Review URL: https://codereview.chromium.org/938763004

Cr-Commit-Position: refs/heads/master@{#316879}

WebRTC 8406:8413
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/cbbabc7..27b46ae

Libjingle 8405:8411
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/b798082..ea35ab3

TBR=niklase@chromium.org

Review URL: https://codereview.chromium.org/937563003

Cr-Commit-Position: refs/heads/master@{#316878}

BUG=458406

Review URL: https://codereview.chromium.org/925673003

Cr-Commit-Position: refs/heads/master@{#316877}

https://chromium.googlesource.com/angle/angle/+log/73edef0a2a..5feea5623

BUG=436191

Review URL: https://codereview.chromium.org/918583003

Cr-Commit-Position: refs/heads/master@{#316876}

DEPENDS ON 914403006

* If a user visits a page that triggers a banner icon download
  and immediately navigates away, the native BitmapFetcher will
  be deleted before its callback is handled, resulting in a crash.
  Address this by storing a vector of BitmapFetchers that are
  trimmed as fetches complete.

* Add basic unit test for ensuring that the race condition doesn't
  cause a crash anymore.

- There is still some timing wackiness that can go on here, like
  having the entire AppBannerManager go away before the fetch
  completes, but that requires further digging.

BUG=453170,457414,457413
TEST=AppBannerManagerTest

Review URL: https://codereview.chromium.org/914813002

Cr-Commit-Position: refs/heads/master@{#316875}