- 15 Jan, 2020 3 commits
-
-
Ramin Halavati authored
Param names are updated in the field trial test. Bug: 1017120 Change-Id: I6f3fee3faaac5f9061c097858c5b02b05c3e8fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989066 Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#731744}
-
Dan Beam authored
Done with: $ git ls-files 'ui/webui/*.js' | xargs perl -p -i -e 's/ ([!=])=(?!=)/ \1==/g' Bug: 720034 Change-Id: Ib012e225c21f3d68176078a7b5410207e1778e0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001259 Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#731743}
-
Kurt Horimoto authored
These classes implement the behavior shared amongst all infobar modal implementations. The coordinator packages a modal view configured by subclasses into a UINavigationController and presents it modally. The mediator conforms to InfobarModalDelegate and handles those callbacks. Bug: 1030357 Change-Id: I2c20f8c545daa5038bcccca3c10d7a24a8b3d2b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995687 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#731742}
-
- 14 Jan, 2020 37 commits
-
-
Robert Ogden authored
Bug: 1023482 Change-Id: I182fb9a4534441fecde63fb03949f8441656de4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001555 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#731741}
-
David Munro authored
Bug: None Test: CQ Change-Id: I3ed71c53de6108fbf096202e0d2d8b06f27fa0fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994842Reviewed-by:
David Munro <davidmunro@google.com> Reviewed-by:
Timothy Loh <timloh@chromium.org> Auto-Submit: David Munro <davidmunro@google.com> Commit-Queue: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#731740}
-
Lachlan Ford authored
In order to enable the OpenXR flag by default we must fix tests that assume OpenXR is disabled otherwise they will fail. Change-Id: If9d117e3ea4ef2e2ddd7d9f1bb3aedc601c0b27e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999450Reviewed-by:
Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Lachlan Ford <laford@microsoft.com> Cr-Commit-Position: refs/heads/master@{#731739}
-
Xianzhu Wang authored
This implements the same logic in pre-CAP compositor that prevents squashing of two layers that are too far away to avoid big squashed layer with sparse contents. Change-Id: Iea9f761ed6bcff19a45d57489bc3929d4bca71a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990343 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#731738}
-
Rachel Carpenter authored
Have commented the new code out as the file does not exist in the current app that is pulled in from g3. Can uncomment line after the next CIPD update that includes the new file. Bug: b/147331285 Change-Id: Ib323a03c8c6f0404f97957185936320a7a5ed6fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999887Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@google.com> Cr-Commit-Position: refs/heads/master@{#731737}
-
Cathy Li authored
Change-Id: Ia9237329cedb733e657912fc44a15688ae3bafd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806075Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#731736}
-
Carlos IL authored
ContentSettings.MixedScript has already expired, and the metrics are no longer used (or emitted) after the mixed content shield removal. This CL removes uses from code and marks the histogram obsolete. Bug: 988686 Change-Id: I203a447b53aff09f7ac10895e35e4355e5ddf61e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987294Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#731735}
-
Mike Reed authored
- override new 4x4 virtual - override scale/translate virtuals In the new *brave* world, SkCanvas will call didTranslate() and didScale() in response to the corresponding public calls. On the impl side, SkCanvas no longer has a default impl for either, so they must be overridden. Having to update multiple unittests might point to a slight problem with layering and testing. It appears (to me) that most of the sites I had to update were incidental, not core, to the test. The caller is baking in assumptions about how Skia handles some high-level api calls (and what virtuals it may call). If we could find a different way to still test the chrome/blink code in question, it will be easier going forward. bug: skia:9768 Change-Id: I8aa62feb354392105229ea45686b8208ba0e1450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998247 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#731734}
-
John Lee authored
This CL updates the TabStripUIHandler to send events ot the WebUI for when a tab's group state is changed. This CL also sets up the first unit test for the handler. This CL does not add the front-end changes, or the events for changes to a tab group's visuals or indexes. Bug: 1027373 Change-Id: I7c72dbbd189a308c8565c9ecd29e76007fe60c93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999225 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#731733}
-
Theresa Wellington authored
BUG=1041822 TBR=harringtond@chromium.org Change-Id: Id22776f84bc687fbe164fd197496314b5941c94d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001583Reviewed-by:
-
Alan Cutter authored
This CL changes PWA manifest update check throttling to reset on browser restart. This is to make it easier to diagnose any issues with PWA updating detected on live profiles by ensuring that manifest update checks will be performed after a browser restart. This CL adds a DesktopPWAsLocalUpdatingThrottlePersistence flag that can quickly revert us back to the previous behaviour should we need. Bug: 926083 Change-Id: Id9a0f9146af710922dd11cc42c114bf6dff31a3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999902Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#731731}
-
Ovidio Henriquez authored
This change implements the methods in BluetoothChooserContext and creates a unit test for the class. Design Doc: https://docs.google.com/document/d/1h3uAVXJARHrNWaNACUPiQhLt7XI-fFFQoARSs1WgMDM/edit?usp=sharing Bug: 589228 Change-Id: I1c564177063f9459081c45ddb4c0bb757fabd667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978819 Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#731730}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d85dc3874aaa..a0840e9a2f6a git log d85dc3874aaa..a0840e9a2f6a --date=short --first-parent --format='%ad %ae %s' 2020-01-14 hongchan@chromium.org Migrate webaudio/ to ESM internally Created with: gclient setdep -r src/third_party/devtools-frontend/src@a0840e9a2f6a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1040646 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7a57268e4ee9d4ab4fd54fde8fe5b2f2fdc4c949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001522Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#731729}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6e62267bbb42..69949ed05dcf Created with: gclient setdep -r src-internal@69949ed05dcf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1022108,chromium:1028270,chromium:684817 Tbr: jbudorick@google.com Change-Id: Ia7acfb14e57e52374e5c4d0f1e3cebaee1eb612c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001519Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#731728}
-
shrekshao authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/88d715c..4f3976e TBR=kbr@chromium.org Bug: 1000354 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64 Change-Id: Icf1f39b04a3b90b8a652238b6110f1b87221f0d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998295Reviewed-by:
Shrek Shao <shrekshao@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Auto-Submit: Shrek Shao <shrekshao@google.com> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#731727}
-
Alex Cooper authored
This adds code (behind a flag) to allow WebXr sessions to determine the needed permissions and prompt the user for them on both Desktop and Android. In order to properly link to the PermissionManager and related classes, VRServiceImpl and the classes that call into it needed to be moved into the chrome/browser Build target. Given that this target depends on vr_common (where these other classes are), vr_common couldn't depend on it, or else it would introduce a circular dependency. Therefore, these files were moved into chrome/browser's target, which seemed to be common for other classes that relied on PermissionManager. vr_headset.png's generated from source SVG in crbug.com/912203 (which is the source of the currently checked-in vr_headset.icon) Note that strings are currently placeholders. Showing the permission status in the page info bubble and site settings will be done in future changes. Bug: 1033592 Change-Id: I5be7f8b6e62c00fcb11ddeb6c2410720ec9c1bf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992508 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#731726}
-
Jimmy Gong authored
- Moving these test util functions allows shared access to the functions. Bug: 1015628 Test: browser test Change-Id: I3332b6e477222eba590725165569beb2715942ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998819 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#731725}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/59a3b2fd5d0e..ce09ca54f86e git log 59a3b2fd5d0e..ce09ca54f86e --date=short --first-parent --format='%ad %ae %s' 2020-01-14 vadimsh@chromium.org [lucicfg] Update v1.11.14 => v1.11.17. Created with: gclient setdep -r src/third_party/depot_tools@ce09ca54f86e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I01b74cc5e5116841e32e712c5ce1777b59ab2645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001520Reviewed-by:
-
Roberto Carrillo authored
external/wpt/html/semantics/forms/constraints/form-validation-reportValidity.html TBR=robertma,foolip Bug: 1041973 Change-Id: Id554bd1ea92db462040836d3c74ec985c2d68627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001577Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#731723}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/52e9146a65fd..c58babd220a9 git log 52e9146a65fd..c58babd220a9 --date=short --first-parent --format='%ad %ae %s' 2020-01-14 tsepez@chromium.org Initialize more fwl classes in header. 2020-01-14 thestig@chromium.org Rename CPDF_DIBBase to CPDF_DIB. Created with: gclient setdep -r src/third_party/pdfium@c58babd220a9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I6f310c04c9cb1ba3fe015ddb58ca211fe51c7a16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001517Reviewed-by:
-
Nick Diego Yamane authored
crrev.com/c/1769450 removed X11-specific DWTHX11::{Set,Is}Fullscreen() overrides in favor of DWTHPlatform versions, making chrome to enter/exit browser fullscreen mode both when it is requested explicitly by the user (e.g: Using F11 keybinding) as well as when it was requested by the other process, e.g: custom WM keybinding to toggle _NET_WM_STATE_FULLSCREEN window state. Such functionality change can be considered a regression as it violate EWMH guidelines, which states: > When a window-manager tells a window to become 'fullscreen', it is not > telling the window to make a sub-selection of its contents fullscreen, but > instead optimize the whole application for fullscreen usage. Window > decorations (e.g. borders) should be hidden, but the functionalily of the > application should not change. This CL restores the previous behavior and test expectations. Additionally this fixes an issue in window bounds tracking while it is in browser fullscreen mode (but the X11 window is not in fullscreen state). Such issue was already present before this regression has been introduced. Bug: 1035772 Change-Id: Ief8fba7df2c5d2466da038c2b9edf1d928261c8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989049Reviewed-by:Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#731721}
-
Oksana Zhuravlova authored
Since Java bridge is an Android-specific feature, this change guards the relevant code in the renderer with #if defined(OS_ANDROID). Bug: 794320 Change-Id: I4b14f47eebce91b6697d5dec04af0314ec6162b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995992Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#731720}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/28f5c8101b20..d3e59119bcf5 git log 28f5c8101b20..d3e59119bcf5 --date=short --first-parent --format='%ad %ae %s' 2020-01-14 primiano@google.com Merge "ui: add offline support via ServiceWorker" Created with: gclient setdep -r src/third_party/perfetto@d3e59119bcf5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Iba5174d39a4dfb5e4c6e3023ba8822891706ad5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001518Reviewed-by:
-
Chris Mumford authored
Required changes: 1. Python 3 exceptions no longer have a message attribute so created a new ExtractError exception. 2. Switched from the imp to the importlib module. Bug: none Change-Id: I5c8b08dca1534e235309464cf5e054578b9ed2f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000981 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#731718}
-
Bin Wu authored
In QUIC field trial testing config, change the connection_options of the 'Enabled' group from 'NSTP' to '5RTO,ACKD'. R=rch@chromium.org Change-Id: If8f66f1c892c27bb8525e0798c41be725724d6aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000968 Commit-Queue: Bin Wu <wub@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#731717}
-
Julian Watson authored
Bug: 1023256 Change-Id: I69df55758d0388f9d1630bd97e57df4518b1e932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977885 Commit-Queue: Julian Watson <juwa@google.com> Reviewed-by:
Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#731716}
-
Daniel McArdle authored
Change-Id: Ie0bf69b8c599c46df165e3ca624939ee34dd5dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001186Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#731715}
-
David Van Cleve authored
We have a feature in //net where we'd like to reuse the SQLite-wrapping infrastructure implemented in //chrome/browser/predictors. This change, the first of two CLs comprising this refactor, moves ResourcePrefetchPredictor's table classes to //components, making only the smallest possible changes to the classes themselves. The subsequent followup change will do some renaming in order to make the classes sound a little more generic. Bug: 1036494 Change-Id: I5dd8f35d4e135115eeae149099f474e21187c270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979366 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#731714}
-
Greg Guterman authored
I've joined the current mb_config.pyl with /src/cr-buildbucket.cfg to remap masters to buckets for a new bucket-based mb_config_buckets.pyl. Also the old logic that used the 'master: { chromium: {...}}' dict to specify the chromium builders that blacklist chrome proprietary mixins now looks at a top-level config key in mb_config_buckets.pyl called 'public_artifact_builders'. mb.py has been modified to support the new type of mapping in mb_config_buckets.pyl and will use it by default if a bucket is specified. I hope to move all the code that uses mb to use buckets instead of masters, at which point I plan to remove all the master-related functions from mb.py The new functions have been written in a way that makes it easy to remove the old master-based functions at the cost of being less DRY. Validation stuff was factored out to a helper file to lighten the load inside of mb.py. Also there seems to be a dead function which I removed: CheckCompile. This pyl also excludes all the internal builders, which will be moved to src-internal. Bug: 1028719 Change-Id: I86b55b12def06afab81faec66463963ede2f3244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963441 Commit-Queue: Gregory Guterman <guterman@google.com> Reviewed-by:Aaron Gable <agable@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#731713}
-
Dan Beam authored
R=poromov@chromium.org Bug: 1028829 Change-Id: I851c2a128c9ce26d02f1be9f3970d1bbc46f9ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996135 Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#731712}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=pasko@chromium.org Bug: 1041419 Change-Id: Ib7bfeb431e9f0522d2b9b1869bfcabfaf21c34fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998388 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#731711}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=alemate@chromium.org Bug: 1041419 Change-Id: I5723ed7e974e973d1e2d66c9ebf60243507e1111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998797 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#731710}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=alemate@chromium.org Bug: 1041419 Change-Id: I44fcaf044733231b29c44ee2461761a0a6ee23c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998328 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=alemate@chromium.org Bug: 1041419 Change-Id: I6d8f45630e1c04bae8d1f5ff9b41f086a383a74e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997975 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Bence Béky authored
These tests were disabled at one point during the preparation of a recent merge CL, but in the end disabling them would not have been necessary. Change-Id: Iebf4092746e84054acba1a8d6bfe5554a7720956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001317Reviewed-by:
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=alemate@chromium.org Bug: 1041419 Change-Id: I7317b4bfdc0f3a7092ab59f1e8cc5a7380bf402c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993849 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=alemate@chromium.org Bug: 1041419 Change-Id: Ib84fc73891f9d365b3dc0251f7e63111007d1115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997984 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
