GitLab

WebXR AR DOM overlay mode no longer needs the local frame view's
background color to be changed, this is now handled by CSS for the
:xr-overlay pseudoclass. Remove this code to avoid potential
complications such as incorrect background color restoration.

Bug: 1149708
Change-Id: I130842a80eff6d56f58590c8611b2c5e5f7f2878
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543484Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828271}

Project is taking a different approach that neccessitates a change to
the flag name for accuracy.

Change-Id: I45ce6026963c9fda614cc3f1b1c14645b1051405
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544542
Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828270}

Feature has been launched to stable.

Bug: 1147291
Change-Id: I326292a7b38aba0f5a8d71f1dab908f4707c78b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542848
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Glenn Hartmann <hartmanng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828269}

This metric tracks usage of backends and is useful long-term

Bug: 1140055
Change-Id: Ie672922dd8d465da30472fec947582c216ef46f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540611Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828268}

This class was also slightly refactored to get rid of the
logic in VoteData.

Bug: 971272
Change-Id: If10c30d44371ebb00df5507e78dc4dcbd7a165e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533141
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828267}

This CL fixes navigating back to offline pages with the new error page
workflow. It is allowing navigating to WebUI from the error page.
It is also removing the decoding in the JavaScript of the error page as
it was decoding the parameters of the URL which might create issue in
parsing the URL.

Bug: 1138228, 1138894
Change-Id: I8da6b84b295b3f9cbaf53c28fd3f766938409815
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540982
Commit-Queue: Eugene But <eugenebut@chromium.org>
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828266}

Bug: 1115463
Change-Id: I32a0f1c6efb76adc99e6182876541881753212b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541571Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Ian Wells <iwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828265}

Bug: None
Change-Id: Ia92791c401c483d2dff98ca3583f087baa9e4bcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543691
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Auto-Submit: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828264}

Followed process in //third_party/protobuf/README.chromium
Highlights:
* Some protobuf APIs started being deprecated. Moved sources in
//chromecast and //components to start using the non-deprecated
versions.
* Removed most of the patches and updated the ones that are still
needed. No new patches.
* //components/subresource_filter/core/common/unindexed_ruleset.h:
HadError is not const anymore.

Size increase is caused by protobuf mainlining 2
functions to Serialize and Parse inside each *pb.cc file. This new
methods are now the way protobuf serializes and deserializes messages
so no way to avoid those without substantially changing protobuf
internals.

Binary-Size: Unavoidable. Increase intrinsic to new protobuf.
Bug: 1144985
Change-Id: I23ce43f07da82fdda60575934a4b039200164f48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518036
Commit-Queue: Andres Medina <medinaandres@chromium.org>
Auto-Submit: Andres Medina <medinaandres@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828263}

Now that the CPU routines have good default parameter values and
can look up board-specific parameters from cros_config, mark the
duration parameters optional, so the end user doesn't need to know
good values for these durations to effectively use the routines.
Keep exposing the parameters because the routines have long runtimes,
and it would still be useful to be able to configure them for cases
like a CPU problem that only shows up after hours of stress testing.

Also remove the |max_num| parameter from the prime search routine,
because it has a good default value and should never need to be
changed. Note that this value can still be tweaked on a per-device
basis in cros_config if necessary.

Bug: b:173062802
Change-Id: I53e01332606f2efb33e7205a0750536e2058e1ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541574
Commit-Queue: Paul Moy <pmoy@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Oleh Lamzin <lamzin@google.com>
Cr-Commit-Position: refs/heads/master@{#828262}

The previous change
https://chromium-review.googlesource.com/c/chromium/src/+/2528804
updated one of the occurrences of the dubious URL "javascript:42" in
this test class but not the other, and the remaining one is somehow
causing test flakes rather than consistent failures. Change it to match
the other to deflake the test.

Bug: 1149051
Change-Id: I9a813f9272ad1b675d5f51d4a78e4574f7b7beed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542760
Auto-Submit: Richard Coles <torne@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828261}

been successfully processed

Having the prediction manager store use the models that are ready will
be in the next CL.

Bug: 1146151
Change-Id: Iab50e336a0c5853055a0ce4f9ed47bc8fefb5f3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536255Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828260}

This change adds initial draft of IDL for Storage Buckets.
This does not have the full implementation of the API and only
stores bucket names in the renderer. Implementation of the
endpoints will come in following CLs. This CL adds the following.

navigator.storageBuckets
- openOrCreate(name): Stores bucket name if it doesn't exist already
- keys(): Lists stored bucket names in the renderer
- delete(name): Deletes specified bucket name from stored list

Bug: 1107553
Change-Id: I84cd5f877cf5719b2bb74c9b50c75f1ffd604154
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308509Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828259}

As creis@ notes, the CL in
https://chromium-review.googlesource.com/c/chromium/src/+/2534260 fails
to correctly handle the case where an opt-in is attempted in a
BrowsingInstance in a BrowserContext where the same origin previously
did not opt-in, on account of the global walk not being initiated due to
the presence of an opt-in for that origin in another BrowserContext.

This CL splits the opt-in tracking to be per-BrowserContext in order
to avoid that scenario.

Bug: 1148379
Change-Id: I80dd70f2fec80101ba0260812eb8a2a12cd141d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540749Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828258}

Bug: 1149575, 1070922, 1091285
Change-Id: If6118f86e0a7d7333513af52a01fbe8e61d83c12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541924Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828257}

Extend the expiry data of this histograms of splitview.

Bug: 1144814, 1144813, 1144808, 1144807, 1144806
Change-Id: If22e506af928b71834fa6db64123c6d442fe997e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543082Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828256}

https://chromium.googlesource.com/webm/libvpx.git/+log/94384b5c685a..b5d77a48d740

$ git log 94384b5c6..b5d77a48d --date=short --no-merges --format='%ad %ae %s'
2020-11-16 jianj Remove condition on copying svc loopfilter flag
2020-11-11 marpan vp9: Allow for disabling loopfilter per spatial layer
2020-11-05 chengchen Accumulate frame tpl stats and pass through rate control api
2020-10-29 jzern libs.mk: set LC_ALL=C w/egrep invocations
2020-09-20 wtc Add a comment about bitdeptharg and inbitdeptharg
2020-10-27 jzern vp9_ext_ratectrl_test: add missing override
2020-10-27 jianj Add cmd line option to control loopfilter for vpxenc
2020-10-26 angiebird Download bus_352x288_420_f20_b8.yuv properly
2020-10-20 angiebird Small changes of vp9_ext_ratectrl_test.cc
2020-10-16 angiebird Add ref frame info to vpx_rc_encodeframe_info_t
2020-10-12 angiebird Add vpx_rc_status_t
2020-10-15 angiebird Add unit test for vp9_ext_ratectrl

Created with:
  roll-dep src/third_party/libvpx/source/libvpx
R=jzern@google.com

Change-Id: I48637e4f7b9d7c505157125afeb9f4823816c903
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543187Reviewed-by: James Zern <jzern@google.com>
Commit-Queue: Jerome Jiang <jianj@google.com>
Cr-Commit-Position: refs/heads/master@{#828255}

This CL is the fourth part of an effort to port the existing Desktop
feature to Android. This feature enables a user to send an image to
Google to process to generate a descriptive alt text if a website
does not provide one.

Design Doc: go/2020-q1-android-image-descriptions
Slide Deck: go/clank-imageDescriptions
Launch Bug: 1057168

Original Desktop Design Doc for reference:
go/chrome-a11y-annotations-design

This is a conservative approach, we use a separate set of profile
Prefs for this feature rather than syncing with the Desktop Prefs.
This can be updated in time as needed. We have also hidden the
entire feature behind a feature flag, so this CL is not visible
to an average user.

----------

This CL adds the following:

- Enabling image descriptions from dialog
- Enabling image descriptions through settings
- Connection through JNI from Java to native code

----------

AX-Relnotes: Adds feature to enable generating alt image descriptions, currently behind a feature flag.
Bug: 1057169
Change-Id: I6c0a81664f417a2f5ce1c06b9cb3153cc9c0d5d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327176Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Mark Schillaci <mschillaci@google.com>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Mark Schillaci <mschillaci@google.com>
Cr-Commit-Position: refs/heads/master@{#828254}

This CL adds guava_android_target variable to
build/config/android/config.gni in order to enable internal builds to
switch the guava target being used to the internal target.

BUG=1144019

Change-Id: Id93eb3c36256ee786801c7e122e82aefca625f2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544045Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828253}

Since UniqueWidgetPtr closes the native windows of the widgets created
by the capture mode session asynchronously, they end up showing up in
the captured screenshot. This CL fixes this by closing those windows
immediately.

BUG=1149423
TEST=Manually, added a test that fails without the fix.

Change-Id: Idb5e0bcf734173a7577b56f311abd321e1ee85ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543201Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828252}

This is a part of go/cros-bento which aims to improve virtual desks.

Currently when a user creates a new desk, the desk mini view is created
and given a default name. Clearing and focusing on the desk's renaming
textfield will encourage users to actually rename their desks,
increasing the intentionality of their desks.

This CL alters the desk creation flow by clearing and focusing on the
newly created desk's renaming textfield.

Test: manual + modified existing tests
Bug: 1143856
Change-Id: I62bce0251ba6e260c011d29aa7e85dd3d200db4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533364Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828251}

Bug: 1148195, 1149950
Change-Id: I658e01ad6601f7cdf145502918419f2637bda8ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543127Reviewed-by: Charlene Yan <cyan@chromium.org>
Commit-Queue: Connie Wan <connily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828250}

This is a reland of ac21d86a

Original change's description:
> Reland "Deprecate uninstall_metrics."
>
> This is a reland of e15311e1
>
> Original change's description:
> > Deprecate uninstall_metrics.
> >
> > Remove the tracking/persisting of these metrics in prefs. Removed
> > uploading in uninstaller.
> >
> > Bug: 1107516
> > Change-Id: I84499820cea86b5f785949d9274e8b2205714aae
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308133
> > Reviewed-by: Tommy Li <tommycli@chromium.org>
> > Reviewed-by: Nate Fischer <ntfschr@chromium.org>
> > Reviewed-by: Greg Thompson <grt@chromium.org>
> > Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#825461}
>
> Bug: 1107516
> Change-Id: Id7a71c3b8d64dbe9984b2f7f33808207071550f5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528581
> Reviewed-by: Nate Fischer <ntfschr@chromium.org>
> Reviewed-by: Tommy Li <tommycli@chromium.org>
> Reviewed-by: Greg Thompson <grt@chromium.org>
> Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#826222}

Bug: 1107516
Change-Id: Id9371d0221fefe009730528eec967d5cbe87918b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532988
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828249}

This patch changes how we implement 'list-style-type' internally:

1. It's parsed into a CustomIdentValue to support custom counter styles.
   Note that when CSSAtRuleCounterStyle flag is off, we discard values
   that are not predefined counter styles to match the existing
   behavior.

2. The computed value is represented by a new ListStyleTypeData class,
   which contains not only type and string value, but also a tree scope
   references. This allows accessing @counter-style rules defined in
   shadow trees.

3. ComputedStyle::ListStyleType() and ListStyleStringValue() are
   reimplemented on top of the new representation. This ensures that
   all the remaining code acts in the same way as before, and there is
   no behavior change.

Bug: 687225
Change-Id: I110695ff11e2ab4e2378e9290ba57360e5ed1610
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538366Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828248}

This reverts commit f7713274.

Reason for revert: The added browser tests appear to be (flakily) crashing on various builders:

For example https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/95504 with https://chromium-swarm.appspot.com/task?id=4fef1ab263264c10

[1303/1306] StartupBrowserWithWebAppTest.PRE_PRE_LastUsedProfilesWithWebApp (1571 ms)
[ RUN      ] StartupBrowserWithWebAppTest.PRE_LastUsedProfilesWithWebApp
[11419:11462:1117/050706.931735:ERROR:object_proxy.cc(621)] Failed to call method: org.freedesktop.DBus.Properties.Get: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files
[11419:11462:1117/050706.931814:WARNING:property.cc(144)] DaemonVersion: GetAndBlock: failed.
[11419:11462:1117/050706.932083:ERROR:object_proxy.cc(621)] Failed to call method: org.freedesktop.UPower.GetDisplayDevice: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files
[11419:11462:1117/050706.932300:ERROR:object_proxy.cc(621)] Failed to call method: org.freedesktop.UPower.EnumerateDevices: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files
BrowserTestBase received signal: Segmentation fault. Backtrace:
#0 0x558aecd46cd9 base::debug::CollectStackTrace()
#1 0x558aeccb6753 base::debug::StackTrace::StackTrace()
#2 0x558aed26b5f6 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#3 0x7f26cd1224c0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354bf)
#4 0x558ae929f9a0 StartupBrowserWithWebAppTest_PRE_LastUsedProfilesWithWebApp_Test::RunTestOnMainThread()
#5 0x558aed26a407 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#6 0x558aecde10ef ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#7 0x558aecddfed5 ChromeBrowserMainParts::PreMainMessageLoopRun()
#8 0x558aeb16da36 content::BrowserMainLoop::PreMainMessageLoopRun()
#9 0x558aeb5c3b13 content::StartupTaskRunner::RunAllTasksNow()
#10 0x558aeb16ca17 content::BrowserMainLoop::CreateStartupTasks()
#11 0x558aeb16f638 content::BrowserMainRunnerImpl::Initialize()
#12 0x558aeb16af68 content::BrowserMain()
#13 0x558aebc439c3 content::ContentMainRunnerImpl::RunServiceManager()
#14 0x558aebc435b6 content::ContentMainRunnerImpl::Run()
#15 0x558aebc40a64 content::RunContentProcess()
#16 0x558aebc413ec content::ContentMain()
#17 0x558aed269f34 content::BrowserTestBase::SetUp()
#18 0x558aecca3c51 InProcessBrowserTest::SetUp()
#19 0x558aea228198 testing::Test::Run()
#20 0x558aea22902f testing::TestInfo::Run()
#21 0x558aea229a07 testing::TestSuite::Run()
#22 0x558aea237207 testing::internal::UnitTestImpl::RunAllTests()
#23 0x558aea236b6f testing::UnitTest::Run()
#24 0x558aecd97f74 base::TestSuite::Run()
#25 0x558aecc8d252 ChromeTestSuiteRunner::RunTestSuite()
#26 0x558aed299357 content::LaunchTests()
#27 0x558aecc8d522 LaunchChromeTests()
#28 0x558aecc8ac54 main
#29 0x7f26cd10d840 __libc_start_main
#30 0x558ae864e0aa _start
[1304/1306] StartupBrowserWithWebAppTest.PRE_LastUsedProfilesWithWebApp (CRASHED)

Similar crash also on https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/110376 (https://chromium-swarm.appspot.com/task?id=4feff52dc4172910)

Original change's description:
> Fix session restore after launching with PWA.
>
> The underlying issue is that the kProfilesLastActive pref gets
> cleared when Chrome is launched with a specific profile, which
> prevents Chrome from iterating over the last active profiles
> and calling session restore on each of them. This CL stops
> clearing the pref when launched with --app-id, and avoids
> restoring sessions for the last active profiles
> if launched with --app-id. Also, ignore browser opens and
> closes if the browser window is for a web app, in order to prevent
> kProfilesLastActive pref from getting overwritten.
>
> Bug: 1022795
> Change-Id: I350a54eaaf167dabb297b9bda9061fe965f0750e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984710
> Reviewed-by: Greg Thompson <grt@chromium.org>
> Reviewed-by: David Roger <droger@chromium.org>
> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#827876}

TBR=droger@chromium.org,grt@chromium.org,davidbienvenu@chromium.org

Change-Id: Ib48b40d1c39911d9c5b1072fda35703a70be1f5a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1022795
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544744Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828247}

https://chromium.googlesource.com/angle/angle.git/+log/2f5d646c928e..d8e982264ce5

2020-11-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 9d3ef3258715 to 0cb8cc8cfcb2 (4 revisions)
2020-11-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from e4c1a25cc679 to 04515da400d5 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: cnorthrop@google.com
Change-Id: Id8bec0df85348af3cba9fcd152531952d50ce9b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544251Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#828246}

- These methods now return a tuple of FilePath, PathType
- Pre-req for properly handling external path types for ChromeOS

Bug: 1139907
Change-Id: I91638f4957e578f0dbf60b03d1a2c3facc82c034
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542805
Auto-Submit: Austin Sullivan <asully@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828245}

Batch tests to speed up execution. See go/test-batching.

Bug: 1149694
Change-Id: I953d198712ad60ba338344d446a0e4e99a5d9a53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542825
Commit-Queue: Ken Rockot <rockot@google.com>
Auto-Submit: benjamin joyce <bjoyce@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#828244}

This is in preparation of migrating to JS modules.

Bug: 1149868
Change-Id: I98dfdf93b7d8d6e8fc024dc0594a2c871b62cbfc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478900
Auto-Submit: dpapad <dpapad@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828243}

Accidentally let these flags lapse.

Change-Id: I1e60bcb9624e054e0c0e2f8c145887fbe0008c66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542859
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828242}

Use RegistryOverrideManager for those tests that fiddle in HKCU.  Tests
that write to HKLM remain disabled, as they will require additional work
to support parallel execution.

BUG=631208

Change-Id: I83824b0f868261b2ea28af28aec71bea2aa3e6f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544462
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Auto-Submit: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828241}

SecurityOrigin currently returns identical objects when constructed from
KURLs with ports explicitly set to 0 and KURLs with ports equal to their
schemes' defaults. This is inconsistent with the //url implementation
(and the HTML spec!).

This CL makes two changes to ensure that
  AreSameOrigin(KURL("https://a.com:0"), KURL("https://a.com"))
starts returning false.

(1)  It updates SecurityOrigin(KURL) to set the origin's "effective
port" field to the given URL's protocol's default port when the URL's
parsed port is empty.
(2)  It updates SecurityOrigin::IsSameOriginWith to use
SecurityOrigin::effective_port_ for comparison rather than
SecurityOrigin::port_.

(SecurityOrigin::effective_port_ and SecurityOrigin::port_ differ in
that `effective_port_` takes into account empty/default ports, and
`port_` doesn't; prior to this change, `effective_port_` was being
initialized incorrectly to the default port for SecurityOrigins
constructed from URLs with port explicitly set to 0.)

This CL adds serialization behavior for port-0 origins that is incorrect
but matches url::Origin's. Port-0 origins' serializations should include
the port, but they currently don't (crbug.com/1136966). A subsequent
change will implement this fix for both SecurityOrigin and url::Origin.
(Doing one at a time is tricky because some tests check equality of
origins' serializations.)

Test: Adds unit tests covering same-originness and effective_port_.
Change-Id: I5f9b4478d28d2892abb31ea9e12ab7d3bcaa8077
Fixed: 1136678, 1138540, 1100794
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472460
Auto-Submit: David Van Cleve <davidvc@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828240}

Bug: None
Change-Id: Ia17656ca86f5bfd292d9879a3dc46629fd12f0d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507459
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#828239}

This is a new RPC added in crbug.com/1147548 for uploading artifacts
that apply to the whole test invocation, rather than a single test case.

Bug: 1129654
Change-Id: If1ff99a43bd797745795357664aafdcd7b61594a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542767Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: benjamin joyce <bjoyce@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828238}

If an IFC contains an item for an orthogonal writing-mode root,
NGFragmentItems::DirtyLinesFromNeedsLayout() failed to mark it as dirty
because NeedsLayout flag for the item was already cleared in the
ComputeMinMaxSizes() step.

This CL avoids this issue by assuming orthogonal writing-mode roots
dirty regardless of NeedsLayout flag.

Bug: 1125870, 1147357
Change-Id: I603bdd76f9015fbcde46da8e09fb6757b4b0222b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544326Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828237}

*Temporarily* removing characters from GREASEy brand that have been
causing major compat issue. See:
https://github.com/ESAPI/esapi-java-legacy/issues/578

Bug: 1149575, 1070922, 1091285
Change-Id: I727905b13625a8b445056f4ffef59ca46e609336
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541542Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828236}

This CL gives ability to Incognito CCT to show title on toolbar.

For screenshot:
https://drive.google.com/file/d/1WQFhK3yhVsF-OazSSrUh9d8mfpNb1ZeK

Bug: 1104180
Change-Id: I195ba2200d0994bb0aea5f06ce017ec81172e2a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537677
Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org>
Reviewed-by: Rohit Agarwal <roagarwal@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828235}

Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202011170600_RC00.html

https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/FB_bifMNysoEImRPjxxeBSyH7DJ-w_mTig1qaRVVxMgC

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll
Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: help-app@grotations.appspotmail.com
Change-Id: Iede9f1a8ff99611e780405d6528c360b8d63e4fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544252Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#828234}

handles

This change removes generation of the Serialize() method for structs
that contain handles since such handles would not be deserialized
correctly outside of IPC sendind context.

Bug: 1147520
Change-Id: Ia9bfa29075d5610b21089bccc4f27015c83dc05c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538370Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828233}

This CL updates Nearby Connections to use the updated InjectEndpoint()
API from cl/341868361 and cl/341876430. It also updates the
SecureChannel Nearby integration to use this new API correctly.

This CL:
(1) Adds endpoint_id and endpoint_info as a parameters to the
    InjectBluetoothEndpoint() call.
(2) Updates NearbyEndpointFinderImpl to generate a unique endpoint_id
    and endpoint_info to be passed to InjectBluetoothEndpoint(). This
    class also now verifies that the endpoint info received matches the
    one that was passed to the call.
(3) Updates relevant tests.

Fixed: 1148152
Bug: 1106937
Change-Id: I29a8110ed880f0e5e38f7c9320f0e728195eb3e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532904Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828232}