- 02 Nov, 2020 40 commits
-
-
Dave Tapuska authored
This is the browser side change of removing pepper throttling. Since flash is no longer loaded and the throttling code was specific for flash it can be removed. Renderer side was done in https://chromium-review.googlesource.com/c/chromium/src/+/2508289 BUG=1143755,993189 Change-Id: I8eed030decf312ba7e60874428d817ebf7983220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508430 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#823272}
-
Chait Pinnamaneni authored
Rebaselining test PR: https://chromium-review.googlesource.com/c/chromium/src/+/2504690 Original PR: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2403841 Bug: 1137050 Change-Id: I64646db2b2a3980525aeb870dd7655b0a8d29eae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510732Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Chait Pinnamaneni <cpinnamaneni@microsoft.com> Cr-Commit-Position: refs/heads/master@{#823271}
-
Francois Doray authored
This CL adds an histogram which counts "pageloads" by type. The total count of this histogram should be equal to the "Total pageloads" on the stability dashboard, and can be used to diagnose changes to this value. In particular, it will be used to diagnose changes to "pageloads" with the "intensive wake up throttling" experiment. Context: https://groups.google.com/a/google.com/g/chrome-catan/c/3OafGFoj8Qc Bug: 1075553 Change-Id: Ib238b73e42b0d460f36b055808b425c5eebf9341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507515 Commit-Queue: François Doray <fdoray@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#823270}
-
Stephen Chenney authored
If there is a selection style but no text-decoration in it, and text decoration in another pseudo style that applies, then it is possible for the style to have text decorations but not the pseudo selection style. Avoid crashing in this case. Also improve selection decoration color by using just the color from the selection style if available. Bug: 1144134 Change-Id: Id09fbaeafcc7bdf187abcf6be5d542004e61a16c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513825Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#823269}
-
Michael Thiessen authored
These tests "started" the same Activity instance multiple times, unnecessarily. Bug: 1144769 Change-Id: If64cbd0638a62273e98b6502112c6e7dbbba0de9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514742 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#823268}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/142cb87f803d..ed8bd0453f73 2020-11-02 jaebaek@google.com Do not use PropagateLineInfoPass and RedundantLineInfoElimPass (#2440) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: I31a7b924290fc5579bf3fcbb903f6fe7683bfd4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513802Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823267}
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 88-4296.0-1603705354-benchmark-88.0.4307.0-r1 to 88-4296.0-1604316477-benchmark-88.0.4312.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I420b57b0ba773c8b83f9378e4f1f7fc1382cc3e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514703Reviewed-by:
-
kylechar authored
The test suite is failing on Win10 FYI x86 Release (NVIDIA) bot since it landed. Add rule to stop it from running there. Bug: 1144751 Change-Id: I69fac186a3eacb8dcd262ba88a0d3e29d927908f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512290 Commit-Queue: kylechar <kylechar@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#823265}
-
Xiaoqian Dai authored
Bug: 1142940 Change-Id: I79d58fcd6ac037b2fec36e33402e45943a644f4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508150 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#823264}
-
Dominique Fauteux-Chapleau authored
This also update tests to switch to ContentAnalysisResponse. Bug: 1103390 Change-Id: I1d4861706efa3750b16b828f49bdc74c4ed359af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510414Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#823263}
-
Friedrich Horschig authored
With https://crrev.com/c/2260639, the paddings weren't distributed evenly anymore (start/end padding) causing misalignments. Additionally, the non-square icon dimensions caused rounding errors increasing that effect. This CL ensures consistent paddings for RTL and LTR mode. Screenshots are in the linked bug. Bug: 1144629 Change-Id: Ied4af63de6d94abb2b6510cfd061a970f8f98da8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513600Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#823262}
-
Rayan Kanso authored
Bug: 1138316, 1138317 Change-Id: Ib2ce5f4114643e3e463f413bd01cd0934d00c3ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512897 Auto-Submit: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#823261}
-
Mason Freed authored
TBR=chasej@chromium.org Bug: 937746 Change-Id: I002fc4bd42feb6e41dea6b8eefebc6f460f223f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514658Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#823260}
-
Alexandre St-Onge authored
Bug: 662752 Change-Id: I9524e40e3645f11841de4805980d905a5ac25143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500762Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Alex St-Onge <alstonge@chromium.org> Cr-Commit-Position: refs/heads/master@{#823259}
-
rajendrant authored
Change-Id: Ifc8c20506e46c1be957bf551325d4bb4fd63678b Fixed: 1142526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514069 Commit-Queue: Robert Ogden <robertogden@chromium.org> Auto-Submit: rajendrant <rajendrant@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#823258}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/98b928fcfad7..dffd20efe95c 2020-11-02 kjlubick@google.com [canvaskit] Add unit tests to wasm_gm_tests 2020-11-02 csmartdalton@google.com Fix Wang's formula for cubics 2020-11-02 johnstiles@google.com Revert "heif: Add AVIF type and AVIF sniffing" 2020-11-02 vigneshv@google.com heif: Add AVIF type and AVIF sniffing 2020-11-02 johnstiles@google.com Split Texture test into separate 1D and 2D tests. 2020-11-02 robertphillips@google.com Add callback to thread-safe cache to resolve vertexData collisions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408 Tbr: bsalomon@google.com Change-Id: Ifd340bf5099bdfaf3a22a6bf1f95044e238ded68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513799Reviewed-by:
-
Titouan Rigoudy authored
This retires ERR_INSECURE_PRIVATE_NETWORK_REQUEST in favor of the same scheme used by regular (non-RFC1918) CORS errors: ERR_FAILED along with a CorsErrorStatus to further explain the error. Fixed: chromium:1141851 Change-Id: Ie8356b63e5139c2bc0352f0e98dc17f90f287238 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503510 Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Cr-Commit-Position: refs/heads/master@{#823256}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1c4431bb. With Chromium commits locally applied on WPT: 82e2bc96 "Support complex selectors in :not()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: Idf8bcd3e794ac07054e03cb8d74cf38cd3a62718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512603Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823255}
-
Sylvain Defresne authored
Add "arm64" architecture to simulator version of the clang runtime library to support `-target arm64-apple-ios*-simulator` (for Apple Silicon cpu mac). Bug: 1138425 Change-Id: I1f2cf794db72e9413090788ad75906837f38a983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490564 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#823254}
-
Olga Gerchikov authored
CL [1] introduced performance regressions in number of benchmarks. The regression is caused by the fact of querying the value of kWheelEventRegions flag. This CL optimizes the querying. Most of the regressions partially or fully reverted. [1]https://chromium-review.googlesource.com/c/chromium/src/+/2419718 Bug: 1140321 Change-Id: Ib0cd7cfbafa0603579459e36853f993d2133a969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490327Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Sam Fortiner <samfort@microsoft.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com> Cr-Commit-Position: refs/heads/master@{#823253}
-
henrika authored
Contains additional changes and improvements proposed after landing by robliao@. Bug: 1133643 Change-Id: Ib05e3878b70fc10fa5255645d4551639e2c96587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514423 Commit-Queue: Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#823252}
-
Michael Bai authored
Previously ContentCaptureConsumer had no way to know the the frame shows again because the visible content didn't change. This patch resets the task session when the frame was hidden, so ContentCapture task will stream on-screen content because they aren't streamed from the task point of view when the frame was shown. Adds the test to coverage this scenario. Bug: 1137463 Change-Id: I0065ce080101d2149622b0f9f6a3aa196c18d717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511030Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Michael Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#823251}
-
Michael Checo authored
Screenshots: Expanded: http://shortn/_ozPsFShPLu Closed: http://shortn/_810zjzDQgC Bug: 1059779 Test: browser_tests --gtest_filter=ScanningAppBrowserTest.All Change-Id: Ia9ad13ae2e8baf09e4c0a42fb9bc2b2a9942e297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506392 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#823250}
-
Andrey Kosyakov authored
- check inner URL for nested URLs; - check actual RFH of RenderFrameDevToolsAgentHost; Bug: 1125362 Change-Id: I6d593d45d749b2a34d7711a983e2bda730027117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506354Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#823249}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/7751fe38f474..b0e426fcf955 2020-11-02 amaiorano@google.com Subzero: fix Ice::BitVector::grow not copying old to new data If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I14804ca4b935fab7ec5457acf1b5a754f72f07eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513795Reviewed-by:
-
Mohamed Heikal authored
image_editor is a downstream only module. Remove references to clank and move it downstream.Also migrate ImageEditorModuleProvider downstream and access using Apphooks. Followup downstream cl crrev.com/i/3370803 Bug: 1142775 Change-Id: I82f9748ddef8e3ada99d6394cb8410a84fc741c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508332Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#823247}
-
John Lee authored
Previously, CrMenuSelector relied on :focus-visible to determine if focus was moved into it using a keyboard. This isn't a reliable way because users can turn on an accessibility mode that forces :focus-visible pseudoclasses on elements regardless of mouse or keyboard input. Bug: 1143200 Change-Id: I9b12138546ec4eaf31296147b808ad1a9f2faa4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505680Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#823246}
-
Lily Chen authored
This adds two new columns, source_port and is_same_party, to the schema for the SQLitePersistentCookieStore. These are not yet hooked up to anything. The default values are -1 and false, respectively. Bug: 1142606, 1141135 Change-Id: Id2774272b62c8070a5a2eab5a765937f124a764a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505468Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#823245}
-
Jacobo Aragunde Pérez authored
The accounts & sync dialog UI is a better fit for the menu accessible role instead of a dialog, because it contains a list of actionable buttons instead of a message and a few buttons. What's more, it is already built using a menu container. For the dialog to behave like a menu, we need to override the top-level dialog to become a menu bar, and emit the corresponding events for open and close to make it discoverable. Bug: 1098304 Change-Id: I93bb25dc9b790e1f8d0e2c61993d20f191c439c0 AX-relnotes: announce accounts & sync as a menu when opened. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494933 Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#823244}
-
Trent Begin authored
This adds the existing network-diagnostics cr_component into the connectivity diagnostics app and pipes in the necessary dependencies from chrome. Bug: chromium:1140611 Change-Id: I7fa82ab611be6da4a7b93031e2c9ffa4efbd3925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490981 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#823243}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7411aeba4d3b..4cd11945c5a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I40dd6cdaf7c30d0c4ec07ea81abd78811ff8fe98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514078Reviewed-by:
-
Chunlei Niu authored
Change-Id: I29ad465db87724e9731d19aaac246afb5af8b7bd Bug: b/161484971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311065 Commit-Queue: Chunlei Niu <niuchl@google.com> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Auto-Submit: Chunlei Niu <niuchl@google.com> Cr-Commit-Position: refs/heads/master@{#823241}
-
Joe Downing authored
I am working on some ETW stuff for Chrome Remote Desktop and I noticed that this parameter is unused and a default value of 16KB is always used. This isn't a big deal as the only caller appears to be its unit tests but it seemed like the value passed in should do something. The other approach would be to remove the param but adjusting the buffer size seems like a reasonable thing to expose (assuming the param is actually used). Change-Id: I453ac2417d68f6c16fecd517cf1cd74c5aa15731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511290 Commit-Queue: Joe Downing <joedow@google.com> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#823240}
-
Gang Wu authored
This metric is added to record that users come back to app menu and select a similar menu item in short period (10 seconds) of time. Bug: 1143780 Change-Id: I5f5522e4b77103d324b6ebe02a2f832d43d81a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508351 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#823239}
-
John Lee authored
This is a temporary solution to prevent crashes that occur from when a tab's context menu is opened from a tab that is no longer in the tab strip. The tab should be visible in another window's tab strip already. Bug: 1141573 Change-Id: I211bf3e3c31b20d61fd924f74471a40c26f5aa45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511332 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
-
Peter Boström authored
Removes use of GridLayout to agree on column width for textfields. This is replaced by linking textfield views together to make them agree on a shared width. This is a prerequisite for dynamically adding/removing items to DialogModel as GridLayout does not support inserting/removing rows. Remaining GridLayout dependencies are that the dynamic row spacing is set up using padding rows. Bug: 1106422 Change-Id: I76a3823c12dab20aa047e263e27dfbda53003b24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508158Reviewed-by:
Keren Zhu <kerenzhu@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#823237}
-
Lijin Shen authored
Add an observer to notify mediator that message is ready to be shown when browser controls are fully visibly. Bug: 1123947 Change-Id: I46396310824a3b10cfafdabcffcc56b6a3104295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507401Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
Tommy Li authored
This reverts commit f38ba55f. Reason for revert: Caused a bot breakage here: https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-lacros-dbg/2115? Original change's description: > Roll ANGLE from ed916ddf61cc to f34ba6464f31 (7 revisions) > > https://chromium.googlesource.com/angle/angle.git/+log/ed916ddf61cc..f34ba6464f31 > > 2020-11-02 amy.liu@arm.com Fix maxShaderAtomicCounters value. > 2020-11-02 xiaoxuan.liu@arm.com Add support for Linux vulkan backend with VK_KHR_display > 2020-11-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 34ae8a475754 to f7da52775714 (8 revisions) > 2020-11-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from f673b4e6ebf3 to e46399ddd2c7 (11 revisions) > 2020-11-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 740ae9f60b00 to 142cb87f803d (1 revision) > 2020-11-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from e6c9497255c6 to 7751fe38f474 (3 revisions) > 2020-11-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Headers from 320af06cbdd2 to 87451c55aa8b (1 revision) > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/angle-chromium-autoroll > Please CC courtneygo@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 > Bug: None > Tbr: courtneygo@google.com > Test: Test: dEQP-GLES31.functional.shaders.opaque_type_indexing.atomic_counter.*vertex > Change-Id: Ie1e5d3152a5f2fed7abf91fdd6a42c536c42dfab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513791 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#823214} TBR=courtneygo@google.com,chromium-autoroll@skia-public.iam.gserviceaccount.com Change-Id: Iae15ab51252d8bcefff8c0544feba22327ac50d3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514668Reviewed-by:
-
David Maunder authored
In the code as is, there exists the possibility mModel will change before the callback returns which would mean the price is set on an incorrect or out of bounds index. In addition, it better from a resource utilization perspective to only acquire the price when it is actually needed. Bug: 1139031 Change-Id: I2f46851745b70bf6ddfceb33a09c5ef5700b2880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476811Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#823234}
-
Avi Drissman authored
It's been fully launched. Fixed: 1084222 Change-Id: I2f0ede68468e1abac295f902fa64962fba15bc8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514498 Commit-Queue: Avi Drissman <avi@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#823233}
-
