GitLab

set the expected errors accordingly with touch build

BUG=
TEST=AssertionTest.* & CheckFalseTest.* pass on touch build


Review URL: http://codereview.chromium.org/7053019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86693 0039d316-1c4b-4281-b951-d872f2087c98

The changes for the codereview.chromium.org/6992047 include some added binary
test files, which don't work with try jobs. I'm submitting them in this
separate CL in order to be able to run try jobs.

BUG=none
TEST=none

TBR=mpcomplete@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86692 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=sky

Review URL: http://codereview.chromium.org/6992079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86691 0039d316-1c4b-4281-b951-d872f2087c98

BUG=81741,83836
TEST=Memory bots go green
Review URL: http://codereview.chromium.org/7053004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86690 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=out/Debug/base_unittests --gtest_filter=BreakIteratorTest.*

R=tsepez@chromium.org,evan@chromium.org

Review URL: http://codereview.chromium.org/7008005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86689 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=sky

Review URL: http://codereview.chromium.org/7008015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86688 0039d316-1c4b-4281-b951-d872f2087c98

Had to move from content/gpu to content/common/gpu to allow gpu_video_service.cc
to depend on the decoder.
Removed some dead code and did some random cleanup while I was in there.

BUG=none
TEST=chrome compiles on cros/arm!

Review URL: http://codereview.chromium.org/7057027

TBR=fischman@chromium.org
Review URL: http://codereview.chromium.org/6979017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86687 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=sky

Review URL: http://codereview.chromium.org/6987030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86686 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=can connect w/o ClientLogin token.

Review URL: http://codereview.chromium.org/7008003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86685 0039d316-1c4b-4281-b951-d872f2087c98

ExtensionApiTest.Notifications: wait until part 1 finishes cleanup before going to part 2.  Fixes flake.

Without change: 18 failures out of 250 runs on my machine.  3 out of 250 on Linux try bot.

With change: 0 failures out of 250 runs on my machine.  0 out of 250 on Linux try bot.

TEST=Run ExtensionApiTest.Notifications many times.
BUG=42314


Review URL: http://codereview.chromium.org/7064038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86682 0039d316-1c4b-4281-b951-d872f2087c98

Had to move from content/gpu to content/common/gpu to allow gpu_video_service.cc
to depend on the decoder.
Removed some dead code and did some random cleanup while I was in there.

BUG=none
TEST=chrome compiles on cros/arm!

Review URL: http://codereview.chromium.org/7057027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86681 0039d316-1c4b-4281-b951-d872f2087c98

BUG=76697
Review URL: http://codereview.chromium.org/7066039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86679 0039d316-1c4b-4281-b951-d872f2087c98

- added ViewsDelegate::GetDispositionForEvent() pure virtual
- added MenuModelAdapter
- added unit test for MenuModelAdapter
- added comment for MenuModel::GetFirstItemIndex() that callers may pass NULL for NativeMenu argument
- fixed index offset bug in MenuModel::GetModelAndIndexForCommandId()
- fixed spurious call to MenuDelegate::IsCommandEnabled()

BUG=none
TEST=included


Review URL: http://codereview.chromium.org/7067032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86677 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83761
TEST=Print preview always work on Mac

Review URL: http://codereview.chromium.org/7031044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86676 0039d316-1c4b-4281-b951-d872f2087c98

with CHECK_EQ, so on failure, value will appear in minidumps.

BUG=69198
TEST=none

Review URL: http://codereview.chromium.org/7031054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86675 0039d316-1c4b-4281-b951-d872f2087c98

BUG=no
TEST=no

Review URL: http://codereview.chromium.org/7067024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86674 0039d316-1c4b-4281-b951-d872f2087c98

Add web_ui_util::ChromeURLHostEquals and update some checks.
RIP kChromeUIAppLauncherURL (arv:r46266 - tfarina:r62866).
RIP kDefaultOptionsSubPage (zelidrag:r56816 - estade:r76329/r76490).
Remove unnecessary stdlib.h include and some extra spaces.

BUG=55771
TEST=None

Review URL: http://codereview.chromium.org/7049004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86673 0039d316-1c4b-4281-b951-d872f2087c98

This should fix some crashes that end up calling the event filter of a
destroyed message pump.

BUG=none
TEST=some randomly failing unit tests (e.g.  SessionServiceTest.GetCurrentSession)

Review URL: http://codereview.chromium.org/7031057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86672 0039d316-1c4b-4281-b951-d872f2087c98

Also added a comment. This string should only be passed in for
WebGL. If it is being passed in for any other reason it is a bug
and needs to be fixed.

TEST=none
BUG=none

R=jamesr@chromium.org

Review URL: http://codereview.chromium.org/7067034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86671 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83537
TEST=In compact nav mode, ensure that clicking an active (foreground) tab shows the compact location bar with the text selected.
Review URL: http://codereview.chromium.org/6992034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86670 0039d316-1c4b-4281-b951-d872f2087c98

BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/7031053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86669 0039d316-1c4b-4281-b951-d872f2087c98

Please not that a couple of clean-ups will follow this. Consider this really stable once bug 60099 is labeled as fixed.

BUG=60099
TEST=no

Review URL: http://codereview.chromium.org/6992022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86668 0039d316-1c4b-4281-b951-d872f2087c98

BUG=82590,77090
TEST=Prerender*

Review URL: http://codereview.chromium.org/6966017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86667 0039d316-1c4b-4281-b951-d872f2087c98

BUG=60099
TEST=no

Review URL: http://codereview.chromium.org/6990054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86666 0039d316-1c4b-4281-b951-d872f2087c98

Fix crash when creating a desktop shortcut for apps with missing icons (use the default app icon instead).

BUG=79282
TEST=See bug.


Review URL: http://codereview.chromium.org/7065037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86665 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/6992067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86664 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83904
TEST=none


Review URL: http://codereview.chromium.org/7069016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86663 0039d316-1c4b-4281-b951-d872f2087c98

Skia on Mac uses Skia to render WebKit, and CG
to render UI elements. The CG elements need a
transcribed graphics context that preserves the
canvas matrix, and the canvas clip.

The SkiaBitLocker utility class sets up a CGContext
from the SkCanvas, locks the bitmap's bits, and
releases the lock when the class goes out of scope.

The SkiaBitLocker implementation is described by
this patch:
http://codereview.chromium.org/7031006/

For ppapi, use the CG bitmap copy only if Skia
is not used.

Otherwise, adjust the Mac-specific code to convert
the canvas to a CGContext as needed.

Also, add a CG-specific entry point for painting
so that the delegate can paint using a WebCanvas,
while the proxy paints with a CGContext.

This change adds a code path that will be enabled
in the future, but does not modify any
existing code, so there is no functional change.

BUG=79463
TEST=none

Review URL: http://codereview.chromium.org/6823081

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86662 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83667
TEST=see bug

Review URL: http://codereview.chromium.org/7065046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86661 0039d316-1c4b-4281-b951-d872f2087c98

Print Preview: Add some debug logging so one can time when print preview operations starts/finishes.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6979005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86660 0039d316-1c4b-4281-b951-d872f2087c98

This patch covers integrating the the WebUI based login with cros, so that when --dom-login is passed in on boot the WebUI login screen is used, keyboard comes up and the user can login.

I have refactored the WebUI login code to not use a subclass of the Browser class. I have removed the unneeded DOMBrowser* classes. This work was based off a combination of the BackgroundView and the TouchBrowserFrameView. If there is comments or variable names that betray this please let me know. I have endevoured to update the comments, but significant portions of code were pulled in.

Since both of the TouchBrowserFrameView and WebUILoginView have common code for having a a touch keyboard there is some refactoring to be done that will remove duplicated code between the two. This will be dealt with in a follow on CL.

The animation of the keyboard has not been included in this CL, mostly because I was having issues getting it to correctly size and this CL is pretty large already. This will be resolved in a follow on CL.

I am also converting from the use of DOM to WebUI at the moment, so some of the new code uses WebUI instead of DOM. I will be uploading a follow on CL that finishes this conversion.

This CL depends on http://gerrit.chromium.org/gerrit/706 and http://gerrit.chromium.org/gerrit/759 landing before it to work correctly.

It also depends on http://codereview.chromium.org/7014021/ to build.

Patch from Ryan Harrison <rharrison@chromium.org>

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/6973029
Patch from Ryan Harrison <rharrison@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86659 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:15368
TEST=Click on 'Show All Download' link in download panel or any downloaded file. Instead of multiple windows, the same window should get selected and become active.
Review URL: http://codereview.chromium.org/6969057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86658 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83908
TEST=none


Review URL: http://codereview.chromium.org/7031056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86657 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:14964
TEST=Ctrl-o, Ctrl-r, Ctrl-b and ctrl-s should no longer work. ctrl-n, ctrl-w will continue to work.
Review URL: http://codereview.chromium.org/6990067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86656 0039d316-1c4b-4281-b951-d872f2087c98

Fixup order of elements in the ScriptableObject interface header. It's supposed to match the .CC file but had gotten seriously out of sync.

BUG=none
TEST=manual


Review URL: http://codereview.chromium.org/7065036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86655 0039d316-1c4b-4281-b951-d872f2087c98

if it doesn't find the requested key in the "Private" NSS database.

This fixes the ownership process because the ownership key is created
in the public database because that needs to happen before the TPM is
owned and available (and it's not really all that sensitive to begin
with).

BUG=chromium-os:15645
TEST=Built a new recovery image, wiped a device with it and verified
that I was able to sign in as a new user and add users and forget
networks.  It also showed me as the owner of the device.

Review URL: http://codereview.chromium.org/7066032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86654 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83899
TEST=none


Review URL: http://codereview.chromium.org/7031055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86653 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83891
TEST=none


Review URL: http://codereview.chromium.org/6987021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86652 0039d316-1c4b-4281-b951-d872f2087c98

BUG=82590
TEST=Use instant to navigate to a page that is currently being prerendered. Observe it does not crash.


Review URL: http://codereview.chromium.org/7034043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86651 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST='Private networks' option should always show up in ChromeOS Networks menu.

Review URL: http://codereview.chromium.org/7031040

TBR=stevenjb@google.com
Review URL: http://codereview.chromium.org/7053015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86650 0039d316-1c4b-4281-b951-d872f2087c98