GitLab

DatabaseManager holds DatabaseContext references instead.

- We need to move DatabaseManager::registerDatabaseContext call from the
  constructor to the factory because registerDatabaseContext now increments the
  reference counter of a DatabaseContext and we can't update the reference
  counter in the constructor.

- We move DatabaseManager::unregisterDatabaseContext call from stopDatabases to
  contextDestroyed in order to match to deref() in the old code.

- We don't need m_isRegistered any longer because contextDestroyed is called
  just once. stopDatabases can be called twice.

- We need to move ~DatabaseManager implementation to DatabaseManager.cpp because
  we add RefPtr<DatabaseContext> in a member of DatabaseManager and
  ~DatabaseManager needs a complete definition of DatabaseContext.

BUG=347902

Review URL: https://codereview.chromium.org/212133002

git-svn-id: svn://svn.chromium.org/blink/trunk@170027 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=ager

Review URL: https://codereview.chromium.org/212243002

git-svn-id: svn://svn.chromium.org/blink/trunk@170026 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch is in continuation of <https://codereview.chromium.org/210363006>.
While the last patch added an overloaded TextIterator constructor, this patch
adds similar overloads to findPlainText(), which will be used in the find-in-
page implementation in WebFrameImpl.

The added function is not used yet. Hence this patch should have no impact on
the product behavior.

BUG=353430

Review URL: https://codereview.chromium.org/203973005

git-svn-id: svn://svn.chromium.org/blink/trunk@170025 bbb929c8-8fbe-4397-9dbb-9b2b20218538

(still needs a lot of work)

Review URL: https://codereview.chromium.org/207553010

git-svn-id: svn://svn.chromium.org/blink/trunk@170024 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Omitting "int" when using "unsigned" modifier as per Blink Coding Style Guidelines.

BUG=NONE

Review URL: https://codereview.chromium.org/207783002

git-svn-id: svn://svn.chromium.org/blink/trunk@170023 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Persistent handles in on-heap objects are not allowed (because it's likely to cause memory leaks). This CL removes them from the Event hierarchy, which was moved to oilpan's heap in r169941.

BUG=340522

Review URL: https://codereview.chromium.org/208743011

git-svn-id: svn://svn.chromium.org/blink/trunk@170022 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Implements backface-visibility as defined in CSS Transforms[1]. Behavior is
identical to -webkit-backface-visibility.

Note, this property is guarded by the CSSTransformsUnprefixed runtime feature
(enabled only for testing).

[1] http://www.w3.org/TR/css3-transforms/

BUG=154772

Review URL: https://codereview.chromium.org/211213002

git-svn-id: svn://svn.chromium.org/blink/trunk@170021 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a preparation to move DatabaseContext to Oilpan heap.

We don't need to use RefPtr/PassRefPtr of DatabaseContext for function arguments
and function return value. They don't move ownership of DatabaseContext. They
might be meaningful if we didn't have self->ref() in DatabaseContext::create.

Also, this CL simplifies DatabaseContext::backend, and makes
DatabaseManager::databaseContextFor private.

BUG=347902
TEST=none; no behavior changes.

Review URL: https://codereview.chromium.org/209043008

git-svn-id: svn://svn.chromium.org/blink/trunk@170020 bbb929c8-8fbe-4397-9dbb-9b2b20218538

 * importKey-badParameters.html
 * importKey-normalize-usages.html

The reason for deleting the successful key import tests, is that there are much more exhaustive key import tests as part of the clone-* layout tests (which import a large combination of keys in order to serialize them).

Lastly this change fixes a typo in an error message "HmacImporParams" --> "HmacImportParams".

BUG=245025

Review URL: https://codereview.chromium.org/211933003

git-svn-id: svn://svn.chromium.org/blink/trunk@170019 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=307614,288072
NOTRY=true

Review URL: https://codereview.chromium.org/211933008

git-svn-id: svn://svn.chromium.org/blink/trunk@170018 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This was added in WebKit r87692 in order to fix "Scrubbing a Vimeo movie
when in fullscreen stops playback; no way to make it start again":
https://bugs.webkit.org/show_bug.cgi?id=61717

The commit message and bug comments makes it clear that this special
case is no longer needed:

 1. The media controls fullscreen button now uses largely the same code
    path as Element::webkitRequestFullscreen. "Video-only full screen is
    a mode where we use the shadow DOM as an implementation detail that
    should not be detectable by the web content" is no longer true at
    all, since Web content can observe the events fired, etc.

 2. Scrubbing no longer uses HTMLMediaElement::setPausedInternal(),
    which looks like the cause of "no way to make it start again".

BUG=none
TEST=None originally added with the code, but existing tests pass.

Review URL: https://codereview.chromium.org/210763004

git-svn-id: svn://svn.chromium.org/blink/trunk@170017 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The :host-context() functional pseudo-class tests whether there is an ancestor, outside the shadow tree,
which matches a particular selector. Its syntax is:

   :host-context( <compound-selector> )

Spec link: http://drafts.csswg.org/css-scoping/#host-selector

BUG=354287
TEST=no new tests because just renaming.

Review URL: https://codereview.chromium.org/210813003

git-svn-id: svn://svn.chromium.org/blink/trunk@170016 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL removes use of {,un}setPendingActivity from AudioContext. They were used to make the wrappers alive until Document is destroyed. This CL replaces the hack with a |hasPendingActivity()| impl.

Also, this removes ASSERT(m_isStopScheduled) from d-tor. This is never set when OfflineAudioContext::create() fails after creating an instance.

TEST=media/
BUG=354845

Review URL: https://codereview.chromium.org/208493002

git-svn-id: svn://svn.chromium.org/blink/trunk@170015 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=340522
NOTRY=true

Review URL: https://codereview.chromium.org/211623006

git-svn-id: svn://svn.chromium.org/blink/trunk@170014 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Implements transform-style as defined in CSS Transforms[1]. Behavior is
identical to -webkit-transform-style.

Note, this property is guarded by the CSSTransformsUnprefixed runtime feature
(enabled only for testing).

[1] http://www.w3.org/TR/css3-transforms/

BUG=154772

Review URL: https://codereview.chromium.org/211123002

git-svn-id: svn://svn.chromium.org/blink/trunk@170013 bbb929c8-8fbe-4397-9dbb-9b2b20218538

updateStyle was doing too many things, this patch moves the style updating
logic out into a new function called updateStyle and renames the original
one to updateRenderTree. It also renames all the other updateStyle related
things to be named with "updateRenderTree".

Review URL: https://codereview.chromium.org/211773002

git-svn-id: svn://svn.chromium.org/blink/trunk@170012 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Often in traces it's hard to know what events are being hanled and how
much time is spent where in the EventDispatcher and EventHandler. This
patch adds a bunch of new TRACE_EVENT's to make it easier.

Review URL: https://codereview.chromium.org/210823007

git-svn-id: svn://svn.chromium.org/blink/trunk@170011 bbb929c8-8fbe-4397-9dbb-9b2b20218538

After r169941, the SVG leak tests reports failures, but delta is <0, so number of live nodes is not increasing. This CL loosen the check.

Also removes FIXME comments in the tests.

BUG=340522
NOTRY=true

Review URL: https://codereview.chromium.org/211933007

git-svn-id: svn://svn.chromium.org/blink/trunk@170010 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch also cleans up CSSSelector so that it doesn't use ShadowDOM flag.
Runtime ShadowDOM flag was already set to true at r169201. This change shouldn't have any effects.

BUG=336121

Review URL: https://codereview.chromium.org/210763002

git-svn-id: svn://svn.chromium.org/blink/trunk@170009 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It's time to remove. We've shipped unprefixed APIs for these APIs.

BUG=336121

Review URL: https://codereview.chromium.org/208503004

git-svn-id: svn://svn.chromium.org/blink/trunk@170008 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This indirection doesn't help and just introduces unnecessary complexity.

BUG=356257
TEST=none
R=dominicc@chromium.org,dglazkov@chromium.org

Review URL: https://codereview.chromium.org/211663002

git-svn-id: svn://svn.chromium.org/blink/trunk@170006 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Adds a runtime flag (enabled only for testing) and defines property names
for each property defined in CSS Transforms[1]. Future patches will make
these properties functional.

[1] http://www.w3.org/TR/css3-transforms/

NOTRY=true
BUG=154772

Review URL: https://codereview.chromium.org/211033002

git-svn-id: svn://svn.chromium.org/blink/trunk@170005 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It broke a bunch of tests in oilpan bots:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Oilpan/builds/2500

> Oilpan: Move CSSAnimations and CSSAnimationUpdate to oilpan's heap
> 
> BUG=341032
> 
> Review URL: https://codereview.chromium.org/211113002

TBR=haraken@chromium.org

Review URL: https://codereview.chromium.org/199663007

git-svn-id: svn://svn.chromium.org/blink/trunk@170004 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch fixes a crash caused by stale LoadMediaResource flag in
m_pendingActionFlags when load() is explicitly called on a media
element. The insertion of a <track> element triggers the crash by
triggering the scheduling of the m_loadTimer, which ends up using the
stale flag data when the timer fires. The fix is to clear the
LoadMediaResource flag from m_pendingActionFlags when a new load is
initiated.

BUG=356352
TEST=LayoutTests/media/track/track-insert-after-load-crash.html

Review URL: https://codereview.chromium.org/211373009

git-svn-id: svn://svn.chromium.org/blink/trunk@170003 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This refactoring patch is a step towards fixing a bug in the find-in-page
functionality. To fix the issue, we need a way to pass a document range
which may span multiple TreeScopes to findPlainText() (and eventually
TextIterator). Currently it takes a Range, which does not support this kind
of document ranges.

This patch introduces an overloaded constructor of TextIterator taking
two Positions instead of a Range. The core routine of the old constructor
is moved to a private member function so that it can be shared with
different constructors.

This patch also moves some obvious initialization of member variables in
the constructor body to the initializer list.

No behavior change expected.

BUG=353430

Review URL: https://codereview.chromium.org/210363006

git-svn-id: svn://svn.chromium.org/blink/trunk@170002 bbb929c8-8fbe-4397-9dbb-9b2b20218538

They should be GarbageCollectedFinalized because ChangeVersionWrapper has an
OwnPtr member.

BUG=347902

Review URL: https://codereview.chromium.org/211933005

git-svn-id: svn://svn.chromium.org/blink/trunk@170001 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=348033
R=arv@chromium.org, ch.dumez@samsung.com

Review URL: https://codereview.chromium.org/205243013

git-svn-id: svn://svn.chromium.org/blink/trunk@170000 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This method is no longer being called, and can be removed.

BUG=250049
TEST=encrypted media layout and browser tests pass

Review URL: https://codereview.chromium.org/197333006

git-svn-id: svn://svn.chromium.org/blink/trunk@169999 bbb929c8-8fbe-4397-9dbb-9b2b20218538

EventInterfaces.in should depend on event IDL files.
It currently doesn't, which means it fails to rebuild correctly.
This fixes it.

TBR=haraken
BUG=341748

Review URL: https://codereview.chromium.org/209723002

git-svn-id: svn://svn.chromium.org/blink/trunk@169998 bbb929c8-8fbe-4397-9dbb-9b2b20218538

All page-level state changes now go through updatePageInfo, which marks blocks
as needing layout if their multipliers might need updating.

This simplifies the flow and ensures the page updates correctly on orientation
changes and movements of the text scaling slider in accessibility settings.

BUG=353309,347384

Review URL: https://codereview.chromium.org/209353003

git-svn-id: svn://svn.chromium.org/blink/trunk@169997 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Web SQL Database is an obsolete specification.
We already count Web SQL Database usage in the DOMWindow context.

BUG=

Review URL: https://codereview.chromium.org/207823004

git-svn-id: svn://svn.chromium.org/blink/trunk@169996 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=278596

Review URL: https://codereview.chromium.org/208743007

git-svn-id: svn://svn.chromium.org/blink/trunk@169995 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This feature makes the insertedInto tree walk much more complicated and
is the source of security bugs. We've had it disabled behind a flag for a
while now and not seen complaints or bugs from users.

BUG=333318

Review URL: https://codereview.chromium.org/205523003

git-svn-id: svn://svn.chromium.org/blink/trunk@169994 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There's no evidence that this fast path actually matters, the only difference 
seems to be the number of if and switch statements. If it does we should look 
into how we can make the regular SelectorChecker faster instead of having two modes.

Review URL: https://codereview.chromium.org/208423010

git-svn-id: svn://svn.chromium.org/blink/trunk@169993 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL moves the compositorDrivenAcceleratedScrollingEnabled check out of
scrollParent so that it's clearer in the callers that this code only does
something when this setting is enabled.

In compositorDrivenAcceleratedScrollingEnabled, this lets us call
compositorDrivenAcceleratedScrollingEnabled once instead of twice, which is
faster. In a future CL, I'll cache compositorDrivenAcceleratedScrollingEnabled
as a compositing trigger, which will make this code actually go fast.

This CL also reorders a bunch of methods in CompositingReasonFinder.cpp to make
it clearer which of these functions are called during style recalc and which
are call unconditionally on all RenderLayers.

Review URL: https://codereview.chromium.org/205343009

git-svn-id: svn://svn.chromium.org/blink/trunk@169992 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently the WebCrypto API only has support for one-shot digests. This CL
provides the necessary API scaffolding for methods to generate digests one chunk
at a time.

BUG=349514

Review URL: https://codereview.chromium.org/195983024

git-svn-id: svn://svn.chromium.org/blink/trunk@169991 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also rename StyleInvalidationAnalysis to StyleSheetInvalidationAnalysis, to distinguish from StyleInvalidator.

BUG=
R=ojan@chromium.org, rune@opera.com

Review URL: https://codereview.chromium.org/199633020

git-svn-id: svn://svn.chromium.org/blink/trunk@169990 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Without this CL, a SQLError object can be constructed in a database thread,
moved to main/worker thread, and referred by JavaScript object in the
main/worker thread.

We can't move object ownership over threads in Oilpan. So, we should not
construct SQLError objects in a database thread. Unlike the SQLResultSet case
[1], SQLError is created by multiple classes and it's hard to make sure they
create SQLError in a context thread.

So, this CL introduce SQLErrorData, which is an immutable data container. We can
construct a SQLErrorData object in a database thread, and move it to a context
thread, then construct a SQLError with the SQLErrorData object.

Note:
* Change the return type of AbstractSQLStatementBackend::sqlError from
PassRefPtr<SQLError> to SQLErrorData* because the function doesn't release the
ownership of the SQLErrorData object.

[1] https://src.chromium.org/viewvc/blink?revision=169929&view=revision

BUG=347902

Review URL: https://codereview.chromium.org/210833005

git-svn-id: svn://svn.chromium.org/blink/trunk@169989 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=169714

BUG=354688
TBR=abarth@chromium.org

Review URL: https://codereview.chromium.org/211573006

git-svn-id: svn://svn.chromium.org/blink/trunk@169988 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=169756

BUG=344497,352628
TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/199323010

git-svn-id: svn://svn.chromium.org/blink/trunk@169987 bbb929c8-8fbe-4397-9dbb-9b2b20218538