- 04 Feb, 2020 40 commits
-
-
Lukasz Anforowicz authored
When an extension message is received, we check `MessageSender.id` to disallow requests from unknown clients. Unfortunately, `MessageSender.id` is currently not trustworthy (issue 982361) and therefore this CL switches to using `MessageSender.origin` instead. Bug: 10321587 Change-Id: I3cc65cb4105cfc8caf0f98f5cd42cec5dacca4a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035864Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#738206}
-
Marc Treib authored
This reverts commit df3250dd. Reason for revert: Suspected of causing crashes, see crbug.com/1047879 Original change's description: > Sync cleanup: Remove DEPRECATED_EXPERIMENTS ModelType > > It has been deprecated and unused for a while. > The specifics proto itself can't be removed yet because it's still used > on the server. > > Bug: 1009361 > Change-Id: Ic183a6e244435cfce60ccdda34bff3e22a032ff3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022670 > Commit-Queue: Marc Treib <treib@chromium.org> > Reviewed-by: Jan Krcal <jkrcal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736397} TBR=treib@chromium.org,jkrcal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1009361, 1047879 Change-Id: I762fbf6f1b4b752a47b34e6a101a066d0c78aebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036005Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#738205}
-
Matt Menke authored
This was only used by an (unused) URLRequestContextBuilder method, some URLRequest LoadTimingInfo tests, and in the Cronet test fixture. This CL removes the first two uses, and moves the class over to Cronet. This CL also removes two other unused methods from URLRequestContextBuilder. Bug: none Change-Id: Id850440993e5b69b1ac5412a23243ece1200333a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033693 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#738204}
-
Takumi Fujimoto authored
A tab mirroring source from a Cast SDK enabled website (e.g. Google Slides) uses the mirroring app ID rather than the tab mirroring URN. We need to set the tab ID in CreateRoute() for those cases. An alternative way to do this would be making IsTabMirroringSource() return true for those cases, but there's code that assumes support for the audio mirroring app (separate ID from the mirroring app) if IsTabMirroringSource() is true, which wouldn't make sense given the app ID would not be the same as one specified. Bug: 1047788 Change-Id: I100ccbd881854ddbae33b94474761a816061573c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033926Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#738203}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2543c5cbffca..11cc3e8ebc7e git log 2543c5cbffca..11cc3e8ebc7e --date=short --first-parent --format='%ad %ae %s' 2020-02-04 aerotwist@chromium.org [e2e] Implements waitFor helper 2020-02-04 tvanderlippe@chromium.org Migrate snippets/ to import cross-module Created with: gclient setdep -r src/third_party/devtools-frontend/src@11cc3e8ebc7e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1047671 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I263c3e3b7d618737481d3d9cfc9c1fd8e89ef129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036829Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738202}
-
Mark Yacoub authored
BUG=987274 TEST=DrmOverlayValidatorTest, HardwareDisplayControllerTest, HardwareDisplayManagerTest Change-Id: I693464b560384bf42cc9bed9fbe2e68cea5474ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036641 Commit-Queue: Mark Yacoub <markyacoub@google.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#738201}
-
Jeremy Roman authored
These are guaranteed to be valid, non-null strings. Getting a null string here indicates that UTF-8 decode failed, in which case propagating a null string is not the right thing to do. Test included. This test would trigger the DCHECK in the linked bug without this fix. Bug: 1047753 Change-Id: I9e31d50176563d339b07883bbc2e5b52c4ff7641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033568 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#738200}
-
Renato Silva authored
Changes the color of the dropdown arrow to switch between users to Google Grey 200. Fixed: 1006436 Change-Id: Ie4c1151e4dee2dc201378cdb111667e7b1b89680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036175 Auto-Submit: Renato Silva <rrsilva@google.com> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#738199}
-
John Delaney authored
Bug: 1045468 Change-Id: I5f581a84466270258186b9b4b2ddd73ce91970f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036652Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#738198}
-
Jiaqi Han authored
In component build cast_shell from the chromecast:all target, transitive dependencies are not considered from deps, therefore gn desc output does not include them. Add cast_shell to data_deps. Bug: b/143469595 Test: CQ Change-Id: Icbe7afb962a61535da6d166d579aaaf75d2a9faa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036768 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#738197}
-
Abhijeet Kandalkar authored
This CL uses downcast helper for below media classes, - InbandTextTrack - TrackBase - AudioTrack - VideoTrack Bug: 891908 Change-Id: I1c2e68211be3bc60891c3666c6e044f78f3f74ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037271Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#738196}
-
Rohit Agarwal authored
Focusing on Omnibox when incognito tab opening intents are handled, results in partially hiding incognito NTP text and totally hiding incognito tabs count. These two elements are used to warn user about scope of incognito and possibility of prior state. Since 1p apps go through a privacy review and can be enforced to have an interstitial before opening an incognito tab, this feature would be limited to them, given that they would show a suitable interstitial before opening an incognito tab. Bug: 1030188 Change-Id: If031ee8e57ae4ef34c263a7bbc3f8ca996b3971b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012026 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#738195}
-
Samuel Huang authored
This reverts commit 77cffbd1. Reason for revert: This causes compile error in linux-chromeos-chrome. Original change's description: > [test] Clean up some incorrect use of ScopedRunTimeout in //chrome. > > ScopedRunTimeout is intended to be used to fail tests if a loop is Run() > for too long, rather than to Run() the loop for a specific length of > time. > > Clean up some tests which were using ScopedRunTimeout inappropriately. > > Bug: 1021777 > Change-Id: If6b2ee5f3eab498698d09fdee103e759fff51ead > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033445 > Auto-Submit: Wez <wez@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Commit-Queue: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738180} TBR=xiyuan@chromium.org,wez@chromium.org,gab@chromium.org,eroman@chromium.org,mmenke@chromium.org Change-Id: I919d3ce3bdf4430b05664849f8f57b31a21cc3df No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1021777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037315Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#738194}
-
John Budorick authored
DPAD_CENTER appears to have been unreliable and caused test flake. This CL also limits forms to a single autofocus element. Bug: 1048365 Change-Id: I6d1c29f8fc50c4e70e57fe3c65d6f6b59a0fc694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036644Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#738193}
-
Ken MacKay authored
Merge-With: eureka-internal/359612 Merge-With: nest-camera-internal/53240 Bug: internal b/139311908 Test: cast_audio_backend_unittests Change-Id: I318d6030effce41bc5c9cd30fe3759a96800716f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036636Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#738192}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7e86a6a616ab..3a1145d2eb00 Created with: gclient setdep -r src-internal@3a1145d2eb00 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I5c74bf435d0fe9a305b010d4953c61e43a8ba559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036828Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738191}
-
Vasiliy Telezhnikov authored
Currently SurfaceControl takes color space of overlay from GLImage. This CL fixes missed setting color space from SharedImageBackingAHB to OverlayImage. Change-Id: If0c53160a1bfdfb99d8dc40a2e44e1ba04962018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037311 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#738190}
-
Christoph Schwering authored
- |ignore_text_changes_| was not used anywhere. - |provisionally_saved_form_| was a std::unique_ptr<FormData> only to model optionality. Bug: 1007974 Change-Id: I1369b1d98e639acb8068ef7c5e51bc494a6b43ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036061Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#738189}
-
Julian Pastarmov authored
Synchronizes the protobuf definition of the Study proto that contains the new PolicyRestriction field and filters studies based on the value of the ChromeVariations policy and the stidy filter value. BUG=1047683 TEST=components_unittests Change-Id: I48741d677c3f17340d787c363676bb0978af015e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033247 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#738188}
-
Denis Kuznetsov authored
Bug: 887393 Change-Id: I9d831098a90a59efe51e9161babad8187f43656c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036093 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#738187}
-
Xiaocheng Hu authored
This reverts commit 7697ad89. Reason for revert: memory leak fixed Original change's description: > Revert "Skip clipboard CSS sanitizer when there's no style sheets to sanitize" > > This reverts commit 885420c7. > > Reason for revert: Caused memory leak. > Bug: 1048536 > > Original change's description: > > Skip clipboard CSS sanitizer when there's no style sheets to sanitize > > > > The clipboard CSS sanitizer has a side effect that, it may add > > additional inline styles to elements to match their computed style in > > the dummy document. > > > > This isn't necessary when the markup doesn't have any style sheet to > > sanitize, in which case the side effects are undesirable and causes > > some regressions. Hence, this patch skips the sanitization when there > > are no style sheets. > > > > Bug: 1047806 > > Change-Id: I62e20fb5fe29d56bda9d86ca12499b7ffb1497e6 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036731 > > Reviewed-by: Koji Ishii <kojii@chromium.org> > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#738083} > > TBR=yosin@chromium.org,kojii@chromium.org,xiaochengh@chromium.org > > Change-Id: If772ff5e756be2472bba906748fc838c0aabe574 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1047806 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037173 > Reviewed-by: Tsuyoshi Horo <horo@chromium.org> > Commit-Queue: Tsuyoshi Horo <horo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738093} TBR=horo@chromium.org,yosin@chromium.org,kojii@chromium.org,xiaochengh@chromium.org Cq-Include-Trybots=luci.chromium.try:layout_test_leak_detection Change-Id: Ida43d8a42c41826b8232df5aa280609283d471b5 Bug: 1048536, 1047806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036835Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#738186}
-
Yann Dago authored
Bug: 1045887 Change-Id: Iee367ff529aaa268aa0a558f13c3727c29f67880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036397Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#738185}
-
Andreea Costinas authored
This CL adds a new device policy that will control the availability of System-proxy service and the web proxy credentials for system services connecting through System-proxy. BUG=chromium:1042621 TEST=unit_tests:SystemProxySettingsPolicyHandlerTest Change-Id: I183ccd8accd7348d3b3d4580382ddbecc7b5f4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007749Reviewed-by:
Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Cr-Commit-Position: refs/heads/master@{#738184}
-
Robbie Gibson authored
This extends the definition of kZeroSuggestionsOnNTP from Desktop/Android to iOS. Bug: 1048193 Change-Id: I593c8dfd287a20b7afb9b4041ce6c33abbb99c22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036030 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#738183}
-
Raul Tambre authored
map() returns a list in Python 2. Python 3 returns an iterator. Wrapping in a list() results in the same behaviour on both. [1/2] ACTION //chrome/common:service_process_mojom__generator(//build/toolchain/win:win_clang_x64) Traceback (most recent call last): File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 556, in <module> sys.exit(main()) File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 551, in main return args.func(args, remaining_args) File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 267, in _Generate processor._GenerateModule(args, remaining_args, generator_modules, File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 238, in _GenerateModule generator.GenerateFiles(filtered_args) File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 478, in GenerateFiles self.WriteWithComment(self._GenerateModuleSource(), File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\template_expander.py", line 37, in GeneratorInternal return ApplyTemplate(args[0], path_to_template, parameters, **kwargs) File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\template_expander.py", line 30, in ApplyTemplate return template.render(params) File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\..\..\..\..\..\..\..\third_party\jinja2\asyncsupport.py", line 76, in render return original_render(self, *args, **kwargs) File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\..\..\..\..\..\..\..\third_party\jinja2\environment.py", line 1008, in render return self.environment.handle_exception(exc_info, True) File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\..\..\..\..\..\..\..\third_party\jinja2\environment.py", line 780, in handle_exception reraise(exc_type, exc_value, tb) File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\..\..\..\..\..\..\..\third_party\jinja2\_compat.py", line 37, in reraise raise value.with_traceback(tb) File "gen\mojo\public\tools\bindings\cpp_templates.zip\tmpl_443233f41d2b3f893c5bf0eb0f069e01da908ebe.py", line 100, in <module> File "gen\mojo\public\tools\bindings\cpp_templates.zip\tmpl_71c6d092b6dca901ff3ed0d20e7c827a088fac2d.py", line 523, in <module> File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 183, in HasPackedMethodOrdinals max_ordinal = len(interface.methods) * 2 TypeError: object of type 'map' has no len() Bug: 941669 Change-Id: I0a3797c57d9345beb8b6f305cb696051366ce9c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033508 Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#738182}
-
Marc Treib authored
TBR=bokan@chromium.org No-Try: true Bug: 1047818 Change-Id: I65fa745164ee41de85f3049a9531a5b899525803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036064 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#738181}
-
Wez authored
ScopedRunTimeout is intended to be used to fail tests if a loop is Run() for too long, rather than to Run() the loop for a specific length of time. Clean up some tests which were using ScopedRunTimeout inappropriately. Bug: 1021777 Change-Id: If6b2ee5f3eab498698d09fdee103e759fff51ead Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033445 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#738180}
-
Rushan Suleymanov authored
Forward commit failures for proxy and forwarding model type processors. Bug: 1047123 Change-Id: Icfca411086c2bc86976ef0234ba43484e81a640a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034524 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#738179}
-
Michael Ludwig authored
Fix the bad expectation image for mac10.10 video-layer-crash.png and removes the suppression. Bug: 1045050 Change-Id: Ib32967e221ad6dde9e49b0faea04bad6639edb34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033373Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Michael Ludwig <michaelludwig@google.com> Cr-Commit-Position: refs/heads/master@{#738178}
-
Filip Filmar authored
This test started failing recently and consistently on the arm64 build bot, but does not fail locally on device, nor on a repeated job run. Adding a few more asserts to check if those reveal some issues, e.g. OOM or similar. Bug: 1047475 Change-Id: I91f0a3e08d0f2fdeb0b974715575e5486633702c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036279 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#738177}
-
Xiyuan Xia authored
- WorkspaceWindowResizer::CompleteDrag() does not necessarily trigger a new compositor frame. As a result, the wait for the next frame could time out. This CL fixes the issue by explicitly marking a damaged rect to ensure a new frame is produced; - Fix ui::WaitForNextFrameToBePresented use-after-free by using a CancelableCallback as the frame presented callback so that local var |runloop| is not accessed when it times out; Bug: 1047657 Change-Id: I6e7ac27f14d92adf3c9d1535fec62e32e3964f2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036369Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#738176}
-
Marc Treib authored
TBR=ccameron@chromium.org No-Try: true Bug: 1048149 Change-Id: Ie3d719e6e87cd86e54a72c7ef1a6377ae971e13b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036174 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#738175}
-
Alexander Hendrich authored
profile() is only needed for regular extension policies associated to the user's profile(). The login screen extensions use the signin profile instead, so we don't need to check for existence of profile(). Bug: 1025760 Change-Id: I8c28de42aead26aed13d3e5f6c9f72af03913e3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035977Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#738174}
-
Ben Joyce authored
Bug: 1021634 Change-Id: I86c754d84924eba122e62168867a9aea0379a61c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036445Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#738173}
-
Marc Treib authored
This reverts commit 5edf3130. Reason for revert: Suspected of breaking many test targets on 10.10, see crbug.com/1048495 Original change's description: > macOS HDR: Add HDRCopierLayer > > It used to be that setting the contents of a CALayer to an IOSurface > that has an HDR color space, and setting that the CALayer wants > extended range content was sufficient to display HDR content. This was > an undocumented behavior, and macOS has recently fixed it (made it not > work). > > The documented way to get HDR is to use a CAMetalLayer. Unfortunately, > one cannot call setContents (or provide a pre-existing IOSurface) to > this API. As a consequence, we need to perform a copy from the > IOSurface to the CAMetalLayer. Add HDRCopierLayer subclass of > CAMetalLayer, which overrides setContents to blit the specified > contents to the CAMetalLayer. > > Add tests for this. It appears that the test suite is not running, > because most of the tests are broken. Fix all the tests (next step > there is to add them to bots, but that will get a separate patch). > > Bug: 976426 > Change-Id: I8115f2ad19f9a9fd3d1018d2bde7132f7bcfc6e2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033906 > Commit-Queue: ccameron <ccameron@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737885} TBR=ellyjones@chromium.org,ccameron@chromium.org Bug: 976426, 1048495 Change-Id: I20e6ed27e3a6e3da0421f8a57ff4d9aa50b36e80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035957Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#738172}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/43c981c9..842c4bc2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifecf3d46f7bc4194e3b67ec9730e193bf7396c25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037374 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738171}
-
Tomas Popela authored
The main reason for the flag is so called dialog hell, when you try to share the screen on Wayland through PipeWire. To address it we've created two changes, that are currently under review[0][1]. Once that's done the flag could be removed. [0] - https://webrtc-review.googlesource.com/c/src/+/160649 [1] - https://chromium-review.googlesource.com/c/chromium/src/+/1942327 Bug: 682122 Change-Id: I9ced38a015e4b7806bdaac7b1ab32ef0345e4548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036095 Auto-Submit: Tomáš Popela <tomas.popela@gmail.com> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#738170}
-
Hesen Zhang authored
- update-notification-scheduling-integration references to an incorrect OWNERS file. Bug: 1048360 Change-Id: Ifac09c577afc4ca62d19557e3a6f935f829bc530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036446 Auto-Submit: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#738169}
-
arthursonzogni authored
This class wasn't owning any data. It was used like this: ~~~ network::ContentSecurityPolicy content_security_policy content_security_policy.Parse(...) policies = content_security_policy.TakeContentSecurityPolicy(); ~~~ Now, it becomes a function: ~~~ ContentSecurityPolicyParse(&policies, ...); ~~~ Why? 1) Keep it simple. 2) The content/common/content_security_policy/ directory will be merged into service/network/. It contains only functions. It would be nice to turn the existing class into a set of function to keep everything consistent. Bug: 1021462 Change-Id: I250b5137737e921b0e7c5e27ffa4f7222d7c44ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030958 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#738168}
-
Bo Liu authored
There is a race during an unexpected process death. |rebind| and |updateGroupImportance| are called from content code which are notified of process death through IPC code. ChildProcessConnection is also notified of process death directly from Android in onServiceDisconnected. So it is possible Android notices the death and delivers the message first while content code is still trying to access the connection. Simply ignore these calls in that case. Fixes: 1026626 Fixes: 1033577 Change-Id: I13eb65fb796e7a8999f781ae11df23c69d40161a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031866Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#738167}
-