GitLab

This CL makes Widget::InitParams movable, and adds to it a
movable element `init_properties_container` of type
PropertyHandler. This adds support to views::Widget to allow
its users to set any arbitrary properties that will be set
on the native widget's window before it is initialized and
parented.

This way we can watch for windows with particular properties of
interest in WindowObserver::OnWindowAdded().

Example use case: Mark widgets to be ignored in the mini_views
before they're added in the desks containers. This avoids refreshing
the mini_views unnecessarily. This will be handled in a follow-up
CL.

BUG=979434, 866622
TEST=Added a new test.

Change-Id: I26f4c5db77e7acd9c4b52ea77775376d52c50897
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709966
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683208}

The class is now a no-op as of
https://chromium-review.googlesource.com/c/chromium/src/+/1686726.
It never fires its observer calls and always returns https://www.google.com/.
Move that constant to google_util and unwind the rest.

This ends up touching a lot of files. The two interesting parts:

- Check that GoogleURLTracker is always created with ALWAYS_DOT_COM_MODE,
  and that, in ALWAYS_DOT_COM_MODE, it degenerates into return
  kDefaultGoogleHomepage. (Apart from test code which manually triggers
  bits of it.) That means we can replace all uses of
  GoogleURLTracker::google_url with the newly-added
  google_util::kGoogleHomepageURL and remove everything that registers
  callbacks.

- Check that nothing else uses the prefs in google_pref_names.h, and
  thus they can be removed. Check that I've correctly replaced them with
  migration code in chrome/browser/prefs/browser_prefs.cc and
  ios/chrome/browser/prefs/browser_prefs.mm

From there, this CL does that following:

- Remove GoogleURLTracker and associated classes from tests and production
  code.

- //components/google/core/browser got folded into
  //components/google/core/common

- A bunch of test-only functions to simulate the Google URL changing are
  gone.

- UIThreadSearchTermsData in both iOS and non-iOS no longer needs a Profile
  parameter.

Hopefully that's enough context that one can review the bulk of the CL
(which is fairly uninteresting) without too much trouble.

Bug: 973591
Change-Id: I4aa3606e4a1b2ccf2d33932c22a69b74e5176753
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687348
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683207}

Implement the "seekto" and "scrubto" mojo commands
by calling the "seekto" action handler in Blink.

For reference, these are separate in the generic
media session mojo API because not all media
sessions support scrubbing.

BUG=977375

Change-Id: Ib62e069a03539e57de832e8108c877be7f582e93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697428Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683206}

Using wpt-import in Chromium 501c13b1.
With Chromium commits locally applied on WPT:
250461b3 "Worker: Register a service worker just once for worker subresource interception tests"
bf4ad57e "Experimental CookieStore API: some additional browser-side validation"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: I17f35901d86be31d418e6889db8adc55c5d07560
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731310Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683205}

The decision logic depends on browser and webview bitness. These are
Chrome concepts. Therefore, move the decision logic from //build to
//chrome.

Change-Id: Idd334e521ed30dd09805c795be32f790a52a51cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730834
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683204}

This patch makes the ModelListAdapter compliant with MVC by
introducing a "ListObservable" ModelList. This allows the adapter to
know about changes to the list without explicitly being told. As a
result, coordinators and mediators no longer need to hold references
to the adapter to make changes.

Downstream component here: https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/1377764

Bug: 909779
Change-Id: I626f513f1e63bc8a1808390d01d4058b631ca18d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652423
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683203}

Disable this test on Win, ChromeOS and Linux(chromium)

TBR=msramek@chromium.org

Bug: 985131
Change-Id: I2df66eded5c6f5129bde29d8f715dab6c658b3d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731170Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683202}

Another preparation step to Onion souping this test
and its respective production code.

BUG=704136
R=guidou@chromium.org

Change-Id: I213eee21c66213c06350413600f2fbe487c5cd2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731449
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683201}

The initial version of this component was intended for improving
captive portal detection only, and was guarded via
ENABLE_CAPTIVE_PORTAL_DETECTION. The component now handles additional
features such as dynamic interstitials which should be enabled on
Android.

Bug: 987346
Change-Id: I7bf9e7ac411efc97957364fe2ccbab802eebc6b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730089Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683200}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/682bc0e14c7a..1f08ded4fe9a


Created with:
  gclient setdep -r src-internal@1f08ded4fe9a

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:None
Change-Id: I1cf8ea6bc504198d1a12c2d6245d11a707f50e8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731098Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683199}

 - Use ShelfConstants functions instead of using shelf constants directly so
   that dense shelf changes are observed when flag is active.

Bug: 973483
Change-Id: I757c12e84883a025a17288781c3d9662e3ee4b28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729245Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Matthew Mourgos <mmourgos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683198}

The builder has 10 hour hourly resource usage in p99.
http://shortn/_1XQzVGUb76

Failure of linux_chromium_ubsan_rel_ng is not xenial specific.
(crbug.com/989936, crbug.com/989935)

Bug: 954450
Change-Id: If101be573202e0dffd6d2e5f902ed420f1c2c1a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730051
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683197}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=kinuko@chromium.org, tommi@chromium.org

Bug: 968047
Change-Id: I65f388a01112b7ece4ddd77d839ff28b3c22c554
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728665
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683196}

Bug: 973882
Change-Id: I1c962217d3d37c6892d1e03c691496aedc6bf352
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731291Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683195}

The histogram ChromeOS.PlatformVerification.ExpiryStatus is no longer
used. Removed it usage from the attestation platform workflow and marked the
histogram as obsolete.

Bug: 975047
Change-Id: I89891ca8c1a35b1f3daf47431a24324efdc60085
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708711
Commit-Queue: Wei-Cheng Xiao <garryxiao@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683194}

This CL extends the lifespan of three histograms:
KeyboardAccessory.AccessorySheetSuggestionCount(.*)
KeyboardAccessory.AccessorySheetSuggestionsSelected(.*)
KeyboardAccessory.AccessorySheetTriggered(.*)

All three are used to check engagement and usefulness of the keyboard
accessory sheet that is under active development: crbug.com/960741

Bug: 988761, 988748, 988742
Change-Id: I120c751b4f06262883af1bde4f8b76b04345947a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730918Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683193}

This patch contains 2 changes as below.

1) Each invocation of va_start() must be matched by
a corresponding invocation of va_end() in the same function.
But previous code omit the va_end() in AddDebugMessage.
This patch add va_end() for preventing memory leak.

2) Also pipe was not closed when exiting the function.
We need to close pipe using CloseHandle() in this case.

BUG=NONE

Change-Id: I945abcb0ca3fec437a485968abaebd3ed95e81e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/586092Reviewed-by: James Forshaw <forshaw@chromium.org>
Commit-Queue: James Forshaw <forshaw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683192}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/dcf3c07791fc..f275010c435a

git log dcf3c07791fc..f275010c435a --date=short --no-merges --format='%ad %ae %s'
2019-08-01 hidehiko@chromium.org chromite: Move back betty from experimental.

Created with:
  gclient setdep -r src/third_party/chromite@f275010c435a

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: Ie814300c970268e4f85182683a72553fb83c5030
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730594Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683191}

https://android.googlesource.com/platform/external/perfetto.git/+log/c17e81c243e3..6cbf74139e0f

git log c17e81c243e3..6cbf74139e0f --date=short --no-merges --format='%ad %ae %s'
2019-08-01 fmayer@google.com Merge changes I9012332d,I55e7591f

Created with:
  gclient setdep -r src/third_party/perfetto@6cbf74139e0f

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Bug: None
Change-Id: Ifcbc719e7b5d0421710eae0460e6bf8daffa4e10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730760Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683190}

When UIWebView is used, HTTP headers are stored inside WebStateImpl.
When navigation is committed, only headers of main frame is kept and
transferred to NavigationContext. In WKWebView, the headers should be
stored directly to NavigationContext in
[WKNavigationDelegate decidePolicyForNavigationResponse].

Bug: 551677,956511
Change-Id: I6971f7e741761bda5b2e7d4c6adf3cabdd697a38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729594Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683189}

Add ArcCertInstaller to install smart card certificates on ARC via ARC
INSTALL_KEY_PAIR command.

Decrease ARC remote command timeout to 2 minutes.

Move all ARC certificate store related files into
arc/enterprise/cert_store directory.

Bug: b:119914122
Test: unit_tests
Test: local device
Change-Id: I2921e31493b42c80523350d4979db098868bc270
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709581
Commit-Queue: Polina Bondarenko <pbond@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683188}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=rmcilroy@chromium.org

Bug: 968047
Change-Id: I300e3b43de664f0f6bdfefed21a22d886eef8f05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729151
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683187}

This will ensure this won't regress after:
https://chromium-review.googlesource.com/c/chromium/src/+/1688957

Bug: 981339
Change-Id: I67b5896678eac7536811e40bf000a8eb4caff32c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719129Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683186}

The kAutofillImportNonFocusableCreditCardForms is already enable by default. Remove all usage of this flag for the accordion form.

Change-Id: I08b57fb5a145757c7312c98116f1e5616676248c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726641Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Hao Zhang <hozhng@google.com>
Commit-Queue: Sujie Zhu <sujiezhu@google.com>
Cr-Commit-Position: refs/heads/master@{#683185}

This CL renames *_struct_traits.* to *_mojom_traits.* in
//components/spellcheck.

*_struct_traits.* => *_mojom_traits.*

Bug: 806965
Change-Id: I0be9f65ba47c24cce99c36d9628d38675dbc575b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730050Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Rachel Blum <groby@chromium.org>
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Cr-Commit-Position: refs/heads/master@{#683184}

VoteConsumers can implement this efficiently, or choose to invalidate
a vote and create new one.

BUG=971272

Change-Id: I47bf89b6abe223807a2a09b9ba47a2054d241e85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724701
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683183}

Bug: 989802
Change-Id: I34ec22b46276e4c52500e58b9d63d3dc5c2d7376
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731294
Auto-Submit: Fergus Dall <sidereal@google.com>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683182}

https://skia.googlesource.com/skia.git/+log/1532d22050cb..a00318f1ad00

git log 1532d22050cb..a00318f1ad00 --date=short --no-merges --format='%ad %ae %s'
2019-08-01 michaelludwig@google.com Consistify image filter implementation code layouts

Created with:
  gclient setdep -r src/third_party/skia@a00318f1ad00

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=benjaminwagner@google.com

Bug: None
Change-Id: I6779b459ac8df81a3e538e5dbfbd4d17e35753cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730759Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683181}

On Win because flaky.

TBR=siggi@chromium.org

Bug: 989810, 732501
Change-Id: I2a168771aee0789b2c2845dc4f9d4c1d180e2e34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730905Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683180}

Was broken on multiprofile-signin screen in CL:1710000

Bug: 987588
Change-Id: Icb0330b4e427e56215796a7aea21c7fcb5724e1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730451Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683179}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/14cf766b..7ae4b7f3

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I9a4fe6ae8404ca2ff51e235d1304979e80e6efd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731309Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683178}

TBR=hans

Bug: 989932
Change-Id: Id91684d103ad0ce6970c8b69d530d6faf84fc6af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731429Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683177}

This CL removes the dynamic linking of Vista-era APIs in preference to
static linking. To prevent the uxtheme DLL being loaded unnecessarily the
DLL is added marked as delay loaded.

Bug: 986625
Change-Id: I29987f493b7fdf92633b3ba4dde61573b5543bc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720905Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Forshaw <forshaw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683176}

BUG=979342

Change-Id: I9832cc96f3530412a314f79ac9399e93fa986142
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680280
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683175}

WindowedIncognitoObserver provides the interface for querying the
current status of incognito windows, and watch for new incognito window
opening. The interface can be used off the UI thread.

WindowedIncognitoMonitor is used to create WindowedIncognitoObserver
instances off the UI thread. Internally, the implementation class,
WindowedIncognitoMonitor, is registered as a BrowserListObserver
to observe opening/closing of incognito windows on behalf of queries
from WindowedIncognitoObserver.

Bug: 904785
Test: Add unit_tests WindowedIncognitoMonitorTest.*

Change-Id: I936d679c1963e1ffc1a5bbc5c4470274200d100c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692208
Commit-Queue: Chinglin Yu <chinglinyu@chromium.org>
Reviewed-by: Gabriel Marin <gmx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683174}

Flaky.

TBR=rockot@google.com

Bug: 987448
Change-Id: I6db59e7ce6ac618320e10bfe85b1aa700e0fbce1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730902Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683173}

https://chromium.googlesource.com/catapult.git/+log/2bd4cf346e06..ec6ed57a688e

git log 2bd4cf346e06..ec6ed57a688e --date=short --no-merges --format='%ad %ae %s'
2019-08-01 rnasri@google.com Add rects based speed index utility functions

Created with:
  gclient setdep -r src/third_party/catapult@ec6ed57a688e

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sadrul@google.com

Bug: chromium:982025
Change-Id: If708a72fa7aeaf0b5ccc031984e96f312a07dec2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730951Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683172}

Updating paths, add conditional install, clarify limitations.

Change-Id: I9f3015b8b59015e6f84a6eb87870d68adc8c1bcb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730573Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683171}

Each builder has around 10 hour hourly resource usage in p99.
http://shortn/_gZ2rCCbPNR

So I expect this won't add much burden to existing xenial pool.
Current usage is in
https://datastudio.google.com/s/uf5Kh6NZ8XA
And we have 3400 xenial bots in MTV time now.

Bug: 954890
Change-Id: I18d8e0cd6e8609f4bb924e348555c8d38d14d1bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730492Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683170}

This CL renames *_struct_traits.* to *_mojom_traits.* in //content.

*_struct_traits.* => *_mojom_traits.*

Bug: 806965
Change-Id: I64e94630bdf74821ab454af05240082715a916f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728529Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Cr-Commit-Position: refs/heads/master@{#683169}