GitLab

This adds a basic integration test for saving on a test page, and also a test
for copy-password confirmation toast, which is not coverable by the unittests (yet).

BUG=159166

Review-Url: https://codereview.chromium.org/2846253002
Cr-Commit-Position: refs/heads/master@{#468910}

The interface taking a raw pointer is deprecated and being removed.

BUG=690937
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2853663002
Cr-Commit-Position: refs/heads/master@{#468909}

BUG=none
R=sdefresne@chromium.org

Review-Url: https://codereview.chromium.org/2852413002
Cr-Commit-Position: refs/heads/master@{#468908}

In StyleSurroundData, the border longhand properties are stored in a
single BorderData. This makes it difficult to generate because the
generator assumes that properties don't share storage.

This patch splits the LenthSize objects maintaining the border-*-radius
into individual properties stored directly on the surround group
instead.

Generated files diff here: https://gist.github.com/nainar/3192118aab7de3831137a4ae2cc73958/revisions

BUG=628043

Review-Url: https://codereview.chromium.org/2850173003
Cr-Commit-Position: refs/heads/master@{#468907}

use USVString for URLs instead of DOMString
at CSSURLImageValue.idl.

https://drafts.css-houdini.org/css-typed-om-1/#cssurlimagevalue
https://github.com/w3c/css-houdini-drafts/issues/244

BUG=545318

Review-Url: https://codereview.chromium.org/2858553002
Cr-Commit-Position: refs/heads/master@{#468906}

This patch:
- Removes its getters.
- Makes it inherit from RefCountedCopyable.
- Renames color_ to background_color

This is to set up for generating StyleBackgroundData.

BUG=628043

Review-Url: https://codereview.chromium.org/2854183003
Cr-Commit-Position: refs/heads/master@{#468905}

This CL rolls the instrumented libraries after the addition of
libgnutls26 in https://codereview.chromium.org/2851493005/

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_chromeos_msan_rel_ng
BUG=716118
R=eugenis@chromium.org

Review-Url: https://codereview.chromium.org/2847033002
Cr-Commit-Position: refs/heads/master@{#468904}

- Removes media-router+watch@
- Adds watchlists for cast_channel, dial, and presentation
- Updates watchlist for media_router

BUG=

Review-Url: https://codereview.chromium.org/2859583003
Cr-Commit-Position: refs/heads/master@{#468903}

This change removes the deprecated raw pointer version of
base::DictionaryValue::SetWithoutPathExpansion in //chrome and replaces
it with the unique pointer version or other convenience functions where
appropriate.

BUG=646113

Review-Url: https://codereview.chromium.org/2845113002
Cr-Commit-Position: refs/heads/master@{#468902}

This CL re-enables the ability to create start menu shortcuts from the
create shortcut view in chrome://apps which was disabled in Win8+
because Win8 shortcut creation doesn't work properly. Since things work
again in Win10, just exclude Win8.

BUG=717388

Review-Url: https://codereview.chromium.org/2851303005
Cr-Commit-Position: refs/heads/master@{#468901}

Network traffic annotation is added to network request of:
net/url_request/url_request_data_job_fuzzer.cc

BUG=656607

Review-Url: https://codereview.chromium.org/2851483002
Cr-Commit-Position: refs/heads/master@{#468900}

This CL makes battery impl be completely only part of the implementation
of the Device Service.
  - Moves //device/battery to //services/device/battery
  - Makes //services/device/battery visible in GN only to
    //services/device

BUG=684422
TBR=stevenjb@chromium.org, tsepez@chromium.org, boliu@chromium.org

Review-Url: https://codereview.chromium.org/2818673003
Cr-Commit-Position: refs/heads/master@{#468899}

The Isolate Extensions project/feature shipped on by default in M56.
This CL removes the support for disabling Isolate Extensions, which
includes field trial config, supporting code, command line parameter,
and tests that are no longer relevant.

BUG=545200
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2850793005
Cr-Commit-Position: refs/heads/master@{#468898}

Minor UI fixes :
1- Changed title and space widget text to use Roboto medium
2- Reduced space between title and space widget

BUG=717762

Review-Url: https://codereview.chromium.org/2859453003
Cr-Commit-Position: refs/heads/master@{#468897}

The interface taking a raw pointer is deprecated and being removed.

BUG=690937

Review-Url: https://codereview.chromium.org/2851513005
Cr-Commit-Position: refs/heads/master@{#468896}

Changes:
Sync powerd's backlights forced off state with touchscreen local pref and update touchscreen.

BUG=709209
TEST=added test coverage

Review-Url: https://codereview.chromium.org/2855033004
Cr-Commit-Position: refs/heads/master@{#468895}

We will limit this to /mnt/stateful_partition/ and /home/ as the rest
of directories are just useless noise.

BUG=712942

Review-Url: https://codereview.chromium.org/2844223005
Cr-Commit-Position: refs/heads/master@{#468894}

Based on discussions in https://codereview.chromium.org/2696873002, in
WindowTreeClient::OnWindowInputEvent(), if the target window provided by
window server has already been destroyed by the time client-lib got the
event, we should use the event to update global states related to
MouseEvent and TouchEvent kept in Env() and not dispatch the event to
any window.

BUG=664617
TEST=aura_unittests

Review-Url: https://codereview.chromium.org/2779093004
Cr-Commit-Position: refs/heads/master@{#468893}

We've crossed a threshold where builds now fail without it.

BUG=717815

Review-Url: https://codereview.chromium.org/2853373005
Cr-Commit-Position: refs/heads/master@{#468892}

Update MediaStreamDevicesControllerTest to test with kUsePermissionManagerForMediaRequests feature enabled

This updates MediaStreamDevicesControllerTest to run tests with the
kUsePermissionManagerForMediaRequests flag enabled (as well as without it) by
using a paramaterized test.

A few other changes that were needed to make the test work:
1) |prompt_delegate_| is not used for testing when the feature is enabled.
Instead, |prompt_factory_| is used to check the assumptions about what prompts
are shown. The functions on these 2 objects are slightly different, so
functions in the test harness have been introduced to encapsulate them
(SetPromptResponseType, TotalPromptRequestCount, WasPermissionShown,
ResetPromptCounters).
2) MockPermissionPromptFactory was modified to make it possible to test whether
a specific permission type had been displayed in a prompt.
3) RequestPermissions runs asynchronously. So a RunLoop is used to make
execution of it synchronous for the test.
4) A small bug in PermissionRequestManager::DoAutoResponseForTesting was fixed
where an assumption was made that the function would only be called for single
permission requests (not grouped ones).

BUG=596786
TBR=tommycli@chromium.org

Review-Url: https://codereview.chromium.org/2835863003
Cr-Commit-Position: refs/heads/master@{#468891}

BUG=676220
R=peter@chromium.org
CC=thestig@chromium.org

Review-Url: https://codereview.chromium.org/2848403002
Cr-Commit-Position: refs/heads/master@{#468890}

https://skia.googlesource.com/skia.git/+log/ad15264f9ad2..16a6144dfdba

$ git log ad15264f9..16a6144df --date=short --no-merges --format='%ad %ae %s'
2017-05-02 mtklein ok, add sRGB support

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: Ibcc9e6a34f1f337057b23726972f77859870535c
Reviewed-on: https://chromium-review.googlesource.com/493837Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468889}

This CL is a refactor and has no intended behavior change.

The method was initially introduced to assist in IPC, before Chrome's IPC
subsystem was capable of transporting handles across processes. Now that the
IPC subsystem does have the capability, the functionality is no longer needed
in base::SharedMemory.

BUG=716206
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=brettw@chromium.org

Review-Url: https://codereview.chromium.org/2852803002
Cr-Commit-Position: refs/heads/master@{#468888}

Only show this option when
a) clipboard content has additional format.
b) target text field has the ability to accept formatted content.

BUG=707857

Review-Url: https://codereview.chromium.org/2801003004
Cr-Commit-Position: refs/heads/master@{#468887}

Simply moves the panel of where screenshots are shown to below the
filter bar.

See: http://imgur.com/a/qvTvn

R=pfeldman
BUG=None

Review-Url: https://codereview.chromium.org/2857833002
Cr-Commit-Position: refs/heads/master@{#468886}

https://pdfium.googlesource.com/pdfium.git/+log/d7188f7f91a9..cadb4711bdc9

$ git log d7188f7f9..cadb4711b --date=short --no-merges --format='%ad %ae %s'
2017-05-02 thestig Add a unit test for CRYPT_ArcFourSetup().

Created with:
  roll-dep src/third_party/pdfium
BUG=686128


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I36a220def9c931f30aac6fd561eb6698fe294981
Reviewed-on: https://chromium-review.googlesource.com/493838
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468885}

BUG=714503

Review-Url: https://codereview.chromium.org/2848353002
Cr-Commit-Position: refs/heads/master@{#468884}

Revert of Convert ChromeActivityTestCaseBase direct children to JUnit4 (patchset #5 id:120001 of https://codereview.chromium.org/2831823003/ )

Reason for revert:
Suspect this is causing issues on LauncherActivityTest#testLaunchWithUrlNoScheme: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk%20(with%20patch)&tests=org.chromium.chrome.browser.document.LauncherActivityTest%23testLaunchWithUrlNoScheme

Original issue's description:
> Convert ChromeActivityTestCaseBase direct children to JUnit4
>
> This CL convert all the ChromeActivityTestCaseBase direct children tests to
> JUnit4. All TouchCommon methods (dragTo, dragStart, etc) are refactored
> to directly calling TouchCommon. For more on JUnit4 migration, check
> src/testing/android/docs/junit4.md
>
> BUG=640116
>
> Review-Url: https://codereview.chromium.org/2831823003
> Cr-Commit-Position: refs/heads/master@{#468847}
> Committed: https://chromium.googlesource.com/chromium/src/+/8e8d36a33e54fa305ac6842ccfafb03343d18d24

TBR=mikecase@chromium.org,tedchoc@chromium.org,yolandyan@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=640116

Review-Url: https://codereview.chromium.org/2853423003
Cr-Commit-Position: refs/heads/master@{#468883}

Also explicitly call PrintContext::EndPrintMode(), rather than calling
it in the destructor. Add a ScopedPrintMode helper class to do that
conveniently.

BUG=716474

Review-Url: https://codereview.chromium.org/2848823005
Cr-Commit-Position: refs/heads/master@{#468882}

Cr-Commit-Position: refs/heads/master@{#468881}

This CL removes the |type| parameter from PlatformSensorAmbientLightMac
constructor and updates the comments.

BUG=None

Review-Url: https://codereview.chromium.org/2859553003
Cr-Commit-Position: refs/heads/master@{#468880}

Is docker'ed now.

TBR=jbudorick@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2854093003
Cr-Commit-Position: refs/heads/master@{#468879}

BUG= internal b/35766299
TEST= unittests, on device

Review-Url: https://codereview.chromium.org/2859733002
Cr-Commit-Position: refs/heads/master@{#468878}

DocumentActivityTestBase is not used by any test class, in JUnit4,
a test that requires DocumentActivity can use
`ChromeActivityTestRule<DocumentActivity>`

BUG=640116

Review-Url: https://codereview.chromium.org/2853273004
Cr-Commit-Position: refs/heads/master@{#468877}

BUG=676220
R=peter@chromium.org,thestig@chromium.org

Review-Url: https://codereview.chromium.org/2849003002
Cr-Commit-Position: refs/heads/master@{#468876}

BUG=

Review-Url: https://codereview.chromium.org/2862473002
Cr-Commit-Position: refs/heads/master@{#468875}

This CL makes HistoryBackend::UpdateFaviconMappingsAndFetchImpl() take one icon
type and one icon URL. All of its callers only pass in a single type and a
single icon URL

This CL makes HistoryService::GetFavicon() take a one icon type and one icon
URL as well.

BUG=712466

Review-Url: https://codereview.chromium.org/2828173002
Cr-Commit-Position: refs/heads/master@{#468874}

Add support to change the layer's color temperature by toning down the
blue and green colors scales.

BUG=705816
TEST=compositor_unittests --gtest_filter=LayerAnimatorTest.Temperature

Review-Url: https://codereview.chromium.org/2854653003
Cr-Commit-Position: refs/heads/master@{#468873}

[CrOS Tether] Create DisconnectTetheringOperation, which sends a DisconnectTetheringRequest to a remote tether host.

BUG=672263

Review-Url: https://codereview.chromium.org/2861603002
Cr-Commit-Position: refs/heads/master@{#468872}

Revert of (Reland x2) Expose resources in Robolectric/JUnit tests. (patchset #4 id:60001 of https://codereview.chromium.org/2842603002/ )

Reason for revert:
TileGroupTest failing on waterfall, see http://crbug.com/717820

BUG=717820

Original issue's description:
> (Reland x2) Expose resources in Robolectric/JUnit tests.
>
> Will let people use Android resources in Robolectric tests.
> To use, specify package_name GN variable in junit_binary
> targets with your apps package name.
>
> This change will also (basically) require that you use the
> generated wrappers from out_dir/bin/run_<suite name> to run
> the tests since GN will be generating many arguments to
> pass along to the test runner.
>
> BUG=693573
>
> Review-Url: https://codereview.chromium.org/2842603002
> Cr-Commit-Position: refs/heads/master@{#468822}
> Committed: https://chromium.googlesource.com/chromium/src/+/bc26a6f5b4ed9ee2b84878c17e8f4149db815db7

TBR=agrieve@chromium.org,jbudorick@chromium.org,nyquist@chromium.org,mikecase@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=693573

Review-Url: https://codereview.chromium.org/2859583004
Cr-Commit-Position: refs/heads/master@{#468871}