GitLab

Previously NetworkChangeNotifier was created on UI thread, but could be 
destroyed on some other random thread, which could cause the crash in the 
linked bug.

Moved creation and destruction of the NetworkChangeNotifier to the 
network thread.

BUG=179476


Review URL: https://chromiumcodereview.appspot.com/12703020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190549 0039d316-1c4b-4281-b951-d872f2087c98

chromeos: In DriveResourceMetadata::RefreshEntry, reject entry with root resource id if it has parent

BUG=None
TEST=unit_tests

Review URL: https://codereview.chromium.org/12905010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190548 0039d316-1c4b-4281-b951-d872f2087c98

Instead of gfx::Rect(gfx::Point(), gfx::Size(3, 4)), use gfx::Rect(0, 0, 3, 4).
Instead of gfx::Rect(gfx::Point(), some_size), use gfx::Rect(some_size).

R=jamesr
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/12967018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190547 0039d316-1c4b-4281-b951-d872f2087c98

This reduces intl1 memory usages by ~10M or 22%.

This has two benefits:
1. The memory usage by the http server seems to be causing intl1 to fail on the
   win perf bots.
2. Decompressing textual resources makes the page loads more realistic.

BUG=223543
TEST=intl1 page cycler on windows
NOTRY=True


Review URL: https://chromiumcodereview.appspot.com/12916011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190544 0039d316-1c4b-4281-b951-d872f2087c98

I don't think this is the ideal fix, but it works, and I don't think I
can get the real fix debugged by the M27 branch.

BUG=178542
TEST=Use the instructions at http://crbug.com/178542#c16

Review URL: https://codereview.chromium.org/13067002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190543 0039d316-1c4b-4281-b951-d872f2087c98

I had forgotten to add a call to SetViewportWithinScrollableArea outside
the root layer.

NOTRY=true
BUG=223792


Review URL: https://chromiumcodereview.appspot.com/13079003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190542 0039d316-1c4b-4281-b951-d872f2087c98

BUG=177691

Review URL: https://codereview.chromium.org/12769017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190540 0039d316-1c4b-4281-b951-d872f2087c98

Ctrl-Shift-Back -> Scale down UI
Ctrl-Shift-Foward -> Scale up UI
Ctrl-Shift-Reload -> Rotate screen

BUG=196817

Review URL: https://codereview.chromium.org/12617019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190538 0039d316-1c4b-4281-b951-d872f2087c98

Main change is the interface of chrome.h

BUG=chromedriver:241, chromedriver:248, chromedriver:254
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/12978003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190537 0039d316-1c4b-4281-b951-d872f2087c98

GData service code seems to occasionally return -1 when network is
unavailable.

BUG=223042
TEST=manual
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/12916010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190536 0039d316-1c4b-4281-b951-d872f2087c98

[Telemetry] Don't crash if a process is stopped between GetChildPids() and GetMemoryStats() or GetIOStats().

Example of this crash on the bots:
http://build.chromium.org/p/chromium.perf/builders/Win7%20Perf%20%281%29/builds/8028/steps/indexeddb/logs/stdio

BUG=None
TEST=indexed_db page cycler on windows
NOTRY=True


Review URL: https://chromiumcodereview.appspot.com/12837013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190535 0039d316-1c4b-4281-b951-d872f2087c98

I believe cancel upon capture lost is necessary regardless.

BUG=175486
TEST=covered by tests, manually on lock screen.

Review URL: https://codereview.chromium.org/13041002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190534 0039d316-1c4b-4281-b951-d872f2087c98

BUG=222483
TEST=no functionality change. covered by existing unit tests.

Review URL: https://codereview.chromium.org/12983010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190533 0039d316-1c4b-4281-b951-d872f2087c98

BUG=no

Review URL: https://codereview.chromium.org/12521022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190532 0039d316-1c4b-4281-b951-d872f2087c98

In order to get OAuth tokens on Android, we have to call out to Java. This CL
makes it possible. It's not the ideal solution but works for now.

BUG= 222271

Review URL: https://codereview.chromium.org/12880014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190531 0039d316-1c4b-4281-b951-d872f2087c98

> Alternate NTP Mac: Show overlay at fixed position
> 
> Previously the overlay was shown at the bottom of the toolbar. The height of
> the bookmark bar changes if the bookmark bar is attached. This meant that the
> overlay would change positions (relative to the omnibox) depending on the
> bookmark bar's attached state.
> 
> With this CL we now show the overlay at the fixed offset from the omnibox.
> 
> One side effect of this is that the bottom of the toolbar can no longer act
> as a separator for the overlay. I've changed the overlay to draw its own
> separator.
> 
> Screenshot: http://i.imgur.com/ub9gfDo.png
> 
> BUG=173475, 174077
> TBR=sky@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190213
> 
> Review URL: https://codereview.chromium.org/12674019

TBR=sail@chromium.org
Review URL: https://codereview.chromium.org/12905008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190530 0039d316-1c4b-4281-b951-d872f2087c98

BUG=223791
Review URL: https://codereview.chromium.org/12941012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190529 0039d316-1c4b-4281-b951-d872f2087c98

BUG=222110
NOTRY=true

Review URL: https://codereview.chromium.org/12939013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190528 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190527 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=yurys
Review URL: https://codereview.chromium.org/13076003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190526 0039d316-1c4b-4281-b951-d872f2087c98

- Use set instead of list
- Encapsulate internals
- Add unit tests
- Separate out the reporting utilities

BUG=167331
NOTRY=True

Review URL: https://codereview.chromium.org/12544033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190525 0039d316-1c4b-4281-b951-d872f2087c98

This patch makes limited changes to minimize the likelyhood of breaking
dependent scripts.

NOTRY=True
TBR=brettw@chromium.org
BUG=180587
TEST=ran run_command.RunOnce with a timeout of 0.

Review URL: https://codereview.chromium.org/13047009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190524 0039d316-1c4b-4281-b951-d872f2087c98

This allows to avoid asking user to create 

BUG=223485

Review URL: https://chromiumcodereview.appspot.com/13039002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190523 0039d316-1c4b-4281-b951-d872f2087c98

Previously, a directory traversal on the left directory tree is not limited because of a wrong condition. This patch fixes it.

BUG=none
TEST=manual
TBR=kinaba@chromium.org
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/12683006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190522 0039d316-1c4b-4281-b951-d872f2087c98

1. After r190443 now we may call UploadNewFileForLocalSync even for the
files we have (stale) metadata
2. In auto conflict resolution we could have metadata that doesn't have
resource_id in metadata_store while having a remote change for the file
(thus resulting in a conflict)

BUG=177626,223415
TEST=manual
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/12660020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190521 0039d316-1c4b-4281-b951-d872f2087c98

BUG=180647,223723

Review URL: https://codereview.chromium.org/12695017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190520 0039d316-1c4b-4281-b951-d872f2087c98

Previously the overlay was shown at the bottom of the toolbar. The height of
the bookmark bar changes if the bookmark bar is attached. This meant that the
overlay would change positions (relative to the omnibox) depending on the
bookmark bar's attached state.

With this CL we now show the overlay at the fixed offset from the omnibox.

One side effect of this is that the bottom of the toolbar can no longer act
as a separator for the overlay. I've changed the overlay to draw its own
separator.

Screenshot: http://i.imgur.com/ub9gfDo.png

BUG=173475, 174077
TBR=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190213

Review URL: https://codereview.chromium.org/12674019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190519 0039d316-1c4b-4281-b951-d872f2087c98

BUG=150017
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/12987024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190518 0039d316-1c4b-4281-b951-d872f2087c98

BUG=223669
R=shishir@chromium.org
TEST=See bug.

Review URL: https://codereview.chromium.org/13030009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190517 0039d316-1c4b-4281-b951-d872f2087c98

BUG=223671
R=shishir@chromium.org,brettw@chromium.org
TEST=See bug.

Review URL: https://codereview.chromium.org/12742014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190516 0039d316-1c4b-4281-b951-d872f2087c98

Since webkit/media creates cc::VideoLayer objects and implements the
cc::VideoFrameProvider interface, it should depend on the cc library.

R=jamesr
BUG=196810

Review URL: https://codereview.chromium.org/12961009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190515 0039d316-1c4b-4281-b951-d872f2087c98

BUG=165458
TBR=scherkus

Review URL: https://codereview.chromium.org/12638044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190514 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190513 0039d316-1c4b-4281-b951-d872f2087c98

It made many test fails to get the test case list and I failed to reproduce
locally.

TBR=csharp@chromium.org
BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/13076002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190512 0039d316-1c4b-4281-b951-d872f2087c98

BlockUntilBookmarkModelLoaded() is just a tiny wrapper around
WaitForBookmarkModelToLoad(), so it doesn't add much per se,  and we ended up
calling BookmarkModelFactory::GetForProfile() twice, either before or after
the call to BlockUntilBookmarkModelLoaded().

BUG=144783
R=sky@chromium.org

Review URL: https://codereview.chromium.org/12929016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190511 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 54d2b618.
This caused a regression:
https://code.google.com/p/chromium/issues/detail?id=223716

TBR=brettw@chromium.org
BUG=223716

Review URL: https://codereview.chromium.org/13071008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190510 0039d316-1c4b-4281-b951-d872f2087c98

We're keeping a token and going to call a method which takes token,
so we should probably just call the method there.

BUG=223705
TEST=manual
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/13047011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190509 0039d316-1c4b-4281-b951-d872f2087c98

This avoids reading in the large .svn directories on the bots.

BUG=None
TEST=intl1 cycler on windows
NOTRY=True


Review URL: https://chromiumcodereview.appspot.com/12767015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190508 0039d316-1c4b-4281-b951-d872f2087c98

TBR=estade@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/13074002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190507 0039d316-1c4b-4281-b951-d872f2087c98

In some rare cases it has been found that Windows returns a sample-rate of 0, even though it's capable of
rendering audio with WASAPI.

For the Web Audio API, Let's make sure to return a sane fallback sample-rate.

BUG=222718
TEST=none
Review URL: https://codereview.chromium.org/12937017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190506 0039d316-1c4b-4281-b951-d872f2087c98